There was a number of problems I found with this mod. Although it is certainly a very good one, much better than the other 'group color' mods out there.
As a couple of people noted, the SCU_Global.mod file has some errors in it, not least the duplicate viewforum.php edits in it!
A_O_C wrote:Ishimaru Chiaki wrote:More, the "viewforum.php" appears twice in the files modification directions.
yes, for some reason, the mod author thought it would be "creative" to do it twice, but they are two different sets of directions, so just follow them both.
When using with EasyMOD, this actually makes for errors if you install and then deinstall. The first set of changes get stuck in the viewtopic.php causing an error if you try to install it again. As already mentioned, only the second set of viewtopic.php changes need following! >>>
finlay wrote:For the benefit of you and other readers, I can confirm that I've resolved the duplicate code references I listed above. The first instances should be ignored in both cases, and the latter ones used.
...those people who implement the first change will then not be able to do a 'search and replace' for the second instance because the code will have changed...!
* note - thats because they do a bit extra the first bit don't - add colour to the forum moderators bit at the top.
Ishimaru Chiaki wrote:In the addon install file, the search.php and the templates/subSilver/privmsgs_body.tpl don't appear in the "files to modify" list on top of the page.
yeah that as well! - oh, memberlist.php too. I also found a small change was needed to make it compatible with phpBB 2.0.23.
As for the actual mod, there's an error I found with it. When you edit a users profile from the ACP, and make an error, the returning page doesn't display the priority group drop down box. I'm not sure exactly why, but I did make a change putting the drop down box function higher up in admin_users.php and it seemed to fix problem. The drop down box could also do with having a 'none' option, so that the user's group can follow the default as defined by the main group ordering.
darkcloudinc wrote:I'm getting this error when I'm in the edit window:
Code: Select all
Warning: Invalid argument supplied for foreach() in /mnt/w0401/d31/s30/b02b7700/www/gods/includes/usercp_register.php on line 884
anyone care to help?
Nevermind, the solution was as simple as creating a group for the user to be in.
Hmm did anyone resolve this? I see Ishimaru experienced a similar problem:
Ishimaru Chiaki wrote:I tested my MODs on my local board (installed with WAMP) and I keep them installed. Recently, I had to turn off the colors on my two test groups (removed the color hexa code and unchecked the checkbox to apply the color). But I kept my founder account as the moderator of the groups.
Then, when I edited my profile to look at something, I saw this warning line :
Code: Select all
Warning: Invalid argument supplied for foreach() in C:\wamp\www\Tests\phpBB-2.0.22\phpBB2\includes\usercp_register.php on line 947
It would seem that for some reason the bit in usercp_register.php (the profile edit page) is not getting an array passed to it. I'll try and have a look at that one.
phorum.ws wrote: I just added a new group, suppose to displayed AFTER elite mod, it showed up where elite mod is suppose to be (2nd place - so new group is 3rd) but elite mod is actually last on the legend and will not change no matter what, thats cos there is a bug in the DB if you delete an existing group, or add a new one, and try and move the order around it screws everything up... read me and another users posts 2 pages back... is the author still supporting this? (they all seem to run away after a while, not that this guy has, but 90% of my mods authors have run away).
Yeah this is another pain, the group ordering system is not solid at all. Ideally, each time you submit a group change, some SQL should be devised to update the group_order value of each of the groups to ensure that the ordering is correct, im not too sure if this :
A_O_C wrote:may i suggest that instead of using the "display after" option, you use a numbering system like in
this mod.
is it or not. Should be looked into.
squeek wrote:I have an issue concerning the Admin and Moderator and i am not sure about it.
Obviously there is already group for the Moderator and Admin so when i install this MOD do i have to re-create these groups again? if so then what happens to the 'already created' Admin and Moderator groups?
Yeah, this could do with being something to add to the mod - provision to keep the existing Admin & Moderator colouring, with some sort of option to set what colour gets what priority... Perhaps adding these to the group order drop down box? Something or the other anyway. I also think the original board style for the colour legends is better as well, rather than a 'new' line at the bottom of the page. But thats just a preference i think!
DizzyDazzle wrote:1: as phorum.ws stated, it seems to put the groups in alphebetical order on the legend, regardless of where you state in the ACP...
2: like anton1o suggested, is there any way to have a hidden group and still color its members? i have different clans on my forums and would like all clan members to be colored, but dont want to list ALL of the clan groups in the legend, it would be silly. anyone who can give a quick fix for this will be very appreciated!
This could do with a fix too. I shouldn't think this would be too hard to change. The SQL logic has a bit in it to not return group data that is hidden for non-mod users. The logic ought to be taken out of that and moved to the group legend display where hidden groups can be prevented from displaying.
Other than that I needed to make a simple change to one of the find commands to make it compatible with the Attach Mod.
But, as for some other suggestions,
jalaln wrote:squeek wrote: its a shame this mod doesnt add the user's rank next to their name as well as the colour everywhere or at lease offer a choice in the acp to do so.
You mean by rank the usergroup?
This would be an excellent feature for this mod to have! Currently this mod works very well with the
Group Rank Hack, even, amazingly, seeming to follow the same group ordering too. But, integration of this feature would be excellent
Cheesemaker wrote:Does this mod also colour the names in the user profile? Because I don't want that. I only want it in the index.php and in viewforum and viewtopic
Yes - I agree - that bit of the SCU_global.mod is just silly and looks truely ugly! I just cut out the usercp_viewprofile.php edit section out of it, much better now.
figo wrote:oh i was also able to figure out how to put the link the profile mod back in.
This sounds like something simple and would be another good change to this mod
HCP wrote:In the following pages, the underline of usergroup links is not coloured (eg. the text is in the colour you specified in the ACP, but the underline is still in the default link colour):
viewonline.php
memberlist.php
groupcp.php
How do I edit those three PHP files and their corresponding TPL files so that the underline is coloured too, like in index.php and viewforum.php?
yes, this is something ugly and ought to be changed. If you look at SCU_global.mod you will see that the changes to usercp_viewprofile.php actually address this problem - by making change also to privmsgs_body.tpl. The style colour needs to be added to the <a> tag rather than putting in a <span> tag - this is what makes the non matching underline colour appear.