Approval MOD

All new MODs released in our MOD Database will be announced in here. All support for released MODs needs to take place in here. No new MODs will be accepted into the MOD Database for phpBB2
Forum rules
READ: phpBB.com Board-Wide Rules and Regulations

On February 1, 2009 this forum will be set to read only as part of retiring of phpBB2.

Rating:

Excellent!
13
65%
Very Good
5
25%
Good
2
10%
Fair
0
No votes
Poor
0
No votes
 
Total votes: 20

User avatar
uncle.f
Registered User
Posts: 253
Joined: Thu Mar 25, 2004 11:42 am
Location: Purple Yonder
Contact:

Post by uncle.f » Mon Nov 20, 2006 12:17 am

acharabia wrote: This is viewforum.php... But there are already some editing in my file. e.g. Global announcement, or topic-calendar... etc. How do I do?


As it states in the readme file and in the third post in this thread:
This MOD most likely will NOT work with any other MOD that changes message posting or topic/forum viewing behaviour. The approval functionality is something that affects phpBB quite deeply, so unfortunately that is the price to pay. Sorry :( Some MODs will require tiny adjustment to work together with the Approval MOD. Others may need significant code changes.

acharabia wrote: What's mean that?

If you are asking about what the commands like "-----[ IN-LINE FIND ]-----" mean, you should read about the commonly used MOD syntax here and try resolving MOD incompatibility by editing your files manually.

acharabia
Registered User
Posts: 139
Joined: Fri Sep 27, 2002 4:41 pm
Location: SEOUL/KOREA
Contact:

Post by acharabia » Mon Nov 20, 2006 12:32 am

Yeh~ I like this MOD cause too huge to edit but there are already
code change much in my files so I will give it up... I'm very regreat...
This MOD quite look charm to me... I need this fonction on my board.
So you can develope more easily to edit for install this MOD in the future?
Make this MOD another method. :wink:

Thanks anyway making good MOD. In fact,
I challenged much time to install this MOD...
But this manual is not to write 100% principle of guideline.
Furthemore, I can't find some part of code like below
in manual... :cry:

Code: Select all

#
#-----[ OPEN ]------------------------------------------
#
includes/functions_post.php

#
#-----[ IN-LINE FIND ]---------------------------------
#
$attach_sig" . $edited_sql . "

#
#-----[ IN-LINE AFTER, ADD ]-------------------------
#
, post_approve = {$post_data['approve']}

Oh~ Good Job~ I like to hear a Sound like easy~
Keep going on~ I'd like to wait this new version. :wink:
Last edited by acharabia on Mon Nov 20, 2006 12:44 am, edited 1 time in total.
Image

User avatar
uncle.f
Registered User
Posts: 253
Joined: Thu Mar 25, 2004 11:42 am
Location: Purple Yonder
Contact:

Post by uncle.f » Mon Nov 20, 2006 12:39 am

acharabia wrote: I need this fonction on my board.
So you can develope more easily to edit for install this MOD in the future?
Make this MOD another method.


I am developing a new MOD which is much more powerful than this one. Hopefully it will be easier to install as well. This is the topic for the new MOD, which is not ready yet, but will be soon:

http://www.phpbb.com/phpBB/viewtopic.php?t=444640

wgetd
Registered User
Posts: 3
Joined: Tue Nov 21, 2006 9:38 am

Post by wgetd » Wed Nov 22, 2006 1:05 pm

I have the following error when I try to create a new forum in the Administration Panel:

Code: Select all

Couldn't insert row in forums table

DEBUG MODE

SQL Error : 1110 Column 'forum_approve' specified twice

INSERT INTO phpbb_forums (forum_id, forum_name, cat_id, forum_desc, forum_order, forum_status, prune_enable, auth_view, forum_approve, auth_read, forum_approve, auth_post, forum_approve, auth_reply, forum_approve, auth_edit, forum_approve, auth_delete, forum_approve, auth_sticky, forum_approve, auth_announce, forum_approve, auth_vote, forum_approve, auth_pollcreate, forum_approve, auth_attachments, forum_approve, auth_download, forum_approve) VALUES ('22', 'test', 3, 'eee', 80, 0, 0, 0, 0, 0, 0, 1, 0, 1, 0, 1, 0, 1, 0, 3, 0, 3, 0, 1, 0, 1, 0, 1, 0, 1, 0)

Line : 439
File : admin_forums.php

User avatar
uncle.f
Registered User
Posts: 253
Joined: Thu Mar 25, 2004 11:42 am
Location: Purple Yonder
Contact:

Post by uncle.f » Wed Nov 22, 2006 1:23 pm

wgetd wrote: I have the following error when I try to create a new forum in the Administration Panel:

Code: Select all

Couldn't insert row in forums table

DEBUG MODE

SQL Error : 1110 Column 'forum_approve' specified twice


The editing of admin_forums.php has obviously gone wrong. Did you install Approve MOD by hand or using EasyMOD or somehow else?

wgetd
Registered User
Posts: 3
Joined: Tue Nov 21, 2006 9:38 am

Post by wgetd » Wed Nov 22, 2006 1:42 pm

It was installed by hand

Code: Select all


#
#-----[ FIND ]---------------------------------------------
#
$sql
SET forum_name
#
#-----[ BEFORE, ADD ]-----
#
			// query modified by approval mod
#
#-----[ IN-LINE FIND ]-----
#
intval($HTTP_POST_VARS['forumstatus']) . ",
#
#-----[ IN-LINE AFTER, ADD ]-----
#
 forum_approve = $forum_approve_status,
#

Can you confirm if this step refers to:

Code: Select all

$sql = "UPDATE " . FORUMS_TABLE . "
SET forum_name
Last edited by wgetd on Wed Nov 22, 2006 6:46 pm, edited 1 time in total.

User avatar
uncle.f
Registered User
Posts: 253
Joined: Thu Mar 25, 2004 11:42 am
Location: Purple Yonder
Contact:

Post by uncle.f » Wed Nov 22, 2006 2:00 pm

wgetd wrote: Can you confirm if this step refer to:

Code: Select all

$sql = "UPDATE " . FORUMS_TABLE . "
SET forum_name


Yes, it does.

wgetd
Registered User
Posts: 3
Joined: Tue Nov 21, 2006 9:38 am

Post by wgetd » Thu Nov 23, 2006 10:12 am

I've found the issue at this step. Thank you.
#
#-----[ FIND ]---------------------------------------------
#
$value_sql .= ", $value";

}
#
#-----[ AFTER, ADD ]-----
#

// approval block start
$field_sql .= ", forum_approve";
$value_sql .= ", $forum_approve_status";
// approval block end

DigiMusicDoc
Registered User
Posts: 35
Joined: Sat May 28, 2005 2:01 am

Post by DigiMusicDoc » Sat Nov 25, 2006 1:48 am

I was wondering if you would consider another variation on this mod, namely, approve first post. I already have several of the anti-spam mods installed, and I still get several spam posts a day. The idea is that if the member's first post is not spam, then he is probably OK and you don't need to approve any more posts.

User avatar
uncle.f
Registered User
Posts: 253
Joined: Thu Mar 25, 2004 11:42 am
Location: Purple Yonder
Contact:

Post by uncle.f » Sat Nov 25, 2006 1:19 pm

DigiMusicDoc wrote: I was wondering if you would consider another variation on this mod, namely, approve first post. I already have several of the anti-spam mods installed, and I still get several spam posts a day. The idea is that if the member's first post is not spam, then he is probably OK and you don't need to approve any more posts.


This can be added as a feature in the new MOD I am working on now..
http://www.phpbb.com/phpBB/viewtopic.php?t=444640

ruler
I've Been Banned!
Posts: 292
Joined: Sat Dec 24, 2005 1:51 am

Post by ruler » Thu Nov 30, 2006 12:34 am

hi
this looks like a great MOD so i decided to try and install it but i dont understand how anyone could have installed this MOD successfully without errors? did a moderator REALLY test this MOD out before releasing it?

here is some of the code in the instalation file ( approval.mod ) Please feel free to check this out and you will see that im right ;)

Code: Select all

#
#-----[ OPEN ]---------------------------------------------------------------------------------------------------------
#
templates/subSilver/overall_header.tpl
#
#-----[ FIND ]---------------------------------------------
#
a.topictitle:hover
#
#-----[ AFTER, ADD ]-----
#

/* titles for unapproved topics */
.topicUnapproved         { font-weight: bold; color: {T_FONTCOLOR1}; }
.topicUnapproved a       { text-decoration: none; color: {T_FONTCOLOR1}; }
.topicUnapproved a:hover { text-decoration: underline; color: {T_BODY_HLINK}; }
.postUnapproved          { color: {T_FONTCOLOR1}; }
and a little further down you will also find the code...

Code: Select all

#
#-----[ OPEN ]---------------------------------------------------------------------------------------------------------
#
templates/subSilver/simple_header.tpl
#
#-----[ FIND ]---------------------------------------------
#
a.topictitle:hover
#
#-----[ AFTER, ADD ]-----
#

/* titles for unapproved topics */
.topicUnapproved         { font-weight: bold; color: {T_FONTCOLOR1}; }
.topicUnapproved a       { text-decoration: none; color: {T_FONTCOLOR1}; }
.topicUnapproved a:hover { text-decoration: underline; color: {T_BODY_HLINK}; }
.postUnapproved          { color: {T_FONTCOLOR1}; }
i mean you can see right away that simple_header.tpl is just a template file and DOESNT have CSS code in it and neither does the overall_header.tpl

ok having said that i figure the code is missing for the overall_header.tpl and the simple_header.tpl so it would be nice if this MOD was updated to include the code that is needed to install this MOD properly.

i just hope that someone can help with this topic as im half way though installing it :(

thanks

User avatar
uncle.f
Registered User
Posts: 253
Joined: Thu Mar 25, 2004 11:42 am
Location: Purple Yonder
Contact:

Post by uncle.f » Thu Nov 30, 2006 1:14 am

ruler wrote: here is some of the code in the instalation file ( approval.mod ) Please feel free to check this out and you will see that im right ;)


To put it simply, you are not. :roll:
i mean you can see right away that simple_header.tpl is just a template file and DOESNT have CSS code in it and neither does the overall_header.tpl


I honestly do not know where you are looking (maybe in another theme, not the default subSilver one) but if you actually open the file templates/subSilver/overall_header.tpl belonging to phpBB 2.0.21, you will see that everything between the lines 10 and 210 is pure CSS. Similar situation with the simple_header.tpl.

There is nothing missing is the MOD to install it properly on a vanilla installation of phpBB with default SubSilver theme.

ruler
I've Been Banned!
Posts: 292
Joined: Sat Dec 24, 2005 1:51 am

Post by ruler » Thu Nov 30, 2006 1:19 am

I'm such a n00b and i do appologise. i realised what i had done...
in my profiles i had set the template to subSilver but on the board in the ACP i had set the default template to another template that i use. after looking again i realised that i was looking in the wrong files for the code that needs editing and i 'did' find the code that you i listed previously in the subSilver templates :oops:

i just couldnt figure out why it wouldnt install and why it kept saying it couldnt find particular lines :D maybe i need sleep lol

thanks

ruler
I've Been Banned!
Posts: 292
Joined: Sat Dec 24, 2005 1:51 am

Post by ruler » Thu Nov 30, 2006 1:46 am

ok i finally have it all working now and i must say its a super MOD, just what the doctor ordered 8)
the only thing i cant find is the Moderators control panel, is there supposed to be a link to that somewhere? thanks

User avatar
uncle.f
Registered User
Posts: 253
Joined: Thu Mar 25, 2004 11:42 am
Location: Purple Yonder
Contact:

Post by uncle.f » Thu Nov 30, 2006 11:14 am

ruler wrote: ok i finally have it all working now and i must say its a super MOD, just what the doctor ordered 8)
the only thing i cant find is the Moderators control panel, is there supposed to be a link to that somewhere? thanks


Log in as a moderator or admin, display any topic and look down below in the right corner, where "You can post new topics in this forum" messages are.

Post Reply

Return to “[2.0.x] MOD Database Releases”