MOD FIX : Visual Confirm

A place for MOD Authors to post and receive feedback on MODs still in development. No MODs within this forum should be used within a live environment! No new topics are allowed in this forum.
Forum rules
READ: phpBB.com Board-Wide Rules and Regulations

IMPORTANT: MOD Development Forum rules

On February 1, 2009 this forum will be set to read only as part of retiring of phpBB2.
Post Reply
safeTsurfa
I've Been Banned!
Posts: 1959
Joined: Sat May 08, 2004 10:21 am
Location: United Kingdom
Contact:

MOD FIX : Visual Confirm

Post by safeTsurfa »

This MOD is withdrawn and no longer provided by the author to members of this community.
Last edited by safeTsurfa on Thu Jul 01, 2004 7:38 pm, edited 1 time in total.

wGEric
Former Team Member
Posts: 8805
Joined: Sun Oct 13, 2002 3:01 am
Location: Friday
Name: Eric Faerber
Contact:

Post by wGEric »

All you did was change the single quotes into double quotes? What does that do?

Moving to Beta forum
Eric

safeTsurfa
I've Been Banned!
Posts: 1959
Joined: Sat May 08, 2004 10:21 am
Location: United Kingdom
Contact:

Post by safeTsurfa »

Well I do beg your pardon! So sorry for living, I'm sure. I try to help, and get kicked in the teeth for it. Thanks a bunch.
safeTsurfa
Need help? First READ THIS
Personal projects: My Mods

ayusuf
I've Been Banned!
Posts: 917
Joined: Fri Feb 06, 2004 11:00 pm
Location: Orlando,Fl
Contact:

Post by ayusuf »

I mean hes right . Wat did you do nothing . And plus wat is visual confirm.

wGEric
Former Team Member
Posts: 8805
Joined: Sun Oct 13, 2002 3:01 am
Location: Friday
Name: Eric Faerber
Contact:

Post by wGEric »

safeTsurfa wrote: Well I do beg your pardon! So sorry for living, I'm sure. I try to help, and get kicked in the teeth for it. Thanks a bunch.


What was the problem though?

ayusuf wrote: And plus wat is visual confirm.


Look in the contrib folder of phpBB 2.0.8 and you'll see.
Eric

A.I. BOT
Registered User
Posts: 1848
Joined: Thu Apr 17, 2003 11:43 pm
Location: Newfoundland, Canada
Contact:

Post by A.I. BOT »

let me no if im wrong but single quotes are more secure than double quotes

User avatar
smithy_dll
Former Team Member
Posts: 7630
Joined: Tue Jan 08, 2002 6:27 am
Location: Australia
Name: Lachlan Smith
Contact:

Post by smithy_dll »

1. impropper MOD Template
2. phpBB coding standards say to use single quotes (for speed/security)

so I have no idea what you have done here...
coding standards wrote: Quoting strings: There are two different ways to quote strings in PHP - either with single quotes or with double quotes. The main difference is that the parser does variable interpolation in double-quoted strings, but not in single quoted strings. Because of this, you should always use single quotes unless you specifically need variable interpolation to be done on that string. This way, we can save the parser the trouble of parsing a bunch of strings where no interpolation needs to be done. Also, if you are using a string variable as part of a function call, you do not need to enclose that variable in quotes. Again, this will just make unnecessary work for the parser. Note, however, that nearly all of the escape sequences that exist for double-quoted strings will not work with single-quoted strings. Be careful, and feel free to break this guideline if it's making your code harder to read.


The MOD Team has a policy on not releasing MODs into the MOD DB that don't follow the phpBB2 coding standards, sorry

User avatar
Rookie7
Registered User
Posts: 189
Joined: Mon Mar 10, 2003 3:32 pm
Contact:

Re: MOD FIX : Visual Confirm

Post by Rookie7 »

safeTsurfa wrote:

Code: Select all

############################################################## 
## MOD FIX Title: Visual Confirm Coding Fix
## MOD FIX Author: safeTsurfa 
## Release Date: 15 May, 2004
## FIX Description: This fixes a coding inconsistency in the
## Visual Confirm MOD affecting code entered in admin_board.php.
## ONLY use it if you have Visual Confirm installed. 
############################################################## 
## Before Adding This MOD FIX, You Should Back Up All Files
## Related To The Visual Confirm MOD 
############################################################## 

# 
#-----[ OPEN ]------------------------------------------ 
# 
admin_board.php

# 
#-----[ FIND ]------------------------------------------ 
# 
$confirm_yes = ($new['enable_confirm']) ? 'checked="checked"' : '';
$confirm_no = (!$new['enable_confirm']) ? 'checked="checked"' : '';

# 
#-----[ REPLACE ]------------------------------------------ 
# 
$confirm_yes = ($new['enable_confirm']) ? "checked=\"checked\"" : "";
$confirm_no = (!$new['enable_confirm']) ? "checked=\"checked\"" : "";

# 
#-----[ SAVE/CLOSE ALL FILES ]------------------------------------------ 
# 
# EoM 


This is HARDLY a fix. :roll:

Post Reply

Return to “[2.0.x] MODs in Development”