[DISC] Activity Mod Plus (Newest Release: v1.1.0)

A place for MOD Authors to post and receive feedback on MODs still in development. No MODs within this forum should be used within a live environment! No new topics are allowed in this forum.
Forum rules
READ: phpBB.com Board-Wide Rules and Regulations

IMPORTANT: MOD Development Forum rules

On February 1, 2009 this forum will be set to read only as part of retiring of phpBB2.
mcksmith
Registered User
Posts: 18
Joined: Wed Nov 24, 2004 4:13 am
Location: Saskatchewan, Canada
Contact:

Post by mcksmith »

dude,
I don't know if this has been covered (and I'm not reading 102 pages :roll:) but you get a point for a MOD that seems to do what it's supposed to do.

You lose two points though for your horrible abuse of HTML. Did you not run your pages through w3c's validator? I don't know what theme or browser you tested on but in Firefox 1.0 with a black background your improper nesting of tags and incorrect attributes are causing me a headache. I wasn't planning on rewriting all the markup when I installed this MOD but it looks like I'll have to. :evil:

So far your php skills seem to be okay but you need to pick up a book on HTML.
User avatar
aUsTiN-Inc
Registered User
Posts: 929
Joined: Fri Apr 16, 2004 10:31 am
Location: Georgia
Contact:

Post by aUsTiN-Inc »

And ill leave that alone... lol

Put simply, dont use it. Also put simply, i dont use nor care for Firefox so i dont rightly care what it looks like with it :)

If you want to give criticism, go for it, but if you want support & someone to care for what you actually write, i suggest you learn to do things in a somewhat respectfull manner.

So enjoy what ya got & have fun 'recoding' it as you seem to be alot smarter than me with this... spose thats why you're 'recoding' ;)
¤ phpBB Security ¤ Blend Portal Creator ¤
¤ Activity Mod Plus Creator «« 2004 phpBBHacks "Hack" Of The Year ¤
¤ Activity Mod Plus Home ¤ 2004 phpBBHacks "Hack" Author Of The Year ¤
My mods are never done, always in update status!
mcksmith
Registered User
Posts: 18
Joined: Wed Nov 24, 2004 4:13 am
Location: Saskatchewan, Canada
Contact:

Post by mcksmith »

you get a point for a MOD that seems to do what it's supposed to do.
So far your php skills seem to be okay<snip>


Twice I commented that your php coding skills are up to snuff. If it had been a few minor misplaced tags or you consisently made the same markup error I wouldn't have said anything about your HTML skills (or lack thereof). But your markup is seriously wrong. Sorry. What do you want me to say?

Just so you know, just because your MOD looks fine in current versions of IE that doesn't mean it always will. If future releases don't allow as much slack in the HTML markup you will have other users complaining of the same thing.

Oh, and just because you prefer IE that doesn't mean that users that installs your MOD on their site prefer IE or that their visitors prefer IE. Valid HTML would greatly minimize the chances of display discrepancies but obviously you don't care about that.

BTW, I guess I forgot to thank you for the great MOD. It functions the way I wanted & expected. Unfortunately black text on a black background isn't the best color scheme.
User avatar
aUsTiN-Inc
Registered User
Posts: 929
Joined: Fri Apr 16, 2004 10:31 am
Location: Georgia
Contact:

Post by aUsTiN-Inc »

Thats not lack of HTML knowledge, thats forgetting to add classes to inputs etc..

Also it is displaced on certain templates, can i help that? no...

Some of the text is bigger in some places, thats forgetting to add span classes..

Alot of which has been amended in .9 & alot more will be as i find more.
¤ phpBB Security ¤ Blend Portal Creator ¤
¤ Activity Mod Plus Creator «« 2004 phpBBHacks "Hack" Of The Year ¤
¤ Activity Mod Plus Home ¤ 2004 phpBBHacks "Hack" Author Of The Year ¤
My mods are never done, always in update status!
breedingexotics
Registered User
Posts: 109
Joined: Fri Aug 06, 2004 4:01 am
Contact:

Post by breedingexotics »

ok i have done a fresh install of this Mod and ran the DB as well as the commom.php file and it still shows that i havnt done any thing when i click on games i get this error:

Code: Select all

  phpBB : Critical Error 

Sorry, the games are currently offline until the admin upgrades/installs the current version. The current version is 1.0.8. Your version is Unknown.


Instructions


Since you are an admin, please goto your admin panel, you can get there by clicking here. After you do that, please look on the left for [b]Activities[/b] and under it you will see a link, Db Adjustments. If this is a fresh install for you, please click Install Activity Mod Plus. If you are upgrading from a previous version, please look in the second section, and in the drop down menu and select what you are upgrading from. You are upgrading to 1.0.8. After doing that, this error will go away and you will be allowed to play games.    


i also get this one when i click add new game in ACP
and it doesnt hold my information that i add to the ACP

Code: Select all

Warning: Division by zero in /home/breeding/public_html/petforum/admin/admin_activity.php on line 146

Warning: Division by zero in /home/breeding/public_html/petforum/admin/admin_activity.php on line 162


Any ideas ?? Thanks
breedingexotics
Registered User
Posts: 109
Joined: Fri Aug 06, 2004 4:01 am
Contact:

Post by breedingexotics »

ok got rid of this problem :

Code: Select all

  phpBB : Critical Error 

Sorry, the games are currently offline until the admin upgrades/installs the current version. The current version is 1.0.8. Your version is Unknown. 


Instructions 


Since you are an admin, please goto your admin panel, you can get there by clicking here. After you do that, please look on the left for [b]Activities[/b] and under it you will see a link, Db Adjustments. If this is a fresh install for you, please click Install Activity Mod Plus. If you are upgrading from a previous version, please look in the second section, and in the drop down menu and select what you are upgrading from. You are upgrading to 1.0.8. After doing that, this error will go away and you will be allowed to play games.   
<~~~Fixed by doing this

UPDATE phpbb_config SET config_value='1.0.8' WHERE config_name='ina_version';


and now i got a new one plus these others:

Code: Select all

 Couldn't obtain game data 

DEBUG MODE 

SQL Error : 1064 You have an error in your SQL syntax. Check the manual that corresponds to your MySQL server version for the right syntax to use near 'LIMIT 0,' at line 5 

SELECT * FROM phpbb_ina_games ORDER BY LIMIT 0, 

Line : 1456 
File : /home/breeding/public_html/petforum/activity.php

i also get this one when i click add new game in ACP
and it doesnt hold my information that i add to the ACP

Code: Select all

Warning: Division by zero in /home/breeding/public_html/petforum/admin/admin_activity.php on line 146 

Warning: Division by zero in /home/breeding/public_html/petforum/admin/admin_activity.php on line 162 
Any ideas ?? Thanks
User avatar
aUsTiN-Inc
Registered User
Posts: 929
Joined: Fri Apr 16, 2004 10:31 am
Location: Georgia
Contact:

Post by aUsTiN-Inc »

All i can suggest first is remove the unset($GLOBALS[' line from the common.php & see if that fixes it.
¤ phpBB Security ¤ Blend Portal Creator ¤
¤ Activity Mod Plus Creator «« 2004 phpBBHacks "Hack" Of The Year ¤
¤ Activity Mod Plus Home ¤ 2004 phpBBHacks "Hack" Author Of The Year ¤
My mods are never done, always in update status!
User avatar
redlabour
Registered User
Posts: 19
Joined: Thu Jan 01, 2004 11:12 pm
Contact:

Post by redlabour »

common.php - again the greatest Problem of all ! ;) I use a phpBB2.0.11 modded to phpBB2+ !

So i´ve tried to use one from phpBB2.0.8 - it fails !

My one looks like :

Code: Select all

<?php 
/*************************************************************************** 
 *                                common.php 
 *                            ------------------- 
 *   begin                : Saturday, Feb 23, 2001 
 *   copyright            : (C) 2001 The phpBB Group 
 *   email                : support@phpbb.com 
 * 
 *   $Id: common.php,v 1.74.2.10 2003/06/04 17:41:39 acydburn Exp $ 
 * 
 * 
 ***************************************************************************/ 

/*************************************************************************** 
 * 
 *   This program is free software; you can redistribute it and/or modify 
 *   it under the terms of the GNU General Public License as published by 
 *   the Free Software Foundation; either version 2 of the License, or 
 *   (at your option) any later version. 
 * 
 ***************************************************************************/ 

if ( !defined('IN_PHPBB') ) 
{ 
   die("Hacking attempt"); 
} 
// 
   error_reporting  (E_ERROR | E_WARNING | E_PARSE); // This will NOT report uninitialized variables 
set_magic_quotes_runtime(0); // Disable magic_quotes_runtime 

// The following code (unsetting globals) was contributed by Matt Kavanagh 

// PHP5 with register_long_arrays off? 
if (!isset($HTTP_POST_VARS) && isset($_POST)) 
{ 
   $HTTP_POST_VARS = $_POST; 
   $HTTP_GET_VARS = $_GET; 
   $HTTP_SERVER_VARS = $_SERVER; 
   $HTTP_COOKIE_VARS = $_COOKIE; 
   $HTTP_ENV_VARS = $_ENV; 
   $HTTP_POST_FILES = $_FILES; 

   // _SESSION is the only superglobal which is conditionally set 
   if (isset($_SESSION)) 
   { 
      $HTTP_SESSION_VARS = $_SESSION; 
   } 
} 

if (@phpversion() < '4.0.0') 
{ 
   // PHP3 path; in PHP3, globals are _always_ registered 
    
   // We 'flip' the array of variables to test like this so that 
   // we can validate later with isset($test[$var]) (no in_array()) 
   $test = array('HTTP_GET_VARS' => NULL, 'HTTP_POST_VARS' => NULL, 'HTTP_COOKIE_VARS' => NULL, 'HTTP_SERVER_VARS' => NULL, 'HTTP_ENV_VARS' => NULL, 'HTTP_POST_FILES' => NULL); 

   // Loop through each input array 
   @reset($test); 
   while (list($input,) = @each($test)) 
   { 
      while (list($var,) = @each($$input)) 
      { 
         // Validate the variable to be unset 
         if (!isset($test[$var]) && $var != 'test' && $var != 'input') 
         { 
            unset($$var); 
         } 
      } 
   } 
} 
else if (@ini_get('register_globals') == '1' || strtolower(@ini_get('register_globals')) == 'on') 
{ 


   // PHP4+ path 
    
   // Not only will array_merge give a warning if a parameter 
   // is not an array, it will actually fail. So we check if 
   // HTTP_SESSION_VARS has been initialised. 
   if (!isset($HTTP_SESSION_VARS)) 
   { 
      $HTTP_SESSION_VARS = array(); 
   } 

   // Merge all into one extremely huge array; unset 
   // this later 
   $input = array_merge($HTTP_GET_VARS, $HTTP_POST_VARS, $HTTP_COOKIE_VARS, $HTTP_SERVER_VARS, $HTTP_SESSION_VARS, $HTTP_ENV_VARS, $HTTP_POST_FILES); 

   unset($input['input']); 
    
   while (list($var,) = @each($input)) 
   { 
      unset($$var); 
   } 
    
   unset($input); 


} 

// 
// addslashes to vars if magic_quotes_gpc is off 
// this is a security precaution to prevent someone 
// trying to break out of a SQL statement. 
// 
if( !get_magic_quotes_gpc() ) 
{ 
   if( is_array($HTTP_GET_VARS) ) 
   { 
      while( list($k, $v) = each($HTTP_GET_VARS) ) 
      { 
         if( is_array($HTTP_GET_VARS[$k]) ) 
         { 
            while( list($k2, $v2) = each($HTTP_GET_VARS[$k]) ) 
            { 
               $HTTP_GET_VARS[$k][$k2] = addslashes($v2); 
            } 
            @reset($HTTP_GET_VARS[$k]); 
         } 
         else 
         { 
            $HTTP_GET_VARS[$k] = addslashes($v); 
         } 
      } 
      @reset($HTTP_GET_VARS); 
   } 

   if( is_array($HTTP_POST_VARS) ) 
   { 
      while( list($k, $v) = each($HTTP_POST_VARS) ) 
      { 
         if( is_array($HTTP_POST_VARS[$k]) ) 
         { 
            while( list($k2, $v2) = each($HTTP_POST_VARS[$k]) ) 
            { 
               $HTTP_POST_VARS[$k][$k2] = addslashes($v2); 
            } 
            @reset($HTTP_POST_VARS[$k]); 
         } 
         else 
         { 
            $HTTP_POST_VARS[$k] = addslashes($v); 
         } 
      } 
      @reset($HTTP_POST_VARS); 
   } 

   if( is_array($HTTP_COOKIE_VARS) ) 
   { 
      while( list($k, $v) = each($HTTP_COOKIE_VARS) ) 
      { 
         if( is_array($HTTP_COOKIE_VARS[$k]) ) 
         { 
            while( list($k2, $v2) = each($HTTP_COOKIE_VARS[$k]) ) 
            { 
               $HTTP_COOKIE_VARS[$k][$k2] = addslashes($v2); 
            } 
            @reset($HTTP_COOKIE_VARS[$k]); 
         } 
         else 
         { 
            $HTTP_COOKIE_VARS[$k] = addslashes($v); 
         } 
      } 
      @reset($HTTP_COOKIE_VARS); 
   } 
} 

// 
// Define some basic configuration arrays this also prevents 
// malicious rewriting of language and otherarray values via 
// URI params 
// 
$board_config = array(); 
$plus_config = array(); 
$userdata = array(); 
$theme = array(); 
$images = array(); 
$lang = array(); 
$nav_links = array(); 
$gen_simple_header = FALSE; 

include($phpbb_root_path . 'config.'.$phpEx); 

if( !defined("PHPBB_INSTALLED") ) 
{ 
   header("Location: install/install.$phpEx"); 
   exit; 
} 

include($phpbb_root_path . 'includes/constants.'.$phpEx); 
include($phpbb_root_path . 'includes/template.'.$phpEx); 
include($phpbb_root_path . 'includes/sessions.'.$phpEx); 
include($phpbb_root_path . 'includes/auth.'.$phpEx); 
//-- mod : categories hierarchy -------------------------------------------------------------------- 
//-- add 
include_once( $phpbb_root_path . './includes/functions_categories_hierarchy.' . $phpEx ); 
//-- fin mod : categories hierarchy ---------------------------------------------------------------- 
include($phpbb_root_path . 'includes/functions.'.$phpEx); 
include($phpbb_root_path . 'includes/db.'.$phpEx); 

// 
// Obtain and encode users IP 
// 
// I'm removing HTTP_X_FORWARDED_FOR ... this may well cause other problems such as 
// private range IP's appearing instead of the guilty routable IP, tough, don't 
// even bother complaining ... go scream and shout at the idiots out there who feel 
// "clever" is doing harm rather than good ... karma is a great thing ... :) 
// 
$client_ip = ( !empty($HTTP_SERVER_VARS['REMOTE_ADDR']) ) ? $HTTP_SERVER_VARS['REMOTE_ADDR'] : ( ( !empty($HTTP_ENV_VARS['REMOTE_ADDR']) ) ? $HTTP_ENV_VARS['REMOTE_ADDR'] : $REMOTE_ADDR ); 
$user_ip = encode_ip($client_ip); 

// 
// Setup forum wide options, if this fails 
// then we output a CRITICAL_ERROR since 
// basic forum information is not available 
// 
$sql = "SELECT * 
   FROM " . CONFIG_TABLE; 
if( !($result = $db->sql_query($sql)) ) 
{ 
   message_die(CRITICAL_ERROR, "Could not query config information", "", __LINE__, __FILE__, $sql); 
} 

while ( $row = $db->sql_fetchrow($result) ) 
{ 
   $board_config[$row['config_name']] = $row['config_value']; 
} 
$sql = "SELECT * 
   FROM " . PLUS_TABLE; 
if( !($result = $db->sql_query($sql)) ) 
{ 
   message_die(CRITICAL_ERROR, "Could not query Plus-Config information", "", __LINE__, __FILE__, $sql); 
} 

while ( $row = $db->sql_fetchrow($result) ) 
{ 
   $plus_config[$row['config_name']] = $row['config_value']; 
} 
include($phpbb_root_path . 'attach_mod/attachment_mod.'.$phpEx); 

if (file_exists('install') || file_exists('contrib')) 
{ 
   message_die(GENERAL_MESSAGE, 'Please ensure both the install/ and contrib/ directories are deleted'); 
} 

// 
// Show 'Board is disabled' message if needed. 
// 
if( $board_config['board_disable'] && !defined("IN_ADMIN") && !defined("IN_LOGIN") ) 
{ 
   if ( $board_config['board_disable_msg'] != "" ) 
   { 
      message_die(GENERAL_MESSAGE, $board_config['board_disable_msg'], 'Information'); 
   } 
   else 
   { 
      message_die(GENERAL_MESSAGE, 'Board_disable', 'Information'); 
   } 
} 
$sql = "SELECT user_id, user_color_group, username FROM " . USERS_TABLE; 
if( !($result = $db->sql_query($sql)) ) 
{ 
   message_die(GENERAL_ERROR, 'Could not read user color groups', '', __LINE__, __FILE__, $sql); 
} 

$colorusers = array(); 
$coloruname = array(); 
while ( $row = $db->sql_fetchrow($result) ) 
{ 
   $userid = $row['user_id']; 
   $colorusers[$userid] = $row['user_color_group']; 
   $coloruname[$userid] = $row['username']; 
} 

$colorgroup = array(); 

$sql = "SELECT ug.user_id FROM " . USER_GROUP_TABLE . " ug, " . GROUPS_TABLE . " g 
   WHERE g.group_single_user = 0 
   AND g.group_id = ug.group_id 
   GROUP BY ug.user_id 
   ORDER BY ug.user_id"; 
if( !($result = $db->sql_query($sql)) ) 
{ 
   message_die(GENERAL_ERROR, 'Could not read user color groups', '', __LINE__, __FILE__, $sql); 
} 
while ( $row = $db->sql_fetchrow($result) ) 
{ 
   $colorgroup[] = $row['user_id']; 
} 
?>
I tried this to :

Code: Select all

Open => Common.php 

Find 
      unset($GLOBALS[$var_name]); 

Replace With 
      //unset($GLOBALS[$var_name]); 
Close & Save 
But as you can see it isn´t at my common.php :(

Any ideas ?

BTW - where is the ActivityPlus_Install.php ?? http://www.phpbb.com/phpBB/viewtopic.ph ... 22#1134022
walten
Registered User
Posts: 42
Joined: Sun Oct 26, 2003 9:40 pm

Post by walten »

Not sure if it will work but maybe

Open => Common.php

Find
unset($GLOBALS[$var_name]);

Replace With
//unset($GLOBALS[$var_name]);
Close & Save



should be
Open => Common.php

Find
unset($$var);

Replace With
//unset($$var); Close & Save



backup all before
User avatar
aUsTiN-Inc
Registered User
Posts: 929
Joined: Fri Apr 16, 2004 10:31 am
Location: Georgia
Contact:

Post by aUsTiN-Inc »

The installs & updates were removed many versions ago, it is all done in the ACP now.
¤ phpBB Security ¤ Blend Portal Creator ¤
¤ Activity Mod Plus Creator «« 2004 phpBBHacks "Hack" Of The Year ¤
¤ Activity Mod Plus Home ¤ 2004 phpBBHacks "Hack" Author Of The Year ¤
My mods are never done, always in update status!
User avatar
redlabour
Registered User
Posts: 19
Joined: Thu Jan 01, 2004 11:12 pm
Contact:

Post by redlabour »

@aUsTiN-Inc - And why ?
walten wrote: Not sure if it will work but maybe

Open => Common.php

Find
unset($GLOBALS[$var_name]);

Replace With
//unset($GLOBALS[$var_name]);
Close & Save



should be
Open => Common.php

Find
unset($$var);

Replace With
//unset($$var); Close & Save



backup all before


Why did you post this if you can see my common.php above ? It isn´t in my one ...... 8O
walten
Registered User
Posts: 42
Joined: Sun Oct 26, 2003 9:40 pm

Post by walten »

redlabour wrote: Why did you post this if you can see my common.php above ? It isn´t in my one ...... 8O


?????

unset($$var);
User avatar
redlabour
Registered User
Posts: 19
Joined: Thu Jan 01, 2004 11:12 pm
Contact:

Post by redlabour »

Sorry - i must be blind. ;) :D

Found it - but nothing happens with this solution like with the other ones.

:(
User avatar
redlabour
Registered User
Posts: 19
Joined: Thu Jan 01, 2004 11:12 pm
Contact:

Post by redlabour »

Solution for phpBB2 Plus 1.52 and phpBB 2.0.11 !!

Attention at phpBB2 Plus 1.52 you have to use a common.php and functions.php from phpBB 2.0.11 after DB Adjustements take back you own ones ! ;)

You have to do this at phpBB 2.0.11 :
Open => Common.php

Find
unset($GLOBALS[$var_name]);

Replace With
//unset($GLOBALS[$var_name]);
Close & Save


but at phpBB2 Plus 1.52 you have to upload a functions.php from phpBB 2.0.11 too ! Then just type :

Then :

http: // your domain / your phpBB / admin / admin_ina_in_un.php

Be sure that you are logged in before as a Admin !!!

And then a manual
UPDATE phpbb_config SET config_value='1.0.8' WHERE config_name='ina_version';
at phpmyadmin ! ;)

Enjoy ... :D
HipHopBoard
Registered User
Posts: 153
Joined: Sat Sep 04, 2004 1:23 pm
Location: Bucharest, Romania
Contact:

Post by HipHopBoard »

Any ideas why I can't play games?
When I want to play a game, the page is redirecting me to play that game that I selected but in the place of the flash I see a blank big square.
Locked

Return to “[2.0.x] MODs in Development”