[ABD] The wGEric Store Mod v0.1.2! Great for RPG boards!

A place for MOD Authors to post and receive feedback on MODs still in development. No MODs within this forum should be used within a live environment! No new topics are allowed in this forum.
Forum rules
READ: phpBB.com Board-Wide Rules and Regulations

IMPORTANT: MOD Development Forum rules

On February 1, 2009 this forum will be set to read only as part of retiring of phpBB2.
Locked
Prizem
Registered User
Posts: 249
Joined: Sun Sep 07, 2003 9:14 am
Contact:

Post by Prizem »

geoffreak wrote: >> Prizem
I tried to remove that but I guess I missed one
I shall fix store.php and re-upload soon

I'm not sure if you caught it, but the source of the errors are found in admin_store.php. By removing or commenting out references to the non-existent database value "priv_group," board-owned stores can once again be created.


Excess Item Amounts from Stores
Thank you for fixing the error of moving higher values of items from the personal inventory to a personal store. However, just the opposite occurs as well! If you presently have a set amount of items in the store, you can move an extra amount of items from the store to your personal inventory without anything stopping you from doing so. The store shows up as having a negative amount of the item.

When trying to move the excess amount back to the personal store you transferred from, the amount disappears, as the store gives a 0 count. In fact, even if you purchase it from elsewhere (the board, for instance), then transfer it to the original personal store, the count continues to be 0. The only way to get the count back of such an item is to delete the personal store and create a new one. Therefore, to exploit the loophole, the user simply has to delete the original store and create a new one in order to sell an excess amount.


Items Disappear When Deleting Store
When deleting a personal store, whether it be on the store's menu or on the list of stores, if you have items in the store, the items disappear when the store is deleted. This makes it a slight inconvinence, since you have to move all the items back to your inventory if you want to delete the store and not lose your items! Could you make it so that the items are automatically returned to your personal inventory when deleting the store?


Pricing Items When Transferring from Personal Inventory
When transferring items from your personal inventory, if no price is initially set, the items are transferred anyways. The items can then be purchased from other users without deduction since the price displayed in the store for the item is set default as 0. Although this might be a big problem, perhaps you could also give an error message stating that an initial price must be given when transferring items from a personal inventory to a personal store. (I believe that's the main reason someone would transfer items to a store in the first place, besides wanting to "trade" with someone until a trade function becomes available.)


Moving/Pricing Store Inventory Items w/o Selecting Items
When going to a personal store and selecting to Price or Move items without selecting any items to price or move, the following error is given:

Code: Select all

error getting items's information

DEBUG MODE

SQL Error : 1064 You have an error in your SQL syntax. Check the manual that corresponds to your MySQL server version for the right syntax to use near 'LIMIT 1' at line 1

SELECT * FROM phpbb_store_items WHERE item_id = LIMIT 1

Line : 394
File : functions_store.php
Could you perhaps give a user-friendly error message so that the user can know what is wrong?


Max Purchasing Value
In Configuration, there is an option to set the maximum amount of items a user can purchase. The default is 10. Currently, when trying to set it to any different value, the following error is given:

Code: Select all

Download security fix failed

DEBUG MODE

SQL Error : 1054 Unknown column 'dl_safety' in 'field list'

SELECT cash_id, cash_name, cash_usestore FROM phpbb_cash ORDER BY cash_order

Line : 763
File : admin_store.php
Even so, the value is still set nonetheless. Could you instead give a user-friendly confirmation of a successfully set value? Also, could you perhaps set -1 to be infinite? While integers below -1 could have a user-friendly error message stating that you're not allowed to set values lower than that integer.
DarthShrine
Registered User
Posts: 5
Joined: Wed May 18, 2005 10:26 am

Post by DarthShrine »

geoffreak, maybe you could do something that lets you change stuff, like name colours, or make your own Rank, or something like that :D
geoffreak
Registered User
Posts: 591
Joined: Sat Feb 12, 2005 8:39 am
Contact:

Post by geoffreak »

>> Prizem
priv_group errors fixed
-x moving to store bug fixed
error when setting max purchase value fixed

within 0.1.2 I will have some more friendly error messages plus the features you mentioned

for the files you need to reupload see the first page
Anime Revolution - Your new #1 source for All things anime and manga!
READ MY BLOG ALREADY!
crappytheclown
Registered User
Posts: 106
Joined: Tue Mar 29, 2005 10:50 pm
Location: NYC
Contact:

Post by crappytheclown »

so we're going to have to wait for teh new version to be able to create board owned stores???
Image
geoffreak
Registered User
Posts: 591
Joined: Sat Feb 12, 2005 8:39 am
Contact:

Post by geoffreak »

no... :?
board owned stores aren't new...
and you asked because... :?
Anime Revolution - Your new #1 source for All things anime and manga!
READ MY BLOG ALREADY!
DarkStarDesigns
Registered User
Posts: 17
Joined: Wed Apr 13, 2005 3:20 am
Location: Florida
Contact:

Post by DarkStarDesigns »

I get this error after I installed everything and when I get to the page it tells me this.

Code: Select all

error getting stores the user owns

DEBUG MODE

SQL Error : 1146 Table 'darkstar_phpbb1.phpbb_store_list' doesn't exist

SELECT * FROM phpbb_store_list WHERE owner_id = 0

Line : 294
File : functions_store.php
Please someone help me.
crappytheclown
Registered User
Posts: 106
Joined: Tue Mar 29, 2005 10:50 pm
Location: NYC
Contact:

Post by crappytheclown »

geoffreak wrote: >> Prizem
priv_group errors fixed
-x moving to store bug fixed
error when setting max purchase value fixed

within 0.1.2 I will have some more friendly error messages plus the features you mentioned

for the files you need to reupload see the first page



there u sed thtat in the new version youll update the priv _group thing error but im asking will it be in the new version or is it for download currently (the updadted files)
Image
Smeep
Registered User
Posts: 86
Joined: Fri Aug 27, 2004 2:47 pm

Post by Smeep »

People still can not download items.

The item's add to the store sucsefully, and If I go looky at the item description, it says it's a DL, and if I click DL it downloads the correct file.

But if people attempt to buy it, it just returns to the stores inventory.

No money is debited, no item is recieved, and no download dialogue appears.
crappytheclown
Registered User
Posts: 106
Joined: Tue Mar 29, 2005 10:50 pm
Location: NYC
Contact:

Post by crappytheclown »

Smeep wrote: People still can not download items.

The item's add to the store sucsefully, and If I go looky at the item description, it says it's a DL, and if I click DL it downloads the correct file.

But if people attempt to buy it, it just returns to the stores inventory.

No money is debited, no item is recieved, and no download dialogue appears.


i have the same exact problem as smeep
Image
DarkStarDesigns
Registered User
Posts: 17
Joined: Wed Apr 13, 2005 3:20 am
Location: Florida
Contact:

Post by DarkStarDesigns »

Smeep wrote: People still can not download items.

The item's add to the store sucsefully, and If I go looky at the item description, it says it's a DL, and if I click DL it downloads the correct file.

But if people attempt to buy it, it just returns to the stores inventory.

No money is debited, no item is recieved, and no download dialogue appears.


I am also having that problem.
crappytheclown
Registered User
Posts: 106
Joined: Tue Mar 29, 2005 10:50 pm
Location: NYC
Contact:

Post by crappytheclown »

in addition to my other problem, I only am seeing one item when i access the forum store
Image
DarkStarDesigns
Registered User
Posts: 17
Joined: Wed Apr 13, 2005 3:20 am
Location: Florida
Contact:

Post by DarkStarDesigns »

Also after I added mutiple items to my store on the Admin Control Panel I only see one item in the store.
geoffreak
Registered User
Posts: 591
Joined: Sat Feb 12, 2005 8:39 am
Contact:

Post by geoffreak »

>> DarkStarDesigns
Run the sql installer in the ACP

>> crappytheclown
the priv_group errors are fixed
next version will include some custom error messages vs the normal phpbb sql errors

>> Smeep
ok I will have to run some tests then a bit later...

>> crappytheclown
you BOTH have that problem?
ok I will have to run some tests then a bit later...

>> DarkStarDesigns
all THREE of you now?
ok I will have to run some tests then a bit later...

>> crappytheclown
ok that must be a variable bug. I will have to check it out later..

>> DarkStarDesigns
ok that must be a variable bug. I will have to check it out later..
Anime Revolution - Your new #1 source for All things anime and manga!
READ MY BLOG ALREADY!
DarkStarDesigns
Registered User
Posts: 17
Joined: Wed Apr 13, 2005 3:20 am
Location: Florida
Contact:

Post by DarkStarDesigns »

Please get it to work I really want them for my forums. :)
KevDesigns
Registered User
Posts: 62
Joined: Thu Apr 14, 2005 12:05 pm
Location: Florida
Contact:

Post by KevDesigns »

heh im having the same problem as you all. hi darkstar. :D
Locked

Return to “[2.0.x] MODs in Development”