geoffreak wrote: >> Prizem
I tried to remove that but I guess I missed one
I shall fix store.php and re-upload soon
I'm not sure if you caught it, but the source of the errors are found in admin_store.php. By removing or commenting out references to the non-existent database value "priv_group," board-owned stores can once again be created.
Excess Item Amounts from Stores
Thank you for fixing the error of moving higher values of items from the personal inventory to a personal store. However, just the opposite occurs as well! If you presently have a set amount of items in the store, you can move an extra amount of items from the store to your personal inventory without anything stopping you from doing so. The store shows up as having a negative amount of the item.
When trying to move the excess amount back to the personal store you transferred from, the amount disappears, as the store gives a 0 count. In fact, even if you purchase it from elsewhere (the board, for instance), then transfer it to the original personal store, the count continues to be 0. The only way to get the count back of such an item is to delete the personal store and create a new one. Therefore, to exploit the loophole, the user simply has to delete the original store and create a new one in order to sell an excess amount.
Items Disappear When Deleting Store
When deleting a personal store, whether it be on the store's menu or on the list of stores, if you have items in the store, the items disappear when the store is deleted. This makes it a slight inconvinence, since you have to move all the items back to your inventory if you want to delete the store and not lose your items! Could you make it so that the items are automatically returned to your personal inventory when deleting the store?
Pricing Items When Transferring from Personal Inventory
When transferring items from your personal inventory, if no price is initially set, the items are transferred anyways. The items can then be purchased from other users without deduction since the price displayed in the store for the item is set default as 0. Although this might be a big problem, perhaps you could also give an error message stating that an initial price must be given when transferring items from a personal inventory to a personal store. (I believe that's the main reason someone would transfer items to a store in the first place, besides wanting to "trade" with someone until a trade function becomes available.)
Moving/Pricing Store Inventory Items w/o Selecting Items
When going to a personal store and selecting to Price or Move items without selecting any items to price or move, the following error is given:
Code: Select all
error getting items's information DEBUG MODE SQL Error : 1064 You have an error in your SQL syntax. Check the manual that corresponds to your MySQL server version for the right syntax to use near 'LIMIT 1' at line 1 SELECT * FROM phpbb_store_items WHERE item_id = LIMIT 1 Line : 394 File : functions_store.php
Max Purchasing Value
In Configuration, there is an option to set the maximum amount of items a user can purchase. The default is 10. Currently, when trying to set it to any different value, the following error is given:
Code: Select all
Download security fix failed DEBUG MODE SQL Error : 1054 Unknown column 'dl_safety' in 'field list' SELECT cash_id, cash_name, cash_usestore FROM phpbb_cash ORDER BY cash_order Line : 763 File : admin_store.php