[DISC] Ban Suite (previous Extenend ban manager) (MMW)

A place for MOD Authors to post and receive feedback on MODs still in development. No MODs within this forum should be used within a live environment! No new topics are allowed in this forum.
Forum rules
READ: phpBB.com Board-Wide Rules and Regulations

IMPORTANT: MOD Development Forum rules

On February 1, 2009 this forum will be set to read only as part of retiring of phpBB2.
DjDoxy
Registered User
Posts: 13
Joined: Wed Dec 14, 2005 2:30 pm

Post by DjDoxy » Wed Nov 29, 2006 4:01 pm

Here is another fix for anther bug ;)

When displaying the list of ban (link "Moderator ban panel" on the bottom of the page, or from the admin panel) only the first 15 bans are displayed.
Clinking on the "Next" link (or on the page number) always display the same list...

Not a big problem, but having it working would be nice, isn't it ?

Actualle, the fix is very simple:

In includes\functions_ban_actions.php

find the ban() function

Code: Select all

function ban()
	{                    
		
		global $template,$ban,$db,$phpEx,$lang;
(...)
:idea: The problem comes from the global line which miss the $HTTP_GET_VARS and $HTTP_POST_VARS, variables.


:arrow: The correct line should be

Code: Select all

function ban()
	{                    
		
global $HTTP_GET_VARS,$HTTP_POST_VARS,$template,$ban,$db,$phpEx,$lang;

Fisch.666
Registered User
Posts: 219
Joined: Sat Jul 30, 2005 10:58 am

Post by Fisch.666 » Fri Dec 01, 2006 5:25 pm

Hi!

I have a problem with the ban suite. When i try to ban a user with a ³ in his name, i get this error:
An unknown JavaScript error has occurred.
DEBUG:
Message: txt.getElementsByTagName("content")[0] has no properties
Name: TypeError
File: http://www.url.de/phpBB2/admin/admin_ba ... dc5e7e2ba1
Line: 101


Any ideas how i can fix this?

@DjDoxy
Thanks for this bugfixes!

SuperFedya
Registered User
Posts: 248
Joined: Sun Jul 14, 2002 9:14 pm
Contact:

Post by SuperFedya » Sun Jan 14, 2007 5:12 am

Hello
Someone! Give me screens of the Report function, please.

Thanks!

Fisch.666
Registered User
Posts: 219
Joined: Sat Jul 30, 2005 10:58 am

Post by Fisch.666 » Sat Feb 10, 2007 6:49 pm

Hi!

And another error when i try to ban a user with a space in his name:

Code: Select all

An unknown JavaScript error has occurred.
DEBUG:
Message: txt has no properties
Name: TypeError
File: http://www.url.de/phpBB2/admin/admin_bansuite.php?act=js&sid=526050866fac7c74f36376dc5e7e2ba1
Line: 100
Any hints how to fix that?

Paul
Infrastructure Team Leader
Infrastructure Team Leader
Posts: 25488
Joined: Sat Dec 04, 2004 3:44 pm
Location: The netherlands.
Name: Paul Sohier
Contact:

Post by Paul » Sat Feb 10, 2007 6:55 pm

Sorry, at this moment i hasn't time to develop this mod further, maybe when i has some more time(Begin next month), i will develop further.
Knock knock
Race condition
Who's there?

My BlogMy Photosmy phpBB Extensionscustom phpBB work & Development

User avatar
Raimon
Former Team Member
Posts: 12088
Joined: Tue May 30, 2006 5:31 pm
Location: Netherlands
Name: Raimon Meuldijk
Contact:

Post by Raimon » Sat Feb 10, 2007 7:03 pm

Thats to bad paul999, but we should waith paitent i think and convins us of the great mod when you have the time ;)
Need phpBB installation, extenstions, Styles or integrate phpBB with you website?
Contact me for fair prices and good service!

Fisch.666
Registered User
Posts: 219
Joined: Sat Jul 30, 2005 10:58 am

Post by Fisch.666 » Wed Feb 14, 2007 10:09 pm

Hi paul999,

you get no money for your work so you don't have to say sorry... :D

But another question, maybe you can help me with this:

Does the Ban Suite affect the normal banning? I ask this because i've try to ban this user and his email address with the old admin_user_ban.php, but this user can still login and post at my forum.

Dzyzus
Registered User
Posts: 3
Joined: Tue Jan 04, 2005 1:28 am

Post by Dzyzus » Fri Feb 16, 2007 4:48 pm

Then trying to report post
Image
Then going to Reports
Image

enderandrew
Registered User
Posts: 71
Joined: Thu Nov 30, 2006 7:55 am
Location: Omaha, NE
Contact:

Temp Bans?

Post by enderandrew » Mon Feb 19, 2007 10:43 pm

Any plans on implementing temp bans like this:

http://www.phpbb.com/phpBB/viewtopic.php?t=431660
Nihilism makes me smile.

Paul
Infrastructure Team Leader
Infrastructure Team Leader
Posts: 25488
Joined: Sat Dec 04, 2004 3:44 pm
Location: The netherlands.
Name: Paul Sohier
Contact:

Post by Paul » Tue Feb 20, 2007 8:47 am

Please read the topic and the first post.
Thats already included.
Knock knock
Race condition
Who's there?

My BlogMy Photosmy phpBB Extensionscustom phpBB work & Development

enderandrew
Registered User
Posts: 71
Joined: Thu Nov 30, 2006 7:55 am
Location: Omaha, NE
Contact:

Post by enderandrew » Thu Feb 22, 2007 4:23 pm

I always do. I did a search in this thread for "temp ban" and "temp " and found nothing.

If you don't believe me, you're more than welcome to check yourself.

With several mods that cover the same territory, it is nice to know which features each includes and how they compare so one can decide which one to install.
Nihilism makes me smile.

DjDoxy
Registered User
Posts: 13
Joined: Wed Dec 14, 2005 2:30 pm

Re:

Post by DjDoxy » Tue Mar 27, 2007 7:08 pm

HI all.

If found a bug... in my fix! :oops:
Shame on me...

Well, here is a litte update on what I wrote on Tue Nov 28:
DjDoxy wrote: This workaround is simple:
Just replace

Code: Select all

else {
$ban = false;
}
by this:

Code: Select all

else
		{       
		// Consider user not banned only if:
               // all ban fields ar empty (IP address 0.0.0.0 is considered as empty) 
			if((empty($ban['ban_ip']) ||  $ban['ban_ip']=='0.0.0.0')
				&& empty($ban['ban_cookie'])
				&& empty($ban['cookie_id'])
				&& empty($ban['user_id'])
				&& empty($ban['time'])) {
				$ban = false;  
			}
		}



In the fix I wrote && empty($ban['user_id']) while it should be && empty($ban['ban_userid'])
as the user id is stored in the ban table under the colum "ban_userid" and not "user_id"

The consequence of this mistake was that if you ban a user permanently using the "standard" ban feature of phbBB (and not the ban suite panel), then the user will not be seen as baned :roll:

This is probably what happened to Fisch.666
Fisch.666 wrote: Does the Ban Suite affect the normal banning? I ask this because i've try to ban this user and his email address with the old admin_user_ban.php, but this user can still login and post at my forum.


So here is the final fix

Code: Select all

else
		{       
		// Consider user not banned only if:
               // all ban fields ar empty (IP address 0.0.0.0 is considered as empty) 
			if((empty($ban['ban_ip']) ||  $ban['ban_ip']=='0.0.0.0')
				&& empty($ban['ban_cookie'])
				&& empty($ban['cookie_id'])
				&& empty($ban['ban_userid'])
				&& empty($ban['time'])) {
				$ban = false;  
			}
		}

Sorry for the inconvience

e-mo
Registered User
Posts: 90
Joined: Tue Oct 01, 2002 2:54 pm

Re: [BETA] Ban Suite (previous Extenend ban manager) (MMW)

Post by e-mo » Tue Mar 27, 2007 10:03 pm

Hello,

several questions to that mod.
will it show the reason for banning to that user when he tries to login, and if yes, will it be shown who was banning him?? and if he was banned for a certain time, will the time/count down be displayed to him when trying to login?

doie,

e-mo
...with great power...comes great responsibilities...

Looking help for this Mod Problem: http://www.phpbb.com/community/viewtopi ... &start=165

e-mo
Registered User
Posts: 90
Joined: Tue Oct 01, 2002 2:54 pm

Re: [BETA] Ban Suite (previous Extenend ban manager) (MMW)

Post by e-mo » Fri Mar 30, 2007 8:18 pm

hm...

warning was issued to me so fast, but not the question to your own mod I am asking....eventhough you are logged in regularely...
revise prioritization please!

e-mo
...with great power...comes great responsibilities...

Looking help for this Mod Problem: http://www.phpbb.com/community/viewtopi ... &start=165

e-mo
Registered User
Posts: 90
Joined: Tue Oct 01, 2002 2:54 pm

Re: [BETA] Ban Suite (previous Extenend ban manager) (MMW)

Post by e-mo » Thu Apr 05, 2007 11:02 am

Is this mod still active? if not, please state, so users are aware of it and not posting without receiving answers...


e-mo
...with great power...comes great responsibilities...

Looking help for this Mod Problem: http://www.phpbb.com/community/viewtopi ... &start=165

Locked

Return to “[2.0.x] MODs in Development”