[RC2] phpBB2 Native SQL Caching (1.1.0)

[tunafish]

The other one does not support DBAL.

[EzerchE]

The other one does not support DBAL.

whats dbal?

[bonelifer]

DBAL= DataBase Abstraction Layer

[Mr. Spoonman]

Hey there - great mod, but I have two questions...

After installing the mod I get the following error messages when I try to login to my ACP:

Code: Select all

Warning: current() [function.current]: Passed variable is not an array or object in /V2/db/sql_cache.php on line 74

Warning: next() [function.next]: Passed variable is not an array or object in /V2/db/sql_cache.php on line 75

After that I wrote a quick workaround to exclude the admin/index.php from the sql_cache.php-file. Now I can logon to my ACP but if I click on any of my links there, the same error messages come up...okay, I could write this workaround for every file I have in my admin-folder, but I think If the bug lies within this mod maybe you could find it for me?

Second thing...I tried two "Page Generation Time"-Mods. Before I installed this mod I got about 60 SQL-Queries shown there - after the Install there are 130-200 SQL-Queries although the board "feels" faster...that is with every version (Smartors PGT, Extended Admin Information) I tried...

Can you help, please?

PHPBB: 2.0.21
MYSQL: V4
PHP: V4
Native SQL Caching: 1.1.0 (w. Configuration Table SQL Caching)
Other Mods: Hundreds (The big ones: Extreme Styles Mod, Attachment Mod, UPI2DB, CrackerTracker 5.0.3, Activity Mod+)

[dcz]

Interesting, could you elaborate a bit about the conditions we could set to update cache (ACP visit, specific action time ...).

What's handy with phpBB styles one is that you can create as many type of cache, with different refresh conditions. This is just very handy to add support for module like KB and clear it's cache independently from phpBB's.

Anyway, great job

++

[genial.soul]

Hi
i installed this mod
mod works fine but if i use its addon for config table i get the following error when i try to login to ACP

Code: Select all

Warning: current() [function.current]: Passed variable is not an array or object in /db/sql_cache.php on line 74

Warning: next() [function.next]: Passed variable is not an array or object in /db/sql_cache.php on line 75

I have Extreme Mod Installed
Any help or suggestions ?

[EfSaNe]

When i wasn't changing db.php file, it is running right but when i was a changing, the forum is not running.i have Xs mod installed. What is the problem ?

[vitjok]

Hi everyone!
It seems that I found the source of this problem:

Code: Select all

Warning: current() [function.current]: Passed variable is not an array or object in /db/sql_cache.php on line 74

Warning: next() [function.next]: Passed variable is not an array or object in /db/sql_cache.php on line 75

If mod is caching some data, and there is a backslash in this data, you are going to get this error.
This is because "some\ text" tuns into "some\\ text" when sql_gen_php() is done, then it turns into
$cache_data = 'some\\ text' in a cache file.
Then when file is included, the data in variable $cache_data is "some\ text", and finally after stripslashes() it is "some text", which is different from the original data. This leads to unserialize() to fail, and then current() and next() don't get an array.

The fix:
change file includes/class_cache.php, function sql_gen_php:

Code: Select all

addslashes ( serialize ( $cache_data )
replace with
addcslashes( addslashes ( serialize ( $cache_data ) ), '\\' )

I may be missing something, a review of this fix would be great.

My comment:
Including the cache file is bad here.
Saving a serialized data in a file, and then getting this data with file_get_contents() and unserializing it back would be better.
Timestamp can be on the first line, and the second line is our cached data.

[vitjok]

Hi again everyone, I found my own bug in a fix: there can be ' symbols in serialized string, so it should be also escaped. So:

Code: Select all

addslashes ( serialize ( $cache_data )
replace with
addcslashes( addslashes ( serialize ( $cache_data ) ), '\\\'' )

There is no need to escape " symbol as string is stored between two '. Even worse - it breaks everything.