[RC8] Quick Title Edition 1.6.2a

A place for MOD Authors to post and receive feedback on MODs still in development. No MODs within this forum should be used within a live environment! No new topics are allowed in this forum.
Forum rules
READ: phpBB.com Board-Wide Rules and Regulations

IMPORTANT: MOD Development Forum rules

On February 1, 2009 this forum will be set to read only as part of retiring of phpBB2.
User avatar
ABDev
Registered User
Posts: 901
Joined: Sun Aug 21, 2005 9:29 pm
Location: France
Name: Adrien Bonnel

Re: [RC6] Quick Title Edition 1.6.0b

Post by ABDev » Fri Sep 14, 2007 8:10 pm

I'll look for this, but I have no errors for the moment.

User avatar
ABDev
Registered User
Posts: 901
Joined: Sun Aug 21, 2005 9:29 pm
Location: France
Name: Adrien Bonnel

Re: [RC6] Quick Title Edition 1.6.0b

Post by ABDev » Wed Oct 03, 2007 10:54 am

New version 1.6.0c

List of the modifications :
  • Fixed an error : the topic authors couldn't apply attributes from the viewtopic page
  • Reduced code in attributes administration
  • Added a switch to hide the attributes combo when the users don't have the necessary permissions

Legster
Registered User
Posts: 8
Joined: Fri Oct 05, 2007 11:36 am

Re: [RC6] Quick Title Edition 1.6.0c

Post by Legster » Fri Oct 05, 2007 11:39 am

[solved]
Where can I find version C? Its not on phpbbhack.com..

also have the Warning: Missing argument 2 for qte::combo( error.
is there a simple edit to fix this (cuz the addon works fine, just all get the annoying error).


ok followed your private info to your forum and downloaded the latest version there.
then i looked at differences in the 2 files.

for other ppl that got it working but just want the error to go away you can

replace: 'S_ATTRIBUTE_SELECTOR' => $qte->combo($forum_topic_data['topic_attribute']),

with:
'S_ATTRIBUTE_SELECTOR' => $qte->combo($forum_topic_data['topic_attribute'], $forum_topic_data['topic_poster']),

User avatar
ABDev
Registered User
Posts: 901
Joined: Sun Aug 21, 2005 9:29 pm
Location: France
Name: Adrien Bonnel

Re: [RC6] Quick Title Edition 1.6.0c

Post by ABDev » Fri Oct 05, 2007 4:04 pm

The link for the last version is inside the first post, or on my board.
The error you quoted is fixed since the 1.6.0c version.

Legster
Registered User
Posts: 8
Joined: Fri Oct 05, 2007 11:36 am

Re: [RC6] Quick Title Edition 1.6.0c

Post by Legster » Fri Oct 05, 2007 5:04 pm

Do you by any chance have codechange listing?
I do have the addon installed and working (version A) but if i want to update to version C, I like to know what is changed from A to C so I can manually edit the php files that where altered.

If you didnt keep track of the changes then I can understand that you dont want to backtrack all your edits to make a txt file how to upgrade from A to C , but If you did keep track, that might be every handy for all users that use the A version :)

I edited my board about 20x to implement all addons I got running now, so just copying files from the release to replace the ones on my server is not an option for me.

Few minor things that dont work with my install are:
* Move up/down in admin (to organise the lines)
* Attributes (the first option in the admin menu just gives a really small dropdownbox without options).
These dont give me any problems in using though so no big deal.

Mostly interested in how to implement the "hide attributes box from non authorized users". Got 156 active users and only 10 can use it, so no point in letting the other 146 see it :)

Lastly I wonder if you in any future update can make another option to who can use besides Admin, Moderator, Poster, you can perhaps add Groups.

Love your addon mate, you did a VERY good job imo :) keep up the good work !

User avatar
ABDev
Registered User
Posts: 901
Joined: Sun Aug 21, 2005 9:29 pm
Location: France
Name: Adrien Bonnel

Re: [RC6] Quick Title Edition 1.6.0c

Post by ABDev » Sat Oct 06, 2007 11:54 am

Hi,
I think you didn't look inside the MOD file.
In mod-qte_160c.txt, you can find this :

Code: Select all

## 2007-10-01 - Version 1.6.0c
##		- Fixed an error : the topic authors couldn't apply attributes from
##			the viewtopic page
##    - Reduced code in attributes administration
##		- Added a switch to hide the attributes combo when the users don't have
##			the necessary permissions
##
## 2007-09-10 - Version 1.6.0b
##		- Small code fixes
##    - Reduced code in attributes administration
##		- Added the image and language keys as examples
##		- Revized all the addons compatibility
##
## 2007-09-04 - Version 1.6.0a
##		- Small fixes
So, you have the changelog.
For the code changes, you have to go in the \upgrade\ folder.
Inside, you have many files. But only two will interest you :
  • changelog_160a_160b.txt
  • changelog_160b_160c.txt
Apply, in a first time, the changelog_160a_160b.txt file. And, after, the changelog_160b_160c.txt file.
Your version will be upgraded to the "c" release.

The errors you quote have been fixed since the "b" release, if I remember.

Thanks for your congratulations ;).

Legster
Registered User
Posts: 8
Joined: Fri Oct 05, 2007 11:36 am

Re: [RC6] Quick Title Edition 1.6.0c

Post by Legster » Sun Oct 07, 2007 11:33 am

Cool:)

ok updated from A to C. All bugs dissapeared like snow for the sun :) great work!

Powlo_U.K.
Registered User
Posts: 57
Joined: Sun Sep 03, 2006 11:20 pm

Re: [RC6] Quick Title Edition 1.6.0c

Post by Powlo_U.K. » Sun Oct 14, 2007 11:02 pm

Is there any possibility that this modification could be worked into phpbb 'plus' ? Im using this pre-modded phpbb based forum at the moment and would love to include this as ive had it on other forums in the past.

All the code fits in fine until i attempt the viewforum.php code, specifically this bit..

Code: Select all

# This may be a partial find and not the whole line(s)
#
$topic_title = ( count($orig_word) ) ?
#
#-----[ AFTER, ADD ]------------------------------------------
#
//-- mod : quick title edition -------------------------------------------------
//-- add
		$qte->attr($topic_title, $topic_rowset[$i]['topic_attribute']);
//-- fin mod : quick title edition ---------------------------------------------
the code does exsist there but it has been commented out...

Code: Select all

// Note : all the code that was standing there stands now in functions_topics_list.php, topic_list() func
//
//---------------------------------------

if( $total_topics )
{
	for($i = 0; $i < $total_topics; $i++)
	{
		$topic_id = $topic_rowset[$i]['topic_id'];

		$topic_title = ( count($orig_word) ) ? preg_replace($orig_word, $replacement_word, $topic_rowset[$i]['topic_title']) : $topic_rowset[$i]['topic_title'];
I then go to the functions_topics_list.php, which resides in the Includes directory and find this...

Code: Select all

		$topic_item_type	= substr($topic_rowset[$i]['topic_id'], 0, 1);
		$topic_id			= intval(substr($topic_rowset[$i]['topic_id'], 1));
		$topic_title		= ( count($orig_word) ) ? preg_replace($orig_word, $replacement_word, $topic_rowset[$i]['topic_title']) : $topic_rowset[$i]['topic_title'];
Ive tried several ways of trying to intergrate the code but it always bums out and gives no forums at all. Like i say the rest of the code fits in fine and as it stands the mod is working but i dont see the result in the view forum.

Any help or direction would be very much apreciated.

User avatar
ABDev
Registered User
Posts: 901
Joined: Sun Aug 21, 2005 9:29 pm
Location: France
Name: Adrien Bonnel

Re: [RC6] Quick Title Edition 1.6.0c

Post by ABDev » Sun Oct 14, 2007 11:19 pm

Hi,
Try to apply the modifications, from the Topics List addon file.
If I remember, it's inside the /optional/ folder.

Powlo_U.K.
Registered User
Posts: 57
Joined: Sun Sep 03, 2006 11:20 pm

Re: [RC6] Quick Title Edition 1.6.0c

Post by Powlo_U.K. » Sun Oct 14, 2007 11:42 pm

Ive just tried the 'Quick Title Edition on Split Topic Type MOD' addon as its the only one that refers to the 'functions_topics_list.php' file and made all the relevant changes....

Code: Select all

#-----[ OPEN ]------------------------------------------
#
includes/functions_topics_list.php
#
#-----[ FIND ]------------------------------------------
#
global $tree;
#
#-----[ AFTER, ADD ]------------------------------------------
#
//-- mod : quick title edition -------------------------------------------------
//-- add
	global $qte;
//-- fin mod : quick title edition ---------------------------------------------
#
#-----[ FIND ]------------------------------------------
#
# This may be a partial find and not the whole line(s)
#
$topic_title		=
#
#-----[ AFTER, ADD ]------------------------------------------
#
//-- mod : quick title edition -------------------------------------------------
//-- add
		$qte->attr($topic_title, $topic_rowset[$i]['topic_attribute']);
//-- fin mod : quick title edition ---------------------------------------------
#
#-----[ SAVE/CLOSE ALL FILES ]------------------------------------------
But still no joy, it returns no furums at all. Ive been through this a few times now and i cant see that ive made any errors.

User avatar
ABDev
Registered User
Posts: 901
Joined: Sun Aug 21, 2005 9:29 pm
Location: France
Name: Adrien Bonnel

Re: [RC6] Quick Title Edition 1.6.0c

Post by ABDev » Mon Oct 15, 2007 9:13 am

I can't really help you. I don't find a download link for phpBB 'plus'.
If I were you, I'd ask to the preMOD author ;).

User avatar
ABDev
Registered User
Posts: 901
Joined: Sun Aug 21, 2005 9:29 pm
Location: France
Name: Adrien Bonnel

Re: [RC7] Quick Title Edition 1.6.1

Post by ABDev » Tue Nov 06, 2007 10:37 pm

New version 1.6.1

List of the modifications :
  • Fixed a security issue
  • Fixed a small constant error in the attributes management
  • Reduced a small part of code in the attributes administration
  • Fixed a CSS error in the language file

User avatar
ABDev
Registered User
Posts: 901
Joined: Sun Aug 21, 2005 9:29 pm
Location: France
Name: Adrien Bonnel

Re: [RC8] Quick Title Edition 1.6.2

Post by ABDev » Wed Nov 21, 2007 3:16 pm

New version 1.6.2

List of the modifications :
  • Added a SQL entry call from posting form
  • The attributes color can now be a numerical RGB color or a CSS class

Legster
Registered User
Posts: 8
Joined: Fri Oct 05, 2007 11:36 am

Re: [RC8] Quick Title Edition 1.6.2

Post by Legster » Wed Nov 28, 2007 2:30 pm

been using this for some time without any problems. (have 1.6.0 C)

Now I have a question regarding this and an other problem I have now.
I tried to make Poll today to see what my users thought of a new roster.
Then i noticed that only moderators could vote, but not normal users, eventhough they have the vote permission set to yes.

So i begin to think what could be the problem and i remember that from version A to C of this mod one of the changes was to make it so that only moderators where able to see the Quick Title Edition and not the normal users.

Since this is the only addon that i recently installed that has anthing to do with rights, I suspect that the problem lies here.

To test this out I made a new user, Gave him group rights and tried to vote on a poll.
I got: The forum you selected does not exist.

Now when i give this same user a moderation on *ANY* part of the forum, this user gets access to the Quick title edition option, and also now they can vote a cast without any problems.

Is there any pointer you can think of that might be responcible for this behaviour?

Legster
Registered User
Posts: 8
Joined: Fri Oct 05, 2007 11:36 am

Re: [RC8] Quick Title Edition 1.6.2

Post by Legster » Wed Nov 28, 2007 3:32 pm

Ok tested out some code and when I disable in Viewtopic.php:

if ( ( ($userdata['user_id'] == $postrow[$row_id]['topic_poster']) && ($userdata['user_level'] == USER) ) ||
($userdata['user_level'] == MOD) || ($userdata['user_level'] == ADMIN) )

all members can vote again. So its indeed based on this addon with a problem in the above line that not only disables members to use QTE , but also disables Poll voting.

There any suggestion on how to edit the above line so it ONLY works for QTE?

PS: Im using 1.6.0c . In release notes i didnt see anything that suggest me that this is fixed in 1.6.2. though.

Post Reply

Return to “[2.0.x] MODs in Development”

Who is online

Users browsing this forum: No registered users and 14 guests

cron