[RC2] Multiple PM Recipients 0.6.1 (MMW)

A place for MOD Authors to post and receive feedback on MODs still in development. No MODs within this forum should be used within a live environment! No new topics are allowed in this forum.
Forum rules
READ: phpBB.com Board-Wide Rules and Regulations

IMPORTANT: MOD Development Forum rules

On February 1, 2009 this forum will be set to read only as part of retiring of phpBB2.
Mr Papa
Registered User
Posts: 44
Joined: Wed Jul 26, 2006 1:48 am

Post by Mr Papa » Mon Aug 07, 2006 7:00 pm

doh! I missed the RC1 in the topic title... Sorry, had been looking in the first post... gonna give it a try later tonight...

thanks...

Mr Papa

Mr Papa
Registered User
Posts: 44
Joined: Wed Jul 26, 2006 1:48 am

Post by Mr Papa » Tue Aug 08, 2006 3:39 am

Installing this now, but a bit confused by the instructions...

Is the file for download 0.5 or 0.5.1?? The file name indicates 0.5 by the mod install file says 0.5.1. Do I have to to the 0.5 install and then 0.5.1 install despite what the mod install file says is the current file?

The changes for privmsg.php are also clouding the issue. From the mod install file

Code: Select all

#
#-----[ FIND ]------------------------------------------
#	
	if ( $mode == 'post' )
	{
		$post_a = $lang['Send_a_new_message'];
	}
	else if ( $mode == 'reply' )
	{
		$post_a = $lang['Send_a_reply'];
		$mode = 'post';
	}
	else if ( $mode == 'edit' )
	{
		$post_a = $lang['Edit_message'];
	}
	if (!$template->_tpldata['recipients.'])
	{
		$template->assign_block_vars('recipients', array("R_USERNAME" => '', "R_FIELDNAME" => 'username_0'));
	}

#
#-----[ REPLACE WITH ]----------------------------------
#
	if ( $mode == 'post' )
	{
		$post_a = $lang['Send_a_new_message'];
		$template->assign_block_vars('switch_not_edit_privmsg', array());
	}
	else if ( $mode == 'reply' )
	{
		$post_a = $lang['Send_a_reply'];
		$mode = 'post';
		$template->assign_block_vars('switch_edit_privmsg', array());
	}
	else if ( $mode == 'edit' )
	{
		$post_a = $lang['Edit_message'];
		$template->assign_block_vars('switch_edit_privmsg', array());
	}

Now the last "if" statement in the FIND section does not appear in any templates that I use and appears to be related to this mod.

That same block_vars assignment does get made in the 0.5.1 upgrade mod.

So, I think I know what the proper syntax is, but wanted to get is straight here first...

Thanks.

Mr Papa

hmartin
Registered User
Posts: 118
Joined: Mon Jun 06, 2005 2:49 am
Location: /home/
Contact:

Post by hmartin » Tue Aug 08, 2006 4:14 am

The filename is 0.5, but the MOD version is actually at 0.5.1 (i.e. what's actually written in the file).
Actually, it's at 0.5.1a now since that last if block on the find should actually be in the replace (as you probably figured out by now).
Sorry about the confusion.
My MODs:
Multiple PM Recipients - Send PMs to multiple users simultaneously
Stylist - Users can modify a forum's appearance by uploading custom CSS files
Download All Attachments As Zip - Download multiple attachments in a single zip file.
Collapsible Categories - Cleanly collapse categories on the index page

Mr Papa
Registered User
Posts: 44
Joined: Wed Jul 26, 2006 1:48 am

Post by Mr Papa » Tue Aug 08, 2006 4:18 am

:wink: Thanks...

Mr Papa

Mr Papa
Registered User
Posts: 44
Joined: Wed Jul 26, 2006 1:48 am

Post by Mr Papa » Tue Aug 08, 2006 4:47 am

looking nice... one mod request though...

when a user puts in an incorrect username and you have it set to die, you are given an informational error page about the error. Could you a link that says back to prev page to correct rather than just the error message. I know they can just hit back on the browser, but not all users would figure that out :lol:

Thanks...

Mr Papa

hmartin
Registered User
Posts: 118
Joined: Mon Jun 06, 2005 2:49 am
Location: /home/
Contact:

Post by hmartin » Wed Aug 09, 2006 3:18 am

Mr Papa wrote: Could you a link that says back to prev page to correct rather than just the error message. I know they can just hit back on the browser, but not all users would figure that out :lol:

So true :lol:
It's included with the latest release (which you might also want to look at since it includes a couple bug fixes).
My MODs:
Multiple PM Recipients - Send PMs to multiple users simultaneously
Stylist - Users can modify a forum's appearance by uploading custom CSS files
Download All Attachments As Zip - Download multiple attachments in a single zip file.
Collapsible Categories - Cleanly collapse categories on the index page

raginpit
Registered User
Posts: 32
Joined: Thu Mar 16, 2006 12:11 am

Post by raginpit » Mon Aug 14, 2006 9:17 pm

Parse error: syntax error, unexpected T_ELSE in /home/raginpit/public_html/backstage/privmsg.php on line 1523

Have any idea on how to fix this?

hmartin
Registered User
Posts: 118
Joined: Mon Jun 06, 2005 2:49 am
Location: /home/
Contact:

Post by hmartin » Mon Aug 14, 2006 10:23 pm

Sounds like a template problem, which probably isn't related to this MOD. If you want to email me your privmsg.php and posting_body.tpl I'll take a look at them.
My MODs:
Multiple PM Recipients - Send PMs to multiple users simultaneously
Stylist - Users can modify a forum's appearance by uploading custom CSS files
Download All Attachments As Zip - Download multiple attachments in a single zip file.
Collapsible Categories - Cleanly collapse categories on the index page

raginpit
Registered User
Posts: 32
Joined: Thu Mar 16, 2006 12:11 am

Post by raginpit » Mon Aug 14, 2006 10:47 pm

Thanks a lot; email sent.

User avatar
lefty74
Registered User
Posts: 3649
Joined: Wed Sep 14, 2005 8:26 pm
Location: NL
Contact:

Post by lefty74 » Tue Aug 15, 2006 9:30 pm

damn, looks like 3 weeks worth of posting have gone down the drain.

:cry:
lefty74
zoocrew.eu - help us save our wildlife
My MODS | Due to lack of time I unfortunately am unable to work on my mods anymore, anyone who has ideas to improve them and would like to take any of them over, please PM me.

JamesNesbit
Registered User
Posts: 13
Joined: Sat Jan 14, 2006 11:48 am

Post by JamesNesbit » Wed Aug 16, 2006 7:29 am

Great mod hmartin, you've done an impressive amount of work in a very short space of time!

Just a few points that I've noticed on my installation after installing via easymod and tested on IE6 + phpbb 2.0.21

1. Find Username popup seems non-functional, after searching for a valid username a select box never seems to appear

2. Nice add boxes to add multiple recipents, however it really needs a delete button to remove them as well

Aside from that it all looks very nice, looking forward to the final release!

hmartin
Registered User
Posts: 118
Joined: Mon Jun 06, 2005 2:49 am
Location: /home/
Contact:

Post by hmartin » Wed Aug 16, 2006 5:30 pm

JamesNesbit wrote: Great mod hmartin, you've done an impressive amount of work in a very short space of time!

Thanks :D
JamesNesbit wrote: 1. Find Username popup seems non-functional, after searching for a valid username a select box never seems to appear

As of right now, the popup box has no way of "knowing" which username box to put the selected name back in. I think I may try and fix this by simply having it insert back into the last username box.
JamesNesbit wrote: 2. Nice add boxes to add multiple recipents, however it really needs a delete button to remove them as well

Why? You can just leave any extra boxes blank.
My MODs:
Multiple PM Recipients - Send PMs to multiple users simultaneously
Stylist - Users can modify a forum's appearance by uploading custom CSS files
Download All Attachments As Zip - Download multiple attachments in a single zip file.
Collapsible Categories - Cleanly collapse categories on the index page

hmartin
Registered User
Posts: 118
Joined: Mon Jun 06, 2005 2:49 am
Location: /home/
Contact:

Post by hmartin » Sat Aug 19, 2006 4:41 am

I'd like your (plural) opinions on how best to deal with finding usernames. Right now I think the best solution is to implement an autocompletion similiar to gmail, but I'm not sure. If you have any criticisms of this idea or want to offer an alternative, please say so.
My MODs:
Multiple PM Recipients - Send PMs to multiple users simultaneously
Stylist - Users can modify a forum's appearance by uploading custom CSS files
Download All Attachments As Zip - Download multiple attachments in a single zip file.
Collapsible Categories - Cleanly collapse categories on the index page

JamesNesbit
Registered User
Posts: 13
Joined: Sat Jan 14, 2006 11:48 am

Post by JamesNesbit » Sat Aug 19, 2006 10:16 am

hmartin wrote:
JamesNesbit wrote:2. Nice add boxes to add multiple recipents, however it really needs a delete button to remove them as well

Why? You can just leave any extra boxes blank.


Mainly for UI consistency. If users can add boxes, they expect to be able to delete them.

The ajax search function offered by some wordpress installs is better than auto completion IMO, you can see at http://www.elliotswan.com just below the logo in the top left hand corner. There are some installation directions at http://www.elliotswan.com/2006/07/05/better-than-live/

hmartin
Registered User
Posts: 118
Joined: Mon Jun 06, 2005 2:49 am
Location: /home/
Contact:

Post by hmartin » Sat Aug 19, 2006 5:32 pm

JamesNesbit wrote:
hmartin wrote:
JamesNesbit wrote:2. Nice add boxes to add multiple recipents, however it really needs a delete button to remove them as well

Why? You can just leave any extra boxes blank.

Mainly for UI consistency. If users can add boxes, they expect to be able to delete them.

You do have a point there. However, such a thing would (a) clutter the interface, (b) be terribly difficult to code, and (c) would still be unnecessary in the strictest sense.
My MODs:
Multiple PM Recipients - Send PMs to multiple users simultaneously
Stylist - Users can modify a forum's appearance by uploading custom CSS files
Download All Attachments As Zip - Download multiple attachments in a single zip file.
Collapsible Categories - Cleanly collapse categories on the index page

Post Reply

Return to “[2.0.x] MODs in Development”