[MODDB] Approval MOD v2.0

A place for MOD Authors to post and receive feedback on MODs still in development. No MODs within this forum should be used within a live environment! No new topics are allowed in this forum.
Forum rules
READ: phpBB.com Board-Wide Rules and Regulations

IMPORTANT: MOD Development Forum rules

On February 1, 2009 this forum will be set to read only as part of retiring of phpBB2.
Locked
abhishek1711
Registered User
Posts: 528
Joined: Tue Apr 17, 2007 6:08 am
Location: India
Contact:

Re: [RC] Approval MOD v2.0

Post by abhishek1711 » Mon Aug 06, 2007 9:59 am

okie i tried using easymod , shows this error
Error Detail

Critical Error

FIND FAILED: In file [includes/topic_review.php] could not find:

$sql = "SELECT u.username, u.user_id, p.*
FROM
WHERE
AND
AND

MOD script line #2272 :: FAQ :: Report
moreover it still displays in install mods page and not in installd mods history...so how do i reverse the changes in case something went wrong

User avatar
uncle.f
Registered User
Posts: 253
Joined: Thu Mar 25, 2004 11:42 am
Location: Purple Yonder
Contact:

Re: [RC] Approval MOD v2.0

Post by uncle.f » Mon Aug 06, 2007 5:27 pm

abhishek1711 wrote:what i meant are the fixes for simple subforums etc are also auto installed by easy mod(since i put whole documents in one folder n upload). am i on right path
The fixes are never autoinstalled. You have to copy the relevant fixes to the same directory where the main approval mod installation file is and then run them through EasyMOD.

legwon
Registered User
Posts: 36
Joined: Sun Jan 08, 2006 8:18 pm

Re: [RC] Approval MOD v2.0

Post by legwon » Mon Aug 06, 2007 6:36 pm

i found where my issue came into effect... EZPortal menu on all pages MOD. within the page header.php

can u take a quick look and just tell me if its an easy fix or not?

Code: Select all

#
#-----[ OPEN ]------------------------------------------
#
includes/page_header.php
#
#-----[ FIND ]------------------------------------------
#
//
// Parse and show the overall header.
//
#
#-----[ BEFORE, ADD ]------------------------------------------
#
// If you don't use these stats on your index you may want to consider
// removing them
//
$total_posts_portal = get_db_stat('postcount');
$total_users_portal = get_db_stat('usercount');
$total_topics_portal = get_db_stat('topiccount');
$newest_userdata = get_db_stat('newestuser');
$newest_user = $newest_userdata['username'];
$newest_uid = $newest_userdata['user_id'];

if( $total_posts_portal == 0 )
{
   $l_total_post_s = $lang['Posted_articles_zero_total'];
}
else if( $total_posts_portal == 1 )
{
   $l_total_post_s = $lang['Posted_article_total'];
}
else
{
   $l_total_post_s = $lang['Posted_articles_total'];
}

if( $total_users_portal == 0 )
{
   $l_total_user_s = $lang['Registered_users_zero_total'];
}
else if( $total_users_portal == 1 )
{
   $l_total_user_s = $lang['Registered_user_total'];
}
else
{
   $l_total_user_s = $lang['Registered_users_total'];
}

if( $userdata['session_logged_in'] )
{
   $sql = "SELECT COUNT(post_id) as total
         FROM " . POSTS_TABLE . "
         WHERE post_time >= " . $userdata['user_lastvisit'];
   $result = $db->sql_query($sql);
   if( $result )
   {
      $row = $db->sql_fetchrow($result);
      $lang['Search_new'] = $lang['Search_new'] . " (" . $row['total'] . ")";
   }
} 
#
#-----[ FIND ]------------------------------------------
#
$template->assign_vars(array(
#
#-----[ AFTER, ADD ]------------------------------------------
#
   'TOTAL_POSTS' => sprintf($l_total_post_s, $total_posts_portal),
   'TOTAL_USERS' => sprintf($l_total_user_s, $total_users_portal),
   'TOTAL_TOPICS' => sprintf($lang['total_topics'], $total_topics_portal),
   'NEWEST_USER' => sprintf($lang['Newest_user'], '<a href="' . append_sid("profile.$phpEx?mode=viewprofile&" . POST_USERS_URL . "=$newest_uid") . '">', $newest_user, '</a>'),
   'L_FORUM' => $lang['Forum'],
   'L_BOARD_NAVIGATION' => $lang['Board_navigation'],
   'L_STATISTICS' => $lang['Statistics'],

User avatar
uncle.f
Registered User
Posts: 253
Joined: Thu Mar 25, 2004 11:42 am
Location: Purple Yonder
Contact:

Re: [RC] Approval MOD v2.0

Post by uncle.f » Mon Aug 06, 2007 7:59 pm

legwon wrote:i found where my issue came into effect... EZPortal menu on all pages MOD. within the page header.php
try this (add 1 line to the SQL statement):

Code: Select all

   $sql = "SELECT COUNT(post_id) as total
         FROM " . POSTS_TABLE . "
         WHERE post_time >= " . $userdata['user_lastvisit']
         AND post_approve = 0";

abhishek1711
Registered User
Posts: 528
Joined: Tue Apr 17, 2007 6:08 am
Location: India
Contact:

Re: [RC] Approval MOD v2.0

Post by abhishek1711 » Mon Aug 06, 2007 8:21 pm

okie as i said i put the entire folder in ftp and ran it using easymod...and got the above error...also unable to reverse it since it doesnt show up in mods history....so can u guide.

also abt fixes, i didnt get u. first u said thy are never auto installed. then u said put them in approval mod file and run through easy mod -well thats what i did , did i?

legwon
Registered User
Posts: 36
Joined: Sun Jan 08, 2006 8:18 pm

Re: [RC] Approval MOD v2.0

Post by legwon » Mon Aug 06, 2007 8:30 pm

Code: Select all

Parse error: syntax error, unexpected '=' in /xxx/xxx/xxx/phpbb/includes/page_header.php on line 109
:cry: unfortunatly that didnt work

thanks for your time uncle.f

User avatar
uncle.f
Registered User
Posts: 253
Joined: Thu Mar 25, 2004 11:42 am
Location: Purple Yonder
Contact:

Re: [RC] Approval MOD v2.0

Post by uncle.f » Mon Aug 06, 2007 8:57 pm

legwon wrote:

Code: Select all

Parse error: syntax error, unexpected '=' in /xxx/xxx/xxx/phpbb/includes/page_header.php on line 109
:cry: unfortunatly that didnt work
Of course :oops:

My bad -- there is a quote and a dot missing... should be like this:

Code: Select all

$sql = "SELECT COUNT(post_id) as total
         FROM " . POSTS_TABLE . "
         WHERE post_time >= " . $userdata['user_lastvisit'] . "
         AND post_approve = 0";

legwon
Registered User
Posts: 36
Joined: Sun Jan 08, 2006 8:18 pm

Re: [RC] Approval MOD v2.0

Post by legwon » Mon Aug 06, 2007 9:12 pm

uncle.f wrote:
legwon wrote:

Code: Select all

Parse error: syntax error, unexpected '=' in /xxx/xxx/xxx/phpbb/includes/page_header.php on line 109
:cry: unfortunatly that didnt work
Of course :oops:

My bad -- there is a quote and a dot missing... should be like this:

Code: Select all

$sql = "SELECT COUNT(post_id) as total
         FROM " . POSTS_TABLE . "
         WHERE post_time >= " . $userdata['user_lastvisit'] . "
         AND post_approve = 0";
WOOOOOOOO HOOOOOOOO!!!!! :D
thank you very much uncle.f!!

abhishek1711
Registered User
Posts: 528
Joined: Tue Apr 17, 2007 6:08 am
Location: India
Contact:

Re: [RC] Approval MOD v2.0

Post by abhishek1711 » Tue Aug 07, 2007 8:34 am

thnks for igonring ..sir

User avatar
uncle.f
Registered User
Posts: 253
Joined: Thu Mar 25, 2004 11:42 am
Location: Purple Yonder
Contact:

Re: [RC] Approval MOD v2.0

Post by uncle.f » Tue Aug 07, 2007 9:40 am

abhishek1711 wrote:thnks for igonring ..sir
I think you should follow your own advice given to somebody above, that is "to chill" and be a bit more patient. This is a free service, and you cannot expect me to run 24 hours helpdesk for nothing. If you've read this whole thread you'd see that firstly, there is no post left unanswered (maybe not immediately but eventually) and secondly again and again you ask questions about how to use EasyMOD. I can only tell you the same thing as before: read EasyMOD documentation and seek help in EasyMOD support forums. This is wrong place to ask about such things.
also abt fixes, i didnt get u. first u said thy are never auto installed. then u said put them in approval mod file and run through easy mod -well thats what i did , did i?
And I still say the same. Fixes are never autoinstalled, meaning that they won't be installed automatically when you install the main Approval MOD using EasyMOD. You have to install them separatly (using EasyMOD or not -- that is up to you) after you have installed the Approval MOD. And by the way, I never said to put fixes into approval mod file (that is what you wrote above and I hope you did not do it). I said to put the fixes in the Approval MOD top level directory.

Further, to your questions, the MOD does not show up in the EasyMOD history because was not installed. You received an error "FIND FAILED: In file [includes/topic_review.php]" and this is what prevented MOD from installation. EasyMOD will not modify any of your files as long as there are FIND errors. You have received a FIND error because you are trying to install the Approval MOD on phpBB board which is either not supported version or has already been modded. If you have other installed MODs that prevent you from installing Approval MOD, you should see the FAQ Question #18 on how to report an issue like that. Also, see Question #10 for additional compatibility info.

abhishek1711
Registered User
Posts: 528
Joined: Tue Apr 17, 2007 6:08 am
Location: India
Contact:

Re: [RC] Approval MOD v2.0

Post by abhishek1711 » Tue Aug 07, 2007 12:01 pm

thnks sir for your time and help.

am sorry if i offended u in anyway...i really dont mean to , ya u r helping for free !

okie so shall i take the fixes out of the Contrib folder, install the other files and then install the specific fixes?

also abt the Find error , how do i find which mod caused this particular error...so that i can report it? or else i did report the entire error code as u can find in earlier posts

ya u always do respond, thnks for that once again.
Last edited by abhishek1711 on Tue Aug 07, 2007 7:48 pm, edited 1 time in total.

User avatar
crackerboy
Registered User
Posts: 255
Joined: Sun Jul 15, 2007 5:49 pm

Re: [RC] Approval MOD v2.0

Post by crackerboy » Tue Aug 07, 2007 3:54 pm

I have a heavy modded board so Easy Mod is out of the questions to use,but the main problem is that i have subforums installed and that is a problem.But if i install this mod and only use forum that containe no subforums it will work or is it the subforum mod that are incompatible with this mod?

User avatar
uncle.f
Registered User
Posts: 253
Joined: Thu Mar 25, 2004 11:42 am
Location: Purple Yonder
Contact:

Re: [RC] Approval MOD v2.0

Post by uncle.f » Wed Aug 08, 2007 8:47 am

crackerboy wrote:I have a heavy modded board so Easy Mod is out of the questions to use,but the main problem is that i have subforums installed and that is a problem.But if i install this mod and only use forum that containe no subforums it will work or is it the subforum mod that are incompatible with this mod?
If your Subforums MOD is the one listed in the documentation (MOD compatibility section) then it shoud work fine with the Approval MOD after applying the appropriate fix, which is supplied with this MOD. Otherwise, no guarantees ;)

User avatar
uncle.f
Registered User
Posts: 253
Joined: Thu Mar 25, 2004 11:42 am
Location: Purple Yonder
Contact:

Re: [RC] Approval MOD v2.0

Post by uncle.f » Wed Aug 08, 2007 8:53 am

abhishek1711 wrote:okie so shall i take the fixes out of the Contrib folder, install the other files and then install the specific fixes?
Normally the order will be something like this: all your mods, approval mod, fixes for approval mod (found in contrib folder).
also abt the Find error , how do i find which mod caused this particular error...so that i can report it? or else i did report the entire error code as u can find in earlier posts.
It is impossible to say exactly which MOD causes the incompatibility just by looking at an error, especially if you have many MODs installed. You can provide a list of MODs installed on your board (with the links to those MODs download pages) and I can try and have a look which MOD is most likely to conflict. Or, if you have time and will, you could create a separate test installation and apply your MODs one by one. So if you have MOD1, MOD2 and MOD3 installed then first try MOD1 + Approval MOD, then MOD1 + MOD2 + Approval MOD, then MOD1 + MOD2 + MOD3 + Approval MOD...

abhishek1711
Registered User
Posts: 528
Joined: Tue Apr 17, 2007 6:08 am
Location: India
Contact:

Re: [RC] Approval MOD v2.0

Post by abhishek1711 » Wed Aug 08, 2007 6:17 pm

okie so which are the files i need to upload to ftp then (before installing fixes)...since i uploaded the entire approval mod file which u uploaded in the first post....

or else hough tedious , should i try to install it manually and then install the fixes

Locked

Return to “[2.0.x] MODs in Development”