[DEV] Pafiledb [DOWNLOAD MOD] 0.0.9d

A place for MOD Authors to post and receive feedback on MODs still in development. No MODs within this forum should be used within a live environment! No new topics are allowed in this forum.
Forum rules
READ: phpBB.com Board-Wide Rules and Regulations

IMPORTANT: MOD Development Forum rules

On February 1, 2009 this forum will be set to read only as part of retiring of phpBB2.
Mohd
Registered User
Posts: 263
Joined: Mon Jul 15, 2002 9:06 pm
Contact:

Post by Mohd » Mon Dec 09, 2002 2:23 pm

LaZeR wrote: Glad to see this one. I have had a few issues. First off I went through all files and matched up the $dbprefix from the default:

Code: Select all

$dbprefix = "pafiledb";
To

Code: Select all

$dbprefix = "phpbb_pafiledb";
And I also renamed all pafiledb tables to this in phpMyAdmin. I like all my tables associated with phpbb prefixed as such thus they get included in the database size totals. :wink: Now I don't feel this is of any issue to the following problems, just thought I would mention it. Database communications seem fine.

Problems:

(1) When addin a file in the ADMIN section and using the "Upload a file to the server" function and then after uploading, I get:
The file test.zip has been uploaded! The URL to the file is http://www.oasisforum.valcato.net/phpbb ... n_file.php
Click Here to place this URL in the Download URL field.


Always happens this way thus I can never get the actual URL as its supposed to work but rather this for any file: http://www.oasisforum.valcato.net/phpbb ... n_file.php requiring me to manually input the correct URL location and file in.

(2) All the paFileDB's admin functions where placed all throughout my ADMIN Panel thus making it very difficult to figure out which functions belonged to this mod and where they were thus I solved this for now by editing all the Admin entries in the pafiledb/lang/english.php with paFileDB words at the beginning of each title thus atleast they are all together and at the bottom in Admin index.

(3) The "Email to friend" functions works well except for one very minor issue. After sending the email, there is a broken image to the left of: Thank you! Your e-mail has been sent to Me's e-mail address. which is due to a wrong URL of: http://www.oasisforum.valcato.net/phpbb ... s/info.gif -Notice the double // also in this.

UPDATE: I just corrected this issue by changing the following code found in pa_email_body.tpl From:

Code: Select all

    <p align="center"><img src="styles/{STYLE}/images/info.gif" border="0"></p>
TO:

Code: Select all

    <p align="center"><img src="pafiledb/styles/default/images/info.gif" border="0"></p>
(4) The following part of the code to add in overall_header.tpl shows:

Code: Select all

<img src="templates/fisubsilver/images/icon_mini_download.gif"
Should be:

Code: Select all

<img src="templates/subSilver/images/icon_mini_download.gif"
For default subSilver ofcourse :wink:

All in all it works well for the main part and function other than the items I noted, most troublesome is the 1st one. 8)

Oops. Forgot to mention you need to include instructions saying to CHMOD the /pafiledb/upload DIR to 777


Thanks Lazer for the replay.
first problem: I also have this problem but I couldn't fix it I will try this time to make it better.

About admin function there is no specific admin function that from pafiledb they are all form phpbb

MJ
Registered User
Posts: 180
Joined: Thu Jan 03, 2002 10:20 pm
Contact:

Post by MJ » Mon Dec 09, 2002 4:30 pm

Have got your changes Lazer, and have completely re-done all the Admin templates to phpBB subSilver default layout & colors, removed alot of unused code & unused language, all modules for it are now in the one section in Admin......so v0.0.2 will be ready soon, just got one little bug to sort....

DanielT
Former Team Member
Posts: 3324
Joined: Tue Aug 27, 2002 10:55 am
Contact:

Post by DanielT » Mon Dec 09, 2002 4:48 pm

MJ no animation in your sig plz :wink:

User avatar
LaZeR
Registered User
Posts: 671
Joined: Sat Jun 29, 2002 8:38 pm
Contact:

Post by LaZeR » Mon Dec 09, 2002 5:07 pm

MJ wrote: Have got your changes Lazer, and have completely re-done all the Admin templates to phpBB subSilver default layout & colors, removed alot of unused code & unused language, all modules for it are now in the one section in Admin......so v0.0.2 will be ready soon, just got one little bug to sort....


Sounds great! 8) Many thanks to both squall and MJ for the work you both are putting into this. Looking forward to those tweaks which will be excellent improvements to an already awesome addition. :wink:

PS: Just curious if there will be an upgrade path to jump to the next version or will it require a new install to get right as in tables re-done or anything else? Like I said I've already done a few of those little (easy) tweaks myself to fix to phpbb_ prefix in tables, ect... so I'm just curious if I can keep current downloads, ratings, ect... and still upgrade :?

MJ
Registered User
Posts: 180
Joined: Thu Jan 03, 2002 10:20 pm
Contact:

Post by MJ » Mon Dec 09, 2002 5:57 pm

As for the prefixed tables, can't really hardcode these to phpbb_ either as not all users use this prefix....maybe a work around for this Squall?

No matter what the result Lazer, you shouldn't lose any ratings etc ;)

Check ya PM @ FMB Squall, for latest news.....

Re DanielT: Why not??

Mohd
Registered User
Posts: 263
Joined: Mon Jul 15, 2002 9:06 pm
Contact:

Post by Mohd » Tue Dec 10, 2002 9:12 pm

Thanks MJ.
Good news: version 0.0.2
Just removing some bugs and changing template in Admin section.

User avatar
Rcrowley
Registered User
Posts: 41
Joined: Sun Aug 04, 2002 6:47 am
Location: Las Vegas, NV
Contact:

Post by Rcrowley » Tue Dec 10, 2002 11:23 pm

Hi, squall -
squall wrote: Thanks MJ.
Good news: version 0.0.2
Just removing some bugs and changing template in Admin section.


Thanks for the update. I have just installed this mod and unfortunately nothing is happening for me. When I click on the 'Download' in the header, I get a blank (white) page. I added all the files where they are supposed to go and followed instructions exactly.

I did find one small error.

Perhaps this:

Code: Select all

<tr> 
						<td height="25" align="center" nowrap class="genmed" valign="top"> 
						&nbsp;<a href="{U_DOWNLOAD}" class="mainmenu"><img src="templates/fisubsilver/images/icon_mini_download.gif" width="13" height="13" border="0" alt="{PRIVATE_MESSAGE_INFO}" title="{PRIVATE_MESSAGE_INFO}" hspace="3" align="top" />{L_DOWNLOAD}</a>&nbsp; 
						</td>
					</tr>
Should be:

Code: Select all

<tr> 
						<td height="25" align="center" nowrap="nowrap" class="genmed" valign="top"> 
						&nbsp;<a href="{U_DOWNLOAD}" class="mainmenu"><img src="templates/subSilver/images/icon_mini_download.gif" width="13" height="13" border="0" alt="{PRIVATE_MESSAGE_INFO}" title="{PRIVATE_MESSAGE_INFO}" hspace="3" align="top" />{L_DOWNLOAD}</a>&nbsp; 
						</td>
					</tr>

User avatar
LaZeR
Registered User
Posts: 671
Joined: Sat Jun 29, 2002 8:38 pm
Contact:

Post by LaZeR » Wed Dec 11, 2002 1:24 am

First off, thanks for the update and the template system is nice! 8)

I have just 3 issues I'm aware of:

(1) The problem remains in Admin - File uploading where you don't get the appropriate URL to paste into the box after upload. Maybe you're aware of this as I didn't know if it was supposed to be one of the bug fixes in 020 or not?

(2) In the Stats it is showing a file with 0 rating for the "Most popular" -maybe a bug within pafiledb itself not related to this development / and it may have existed in last version as I don't think I checked this then.

(3) After sending an "Email file to friend..." the return screen info.gif URL is wrong:

http://www.oasisforum.valcato.net/phpbb ... s/info.gif

Should be:

http://www.oasisforum.valcato.net/phpbb ... s/info.gif

I was too lazy atm to search out the problem in the template so I just made this dir and placed the lonely file in it :lol:

MJ
Registered User
Posts: 180
Joined: Thu Jan 03, 2002 10:20 pm
Contact:

Post by MJ » Wed Dec 11, 2002 6:30 am

LaZeR wrote: (1) The problem remains in Admin - File uploading where you don't get the appropriate URL to paste into the box after upload. Maybe you're aware of this as I didn't know if it was supposed to be one of the bug fixes in 020 or not?
I tried for a while to fix this without any luck!!
LaZeR wrote: (2) In the Stats it is showing a file with 0 rating for the "Most popular" -maybe a bug within pafiledb itself not related to this development / and it may have existed in last version as I don't think I checked this then.
This is a bug with pafiledb v3.0 itself and was in the release from phpArena.
LaZeR wrote: (3) After sending an "Email file to friend..." the return screen info.gif URL is wrong:

http://www.oasisforum.valcato.net/phpbb ... s/info.gif

Should be:

http://www.oasisforum.valcato.net/phpbb ... s/info.gif
This can be fixed by editing : templates/subSilver/pa_email_body.tpl

Find:

Code: Select all

	<td class="row1" align="center" width="5"><img src="styles/subSilver/images/info.gif" border="0"></td>
Replace with :

Code: Select all

	<td class="row1" align="center" width="5"><img src="pafiledb/styles/{STYLE}/images/info.gif" border="0"></td>

User avatar
LaZeR
Registered User
Posts: 671
Joined: Sat Jun 29, 2002 8:38 pm
Contact:

Post by LaZeR » Wed Dec 11, 2002 12:56 pm

Thanks MJ for acknowledging and I will check out that simple fix for the email image link.
Update: Oops :oops: the above described fix for the image link doesn't work right it produces: http://www.oasisforum.valcato.net/phpbb ... s/info.gif

So I do this and it works:

Code: Select all

<td class="row1" align="center" width="5"><img src="pafiledb/styles/subSilver/images/info.gif" border="0"></td>
One other sorta BIG problem I'm having with an Admin function (File-Edit) is it basically does nothing. I have tried either/or changing the title of an actual download OR a description field and it absolutely does nothing although I get no errors, it just basically lets you go thru the motions but never modifies the database apparently. :cry: This was with the last release here also which I discovered late.
And possible associated with this: in the description at the top of admin when in the Edit screen, it says something to the effect that I should see Edit/Delete links or such in the normal Downloads area when logged in Admin ofcourse but I never see these there - Everything needs done or attempted of this nature directly in the main Admin section(s). Hope that made sense :?

Mohd
Registered User
Posts: 263
Joined: Mon Jul 15, 2002 9:06 pm
Contact:

Post by Mohd » Wed Dec 11, 2002 2:45 pm

LaZeR wrote: First off, thanks for the update and the template system is nice! 8)

I have just 3 issues I'm aware of:

(1) The problem remains in Admin - File uploading where you don't get the appropriate URL to paste into the box after upload. Maybe you're aware of this as I didn't know if it was supposed to be one of the bug fixes in 020 or not?

(2) In the Stats it is showing a file with 0 rating for the "Most popular" -maybe a bug within pafiledb itself not related to this development / and it may have existed in last version as I don't think I checked this then.

(3) After sending an "Email file to friend..." the return screen info.gif URL is wrong:

http://www.oasisforum.valcato.net/phpbb ... s/info.gif

Should be:

http://www.oasisforum.valcato.net/phpbb ... s/info.gif

I was too lazy atm to search out the problem in the template so I just made this dir and placed the lonely file in it :lol:


1-for the file upload I have an idea to fix this bug but I didn't test yet ..
2-when I use the mysql.php file (phparena file) I got the write stat for this but when I use phpbb db system It remain Zero.

3-All the message after doing something like sending email and rating will be changed to phpbb message info like when you post a new topic.

Other changes:
1-changing lang variable to phpbb language e.g: $str to $lang via language folder (other language will be supported)
2-Improving template variable.



The BIG error now is editing file in admin panel I couldn't figure out the problem yet but I think it has something to do with UPDATE sql command.
and File in sub category also.

Thanks Lazer for the info.

MJ
Registered User
Posts: 180
Joined: Thu Jan 03, 2002 10:20 pm
Contact:

Post by MJ » Wed Dec 11, 2002 10:29 pm

The sent email brokem image is caused by a typo in pafildb/includes/email.php

Find:
"STYLE" => $config[settings_styl],


Replace with:
"STYLE" => $config[settings_style],


Make sure it's set to {STYLE} and not subSilver in the template as per my earlier post ;)

User avatar
LaZeR
Registered User
Posts: 671
Joined: Sat Jun 29, 2002 8:38 pm
Contact:

Post by LaZeR » Thu Dec 12, 2002 3:57 am

Great MJ! Nice catch :wink: I followed your fix and put back the STYLES tag as previously stated and it worked a treat.
1-for the file upload I have an idea to fix this bug but I didn't test yet ..


I'll be glad to try it :lol: anything to get that admin bug solved, I'd be glad to help test!

My opinion the only things I see need done are and in about this order of importance:

-Fix the upload (file url-name) paste issue.

-Fix the inability to edit file entries via AdminCP.

-Find out a correction to the rating stat (most popular file 0/10) bug. This of the least importance imho although ironically I wondered upon a site the other night running a pafiledb -I forget the version now :oops: and this stat was actually registering and seemingly accurate.

MJ
Registered User
Posts: 180
Joined: Thu Jan 03, 2002 10:20 pm
Contact:

Post by MJ » Thu Dec 12, 2002 7:20 am

Yeah I've also seen the stats ratings working on other sites...... :(

One more bug I've found.....The Sort feature doesen't work on the "ViewAll Files" page, just returns back to the categories.

Mohd
Registered User
Posts: 263
Joined: Mon Jul 15, 2002 9:06 pm
Contact:

Post by Mohd » Thu Dec 12, 2002 9:21 am

hi guys good news I have fixed today some bugs (actully huge bugs)

editing file in admin panel done ( it is because the update command of sql is updating ' ' empty id coz of the template not sending the id when choosing file ( 2 hours until I found it)

file in sub category now done: I for got to put $db-> before sql_query in one of the line in file.php

uploading file fixed the url.

going now to fix sorting in view all.

Locked

Return to “[2.0.x] MODs in Development”