[RC] Printer-friendly topic view mod

A place for MOD Authors to post and receive feedback on MODs still in development. No MODs within this forum should be used within a live environment! No new topics are allowed in this forum.
Forum rules
READ: phpBB.com Board-Wide Rules and Regulations

IMPORTANT: MOD Development Forum rules

On February 1, 2009 this forum will be set to read only as part of retiring of phpBB2.
CyanBlue
Registered User
Posts: 409
Joined: Mon Jul 28, 2003 9:55 am

Post by CyanBlue » Fri Aug 01, 2003 2:34 pm

Nice MOD... Thank you for your time, Svyatozar... :)

I have installed this MOD on 2.0.5 and it is working perfectly...

I seemed to bemissing one thing though...

On the normal page, I get to see this at the bottom of the page...
All times are GMT - 4 Hours
And, at the printer-friendly page, I get to see this...
output generated using printer-friendly topic mod, All times are

I am missing this GMT - 4 Hours part...
I do see that your sample page at http://bbs.inglia.ru/viewtopic.php?t=1& ... msgcount=4 produces this timezone stuff correctly, so I guess this is my fault on implementing this MOD...
However, I cannot find the place where might cause the problem... (I am five days old phpBB user...) Would you care to give me some head up on this??? ;)

printertopic_body.tpl file says...

Code: Select all

<p align=right><br><span class="copyright">output generated using <a href="http://phpbb.com/phpBB/viewtopic.php?t=70751" target=_phpbb class="copyright"><font color=black>printer-friendly topic mod</font></a>, </span><span class="gensmall">{S_TIMEZONE}</span></p><span class="nav">{PAGINATION}</span>
Thank you very much...

Svyatozar
Registered User
Posts: 153
Joined: Fri Apr 12, 2002 5:38 am

Post by Svyatozar » Thu Aug 14, 2003 9:36 pm

Hello!

This is not the first time that I hear about that problem. However, I have not been able to reproduce this kind of bug on my test forums.

If you'd be so kind to send me in whole the code of your forum installation I could look at it. Alternatively I could also post my test version of phpBB, with printer topic mod installed.

So, what do you think?

Regards,

Alexander

CyanBlue
Registered User
Posts: 409
Joined: Mon Jul 28, 2003 9:55 am

Post by CyanBlue » Fri Aug 15, 2003 3:05 am

Howdy... ;)

Thank you for the reply... :)

Oh, I don't mind putting up the file, but it's abit large with lots of MODs that I have applied... If that's the only way, I'll give you the link to the file, but if there is anyway you could tell me which files you want to take a look, that will be better for me...

Please PM me either way so that I can tell you the URL to get the file...

Thank you for your help... Have a nice day... :D

User avatar
Haywood Jahelpme
Registered User
Posts: 475
Joined: Wed Oct 23, 2002 9:16 am
Location: San Diego
Contact:

Post by Haywood Jahelpme » Fri Aug 15, 2003 9:20 am

this looks interesting... will be trying it out soon... I think this is already installed on my board, so I will be upgrading... I wasn't sure which one I put in...

thanks!
Last edited by Haywood Jahelpme on Fri Aug 15, 2003 9:30 am, edited 1 time in total.

User avatar
Haywood Jahelpme
Registered User
Posts: 475
Joined: Wed Oct 23, 2002 9:16 am
Location: San Diego
Contact:

Post by Haywood Jahelpme » Fri Aug 15, 2003 9:24 am

CyanBlue wrote: On the normal page, I get to see this at the bottom of the page...
All times are GMT - 4 Hours
And, at the printer-friendly page, I get to see this...
output generated using printer-friendly topic mod, All times are

I am missing this GMT - 4 Hours part...
I have the inverse problem... I have not yet upgraded to this version (I think this is the one i installed....) but in my Printable view, I have the time zone and in my normal one I don't... I am wondering if it is a font color thing... If not that, then there is some language variable not getting parsed...

Svyatozar
Registered User
Posts: 153
Joined: Fri Apr 12, 2002 5:38 am

Post by Svyatozar » Sat Aug 16, 2003 3:16 pm

CyanBlue wrote: Oh, I don't mind putting up the file, but it's abit large with lots of MODs that I have applied...


When posting the modded forum code, please remove all the languages except for English, remove all the extra templates, and extra translations for the main template (SubSilver), and all the rest is essential for me to be able to re-create the abnormal condition, and, hopefully, help fixing the bug.

All the best!

Svyatozar
Registered User
Posts: 153
Joined: Fri Apr 12, 2002 5:38 am

Post by Svyatozar » Tue Aug 19, 2003 6:00 am

All right, for all those who were getting that annoying missing timezone problem here is a fix: download the latest version and use the fresh page_header_printer.php file from the package.

Have fun!
Last edited by Svyatozar on Wed Aug 20, 2003 2:54 pm, edited 1 time in total.

CyanBlue
Registered User
Posts: 409
Joined: Mon Jul 28, 2003 9:55 am

Post by CyanBlue » Tue Aug 19, 2003 6:46 am

Howdy... ;)

Thanks for taking time to go over things...

Maybe this is just me, but I still do not get the GMT - 4 Hours part after applying the above fix... :(

Anybody else having the same problem and got this thing resorted???

User avatar
Haywood Jahelpme
Registered User
Posts: 475
Joined: Wed Oct 23, 2002 9:16 am
Location: San Diego
Contact:

Post by Haywood Jahelpme » Tue Aug 19, 2003 4:00 pm

I was mistaken... I have a different printable topics mod installed..... I will get back to you when I upgrade to this one...

Svyatozar
Registered User
Posts: 153
Joined: Fri Apr 12, 2002 5:38 am

Post by Svyatozar » Tue Aug 19, 2003 7:50 pm

CyanBlue wrote: Howdy... ;)

Thanks for taking time to go over things...

Maybe this is just me, but I still do not get the GMT - 4 Hours part after applying the above fix... :(

Anybody else having the same problem and got this thing resorted???

Did you save the file after editing it?

CyanBlue
Registered User
Posts: 409
Joined: Mon Jul 28, 2003 9:55 am

Post by CyanBlue » Tue Aug 19, 2003 8:20 pm

Yes, I did... This is how it looks like on my SSH screen around that specific line...

Code: Select all

        'L_BY' => $lang['by'],
 
        'U_INDEX' => append_sid('index.'.$phpEx),
  
        'S_TIMEZONE' => sprintf($lang['All_times'], $lang[intval($board_config['board_timezone'])]),
        'S_LOGIN_ACTION' => append_sid('../login.'.$phpEx),
        'S_JUMPBOX_ACTION' => append_sid('../viewforum.'.$phpEx),

Svyatozar
Registered User
Posts: 153
Joined: Fri Apr 12, 2002 5:38 am

Post by Svyatozar » Wed Aug 20, 2003 3:41 am

I will work on that problem. Please, hang on.

CyanBlue
Registered User
Posts: 409
Joined: Mon Jul 28, 2003 9:55 am

Post by CyanBlue » Wed Aug 20, 2003 4:01 am

But don't take out the possibility that the issue could be mine alone...

Thank you much... ;)

Svyatozar
Registered User
Posts: 153
Joined: Fri Apr 12, 2002 5:38 am

Post by Svyatozar » Wed Aug 20, 2003 2:56 pm

All right, now I hopefully fixed it. Download the mod and use the fresh page_header_printer.php from the package. Good luck!

CyanBlue
Registered User
Posts: 409
Joined: Mon Jul 28, 2003 9:55 am

Post by CyanBlue » Thu Aug 21, 2003 1:35 am

Yes!!! It's working great... Thanks alot!!! :)

Just a couple of things... :D
output generated using printer-friendly topic mod, All times are GMT - 4 Hours

Maybe make it to be two lines to make it 'prettier'???

And, maybe this is not actually your concern, but there is a conflict(?) with this MOD and Rate Topic MOD... You don't have to supply the solution but I think you should be aware of this if you are not already... I cannot find the thread that talks about the fix at the moment, but it's basically adding this line right below the 'define(...' function line...

Code: Select all

define('HEADER_INC', true);
include_once($phpbb_root_path.'includes/functions_rate.php');
Thank you very much... ;)

Locked

Return to “[2.0.x] MODs in Development”