code suggestion

The 2.0.x discussion forum has been locked; this will remain read-only. The 3.0.x discussion forum has been renamed phpBB Discussion.
Registered User
Posts: 5
Joined: Mon Dec 06, 2004 2:29 am

code suggestion

Post by SQLBoy »

I'm not the best PHP coder in the world but it seems to me that the development rules should create some limitation on either the length of the line or the number of functions you can call on a single line of code.
The reason? Its confusing and you have to have noticed by now that most of the arbitrary code execution holes you are opening up are from these overly complex overly long lines of code. Be clear, not clever.

Doesn't the Zend engine optimize most of that stuff away anyway? I mean, in my own benchmarking, I didn't see any gain from chainging together a ton of functions.

Vic D'Elfant
Former Team Member
Posts: 6203
Joined: Sun May 02, 2004 6:21 pm
Location: NL, Maastricht

Post by Vic D'Elfant »

phpBB has IMO teh most sexy coding guidelins ever :D Believe me, if the developers putted multiple functions on one line, there simply wasn't another way to do so.

Vic • DTP, web development & printing
Registered User
Posts: 247
Joined: Sat Oct 18, 2003 9:48 pm
Location: Finland

Post by Einstein »

It's a mater of taste ... phpBB Dev Team do it their way.

Return to “2.0.x Discussion”