Page 1 of 1

code suggestion

Posted: Mon Apr 18, 2005 5:47 pm
by SQLBoy
I'm not the best PHP coder in the world but it seems to me that the development rules should create some limitation on either the length of the line or the number of functions you can call on a single line of code.
The reason? Its confusing and you have to have noticed by now that most of the arbitrary code execution holes you are opening up are from these overly complex overly long lines of code. Be clear, not clever.

Doesn't the Zend engine optimize most of that stuff away anyway? I mean, in my own benchmarking, I didn't see any gain from chainging together a ton of functions.

Mat

Posted: Mon Apr 18, 2005 6:36 pm
by Vic D'Elfant
phpBB has IMO teh most sexy coding guidelins ever :D Believe me, if the developers putted multiple functions on one line, there simply wasn't another way to do so.

Vic

Posted: Mon Apr 18, 2005 7:11 pm
by Einstein
It's a mater of taste ... phpBB Dev Team do it their way.