When Unistall Mod -> SQL data stays in database...why?

Archive of support for the automated MOD installation tool codenamed "Blinky". For support questions regarding AutoMOD please visit here.
Anti-Spam Guide
Forum rules
READ: phpBB.com Board-Wide Rules and Regulations

NOTICE: IF YOU NEED SUPPORT FOR AUTOMOD PLEASE VISIT THE APPROPRIATE LOCATION HERE.
Locked
User avatar
waxxie
Registered User
Posts: 119
Joined: Fri Oct 16, 2009 5:21 pm

When Unistall Mod -> SQL data stays in database...why?

Post by waxxie »

When uninstalling a mod that includes SQL functions/data, why does the data stay in the database after un-installation?

Is there some way to get AutoMod to remove these mod SQL?

:?:
arvo.bowen
Registered User
Posts: 7
Joined: Thu Jan 07, 2010 3:28 pm

Re: When Unistall Mod -> SQL data stays in database...why?

Post by arvo.bowen »

Unfortunately it seems as if AutoMOD does not support a lot of cleanup. One of them being to undo the changes made in the SQL section... :/
User avatar
A_Jelly_Doughnut
Former Team Member
Posts: 34457
Joined: Sat Jan 18, 2003 1:26 am
Location: Where the Rivers Run
Contact:

Re: When Unistall Mod -> SQL data stays in database...why?

Post by A_Jelly_Doughnut »

AutoMOD does the following to undo SQL:

Drops any tables added by the MOD
Drops any db columns added by the MOD

It does NOT remove any rows added to any existing database table by the MOD.

It also does not "detect" changes - so if the MOD has an external database script, AutoMOD will undo nothing in the database.
A Donut's Blog
"Bach's Prelude (Cello Suite No. 1) is driving Indiana country roads in Autumn" - Ann Kish
arvo.bowen
Registered User
Posts: 7
Joined: Thu Jan 07, 2010 3:28 pm

Re: When Unistall Mod -> SQL data stays in database...why?

Post by arvo.bowen »

Well I guess I need to add another bug report then.. :P

My current info:
AutoMOD version: 1.0.0-rc3
phpBB version: 3.0.6

AutoMOD does not do the following...
- DROP tables created by the MOD
- REMOVE table columns created by the MOD

*notes... I'm creating a new MOD and in the install of the MOD I create new tables (NO DATA is ever added to them) then when uninstalling the MOD the tables remain and AutoMOD does not display ANYTHING about SQL in the uninstall screen...

A_Jelly_Doughnut : Should I add a bug report?
FeyFre
Registered User
Posts: 57
Joined: Wed Dec 17, 2008 5:18 pm
Location: Vinnitsa, Ukraine, Eastern Europe
Contact:

Re: When Unistall Mod -> SQL data stays in database...why?

Post by FeyFre »

A_Jelly_Doughnut wrote:Drops any db columns added by the MOD
Not, it doesn't. At least in MOD which I tried.
For instance mod Log connections 1.0.3 on phpbb 3.0.6. It does not dropped column log_number in phpbb_log table added by installation and not droped whole table phpbb_log_lc_exclude_ip.
Everybody can do the same things, but nobody can do it identically.
User avatar
A_Jelly_Doughnut
Former Team Member
Posts: 34457
Joined: Sat Jan 18, 2003 1:26 am
Location: Where the Rivers Run
Contact:

Re: When Unistall Mod -> SQL data stays in database...why?

Post by A_Jelly_Doughnut »

Yes, a bug report would be welcome :)
A Donut's Blog
"Bach's Prelude (Cello Suite No. 1) is driving Indiana country roads in Autumn" - Ann Kish
User avatar
waxxie
Registered User
Posts: 119
Joined: Fri Oct 16, 2009 5:21 pm

Re: When Unistall Mod -> SQL data stays in database...why?

Post by waxxie »

would be cool if we could add SQL removal instructions in the XML for AutoMod

tell it which keys or tables etc to remove that were installed

and it wouldn't let you remove stuff that wasn't installed with the mod

:D
arvo.bowen
Registered User
Posts: 7
Joined: Thu Jan 07, 2010 3:28 pm

Re: When Unistall Mod -> SQL data stays in database...why?

Post by arvo.bowen »

I'm on it, submitting bug report now :)


Edit: Jelly, it's yours ;) Ticket created #56725

Thanks again for the hard work!
User avatar
Sajaki
Registered User
Posts: 1371
Joined: Mon Mar 02, 2009 1:41 pm
Location: Amsterdam
Contact:

Re: When Unistall Mod -> SQL data stays in database...why?

Post by Sajaki »

waxxie wrote:would be cool if we could add SQL removal instructions in the XML for AutoMod
hmm i think you'd better use UMIL to handle complex database changes. Automod has some sql capability, but not to the extent Umil has.
Locked

Return to “[3.0.x] AutoMOD”