problem with one in-line action

Archive of support for the automated MOD installation tool codenamed "Blinky". For support questions regarding AutoMOD please visit here.
Get Involved
Forum rules
READ: phpBB.com Board-Wide Rules and Regulations

NOTICE: IF YOU NEED SUPPORT FOR AUTOMOD PLEASE VISIT THE APPROPRIATE LOCATION HERE.
User avatar
Martin Truckenbrodt
Registered User
Posts: 3045
Joined: Sun Mar 23, 2003 6:22 pm
Location: Franconia
Name: Martin Truckenbrodt
Contact:

problem with one in-line action

Post by Martin Truckenbrodt » Mon Feb 18, 2013 8:35 pm

Hello,
following edit is not working with AutoMOD 1.0.2:

Code: Select all

		<open src="includes/auth/auth_apache.php">
			<edit>
				<find><![CDATA[function login_apache(&$username, &$password)
{
	global $db;]]></find>
				<inline-edit>
					<inline-find><![CDATA[global $db]]></inline-find>
					<inline-action type="after-add"><![CDATA[, $config]]></inline-action>
				</inline-edit>
			</edit>
		</open>
Could somebody test it to confirm the issue?

Bye Martin
Free tutorial: Installing MODs in phpBB 3.0
Advanced Block MOD - Prevent spam on your phpBB 3.0 board with Stop Forum Spam, BotScout, Akismet, Project Honey Pot and several IP-RBL and Domain-RBL DNS blacklists!
My MODs
Use the official phpBB Ideas to vote missing core features!!!

User avatar
Lumpy Burgertushie
Registered User
Posts: 66236
Joined: Mon May 02, 2005 3:11 am
Contact:

Re: problem with one in-line action

Post by Lumpy Burgertushie » Mon Feb 18, 2013 8:50 pm

for what MOD? exactly what are you doing?


robert
I am available for custom work on a donation basis. Please send me a PM with your needs.

Premium phpBB 3.2 Styles by PlanetStyles.net

OK, so what's the speed of dark?

User avatar
Martin Truckenbrodt
Registered User
Posts: 3045
Joined: Sun Mar 23, 2003 6:22 pm
Location: Franconia
Name: Martin Truckenbrodt
Contact:

Re: problem with one in-line action

Post by Martin Truckenbrodt » Mon Feb 18, 2013 9:05 pm

Hello Robert,
I'm programming on new version of my Advanced Double Activation Pack. It will be a new feature. http://tracker.phpbb.com/browse/PHPBB3-11348

Maybe the post would be better placed in MOD writers discussion forum?

Bye Martin
Free tutorial: Installing MODs in phpBB 3.0
Advanced Block MOD - Prevent spam on your phpBB 3.0 board with Stop Forum Spam, BotScout, Akismet, Project Honey Pot and several IP-RBL and Domain-RBL DNS blacklists!
My MODs
Use the official phpBB Ideas to vote missing core features!!!

User avatar
Lumpy Burgertushie
Registered User
Posts: 66236
Joined: Mon May 02, 2005 3:11 am
Contact:

Re: problem with one in-line action

Post by Lumpy Burgertushie » Mon Feb 18, 2013 9:37 pm

the find is not correct. it should be looking for this:

Code: Select all

function login_apache(&$username, &$password)
{
	global $db;
robert
I am available for custom work on a donation basis. Please send me a PM with your needs.

Premium phpBB 3.2 Styles by PlanetStyles.net

OK, so what's the speed of dark?

User avatar
Martin Truckenbrodt
Registered User
Posts: 3045
Joined: Sun Mar 23, 2003 6:22 pm
Location: Franconia
Name: Martin Truckenbrodt
Contact:

Re: problem with one in-line action

Post by Martin Truckenbrodt » Tue Feb 19, 2013 8:52 pm

Hello Robert,
the find is right.

I think there is a problem with

Code: Select all

&$
.

I will report a bug.

Bye Martin
Free tutorial: Installing MODs in phpBB 3.0
Advanced Block MOD - Prevent spam on your phpBB 3.0 board with Stop Forum Spam, BotScout, Akismet, Project Honey Pot and several IP-RBL and Domain-RBL DNS blacklists!
My MODs
Use the official phpBB Ideas to vote missing core features!!!

User avatar
Lumpy Burgertushie
Registered User
Posts: 66236
Joined: Mon May 02, 2005 3:11 am
Contact:

Re: problem with one in-line action

Post by Lumpy Burgertushie » Tue Feb 19, 2013 9:04 pm

no, it is not correct. if you do a search in the file for

Code: Select all

function login_apache(&$username, &$password)
{
   global $db;
it does not find it.

the spacing is off from what is actually in the file.


robert
I am available for custom work on a donation basis. Please send me a PM with your needs.

Premium phpBB 3.2 Styles by PlanetStyles.net

OK, so what's the speed of dark?

User avatar
Martin Truckenbrodt
Registered User
Posts: 3045
Joined: Sun Mar 23, 2003 6:22 pm
Location: Franconia
Name: Martin Truckenbrodt
Contact:

Re: problem with one in-line action

Post by Martin Truckenbrodt » Tue Feb 19, 2013 9:20 pm

Hello Robert,
the FIND is right.

At the code which I have posted here there have been a tabulator included. phpBB is replacing the tabulator with spaces. ;) If you want to test my code then you have to redo it.

There is a MOD to change this phpBB default behaviour:
https://www.phpbb.com/customise/db/mod/ ... ancements/

Bye Martin
Free tutorial: Installing MODs in phpBB 3.0
Advanced Block MOD - Prevent spam on your phpBB 3.0 board with Stop Forum Spam, BotScout, Akismet, Project Honey Pot and several IP-RBL and Domain-RBL DNS blacklists!
My MODs
Use the official phpBB Ideas to vote missing core features!!!

User avatar
tumba25
Former Team Member
Posts: 4430
Joined: Wed Jun 06, 2007 6:42 am
Location: Kokkola, Finland.
Name: Jari Kanerva
Contact:

Re: problem with one in-line action

Post by tumba25 » Tue Feb 19, 2013 10:03 pm

Martin Truckenbrodt wrote:

Code: Select all

		<open src="includes/auth/auth_apache.php">
			<edit>
				<find><![CDATA[function login_apache(&$username, &$password)
{
	global $db;]]></find>
				<inline-edit>
					<inline-find><![CDATA[global $db]]></inline-find>
					<inline-action type="after-add"><![CDATA[, $config]]></inline-action>
				</inline-edit>
			</edit>
		</open>
Just tested that exact piece of code. Using AutoMOD 1.0.2 and a fresh phpBB 3.0.11 install. Worked like a charm, exactly as it should.

Your FIND is correct. Tabs are changed to spaces when viewing a post or using the "Select all" link. But clicking the "Quote" button gives them as tabs.
Need a mod/extension created/installed, other custom-coded solution or a server admin? https://tumba25.net

User avatar
Martin Truckenbrodt
Registered User
Posts: 3045
Joined: Sun Mar 23, 2003 6:22 pm
Location: Franconia
Name: Martin Truckenbrodt
Contact:

Re: problem with one in-line action

Post by Martin Truckenbrodt » Fri Feb 22, 2013 8:04 pm

Hello,
I'm starting to be crazy! I've installed a new board for a test. Also I've replaced the XML file with a new file. Still I'm getting:
Find
function login_apache(&$username, &$password)
{
global $db;

--------------------------------------------------------------------------------

In-Line Find
global $db

--------------------------------------------------------------------------------


The In-Line Find specified by the MOD could not be found. The Find specified by the MOD could not be found
Does anybody have an abstract idea?

Bye Martin
Free tutorial: Installing MODs in phpBB 3.0
Advanced Block MOD - Prevent spam on your phpBB 3.0 board with Stop Forum Spam, BotScout, Akismet, Project Honey Pot and several IP-RBL and Domain-RBL DNS blacklists!
My MODs
Use the official phpBB Ideas to vote missing core features!!!

User avatar
tumba25
Former Team Member
Posts: 4430
Joined: Wed Jun 06, 2007 6:42 am
Location: Kokkola, Finland.
Name: Jari Kanerva
Contact:

Re: problem with one in-line action

Post by tumba25 » Sun Feb 24, 2013 10:40 am

Did you try a XML file only containing that edit?
Need a mod/extension created/installed, other custom-coded solution or a server admin? https://tumba25.net

User avatar
Martin Truckenbrodt
Registered User
Posts: 3045
Joined: Sun Mar 23, 2003 6:22 pm
Location: Franconia
Name: Martin Truckenbrodt
Contact:

Re: problem with one in-line action

Post by Martin Truckenbrodt » Sun Feb 24, 2013 12:32 pm

Hello Jari,
yes. Same result.

The only thing I haven't tried by now is another webserver.

Bye Martin
Free tutorial: Installing MODs in phpBB 3.0
Advanced Block MOD - Prevent spam on your phpBB 3.0 board with Stop Forum Spam, BotScout, Akismet, Project Honey Pot and several IP-RBL and Domain-RBL DNS blacklists!
My MODs
Use the official phpBB Ideas to vote missing core features!!!

User avatar
Martin Truckenbrodt
Registered User
Posts: 3045
Joined: Sun Mar 23, 2003 6:22 pm
Location: Franconia
Name: Martin Truckenbrodt
Contact:

Re: problem with one in-line action

Post by Martin Truckenbrodt » Sun Feb 24, 2013 6:43 pm

Hello,
I've released the new version of the MOD on my website (ADAP 1.4.12).

Maybe somebody wants to test it for this issue here?

Bye Martin
Free tutorial: Installing MODs in phpBB 3.0
Advanced Block MOD - Prevent spam on your phpBB 3.0 board with Stop Forum Spam, BotScout, Akismet, Project Honey Pot and several IP-RBL and Domain-RBL DNS blacklists!
My MODs
Use the official phpBB Ideas to vote missing core features!!!

fs65fool
Registered User
Posts: 1
Joined: Mon Feb 25, 2013 10:36 pm

Re: problem with one in-line action

Post by fs65fool » Mon Feb 25, 2013 10:48 pm

Hello Martin,

I installed ADAP 1.4.12 on a clean install with AutoMod 1.0.1

I get the same error as you:
***************
includes/auth/auth_apache.php
Find

function login_apache(&$username, &$password)
{
global $db;

In-Line Find

global $db

The In-Line Find specified by the MOD could not be found. The Find specified by the MOD could not be found

*******************
I'm a newb, sorry I can't be of any help other than reproducing the same issue. I'm not going to force the install so i am wondering if I should install version 1.4.11?

User avatar
Lumpy Burgertushie
Registered User
Posts: 66236
Joined: Mon May 02, 2005 3:11 am
Contact:

Re: problem with one in-line action

Post by Lumpy Burgertushie » Tue Feb 26, 2013 4:20 am

I believe the problem is that the find should not be a "inline find" . there is a line break and you can't have a inline if you have a line break.



robert
Last edited by Lumpy Burgertushie on Tue Feb 26, 2013 1:17 pm, edited 1 time in total.
I am available for custom work on a donation basis. Please send me a PM with your needs.

Premium phpBB 3.2 Styles by PlanetStyles.net

OK, so what's the speed of dark?

User avatar
RMcGirr83
Recognised Extension Developer
Posts: 21034
Joined: Wed Jun 22, 2005 4:33 pm
Location: Your display
Name: Rich McGirr
Contact:

Re: problem with one in-line action

Post by RMcGirr83 » Tue Feb 26, 2013 9:25 am

Why not just add after global $config;
In times of change, learners inherit the earth, while the learned find themselves beautifully equipped to deal with a world that no longer exists - Eric Hoffer
Former Modifications/Extensions Team Member | My extensions
Appreciate the extensions/mods/support then buy me a beer
All requests for support via PM will be ignored

Locked

Return to “[3.0.x] AutoMOD”