append_sid()

This forum is now closed as part of retiring phpBB2.
Forum rules
READ: phpBB.com Board-Wide Rules and Regulations

This forum is now closed due to phpBB2.0 being retired.
Post Reply
afterlife_69
I've Been Banned!
Posts: 630
Joined: Tue Nov 30, 2004 10:35 am

append_sid()

Post by afterlife_69 »

I noticed that phpBB doesnt always append the sid, so i made a little patch to fix that, im just wondering... is this a good or bad thing, is there a reason that phpbb doesnt always append the sid or is it just a bug?

if it isnt a bug ill release my append_sid() patch as a modification, reply soon
~AL69
User avatar
MHobbit
Former Team Member
Posts: 4761
Joined: Thu Mar 18, 2004 5:32 pm
Location: There and Back Again

Re: append_sid()

Post by MHobbit »

afterlife_69 wrote: I noticed that phpBB doesnt always append the sid, so i made a little patch to fix that, im just wondering... is this a good or bad thing, is there a reason that phpbb doesnt always append the sid or is it just a bug?

if it isnt a bug ill release my append_sid() patch as a modification, reply soon
~AL69


phpBB only appends the SID when it's required, ie the user doesn't support cookies.
Former phpBB MOD Team member
No private support is offered.
"There’s too many things to get done, and I’m running out of days..."
alcaeus
I've Been Banned!
Posts: 431
Joined: Wed Nov 19, 2003 1:12 pm

Post by alcaeus »

Um, phpBB appends the SID whenever the session method is set to SESSION_METHOD_GET, meaning that the SID could not be stored in a cookie. Whenever it can be stored in a cookie, it won't be appended to the URL, making it nicer to look at ;)
However, the URL is appended for all ACP pages.

IMO there's no need to release such a function ;)

Greetz
alcaeus
afterlife_69
I've Been Banned!
Posts: 630
Joined: Tue Nov 30, 2004 10:35 am

Post by afterlife_69 »

Hmm, ill release it anyways since its also an SEO.
edit: http://www.phpbb.com/phpBB/viewtopic.ph ... highlight=
alcaeus
I've Been Banned!
Posts: 431
Joined: Wed Nov 19, 2003 1:12 pm

Post by alcaeus »

afterlife_69 wrote: since its also an SEO.

How's that an SEO? I thought spiders didn't like those nasty SIDs :?

Greetz
alcaeus
markus_petrux
Former Team Member
Posts: 1887
Joined: Wed Apr 23, 2003 7:11 am
Location: Girona, Catalunya (Spain)
Contact:

Post by markus_petrux »

Note removing the SID for ALL guests will create a new sessions table for each page hit done by a guest increasing the sessions table. It might impact the overall performance of the board.

If you are concerned about SEO, you might want to check the KB (there are articles about the SID already) or the Bot Indexing MOD, which just removes the SID for known bots.
EasyMOD Standards | MOD Template Actions | MODs in Development Rules
Useful information for MOD Authors | MOD Queue Stats | Search MODs
Write SQL/DDL portable to all SQL servers supported by phpBB!
Get EasyMOD 0.3.0! | Suport al phpBB en Català!
8)
phantomk
Registered User
Posts: 1039
Joined: Wed Apr 14, 2004 5:32 am
Location: Canada Eh?
Name: Daniel Lee
Contact:

Post by phantomk »

CyberAlien's sid removal for guests does the same thing, and it does not create a sid for each new page hit. I honestly don't see a good reason to add your modification since thier is a better version that does not seriously impact the boards performance.
Post Reply

Return to “[2.0.x] MOD Writers Discussion”