Page 1 of 1

append_sid()

Posted: Fri Sep 23, 2005 10:10 pm
by afterlife_69
I noticed that phpBB doesnt always append the sid, so i made a little patch to fix that, im just wondering... is this a good or bad thing, is there a reason that phpbb doesnt always append the sid or is it just a bug?

if it isnt a bug ill release my append_sid() patch as a modification, reply soon
~AL69

Re: append_sid()

Posted: Fri Sep 23, 2005 10:21 pm
by MHobbit
afterlife_69 wrote: I noticed that phpBB doesnt always append the sid, so i made a little patch to fix that, im just wondering... is this a good or bad thing, is there a reason that phpbb doesnt always append the sid or is it just a bug?

if it isnt a bug ill release my append_sid() patch as a modification, reply soon
~AL69


phpBB only appends the SID when it's required, ie the user doesn't support cookies.

Posted: Fri Sep 23, 2005 10:22 pm
by alcaeus
Um, phpBB appends the SID whenever the session method is set to SESSION_METHOD_GET, meaning that the SID could not be stored in a cookie. Whenever it can be stored in a cookie, it won't be appended to the URL, making it nicer to look at ;)
However, the URL is appended for all ACP pages.

IMO there's no need to release such a function ;)

Greetz
alcaeus

Posted: Fri Sep 23, 2005 10:34 pm
by afterlife_69
Hmm, ill release it anyways since its also an SEO.
edit: http://www.phpbb.com/phpBB/viewtopic.ph ... highlight=

Posted: Sat Sep 24, 2005 7:24 am
by alcaeus
afterlife_69 wrote: since its also an SEO.

How's that an SEO? I thought spiders didn't like those nasty SIDs :?

Greetz
alcaeus

Posted: Sat Sep 24, 2005 7:56 am
by markus_petrux
Note removing the SID for ALL guests will create a new sessions table for each page hit done by a guest increasing the sessions table. It might impact the overall performance of the board.

If you are concerned about SEO, you might want to check the KB (there are articles about the SID already) or the Bot Indexing MOD, which just removes the SID for known bots.

Posted: Sat Sep 24, 2005 8:00 am
by phantomk
CyberAlien's sid removal for guests does the same thing, and it does not create a sid for each new page hit. I honestly don't see a good reason to add your modification since thier is a better version that does not seriously impact the boards performance.