[ABD] ShMk User Feedback 1.0.6

Any abandoned MODs will be moved to this forum.

WARNING: MODs in this forum are not currently being supported or maintained by the original MOD author. Proceed at your own risk.
Forum rules
IMPORTANT: MOD Development Forum rules

WARNING: MODs in this forum are not currently being supported nor updated by the original MOD author. Proceed at your own risk.
Locked
User avatar
zenpig
Registered User
Posts: 642
Joined: Wed Aug 07, 2002 10:58 pm

Re: [RC] ShMk User Feedback 1.0.3

Post by zenpig » Sun Aug 03, 2008 10:34 pm

To the above issue with ampersands, "&", and links to what is being passed to the url it is a limitation of just urlenode being used as a function in the link and in the meta-refresh...urlencode doesn't work too well with escaping ALL special characters, in other words, if passed this way. If anyone else is experiencing the issue what I have done is changed a few lines which inline states .urlencode($a['username'])), to .urlencode(htmlspecialchars_decode($a['username']))),. These lines are either the creation of the link itself('FB_URL') or the meta_refresh which controls the refreshing of the username after an edit, deletion, etc.

in root/feedback.php lines 92,107,276,636,660 were altered in this way

in root/includes/acp/acp_feedback.php lines 472,506,520 were similarly changed.

just watch for maintaining ";" in the meta_refresh lines and "," in the 'FB_URL' lines.

I believe these are the only lines that need to be altered and have tested a bit since doing so. Not sure if this is the best way to tackle the problem but appears to be working fine.

[edit]
bah...for filtering the feedback of a user with an "&" in their userame the same change needs to be made to lines 188 through 202 in root/feedback.php and 138 through 152 in root/includes/acp/acp_feedback.php. These should look like .urlencode(htmlspecialchars_decode($un)).

If the optional link to feedback used under the avatar the edit for viewtopic.php needs to be 'U_FEEDBACK_OF' => append_sid("{$phpbb_root_path}feedback.$phpEx",'mode=feedback&username='.urlencode(htmlspecialchars_decode($row['username']))),
[/edit]
Beer's proof that God loves us and wants us to be happy.

72skylark
Registered User
Posts: 5
Joined: Sat Jul 26, 2008 1:48 pm

Re: [RC] ShMk User Feedback 1.0.3

Post by 72skylark » Mon Aug 04, 2008 4:14 pm

I am aware that these are optional in the install but I am getting the following error when trying to use them. These options are a great feature to this FB mod and would like to utilize them.

Can someone possibly tell me how to correct the following errors

Parse error: syntax error, unexpected T_DOUBLE_ARROW in /home/myforumname/public_html/phpBB3/viewtopic.php on line 1466



Parse error: syntax error, unexpected T_DOUBLE_ARROW in /home/myforumname/public_html/phpBB3/memberlist.php on line 568

I have replaced myforumname with the forum as this forum is still under construction.

Thank you for any help you may provide. :)

72skylark
Registered User
Posts: 5
Joined: Sat Jul 26, 2008 1:48 pm

Re: [RC] ShMk User Feedback 1.0.3

Post by 72skylark » Thu Aug 07, 2008 11:15 pm

Nevermind figured it out!

dr.akester
Registered User
Posts: 2
Joined: Thu Jul 24, 2008 5:43 am

Re: [RC] ShMk User Feedback 1.0.3

Post by dr.akester » Wed Aug 13, 2008 11:20 am

I got a question.

on the feedback.php page, what must I do to remove the "worst" list?

Is there a line of code I can omit? I ctrl+f the instructions page I can find a line of code in the SQL with "worst" in it, can I just leave that line out?

User avatar
GoBieN
Registered User
Posts: 543
Joined: Fri Mar 05, 2004 5:22 pm
Location: Belgium
Contact:

Re: [RC] ShMk User Feedback 1.0.3

Post by GoBieN » Wed Aug 13, 2008 6:13 pm

dr.akester wrote:I got a question.

on the feedback.php page, what must I do to remove the "worst" list?

Is there a line of code I can omit? I ctrl+f the instructions page I can find a line of code in the SQL with "worst" in it, can I just leave that line out?
Don't adjust the SQL, you will break the mod.
You should only adjust the template !

dr.akester
Registered User
Posts: 2
Joined: Thu Jul 24, 2008 5:43 am

Re: [RC] ShMk User Feedback 1.0.3

Post by dr.akester » Wed Aug 13, 2008 11:06 pm

Aww Shucks. Thanks for letting me know.

Anyone have a suggestion of what I could do to remove the "worst" group?

Tom@S
Registered User
Posts: 96
Joined: Thu Jul 12, 2007 7:33 pm
Location: SVK
Contact:

Re: [RC] ShMk User Feedback 1.0.3

Post by Tom@S » Wed Aug 13, 2008 11:27 pm

open template files and delete it, so easy

syk_skillz
Registered User
Posts: 4
Joined: Sat Aug 23, 2008 7:58 pm

Re: [RC] ShMk User Feedback 1.0.3

Post by syk_skillz » Sun Aug 24, 2008 9:12 pm

After installing everything seems fine besides for the view profile page where I get a error message

Code: Select all

Fatal error: Cannot redeclare fb_get_user_feedback() (previously declared in /home/.margreta/ddnsyk/truxity.net/forums/includes/functions_feedback.php:25) in /home/.margreta/ddnsyk/truxity.net/forums/includes/functions_feedback.php on line 40
How do I fix this?

syk_skillz
Registered User
Posts: 4
Joined: Sat Aug 23, 2008 7:58 pm

Re: [RC] ShMk User Feedback 1.0.3

Post by syk_skillz » Mon Aug 25, 2008 3:38 am

Still need help :(
I cant figure it out for anything. I tried re-uploading everything and every other step again and all was correct so any clue of what I need to do?

syk_skillz
Registered User
Posts: 4
Joined: Sat Aug 23, 2008 7:58 pm

Re: [RC] ShMk User Feedback 1.0.3

Post by syk_skillz » Mon Aug 25, 2008 3:28 pm

Can anyone please help me?

User avatar
RMcGirr83
Recognised Extension Developer
Posts: 21034
Joined: Wed Jun 22, 2005 4:33 pm
Location: Your display
Name: Rich McGirr
Contact:

Re: [RC] ShMk User Feedback 1.0.3

Post by RMcGirr83 » Mon Aug 25, 2008 3:42 pm

You can try this, open memberlist.php

FIND

Code: Select all

		// MOD: SHMK USER FEEDBACK
		include($phpbb_root_path . 'includes/functions_feedback.' . $phpEx);
		// END: SHMK USER FEEDBACK
REPLACE WITH

Code: Select all

    if ( !function_exists('fb_get_user_feedback') )
    {
		// MOD: SHMK USER FEEDBACK
		include($phpbb_root_path . 'includes/functions_feedback.' . $phpEx);
		// END: SHMK USER FEEDBACK
    }
Haven't tested it though.
In times of change, learners inherit the earth, while the learned find themselves beautifully equipped to deal with a world that no longer exists - Eric Hoffer
Former Modifications/Extensions Team Member | My extensions
Appreciate the extensions/mods/support then buy me a beer
All requests for support via PM will be ignored

syk_skillz
Registered User
Posts: 4
Joined: Sat Aug 23, 2008 7:58 pm

Re: [RC] ShMk User Feedback 1.0.3

Post by syk_skillz » Mon Aug 25, 2008 11:02 pm

Thanks that worked!

kevinroxx
Registered User
Posts: 94
Joined: Fri Dec 14, 2007 9:57 pm

Re: [RC] ShMk User Feedback 1.0.3

Post by kevinroxx » Thu Aug 28, 2008 3:04 am

This error occurs when you try to leave 3 consecutive smilies in a feedback comment (for example: :) :P :D ) :

Code: Select all

SQL ERROR [ mysqli ]

Data too long for column 'fb_comment' at row 1 [1406]
Any ideas as to a fix?

It seems to work fine when you only leave 1 or 2 smilies in a comment but more than 3 gives you the error seen above

User avatar
RMcGirr83
Recognised Extension Developer
Posts: 21034
Joined: Wed Jun 22, 2005 4:33 pm
Location: Your display
Name: Rich McGirr
Contact:

Re: [RC] ShMk User Feedback 1.0.3

Post by RMcGirr83 » Thu Aug 28, 2008 11:19 am

That's because the smilie codes are going beyond the 255 character limit on the database table

Code: Select all

fb_comment varchar(255)
You could try changing the database column fb_comment to TEXT but that may induce other errors.
In times of change, learners inherit the earth, while the learned find themselves beautifully equipped to deal with a world that no longer exists - Eric Hoffer
Former Modifications/Extensions Team Member | My extensions
Appreciate the extensions/mods/support then buy me a beer
All requests for support via PM will be ignored

kevinroxx
Registered User
Posts: 94
Joined: Fri Dec 14, 2007 9:57 pm

Re: [RC] ShMk User Feedback 1.0.3

Post by kevinroxx » Thu Aug 28, 2008 4:39 pm

RMcGirr83 wrote:That's because the smilie codes are going beyond the 255 character limit on the database table

Code: Select all

fb_comment varchar(255)
You could try changing the database column fb_comment to TEXT but that may induce other errors.
Is there a way to prevent users from inserting too many smilies so an error does not occur?
Thanks

Locked

Return to “[3.0.x] Abandoned MODs”