Page 17 of 46

Re: [RC] ShMk User Feedback 1.0.3

Posted: Sun Aug 03, 2008 10:34 pm
by zenpig
To the above issue with ampersands, "&", and links to what is being passed to the url it is a limitation of just urlenode being used as a function in the link and in the meta-refresh...urlencode doesn't work too well with escaping ALL special characters, in other words, if passed this way. If anyone else is experiencing the issue what I have done is changed a few lines which inline states .urlencode($a['username'])), to .urlencode(htmlspecialchars_decode($a['username']))),. These lines are either the creation of the link itself('FB_URL') or the meta_refresh which controls the refreshing of the username after an edit, deletion, etc.

in root/feedback.php lines 92,107,276,636,660 were altered in this way

in root/includes/acp/acp_feedback.php lines 472,506,520 were similarly changed.

just watch for maintaining ";" in the meta_refresh lines and "," in the 'FB_URL' lines.

I believe these are the only lines that need to be altered and have tested a bit since doing so. Not sure if this is the best way to tackle the problem but appears to be working fine.

[edit]
bah...for filtering the feedback of a user with an "&" in their userame the same change needs to be made to lines 188 through 202 in root/feedback.php and 138 through 152 in root/includes/acp/acp_feedback.php. These should look like .urlencode(htmlspecialchars_decode($un)).

If the optional link to feedback used under the avatar the edit for viewtopic.php needs to be 'U_FEEDBACK_OF' => append_sid("{$phpbb_root_path}feedback.$phpEx",'mode=feedback&username='.urlencode(htmlspecialchars_decode($row['username']))),
[/edit]

Re: [RC] ShMk User Feedback 1.0.3

Posted: Mon Aug 04, 2008 4:14 pm
by 72skylark
I am aware that these are optional in the install but I am getting the following error when trying to use them. These options are a great feature to this FB mod and would like to utilize them.

Can someone possibly tell me how to correct the following errors

Parse error: syntax error, unexpected T_DOUBLE_ARROW in /home/myforumname/public_html/phpBB3/viewtopic.php on line 1466



Parse error: syntax error, unexpected T_DOUBLE_ARROW in /home/myforumname/public_html/phpBB3/memberlist.php on line 568

I have replaced myforumname with the forum as this forum is still under construction.

Thank you for any help you may provide. :)

Re: [RC] ShMk User Feedback 1.0.3

Posted: Thu Aug 07, 2008 11:15 pm
by 72skylark
Nevermind figured it out!

Re: [RC] ShMk User Feedback 1.0.3

Posted: Wed Aug 13, 2008 11:20 am
by dr.akester
I got a question.

on the feedback.php page, what must I do to remove the "worst" list?

Is there a line of code I can omit? I ctrl+f the instructions page I can find a line of code in the SQL with "worst" in it, can I just leave that line out?

Re: [RC] ShMk User Feedback 1.0.3

Posted: Wed Aug 13, 2008 6:13 pm
by GoBieN
dr.akester wrote:I got a question.

on the feedback.php page, what must I do to remove the "worst" list?

Is there a line of code I can omit? I ctrl+f the instructions page I can find a line of code in the SQL with "worst" in it, can I just leave that line out?
Don't adjust the SQL, you will break the mod.
You should only adjust the template !

Re: [RC] ShMk User Feedback 1.0.3

Posted: Wed Aug 13, 2008 11:06 pm
by dr.akester
Aww Shucks. Thanks for letting me know.

Anyone have a suggestion of what I could do to remove the "worst" group?

Re: [RC] ShMk User Feedback 1.0.3

Posted: Wed Aug 13, 2008 11:27 pm
by Tom@S
open template files and delete it, so easy

Re: [RC] ShMk User Feedback 1.0.3

Posted: Sun Aug 24, 2008 9:12 pm
by syk_skillz
After installing everything seems fine besides for the view profile page where I get a error message

Code: Select all

Fatal error: Cannot redeclare fb_get_user_feedback() (previously declared in /home/.margreta/ddnsyk/truxity.net/forums/includes/functions_feedback.php:25) in /home/.margreta/ddnsyk/truxity.net/forums/includes/functions_feedback.php on line 40
How do I fix this?

Re: [RC] ShMk User Feedback 1.0.3

Posted: Mon Aug 25, 2008 3:38 am
by syk_skillz
Still need help :(
I cant figure it out for anything. I tried re-uploading everything and every other step again and all was correct so any clue of what I need to do?

Re: [RC] ShMk User Feedback 1.0.3

Posted: Mon Aug 25, 2008 3:28 pm
by syk_skillz
Can anyone please help me?

Re: [RC] ShMk User Feedback 1.0.3

Posted: Mon Aug 25, 2008 3:42 pm
by RMcGirr83
You can try this, open memberlist.php

FIND

Code: Select all

		// MOD: SHMK USER FEEDBACK
		include($phpbb_root_path . 'includes/functions_feedback.' . $phpEx);
		// END: SHMK USER FEEDBACK
REPLACE WITH

Code: Select all

    if ( !function_exists('fb_get_user_feedback') )
    {
		// MOD: SHMK USER FEEDBACK
		include($phpbb_root_path . 'includes/functions_feedback.' . $phpEx);
		// END: SHMK USER FEEDBACK
    }
Haven't tested it though.

Re: [RC] ShMk User Feedback 1.0.3

Posted: Mon Aug 25, 2008 11:02 pm
by syk_skillz
Thanks that worked!

Re: [RC] ShMk User Feedback 1.0.3

Posted: Thu Aug 28, 2008 3:04 am
by kevinroxx
This error occurs when you try to leave 3 consecutive smilies in a feedback comment (for example: :) :P :D ) :

Code: Select all

SQL ERROR [ mysqli ]

Data too long for column 'fb_comment' at row 1 [1406]
Any ideas as to a fix?

It seems to work fine when you only leave 1 or 2 smilies in a comment but more than 3 gives you the error seen above

Re: [RC] ShMk User Feedback 1.0.3

Posted: Thu Aug 28, 2008 11:19 am
by RMcGirr83
That's because the smilie codes are going beyond the 255 character limit on the database table

Code: Select all

fb_comment varchar(255)
You could try changing the database column fb_comment to TEXT but that may induce other errors.

Re: [RC] ShMk User Feedback 1.0.3

Posted: Thu Aug 28, 2008 4:39 pm
by kevinroxx
RMcGirr83 wrote:That's because the smilie codes are going beyond the 255 character limit on the database table

Code: Select all

fb_comment varchar(255)
You could try changing the database column fb_comment to TEXT but that may induce other errors.
Is there a way to prevent users from inserting too many smilies so an error does not occur?
Thanks