[ABD] Smiley Pagination 0.9.0

Any abandoned MODs will be moved to this forum.

WARNING: MODs in this forum are not currently being supported or maintained by the original MOD author. Proceed at your own risk.
Forum rules
IMPORTANT: MOD Development Forum rules

WARNING: MODs in this forum are not currently being supported nor updated by the original MOD author. Proceed at your own risk.
guxi
Registered User
Posts: 11
Joined: Sun Aug 09, 2009 10:58 am

Re: [Beta] Smiley Pagination 0.9.0

Post by guxi » Fri Aug 14, 2009 8:20 am

muggins wrote:That's odd. It works just fine for me and probably a few hundred other people.

I know it isn't even a remote possibility that you may have made a mistake, but you might check... :lol:
In old latins they are saying:
NON BIS IN IDEM!
That means to do not step twice in the same... sh....t. :)
Now, I have installed 3 versions of phpBB forums, fresh installation, v. 3.05.
And on not any one this nice MOD does not work.
O course, I have some results on each of them. The smillie are deisapeared from the posting window.
So, why to try a fourth time?
Maybe there are some installing intructions forgotten and not revealed.
Anyway, if such mod is working, is a nice looking one, as a saw on screenshot.

salvo1
Registered User
Posts: 46
Joined: Wed Sep 07, 2005 8:46 pm

Re: [Beta] Smiley Pagination 0.9.0

Post by salvo1 » Tue Aug 18, 2009 9:15 pm

If you are smart don't bother, this mod will be built into 3.0.6. You'll have enough to worry about with that version as it is. So don't create more headache for youreself. Just a little patience, yeaaaaaaaaaaaah yeah, just a little patience.

NissanNut
Registered User
Posts: 60
Joined: Mon Jan 26, 2009 11:39 pm
Contact:

Re: [Beta] Smiley Pagination 0.9.0

Post by NissanNut » Fri Aug 21, 2009 3:48 am

Great mod!!! I think its the first Mod from TX I have added.

8-)

Bash
Registered User
Posts: 337
Joined: Wed Mar 11, 2009 3:36 pm
Location: London, England
Name: Glenn

Re: [Beta] Smiley Pagination 0.9.0

Post by Bash » Sun Nov 22, 2009 10:48 am

Ok I was using this mod until the latest phpbb update killed it.

argh, this is hard to explain...

Basically I updated PHPBB with 'merge' files, then afterwards I was getting these errors when I edited a post:

[phpBB Debug] PHP Notice: in file /includes/functions_posting.php on line 144: Invalid argument supplied foreach ()

[phpBB Debug]PHP Notice: in file /includes/functions.php on line 4183: Cannot modify header information - headers already sent by (output started at /includes/functions.php:3493)

[phpBB Debug]PHP Notice: in file /includes/functions.php on line 4185: Cannot modify header information - headers already sent by (output started at /includes/functions.php:3493)

[phpBB Debug]PHP Notice: in file /includes/functions.php on line 4186: Cannot modify header information - headers already sent by (output started at /includes/functions.php:3493)

[phpBB Debug]PHP Notice: in file /includes/functions.php on line 4187: Cannot modify header information - headers already sent by (output started at /includes/functions.php:3493)

I read somewhere that the latest update includes it's own smiley pagination, so I deleted the adds to:

language/en/acp/board.php
includes/acp/acp_board.php

And then undid changes to:

includes/functions_posting.php

like so:

Replaced:

Code: Select all

$smilies_per_page = $config['smilies_per_page'];
	
	$count = 0;
	$current_page = 1;
	// Build nested array for smilies
	foreach ($smilies as $row)
	{
		$count++;
		if ($count > $current_page*$smilies_per_page && $smilies_per_page != 0)
		{
			$current_page++;
		}
		$new_smilies[$current_page][$count] = $row;
	}
	
	if (sizeof($smilies))
	{
		foreach ($new_smilies as $page => $smilies_ary)
		{
			$template->assign_block_vars('smiley_pages', array(
				'PAGE'			=> $page,
				'TOTAL_PAGES'	=> sprintf($user->lang['PAGE_OF'], $page, $current_page, 1),
				'FIRST_PAGE'	=> ($page == 1) ? true : false,
				'PREV_PAGE'		=> $page-1,
				'NEXT_PAGE'		=> $page+1,
				'LAST_PAGE'		=> ($page == $current_page) ? true : false,
				'ONE_PAGE'		=> ($current_page == 1) ? true : false
			));
			
			foreach ($smilies_ary as $key => $row)
			{
				$template->assign_block_vars('smiley_pages.smiley', array(
					'COUNT'			=> $key,
					'SMILEY_CODE'	=> $row['code'],
					'A_SMILEY_CODE'	=> addslashes($row['code']),
					'SMILEY_IMG'	=> $phpbb_root_path . $config['smilies_path'] . '/' . $row['smiley_url'],
					'SMILEY_WIDTH'	=> $row['smiley_width'],
					'SMILEY_HEIGHT'	=> $row['smiley_height'],
					'SMILEY_DESC'	=> $row['emotion']
				));
			}
With:

Code: Select all

	if (sizeof($smilies))
	{
		$root_path = (defined('PHPBB_USE_BOARD_URL_PATH') && PHPBB_USE_BOARD_URL_PATH) ? generate_board_url() . '/' : $phpbb_root_path;

		foreach ($smilies as $row)
		{
			$template->assign_block_vars('smiley', array(
				'SMILEY_CODE'	=> $row['code'],
				'A_SMILEY_CODE'	=> addslashes($row['code']),
				'SMILEY_IMG'	=> $root_path . $config['smilies_path'] . '/' . $row['smiley_url'],
				'SMILEY_WIDTH'	=> $row['smiley_width'],
				'SMILEY_HEIGHT'	=> $row['smiley_height'],
				'SMILEY_DESC'	=> $row['emotion'])
			);			
			
		}
	}

	if ($mode == 'inline' && $display_link)
	{
		$template->assign_vars(array(
			'S_SHOW_SMILEY_LINK' 	=> true,
			'U_MORE_SMILIES' 		=> append_sid("{$phpbb_root_path}posting.$phpEx", 'mode=smilies&f=' . $forum_id))
		);
Which fixed the errors, but now I have no smiley's.

Can anyone advise?

User avatar
patrikstar
Registered User
Posts: 330
Joined: Sun Feb 12, 2006 9:37 am
Location: Phoenix, AZ
Contact:

Re: [Beta] Smiley Pagination 0.9.0

Post by patrikstar » Sun Nov 22, 2009 7:30 pm

I have stated previously I no longer support this mod because of the implementation into 3.0.6

User avatar
muggins
Registered User
Posts: 1183
Joined: Fri Feb 22, 2008 5:12 pm
Location: Texas
Name: Donovan
Contact:

Re: [Beta] Smiley Pagination 0.9.0

Post by muggins » Sun Nov 22, 2009 8:26 pm

Would you be kind enough to post a link or tutorial on how to make the smilies paginate in the posting form instead of relying on the pop-up?

The reason I and many others like this mod is that it doesn't use the pop-up...
Muggins

User avatar
patrikstar
Registered User
Posts: 330
Joined: Sun Feb 12, 2006 9:37 am
Location: Phoenix, AZ
Contact:

Re: [Beta] Smiley Pagination 0.9.0

Post by patrikstar » Sun Nov 22, 2009 8:38 pm

well i am not sure how 3.0.6 works but is it only paginated in the popup?

if so i might rework my mod to modify the post page only

User avatar
muggins
Registered User
Posts: 1183
Joined: Fri Feb 22, 2008 5:12 pm
Location: Texas
Name: Donovan
Contact:

Re: [Beta] Smiley Pagination 0.9.0

Post by muggins » Sun Nov 22, 2009 8:43 pm

Yessir. A default number of smilies are on the posting page, with a "View more Smilies' link.

I have no under-the-hood experience with 3.0.6 yet, but it looks like your mod is still a very useful one. So, please do continue with it! :mrgreen:
Muggins

User avatar
patrikstar
Registered User
Posts: 330
Joined: Sun Feb 12, 2006 9:37 am
Location: Phoenix, AZ
Contact:

Re: [Beta] Smiley Pagination 0.9.0

Post by patrikstar » Sun Nov 22, 2009 9:12 pm

Ok well so far I have no experience with 3.0.6 at all how does the popup one work?

User avatar
muggins
Registered User
Posts: 1183
Joined: Fri Feb 22, 2008 5:12 pm
Location: Texas
Name: Donovan
Contact:

Re: [Beta] Smiley Pagination 0.9.0

Post by muggins » Sun Nov 22, 2009 9:15 pm

Better than the previous one, but still. :?

I just checked, and your mod installs and works properly with 3.0.6.

There's one line in the find for root/includes/functions_posting.php that I took a stab in the dark at, but all works! 8-) I'll back up and document the change later today...
Muggins

Bash
Registered User
Posts: 337
Joined: Wed Mar 11, 2009 3:36 pm
Location: London, England
Name: Glenn

Re: [Beta] Smiley Pagination 0.9.0

Post by Bash » Tue Nov 24, 2009 7:32 pm

Great, so I guess I have to do a clean install and lose all my mods.

Thorx
Registered User
Posts: 5
Joined: Fri Feb 27, 2009 12:42 pm

Re: [Beta] Smiley Pagination 0.9.0

Post by Thorx » Tue Mar 16, 2010 7:17 pm

I like your MOD as well. Just at the update to 3.06 or 3.07PL1 it rally gets difficult where to make the changes. Can somebody post what has to be replaced.
And please continue your good work, the Mod is really an enhancement rather then that popup thing...
Thank you!

Peter77sx
Registered User
Posts: 3253
Joined: Wed Nov 09, 2005 2:51 pm

Re: [Beta] Smiley Pagination 0.9.0

Post by Peter77sx » Wed Mar 17, 2010 3:20 am

Thorx wrote:I like your MOD as well. Just at the update to 3.06 or 3.07PL1 it rally gets difficult where to make the changes. Can somebody post what has to be replaced.
And please continue your good work, the Mod is really an enhancement rather then that popup thing...
Thank you!
phpbb 3.0.7+ already supports smilie pagination out the box. This is an outdated MOD. :)

User avatar
muggins
Registered User
Posts: 1183
Joined: Fri Feb 22, 2008 5:12 pm
Location: Texas
Name: Donovan
Contact:

Re: [Beta] Smiley Pagination 0.9.0

Post by muggins » Wed Mar 17, 2010 4:20 pm

In the same way that 3.0.6 does? I haven't upgraded yet, but this question came up with 3.0.6, and it seems not to be the case.

The smilies paginate in the pop-up, not in the posting form. I can't wait to be corrected. :D
Muggins

User avatar
RMcGirr83
Recognised Extension Developer
Posts: 21034
Joined: Wed Jun 22, 2005 4:33 pm
Location: Your display
Name: Rich McGirr
Contact:

Re: [Beta] Smiley Pagination 0.9.0

Post by RMcGirr83 » Wed Mar 17, 2010 4:59 pm

muggins wrote:The smilies paginate in the pop-up, not in the posting form. I can't wait to be corrected. :D
Corrected for what? You're correct as is...at least where 3.0.7-PL1 is concerned. ;)
In times of change, learners inherit the earth, while the learned find themselves beautifully equipped to deal with a world that no longer exists - Eric Hoffer
Former Modifications/Extensions Team Member | My extensions
Appreciate the extensions/mods/support then buy me a beer
All requests for support via PM will be ignored

Locked

Return to “[3.0.x] Abandoned MODs”