Page 3 of 4

Re: [Beta] Smiley Pagination 0.9.0

Posted: Fri Aug 14, 2009 8:20 am
by guxi
muggins wrote:That's odd. It works just fine for me and probably a few hundred other people.

I know it isn't even a remote possibility that you may have made a mistake, but you might check... :lol:
In old latins they are saying:
NON BIS IN IDEM!
That means to do not step twice in the same... sh....t. :)
Now, I have installed 3 versions of phpBB forums, fresh installation, v. 3.05.
And on not any one this nice MOD does not work.
O course, I have some results on each of them. The smillie are deisapeared from the posting window.
So, why to try a fourth time?
Maybe there are some installing intructions forgotten and not revealed.
Anyway, if such mod is working, is a nice looking one, as a saw on screenshot.

Re: [Beta] Smiley Pagination 0.9.0

Posted: Tue Aug 18, 2009 9:15 pm
by salvo1
If you are smart don't bother, this mod will be built into 3.0.6. You'll have enough to worry about with that version as it is. So don't create more headache for youreself. Just a little patience, yeaaaaaaaaaaaah yeah, just a little patience.

Re: [Beta] Smiley Pagination 0.9.0

Posted: Fri Aug 21, 2009 3:48 am
by NissanNut
Great mod!!! I think its the first Mod from TX I have added.

8-)

Re: [Beta] Smiley Pagination 0.9.0

Posted: Sun Nov 22, 2009 10:48 am
by Bash
Ok I was using this mod until the latest phpbb update killed it.

argh, this is hard to explain...

Basically I updated PHPBB with 'merge' files, then afterwards I was getting these errors when I edited a post:

[phpBB Debug] PHP Notice: in file /includes/functions_posting.php on line 144: Invalid argument supplied foreach ()

[phpBB Debug]PHP Notice: in file /includes/functions.php on line 4183: Cannot modify header information - headers already sent by (output started at /includes/functions.php:3493)

[phpBB Debug]PHP Notice: in file /includes/functions.php on line 4185: Cannot modify header information - headers already sent by (output started at /includes/functions.php:3493)

[phpBB Debug]PHP Notice: in file /includes/functions.php on line 4186: Cannot modify header information - headers already sent by (output started at /includes/functions.php:3493)

[phpBB Debug]PHP Notice: in file /includes/functions.php on line 4187: Cannot modify header information - headers already sent by (output started at /includes/functions.php:3493)

I read somewhere that the latest update includes it's own smiley pagination, so I deleted the adds to:

language/en/acp/board.php
includes/acp/acp_board.php

And then undid changes to:

includes/functions_posting.php

like so:

Replaced:

Code: Select all

$smilies_per_page = $config['smilies_per_page'];
	
	$count = 0;
	$current_page = 1;
	// Build nested array for smilies
	foreach ($smilies as $row)
	{
		$count++;
		if ($count > $current_page*$smilies_per_page && $smilies_per_page != 0)
		{
			$current_page++;
		}
		$new_smilies[$current_page][$count] = $row;
	}
	
	if (sizeof($smilies))
	{
		foreach ($new_smilies as $page => $smilies_ary)
		{
			$template->assign_block_vars('smiley_pages', array(
				'PAGE'			=> $page,
				'TOTAL_PAGES'	=> sprintf($user->lang['PAGE_OF'], $page, $current_page, 1),
				'FIRST_PAGE'	=> ($page == 1) ? true : false,
				'PREV_PAGE'		=> $page-1,
				'NEXT_PAGE'		=> $page+1,
				'LAST_PAGE'		=> ($page == $current_page) ? true : false,
				'ONE_PAGE'		=> ($current_page == 1) ? true : false
			));
			
			foreach ($smilies_ary as $key => $row)
			{
				$template->assign_block_vars('smiley_pages.smiley', array(
					'COUNT'			=> $key,
					'SMILEY_CODE'	=> $row['code'],
					'A_SMILEY_CODE'	=> addslashes($row['code']),
					'SMILEY_IMG'	=> $phpbb_root_path . $config['smilies_path'] . '/' . $row['smiley_url'],
					'SMILEY_WIDTH'	=> $row['smiley_width'],
					'SMILEY_HEIGHT'	=> $row['smiley_height'],
					'SMILEY_DESC'	=> $row['emotion']
				));
			}
With:

Code: Select all

	if (sizeof($smilies))
	{
		$root_path = (defined('PHPBB_USE_BOARD_URL_PATH') && PHPBB_USE_BOARD_URL_PATH) ? generate_board_url() . '/' : $phpbb_root_path;

		foreach ($smilies as $row)
		{
			$template->assign_block_vars('smiley', array(
				'SMILEY_CODE'	=> $row['code'],
				'A_SMILEY_CODE'	=> addslashes($row['code']),
				'SMILEY_IMG'	=> $root_path . $config['smilies_path'] . '/' . $row['smiley_url'],
				'SMILEY_WIDTH'	=> $row['smiley_width'],
				'SMILEY_HEIGHT'	=> $row['smiley_height'],
				'SMILEY_DESC'	=> $row['emotion'])
			);			
			
		}
	}

	if ($mode == 'inline' && $display_link)
	{
		$template->assign_vars(array(
			'S_SHOW_SMILEY_LINK' 	=> true,
			'U_MORE_SMILIES' 		=> append_sid("{$phpbb_root_path}posting.$phpEx", 'mode=smilies&f=' . $forum_id))
		);
Which fixed the errors, but now I have no smiley's.

Can anyone advise?

Re: [Beta] Smiley Pagination 0.9.0

Posted: Sun Nov 22, 2009 7:30 pm
by patrikstar
I have stated previously I no longer support this mod because of the implementation into 3.0.6

Re: [Beta] Smiley Pagination 0.9.0

Posted: Sun Nov 22, 2009 8:26 pm
by muggins
Would you be kind enough to post a link or tutorial on how to make the smilies paginate in the posting form instead of relying on the pop-up?

The reason I and many others like this mod is that it doesn't use the pop-up...

Re: [Beta] Smiley Pagination 0.9.0

Posted: Sun Nov 22, 2009 8:38 pm
by patrikstar
well i am not sure how 3.0.6 works but is it only paginated in the popup?

if so i might rework my mod to modify the post page only

Re: [Beta] Smiley Pagination 0.9.0

Posted: Sun Nov 22, 2009 8:43 pm
by muggins
Yessir. A default number of smilies are on the posting page, with a "View more Smilies' link.

I have no under-the-hood experience with 3.0.6 yet, but it looks like your mod is still a very useful one. So, please do continue with it! :mrgreen:

Re: [Beta] Smiley Pagination 0.9.0

Posted: Sun Nov 22, 2009 9:12 pm
by patrikstar
Ok well so far I have no experience with 3.0.6 at all how does the popup one work?

Re: [Beta] Smiley Pagination 0.9.0

Posted: Sun Nov 22, 2009 9:15 pm
by muggins
Better than the previous one, but still. :?

I just checked, and your mod installs and works properly with 3.0.6.

There's one line in the find for root/includes/functions_posting.php that I took a stab in the dark at, but all works! 8-) I'll back up and document the change later today...

Re: [Beta] Smiley Pagination 0.9.0

Posted: Tue Nov 24, 2009 7:32 pm
by Bash
Great, so I guess I have to do a clean install and lose all my mods.

Re: [Beta] Smiley Pagination 0.9.0

Posted: Tue Mar 16, 2010 7:17 pm
by Thorx
I like your MOD as well. Just at the update to 3.06 or 3.07PL1 it rally gets difficult where to make the changes. Can somebody post what has to be replaced.
And please continue your good work, the Mod is really an enhancement rather then that popup thing...
Thank you!

Re: [Beta] Smiley Pagination 0.9.0

Posted: Wed Mar 17, 2010 3:20 am
by Peter77sx
Thorx wrote:I like your MOD as well. Just at the update to 3.06 or 3.07PL1 it rally gets difficult where to make the changes. Can somebody post what has to be replaced.
And please continue your good work, the Mod is really an enhancement rather then that popup thing...
Thank you!
phpbb 3.0.7+ already supports smilie pagination out the box. This is an outdated MOD. :)

Re: [Beta] Smiley Pagination 0.9.0

Posted: Wed Mar 17, 2010 4:20 pm
by muggins
In the same way that 3.0.6 does? I haven't upgraded yet, but this question came up with 3.0.6, and it seems not to be the case.

The smilies paginate in the pop-up, not in the posting form. I can't wait to be corrected. :D

Re: [Beta] Smiley Pagination 0.9.0

Posted: Wed Mar 17, 2010 4:59 pm
by RMcGirr83
muggins wrote:The smilies paginate in the pop-up, not in the posting form. I can't wait to be corrected. :D
Corrected for what? You're correct as is...at least where 3.0.7-PL1 is concerned. ;)