Page 7 of 12

Re: [DEV] Friend Request Approval MOD

Posted: Fri Aug 14, 2009 1:21 pm
by stathisch
issjut wrote:Here is one more request ;-)

It would be nice to see the already sent friend requests in a separate module as long as these are still unconfirmed.

for example:

I send a friend request to a user. As long as the user has not approved or rejected the request i can see this request on a new module (eg. Sent friend requests or unconfirmed friend requests).

Perhaps with the option to cancel already sent friend requests.
-----------------------

Also it would be great to get an e-mail notification and / or a PM when I get a new friend request.
It's like you're reading my mind :P
I was going to ask for these too

Re: [DEV] Friend Request Approval MOD

Posted: Fri Aug 14, 2009 6:06 pm
by superj707
kmklr, I still think this is one of the greatest mods ever. I hope when you are the master of the universe because of your IM mod that you do come back to this one anyway

Re: [DEV] Friend Request Approval MOD

Posted: Fri Aug 14, 2009 6:28 pm
by kmklr72
I've been working on this a bit. Not much but since I got the second version of the AJAX IM out I will be able to work on this more.
stathisch wrote:
issjut wrote:Here is one more request ;-)

It would be nice to see the already sent friend requests in a separate module as long as these are still unconfirmed.

for example:

I send a friend request to a user. As long as the user has not approved or rejected the request i can see this request on a new module (eg. Sent friend requests or unconfirmed friend requests).

Perhaps with the option to cancel already sent friend requests.
-----------------------

Also it would be great to get an e-mail notification and / or a PM when I get a new friend request.
It's like you're reading my mind :P
I was going to ask for these too
I really like these suggestions and I think I will put them in the mod. If not this version, then the next version.

Re: [DEV] Friend Request Approval MOD

Posted: Fri Aug 21, 2009 9:36 am
by eunaumtenhoid
waiting for subsilver2....

thx for mod^^

Re: [DEV] Friend Request Approval MOD

Posted: Sun Aug 23, 2009 1:01 am
by Spaniel
Where are the "Accept Request" and "Reject Request" buttons? I don't have any on the version I installed. I can send out requests, and view the request, but all I get is the username as a profile link and a line saying, e.g.

"[Username] would like to be your friend."

Also could this be made compatible with Mtrs's Block PMs By User mod so that adding a Foe blocks PMs (already possible with Mtrs's mod) and blocks their requests?

If we have 15 different block features, it might not be intuitive and user-friendly anymore - I'm already confused and this is only 0.0.1 ;)

Re: [DEV] Friend Request Approval MOD

Posted: Sun Aug 23, 2009 1:28 am
by kmklr72
Spaniel wrote:Where are the "Accept Request" and "Reject Request" buttons? I don't have any on the version I installed. I can send out requests, and view the request, but all I get is the username as a profile link and a line saying, e.g.

"[Username] would like to be your friend."
Make sure to refresh the template, theme, and imagesets for all of your styles. That is probably the cause of this problem.
Spaniel wrote:Also could this be made compatible with Mtrs's Block PMs By User mod so that adding a Foe blocks PMs (already possible with Mtrs's mod) and blocks their requests?

If we have 15 different block features, it might not be intuitive and user-friendly anymore - I'm already confused and this is only 0.0.1 ;)
It should already check for mtrs's Block PMs By User mod, although I don't know if he updated that mod recently or not. It should be working with 0.0.9.

Re: [DEV] Friend Request Approval MOD

Posted: Sun Aug 23, 2009 2:07 am
by Spaniel
Oh excellent. Wow - it's both fun and impressive :)


However, I feel 3 different block features developing: Foes, PM Foes, and Request Foes. As the average internet user can't navigate a blank page, won't this cost us in user-friendliness? Would a simple solution be that no matter which block feature a user clicks on, it takes them to a page where they can tick boxes to select how exactly they wish to block the other user, so that page would simply ask us to:

Tick the corresponding boxes to block this user's

[*] forum posts
[*] private messages
[*] friends requests[/b]

Re: [DEV] Friend Request Approval MOD

Posted: Sun Aug 23, 2009 2:27 am
by kmklr72
That's actually a pretty cool idea. I'll see what I can do for the next version, but I'm not going to guarantee anything just yet.

Re: [DEV] Friend Request Approval MOD

Posted: Sun Aug 23, 2009 2:29 am
by eunaumtenhoid
subsilver2 edits , where?

Re: [DEV] Friend Request Approval MOD

Posted: Sun Aug 23, 2009 2:41 am
by Spaniel
kmklr72 wrote:That's actually a pretty cool idea. I'll see what I can do for the next version, but I'm not going to guarantee anything just yet.
Cool :cool: Mtrs's PM Blocking mod update now brings forum Foes together with PM Foes so if you could go one step further and tie your block feature in with all that, that would be wonderful. I believe this is Mtrs's magic code that does the kick-ass blocking:

http://www.phpbb.com/community/viewtopi ... #p10560715

Re: [DEV] Friend Request Approval MOD

Posted: Sun Aug 23, 2009 3:14 am
by Spaniel
One more user-friendly suggestion and then I promise to call it a night ;)

Have one universal Block List with a data table where all the blockees are listed with tick boxes showing how they're blocked, and by changing the ticks and clicking 'submit', it updates that user's block settings, e.g.

Tick or Untick the boxes to change the block settings for each user:

user1
[*] forum posts blocked [*] PMs blocked [*] Friends requests blocked

user15 [ ] forum posts blocked [ ] PMs blocked [*] Friends requests blocked

user25 [*] forum posts blocked [ ] PMs blocked [*] Friends requests blocked


[Submit] [Cancel]
[/b]

Obviously each column would have headings but I don't know how to draw tables on here :)

Re: [DEV] Friend Request Approval MOD

Posted: Sun Aug 30, 2009 11:49 am
by Greyhound76
Hello,

There is also a guide for subSilver?

Re: [DEV] Friend Request Approval MOD

Posted: Sun Aug 30, 2009 5:04 pm
by Greight
When I click to add someone as a friend this errors comes:
Parse error: syntax error, unexpected T_IF in /home/hlyxmrmp/public_html/includes/ucp/ucp_zebra.php on line 1

I re-checked the edits. Everything is fine. Ive also purged the cache.
What can I do ?

EDIT:
Solved! I changes the file format in notepad++ to UNIX and one time uploaded the original file then the edited file! ;)

Re: [DEV] Friend Request Approval MOD

Posted: Sun Sep 06, 2009 11:27 pm
by Tomelie
Hi hi!
This mod is very nice! Thanks for it!

I installed this, but i have a problem x__x!... When someone accepts a friendship request, an error message appears:

Code: Select all

General Error
SQL ERROR [ mysql4 ]

Incorrect string value: '\xEF\xBF\xBDve ...' for column 'message_subject' at row 1 [1366]

SQL

INSERT INTO phpbb_privmsgs (root_level, author_id, icon_id, author_ip, message_time, enable_bbcode, enable_smilies, enable_magic_url, enable_sig, message_subject, message_text, message_attachment, bbcode_bitfield, bbcode_uid, to_address, bcc_address) VALUES (0, '102', 0, '201.214.249.107', 1252279178, 1, 1, 0, 0, 'You�ve been approved', 'Saku-chan has approved your friendship request and you are now friends. Saku-chan now appears on your friend list.', 0, '', '20tlaquy', 'u_54', '')

BACKTRACE

FILE: includes/db/mysql.php
LINE: 174
CALL: dbal->sql_error()

FILE: includes/functions_privmsgs.php
LINE: 1435
CALL: dbal_mysql->sql_query()

FILE: includes/ucp/ucp_fram.php
LINE: 350
CALL: submit_pm()

FILE: includes/ucp/ucp_fram.php
LINE: 147
CALL: ucp_fram->send_pm()

FILE: includes/functions_module.php
LINE: 507
CALL: ucp_fram->main()

FILE: ucp.php
LINE: 344
CALL: p_master->load_active()
Still, the request is accepted...

Help me please ;_;...

Re: [DEV] Friend Request Approval MOD

Posted: Mon Sep 07, 2009 12:31 am
by kmklr72
That's a problem with the subject not getting encoded in utf8 (the is set up for it to be utf8, but it refuses to convert). This edit should fix that:

Open language/en/mods/fram_mod.php

Find:

Code: Select all

'FRAM_APPROVED_SUBJECT'                => 'You’ve been approved', 
Replace with:

Code: Select all

'FRAM_APPROVED_SUBJECT'                => 'You\'ve been approved',