[ABD] Move to Trash 2.0.0

Any abandoned MODs will be moved to this forum.

WARNING: MODs in this forum are not currently being supported or maintained by the original MOD author. Proceed at your own risk.
Forum rules
IMPORTANT: MOD Development Forum rules

WARNING: MODs in this forum are not currently being supported nor updated by the original MOD author. Proceed at your own risk.
User avatar
drndos
Registered User
Posts: 82
Joined: Tue Jan 29, 2008 7:47 am
Location: Slovakia
Contact:

Re: [RC] Move to trash 1.0.1

Post by drndos »

ehm it can't be like this, Please check your installation
because - when it is normal move then $trash is false, if $trash is false then it will execute the normal code means

Code: Select all

$to_forum_id = request_var('to_forum_id', 0);
If the $trash is true which is in that case if the selected option value is move_to_trash (the code calls function mcp_move_topic() )
The function mcp_move_topic() will move desired topic to pre-configured forum
therp
Registered User
Posts: 55
Joined: Sun Jul 19, 2009 7:37 pm

Re: [RC] Move to trash 1.0.1

Post by therp »

drndos wrote:So you didnt edit the language file or wrong language file...
You were right. I did edit the language files, but I made such a rookie mistake. :oops: But then again I am a rookie :lol:

Working like a charm now. No problems with moving either. Thanks a lot man.
User avatar
A_O_C
Registered User
Posts: 2383
Joined: Sun Jul 01, 2007 11:26 pm
Location: phpbb_

Re: [RC] Move to trash 1.0.1

Post by A_O_C »

drndos, I fixed it myself. NOTE - instructions could have been wrote better. ;)
User avatar
drndos
Registered User
Posts: 82
Joined: Tue Jan 29, 2008 7:47 am
Location: Slovakia
Contact:

Re: [RC] Move to trash 1.0.1

Post by drndos »

instructions are good ;) it is all about the user skill, I see you have wrote some mods but many people who even don't know what PHP is, installed this MOD without any problem...
User avatar
A_O_C
Registered User
Posts: 2383
Joined: Sun Jul 01, 2007 11:26 pm
Location: phpbb_

Re: [RC] Move to trash 1.0.1

Post by A_O_C »

Let me rephrase...

Code: Select all

			<edit>
				<find><![CDATA[if (confirm_box(true))]]></find>
				<inline-edit>
					<inline-find>)</inline-find>
					<inline-action type="before-add"><![CDATA[ || $trash]]></inline-action>
				</inline-edit>
			</edit>
MODs are to be installed by finding the first instance of the find, and then following the instructions (after-add, before-add, etc). So, with the above code, most people will have this:

Code: Select all

if (confirm_box(true || $trash))
AutoMOD will do the same thing, making validation fail. My suggestion is change the instructions to this:

Code: Select all

			<edit>
				<find><![CDATA[if (confirm_box(true))]]></find>
				<inline-edit>
					<inline-find>)</inline-find>
					<inline-action type="after-add"><![CDATA[ || $trash]]></inline-action>
				</inline-edit>
			</edit>
Note that the only thing changed is "before-add" to "after-add".
User avatar
tumba25
Former Team Member
Posts: 4430
Joined: Wed Jun 06, 2007 6:42 am
Location: Kokkola, Finland.
Name: Jari Kanerva
Contact:

Re: [RC] Move to trash 1.0.1

Post by tumba25 »

The MOD author has stated that he is not going to submit this MOD in the MODDB, so I'm locking this topic per the forum rules.

If the author changes his mind he can contact me or some other MOD Team member.
Need a mod/extension created/installed, other custom-coded solution or a server admin? https://tumba25.net
User avatar
tumba25
Former Team Member
Posts: 4430
Joined: Wed Jun 06, 2007 6:42 am
Location: Kokkola, Finland.
Name: Jari Kanerva
Contact:

Re: [RC] Move to trash 1.0.1

Post by tumba25 »

The MOD author changed his mind about submitting to the MODDB so I'll reopen this topic.

Do note that MODs in the development forum should be considered unstable and not used in a live forum before they are accepted in the MODDB.
Need a mod/extension created/installed, other custom-coded solution or a server admin? https://tumba25.net
Golden Falcon
Registered User
Posts: 7
Joined: Wed Mar 05, 2008 12:40 am

Re: [RC] Move to trash 1.0.1

Post by Golden Falcon »

Is there anyway to add this as a static button?

Example:
Image
User avatar
mrgoldy
Development Team Member
Development Team Member
Posts: 1392
Joined: Tue Oct 06, 2009 7:34 pm
Location: The Netherlands
Name: Gijs
Contact:

Re: [RC] Move to trash 1.0.1

Post by mrgoldy »

Hello,

You've it set to open languages/en/common.php, that way it doesn't work with AutoMOD as it can not locate the file. It should be language/en/common.php. Thought I should let you know.

And why do you add this to the "User Registration Settings"? Kinda weird, add it to Board Settings / Board Features instead.

Regards,
phpBB Studio / Member of the Studio

Contributing: You can do it too! Including testing Pull Requests (PR).
phpBB Development and Testing made easy.
User avatar
drndos
Registered User
Posts: 82
Joined: Tue Jan 29, 2008 7:47 am
Location: Slovakia
Contact:

Re: [RC] Move to trash 1.0.1

Post by drndos »

Yup, I am planning new version this was just quick done one. Will be released soon so please hold on :)
apierce
Registered User
Posts: 35
Joined: Mon May 25, 2009 4:57 pm
Location: Lubbock
Contact:

Re: [RC] Move to trash 1.0.1

Post by apierce »

Thanks so much for this. I always had to stop my moderators from just deleting posts.
http://chatbam.com - Free Forum Promotion!
User avatar
drndos
Registered User
Posts: 82
Joined: Tue Jan 29, 2008 7:47 am
Location: Slovakia
Contact:

Re: [RC] Move to trash 1.0.1

Post by drndos »

MOD updated
You can find the new version here - http://www.phpbb3hacks.com/viewtopic.php?f=37&t=331
Ather
Registered User
Posts: 1032
Joined: Fri May 08, 2009 9:42 am
Location: Kingdom of Bahrain
Name: Ather Akber

Re: [RC] Move to trash 1.0.2

Post by Ather »

x2 for this please!!

Image

or, if you can make it work on a click of a button? what i want is placed in line of Report button so i can move it directly to trash...
CPL Syed Ather Akbar
Regional Command Southwest
Camp Leatherneck, Afghanistan

My Mods/Snippets
tunderofnl
Registered User
Posts: 3
Joined: Wed Feb 03, 2010 4:12 pm

Re: [RC] Move to trash 1.0.2

Post by tunderofnl »

If I try to move something to trash it moves it to a forum ID I didn't put in in the administrator control instead of 47(trash forum) it moves it to a forum id 0 (it doesn't even exists...)
User avatar
drndos
Registered User
Posts: 82
Joined: Tue Jan 29, 2008 7:47 am
Location: Slovakia
Contact:

Re: [RC] Move to trash 1.0.2

Post by drndos »

try to purge the cache
Locked

Return to “[3.0.x] Abandoned MODs”