Page 3 of 8

Re: [BETA] Calendar Alerts MOD v0.0.1

Posted: Sat Jan 30, 2010 12:42 pm
by battye
I do not see the problem.
The February 1 alert will not show until the day before, which is January 31. :)

Today is January 30, so no alert should appear :)

Re: [BETA] Calendar Alerts MOD v0.0.1

Posted: Sat Jan 30, 2010 10:34 pm
by Jorup16
battye wrote:Thanks Jorup16, I have updated the first post here at phpBB.com and http://forums.cricketmx.com/viewtopic.p ... 835#p98835 :)

;) ;)

Re: [BETA] Calendar Alerts MOD v0.0.1

Posted: Sun Jan 31, 2010 11:53 am
by lovelysummer
Hi battye,

Forget the previous screenshots which I uploaded wrong attachments.

Here are the 31 Jan status :(
Image
Image

Alert of 1 Feb (1 day before, ie. next month) is not shown up.

Do you have the same case I have?

Tks.

Re: [BETA] Calendar Alerts MOD v0.0.1

Posted: Sun Jan 31, 2010 1:03 pm
by battye
Ah okay. Good spotting :wink:
Yes I was able to reproduce that bug as well, but I have got the fix for it (the program was getting confused because it was the last day of the month :))

In index.php, FIND

Code: Select all

		$same_day_alert = $row['alert_day'] && ($day_now == $day_alert);
		$before_day_alert = $row['alert_day_before'] && ($day_now == ($day_alert-1));
		$week_day_alert = $row['alert_week'] && ($day_now == ($day_alert-7));


REPLACE WITH

Code: Select all

		// Check the days in month
		$days_in_month	= date('t', $alert_time);

		$same_day_alert = $row['alert_day'] && ($day_now == $day_alert);
		$before_day_alert = $row['alert_day_before'] && (($day_now == ($day_alert-1)) || ($day_now == $days_in_month && $day_alert == 1));
		$week_day_alert = $row['alert_week'] && (($day_now == ($day_alert-7)) || ($day_now == $days_in_month && $day_alert = ($days_in_month - 7)));



This will be included in v0.0.2 :)

Re: [BETA] Calendar Alerts MOD v0.0.1

Posted: Wed Feb 03, 2010 1:56 pm
by battye
As I have released Beta 4 of the Ultimate Quiz MOD I now have a chance to work on v0.0.2 of this MOD.

Is there anyone interested in testing the next version before I publicly release it?

Re: [BETA] Calendar Alerts MOD v0.0.1

Posted: Wed Feb 03, 2010 5:08 pm
by keith10456
battye wrote:As I have released Beta 4 of the Ultimate Quiz MOD I now have a chance to work on v0.0.2 of this MOD.

Is there anyone interested in testing the next version before I publicly release it?
I don't have a test site to install it on but I wouldn't mind testing the functions/features as a user on a demo site you may have.

Re: [BETA] Calendar Alerts MOD v0.0.1

Posted: Wed Feb 03, 2010 5:34 pm
by lovelysummer
battye wrote:As I have released Beta 4 of the Ultimate Quiz MOD I now have a chance to work on v0.0.2 of this MOD.

Is there anyone interested in testing the next version before I publicly release it?
I have already installed in my live forum 0.0.1 :mrgreen:
And ready for 0.0.2 :mrgreen:

Re: [BETA] Calendar Alerts MOD v0.0.1

Posted: Thu Feb 04, 2010 4:15 am
by battye
Thanks keith and lovelysummer :)

Here is the plan for 0.0.2:
  • allow "global" alerts by administrators (alerts that appear to everyone)
  • 7 day lead-up alerts (alerts appearing every day for the 7 days before the alert)
  • Fix the "16:00" time appearing
  • Fix the end of the month error

Re: [BETA] Calendar Alerts MOD v0.0.1

Posted: Thu Feb 04, 2010 5:34 am
by keith10456
battye wrote:Thanks keith and lovelysummer :)

Here is the plan for 0.0.2:
  • allow "global" alerts by administrators (alerts that appear to everyone)
  • 7 day lead-up alerts (alerts appearing every day for the 7 days before the alert)
  • Fix the "16:00" time appearing
  • Fix the end of the month error
Sweet 8-)

Re: [BETA] Calendar Alerts MOD v0.0.1

Posted: Fri Feb 05, 2010 10:48 am
by battye
Here is the download link to Beta 2... I just realised I didn't fix the 16:00 bug, I guess that will have to wait until Beta 3 :)

So new in beta 2 is:
- bug fixes
- global alerts (admins can set an alert so that alerts appear for everyone)
- 7 day leadup alerts (so the alert appears every day in the seven days leading up to the alert)

My plan for Beta 3 (v0.0.3) is:

- Fix the 16:00 bug
- Have a UMIL file

Download link: http://www.cmxmods.net/downloads/Calend ... _beta2.zip

If someone could confirm that it indeed works (it works on my site, but it would be bad if I missed an edit or something in the released package :)) I will update the first post with the new download link.

Re: [BETA] Calendar Alerts MOD v0.0.1

Posted: Fri Feb 05, 2010 1:11 pm
by ChriZathens
It seems to work just fine...
Also tested it using Greek language and all is OK... But could you please consider the possibility to edit an already created alert?

EDIT: If I enter long test I get the error

Code: Select all

SQL ERROR [ mysqli ]

Data too long for column 'alert_text' at row 1 [1406]
Perhaps you should also consider increasing the allowed characters and/or add an error message in the case the message exceeds the limit, instead of getting the nasty error... :P

Re: [BETA] Calendar Alerts MOD v0.0.1

Posted: Fri Feb 05, 2010 1:18 pm
by battye
ChriZathens wrote:It seems to work just fine...
Also tested it using Greek language and all is OK... But could you please consider the possibility to edit an already created alert?
Thanks for confirming that 0.0.2 works okay ChriZathens. I've thought about adding an edit function, but because it only takes about 20 seconds to delete the event and re-add it I felt it seemed like bloat.

Edit: Ah, thanks for telling me about that error. I will add a message in the next version :)

Re: [BETA] Calendar Alerts MOD v0.0.2

Posted: Fri Feb 05, 2010 1:50 pm
by ChriZathens
Yes, perhaps you are right about the edit function...
A few more:
The caching is a bit confusing... If you add an alert you have to wait for the cache time to pass until it shows... It may confuse a lot of people (make them think that it wasn't added)
And the 255 char limit is too low IMHO...(perhaps double would be OK)

And I have a question: Global option is only available to admins, right? And every user sees their own alerts, unless there are alerts set global by an admin, right?

Re: [BETA] Calendar Alerts MOD v0.0.2

Posted: Fri Feb 05, 2010 2:04 pm
by battye
ChriZathens wrote:Yes, perhaps you are right about the edit function...
A few more:
The caching is a bit confusing... If you add an alert you have to wait for the cache time to pass until it shows... It may confuse a lot of people (make them think that it wasn't added)
And the 255 char limit is too low IMHO...(perhaps double would be OK)

And I have a question: Global option is only available to admins, right? And every user sees their own alerts, unless there are alerts set global by an admin, right?
Yes, that is a good point about the caching. I want the caching there for most of the time, because there is no need to query the database every time a user goes to the index page - but it should appear immediately so users aren't confused... something I will need to think about.

Yes, the global alerts option is only available to admins (well, I hope it is!). Every user sees their own alerts as well as any alerts submitted by the admin which have been set to global.

Re: [BETA] Calendar Alerts MOD v0.0.2

Posted: Fri Feb 05, 2010 3:17 pm
by keith10456
Thanks for the release :lol: