[ABD] Subject Prefix

Any abandoned MODs will be moved to this forum.

WARNING: MODs in this forum are not currently being supported or maintained by the original MOD author. Proceed at your own risk.
Forum rules
IMPORTANT: MOD Development Forum rules

WARNING: MODs in this forum are not currently being supported nor updated by the original MOD author. Proceed at your own risk.
Locked
User avatar
VSE
Extensions Development Coordinator
Extensions Development Coordinator
Posts: 4917
Joined: Sat Jan 17, 2009 9:37 am
Location: Los Angeles, CA
Name: Matt Friedman
Contact:

Re: [BETA] Subject Prefix

Post by VSE » Thu Jun 10, 2010 2:49 am

Every time I try the Quick Mod menu to change the Prefix, I get an error message:
The submitted form was invalid. Try submitting again.
Dictated but not read.
Official phpBB Extensions My Extensions & MODs
Please do not PM me for support.

User avatar
tbackoff
Former Team Member
Posts: 7022
Joined: Thu Jun 04, 2009 1:41 am
Location: cheerleading practice
Name: Tabitha Backoff

Re: [BETA] Subject Prefix

Post by tbackoff » Thu Jun 10, 2010 4:57 am

That's a known issue (well, I reported it twice so it should be known). :D
Flying is the second best thrill to cheerleaders; being caught is the first.

User avatar
Erik Frèrejean
Former Team Member
Posts: 9899
Joined: Tue Oct 09, 2007 9:09 am
Location: The Netherlands, 3.0.x Support Forum
Name: Erik Frèrejean
Contact:

Re: [BETA] Subject Prefix

Post by Erik Frèrejean » Thu Jun 10, 2010 10:33 am

Well the main issue here is that it does work in my development environment. Does one of you by any chance have this MOD installed in a testing environment I can access to see the issue?
Support Toolkit | Support Request Template | Knowledge Base | phpBB 3.0.x documentation
I don't give support via PM or IM! (all unsolicited pms will be trashed!)

User avatar
tbackoff
Former Team Member
Posts: 7022
Joined: Thu Jun 04, 2009 1:41 am
Location: cheerleading practice
Name: Tabitha Backoff

Re: [BETA] Subject Prefix

Post by tbackoff » Thu Jun 10, 2010 3:27 pm

I can get one up. I'll post here when I do.
Flying is the second best thrill to cheerleaders; being caught is the first.

User avatar
tbackoff
Former Team Member
Posts: 7022
Joined: Thu Jun 04, 2009 1:41 am
Location: cheerleading practice
Name: Tabitha Backoff

Re: [BETA] Subject Prefix

Post by tbackoff » Thu Jun 10, 2010 4:16 pm

Erik,

Global Mod access should be sufficient, right?

http://testbed.code-w.org
Username: testmod
Password: testmod

There's 2 issues. The first one is that adding a prefix to an already created topic using the dropdown box in viewtopic throws the invalid form error. The second one is that creating a new topic prefix requires refreshing the cache.
Flying is the second best thrill to cheerleaders; being caught is the first.

User avatar
VSE
Extensions Development Coordinator
Extensions Development Coordinator
Posts: 4917
Joined: Sat Jan 17, 2009 9:37 am
Location: Los Angeles, CA
Name: Matt Friedman
Contact:

Re: [BETA] Subject Prefix

Post by VSE » Thu Jun 10, 2010 5:17 pm

Erik Frèrejean wrote:Well the main issue here is that it does work in my development environment. Does one of you by any chance have this MOD installed in a testing environment I can access to see the issue?
Hopefully you saw all my fixes for the installer files?

Recap:
install/index.php

Change:

Code: Select all

$language_file = 'mods/subject_prefix/subject_prefix_common.php';
to: (no .php at end):

Code: Select all

$language_file = 'mods/subject_prefix/subject_prefix_common';
install/install_versions.php

Constants need not be enclosed in quotes (appears three times):

Code: Select all

'TOPICS_TABLE'
Should be:

Code: Select all

TOPICS_TABLE
The module is not correctly assigned to the .MODS tab, so it doesn't appear unless:
Change: 

Code: Select all

ACP_CAT_MODS
to: 

Code: Select all

ACP_CAT_DOT_MODS
subject_prefix_install.xml

It does not copy the whole install folder, just its index.php so the file install_versions.php is not present and this causes the installer file to fail.


After those fixes, that leaves 1 remaining install issue for me I can't figure out:
Adding a new database table: subject_prefix
SQL ERROR Invalid default value for 'prefix_id'
Dictated but not read.
Official phpBB Extensions My Extensions & MODs
Please do not PM me for support.

User avatar
Erik Frèrejean
Former Team Member
Posts: 9899
Joined: Tue Oct 09, 2007 9:09 am
Location: The Netherlands, 3.0.x Support Forum
Name: Erik Frèrejean
Contact:

Re: [BETA] Subject Prefix

Post by Erik Frèrejean » Fri Jun 11, 2010 8:57 am

@VSE,
Yah I've seen the fixes (thanks :)), they are currently waiting for a git push so they'll be in the repository.
VSE wrote:After those fixes, that leaves 1 remaining install issue for me I can't figure out:
Adding a new database table: subject_prefix
SQL ERROR Invalid default value for 'prefix_id'
I mistakenly set the default value of that column to '0', but as its an auto increment column it should be 'NULL'.
Support Toolkit | Support Request Template | Knowledge Base | phpBB 3.0.x documentation
I don't give support via PM or IM! (all unsolicited pms will be trashed!)

User avatar
Erik Frèrejean
Former Team Member
Posts: 9899
Joined: Tue Oct 09, 2007 9:09 am
Location: The Netherlands, 3.0.x Support Forum
Name: Erik Frèrejean
Contact:

Re: [BETA] Subject Prefix

Post by Erik Frèrejean » Fri Jun 11, 2010 8:59 am

Thanks Tabitha,
t_backoff wrote:There's 2 issues. The first one is that adding a prefix to an already created topic using the dropdown box in viewtopic throws the invalid form error.
Ah, I see. It works when QR is enabled or when the topic contains a poll because then phpBB will assign the form token. In case of this option box no token is required. Shall be fixed in the next release. For now simply remove

Code: Select all

        if (!check_form_key('posting'))
        {
            trigger_error($user->lang['FORM_INVALID']);
        } 
from: includes/mcp/mcp_subject_prefix.php
Support Toolkit | Support Request Template | Knowledge Base | phpBB 3.0.x documentation
I don't give support via PM or IM! (all unsolicited pms will be trashed!)

User avatar
Erik Frèrejean
Former Team Member
Posts: 9899
Joined: Tue Oct 09, 2007 9:09 am
Location: The Netherlands, 3.0.x Support Forum
Name: Erik Frèrejean
Contact:

Re: [BETA] Subject Prefix

Post by Erik Frèrejean » Fri Jun 11, 2010 9:28 am

t_backoff wrote:The second one is that creating a new topic prefix requires refreshing the cache.
This should be solved in the next release. Just to be sure, it does update the cache when you delete a prefix?
Support Toolkit | Support Request Template | Knowledge Base | phpBB 3.0.x documentation
I don't give support via PM or IM! (all unsolicited pms will be trashed!)

User avatar
Erik Frèrejean
Former Team Member
Posts: 9899
Joined: Tue Oct 09, 2007 9:09 am
Location: The Netherlands, 3.0.x Support Forum
Name: Erik Frèrejean
Contact:

Re: [RC] Subject Prefix

Post by Erik Frèrejean » Fri Jun 11, 2010 11:24 am

RC1 is available on the github downloads page (direct link). This release should resolve all issues posted in this topic and is (unless some serious issues arise) the last release before I submit this MOD to the MODDB.
Support Toolkit | Support Request Template | Knowledge Base | phpBB 3.0.x documentation
I don't give support via PM or IM! (all unsolicited pms will be trashed!)

User avatar
tbackoff
Former Team Member
Posts: 7022
Joined: Thu Jun 04, 2009 1:41 am
Location: cheerleading practice
Name: Tabitha Backoff

Re: [RC] Subject Prefix

Post by tbackoff » Fri Jun 11, 2010 1:12 pm

Erik Frèrejean wrote:
t_backoff wrote:The second one is that creating a new topic prefix requires refreshing the cache.
This should be solved in the next release. Just to be sure, it does update the cache when you delete a prefix?
Yeah, it seems to update the cache if I delete a prefix.
Erik Frèrejean wrote:RC1 is available on the github downloads page (direct link). This release should resolve all issues posted in this topic and is (unless some serious issues arise) the last release before I submit this MOD to the MODDB.
Thanks! I'll have a look at it tonight. :D
Flying is the second best thrill to cheerleaders; being caught is the first.

User avatar
tbackoff
Former Team Member
Posts: 7022
Joined: Thu Jun 04, 2009 1:41 am
Location: cheerleading practice
Name: Tabitha Backoff

Re: [RC] Subject Prefix

Post by tbackoff » Fri Jun 11, 2010 2:00 pm

Erik,

I gave it a quick look and only noticed 2 issues.
  • The cache issue still isn't fixed. I still have to purge the cache if I create a new prefix (it shows up in the ACP, just not on the main board). Removing is fine.
  • When installing, the installer creates the SUBJECT_PREFIX_TABLE and the SUBJECT_PREFIX_FORUMS_TABLE, but it omits the $table_prefix variable (for example, subject_prefix should be (in my case) phpbb_subject_prefix). My guess is adding the two tables to the constants.php file and defining them would fix this issue (or change the install to use the $table_prefix variable).
I will give it more testing tonight.
Flying is the second best thrill to cheerleaders; being caught is the first.

User avatar
Erik Frèrejean
Former Team Member
Posts: 9899
Joined: Tue Oct 09, 2007 9:09 am
Location: The Netherlands, 3.0.x Support Forum
Name: Erik Frèrejean
Contact:

Re: [RC] Subject Prefix

Post by Erik Frèrejean » Fri Jun 11, 2010 2:05 pm

Tabitha,

Are you sure that the latest files are used? To check remove the old files before uploading the new files, sometimes funny things happen when you're only overwrite them.
Support Toolkit | Support Request Template | Knowledge Base | phpBB 3.0.x documentation
I don't give support via PM or IM! (all unsolicited pms will be trashed!)

User avatar
tbackoff
Former Team Member
Posts: 7022
Joined: Thu Jun 04, 2009 1:41 am
Location: cheerleading practice
Name: Tabitha Backoff

Re: [RC] Subject Prefix

Post by tbackoff » Fri Jun 11, 2010 2:10 pm

New phpBB3 install with fresh files. It's even on a different computer than what I've been testing on. :D
Flying is the second best thrill to cheerleaders; being caught is the first.

User avatar
Erik Frèrejean
Former Team Member
Posts: 9899
Joined: Tue Oct 09, 2007 9:09 am
Location: The Netherlands, 3.0.x Support Forum
Name: Erik Frèrejean
Contact:

Re: [RC] Subject Prefix

Post by Erik Frèrejean » Fri Jun 11, 2010 2:13 pm

o.0 /me goes checking tha package
Support Toolkit | Support Request Template | Knowledge Base | phpBB 3.0.x documentation
I don't give support via PM or IM! (all unsolicited pms will be trashed!)

Locked

Return to “[3.0.x] Abandoned MODs”