Page 2 of 6

Re: [DEV] AJAX Comment on Posts

Posted: Sun Jan 27, 2013 1:06 am
by Jessica
sweet! can't wait :mrgreen:

Re: [DEV] AJAX Comment on Posts

Posted: Sun Jan 27, 2013 2:37 am
by Jessica
bug -- maybe?

I tested this on your demo

I clicked "Send a Comment" -- page refreshed. Typed in the comment. Submitted it (seems to have submitted automatically without page refresh). Clicked the Send a Comment button again, but nothing happened. Seems like it doesn't work after a comment is submitted? Have to refresh page...

Re: [DEV] AJAX Comment on Posts

Posted: Sun Jan 27, 2013 8:25 am
by emosbat
I like anything that is ajax even cockroaches :mrgreen:

Re: [DEV] AJAX Comment on Posts

Posted: Sun Jan 27, 2013 10:37 am
by Ali@php
Jessica wrote:bug -- maybe?

I tested this on your demo

I clicked "Send a Comment" -- page refreshed. Typed in the comment. Submitted it (seems to have submitted automatically without page refresh). Clicked the Send a Comment button again, but nothing happened. Seems like it doesn't work after a comment is submitted? Have to refresh page...
That's right. Because of link id (#sendcomment) browser thinks operation is on the same page. I will change link method to jquery, Hopefully problem will fix then.
emosbat wrote:I like anything that is ajax even cockroaches :mrgreen:
Yeah, AJAX is amazing :D

Re: [DEV] AJAX Comment on Posts

Posted: Sun Jan 27, 2013 10:44 am
by Ali@php
MOD updated to version 0.3.0

[New feature]
-AJAX edit comment

Live demo: [Removed] (Username: demo, Password: demo123)

Re: [DEV] AJAX Comment on Posts

Posted: Sun Jan 27, 2013 11:13 am
by Meis2M
Thank U ali. :D

i like to see Ajax comment on profile too.

Re: [DEV] AJAX Comment on Posts

Posted: Sun Jan 27, 2013 7:20 pm
by leschek
Nice MOD. I did some testing on my test board and here is feedback:

1. When someone comments on your post you will receive a PM. I checked a PM and it seems that there is problem with non English characters in quote of comment. Example: I wrote into comment test komentáře 02, but in a PM it shows me test koment????e 02.

2. Would be nice if user who read the comments can decide himself, if he/she wants to show comments in descending or ascending order. I mean I prefer to see the older comments first, but if there is more comments than admin set in an ACP, I would prefer see newer comments first (without showing all comments).

3. What do you think about counting the comments as posts. Would be nice if admin could set e.g. 2 comments = 1 normal post, so number of users posts will increase by 1 post after sending 2 comments.

4. I would like to see number of a comments on viewforum and index pages. In same way as number of a posts and topics are displayed now.

Re: [DEV] AJAX Comment on Posts

Posted: Mon Jan 28, 2013 5:18 pm
by Jessica
Ali@php wrote:MOD updated to version 0.3.0

[New feature]
-AJAX edit comment

Live demo: [Removed] (Username: demo, Password: demo123)
Must be me, but the ajax edit doesn't seem to work. the page still refreshes...

Re: [DEV] AJAX Comment on Posts

Posted: Wed Jan 30, 2013 5:32 pm
by Ali@php
Meis2M wrote:Thank U ali. :D

i like to see Ajax comment on profile too.
Nice idea, Maybe with another MOD :)
leschek wrote:Nice MOD. I did some testing on my test board and here is feedback:

1. When someone comments on your post you will receive a PM. I checked a PM and it seems that there is problem with non English characters in quote of comment. Example: I wrote into comment test komentáře 02, but in a PM it shows me test koment????e 02.

2. Would be nice if user who read the comments can decide himself, if he/she wants to show comments in descending or ascending order. I mean I prefer to see the older comments first, but if there is more comments than admin set in an ACP, I would prefer see newer comments first (without showing all comments).

3. What do you think about counting the comments as posts. Would be nice if admin could set e.g. 2 comments = 1 normal post, so number of users posts will increase by 1 post after sending 2 comments.

4. I would like to see number of a comments on viewforum and index pages. In same way as number of a posts and topics are displayed now.
Right, This bug exists and I will review just after finishing current tasks.
Jessica wrote:
Ali@php wrote:MOD updated to version 0.3.0

[New feature]
-AJAX edit comment

Live demo: [Removed] (Username: demo, Password: demo123)
Must be me, but the ajax edit doesn't seem to work. the page still refreshes...
Fixed in new version.

Re: [DEV] AJAX Comment on Posts

Posted: Wed Jan 30, 2013 6:09 pm
by Ali@php
MOD updated to version 0.6.0.
Now AJAX milestone is complete :
AJAX
-Send comment (completed)
-Edit comment (completed)
-Delete comments (completed)
-Load forms (completed)
-Pagination (completed)

Live demo: [Removed] (Username: demo, Password: demo123)

New Screenshots:

http://www.phpbbpersian.com/images/com/screen.jpg
http://www.phpbbpersian.com/images/com/screen2.jpg
http://www.phpbbpersian.com/images/com/screen3.jpg
http://www.phpbbpersian.com/images/com/screen4.jpg
http://www.phpbbpersian.com/images/com/screen5.jpg
http://www.phpbbpersian.com/images/com/screen6.jpg

Github repository: https://github.com/phpbbpersian/Comment-on-Posts
Modification Download: https://github.com/phpbbpersian/Comment ... master.zip

I appreciate any test, feedback or bug report.

Re: [DEV] AJAX Comment on Posts

Posted: Wed Jan 30, 2013 6:10 pm
by Jessica
Tested it, works great now :mrgreen:

Re: [DEV] AJAX Comment on Posts

Posted: Wed Jan 30, 2013 6:19 pm
by Jessica
Is it possible/would you be willing to create a completely new method of notification of post comments? I really don't like that it notifies you by PM for some reason >_< Though I guess it'll be tedious and unnecessary just to create a new notification system?

(and maybe you shouldn't get a notification of a comment YOU posted on YOUR own post?)

Re: [DEV] AJAX Comment on Posts

Posted: Wed Jan 30, 2013 6:30 pm
by Ali@php
Jessica wrote:Is it possible/would you be willing to create a completely new method of notification of post comments? I really don't like that it notifies you by PM for some reason >_< Though I guess it'll be tedious and unnecessary just to create a new notification system?

(and maybe you shouldn't get a notification of a comment YOU posted on YOUR own post?)
According to this topic it's possible to see new notification system in phpBB 3.1. It may be an alternative in the future but for now and 3.0 cycle it's better to focus on this method and improve other features.

Re: [DEV] AJAX Comment on Posts

Posted: Wed Jan 30, 2013 6:38 pm
by emosbat
great job well done. could you add a progress bar/ or a loading message when click on `load more comments`? and then if there was no more comments tell that or hide button :)

Re: [DEV] AJAX Comment on Posts

Posted: Wed Jan 30, 2013 6:52 pm
by Ali@php
emosbat wrote:great job well done. could you add a progress bar/ or a loading message when click on `load more comments`? and then if there was no more comments tell that or hide button :)
Yes I will :)