Page 4 of 42

Re: [BETA] Full Syndication Suite 0.9.4a (RSS/ATOM)

Posted: Wed May 30, 2007 12:17 am
by Volunteer Forum
And also, in the acp all text hase been quite big on almost all pages...
Looks really weird...

I wonder why :|

Been looking over the mod a few times now, i see no wrong koding at all :|

Re: [BETA] Full Syndication Suite 0.9.4a (RSS/ATOM)

Posted: Wed May 30, 2007 1:00 am
by Volunteer Forum
Well, thats it for me, too many crazy bugs...

I gona uinstall it now (files already unmodded)...

But how do i get rid of all the database changes this mod has caused ?

Re: [BETA] Full Syndication Suite 0.9.4a (RSS/ATOM)

Posted: Wed May 30, 2007 1:58 am
by G.I. Suck
Schumi,

How hard would it be to change the feed from

{{Topic}}

to

{{Topic}} - {{Forum it's located in}}

This thing is coming out great, especially when we are using Outlook 2007 to read the feeds. It shows up with the name of the poster in the from field, the topic name in the subject field, and the date post in the date field. We just want to identify which forum it came from rather quickly. ;)

Can't wait for more updates schumi, really great stuff!

Re: [BETA] Full Syndication Suite 0.9.4a (RSS/ATOM)

Posted: Thu May 31, 2007 11:35 am
by canitb
Hi, I have tried install the board and I am experiencing some problems.
I'm not good in programming so hope to get some help :)

I get this message for each page of the forum and I get logged out after I logge in??

phpBB Debug] PHP Notice: in file /includes/functions.php on line 4230: Cannot modify header information - headers already sent by (output started at /language/en/common.php:1)
[phpBB Debug] PHP Notice: in file /includes/functions.php on line 4232: Cannot modify header information - headers already sent by (output started at /language/en/common.php:1)
[phpBB Debug] PHP Notice: in file /includes/functions.php on line 4233: Cannot modify header information - headers already sent by (output started at /language/en/common.php:1)
[phpBB Debug] PHP Notice: in file /includes/functions.php on line 4234: Cannot modify header information - headers already sent by (output started at /language/en/common.php:1)

Any ideas?

Re: [BETA] Full Syndication Suite 0.9.4a (RSS/ATOM)

Posted: Thu May 31, 2007 11:59 am
by Schumi
G.I. Suck wrote:How hard would it be to change the feed from

{{Topic}}

to

{{Topic}} - {{Forum it's located in}}
That's easy to do :).
Open includes/functions_syndication and replace the function get_content_data with this variant:

Code: Select all

/**
* get actual data about topics or posts
*/
function get_content_data($content, &$feed_data, $start, $end)
{
    global $global, $number_items, $board_url, $config, $phpEx, $db;

    switch ($content)
    {
        case 'posts':
        case 'topic_posts':    
            if ($content == 'posts')
            {
                global $forum_ids;
                $where_sql = $db->sql_in_set('p.forum_id', $forum_ids);
            }
            else
            {
                global $topic_id;
                $where_sql = 'topic_id = ' . $topic_id;
            }

            $sql = 'SELECT topic_id, p.forum_id, forum_name, post_id, post_text, post_username, post_time, post_subject, bbcode_bitfield, bbcode_uid, enable_bbcode, enable_smilies, enable_magic_url, username
                FROM ' . POSTS_TABLE . ' p, ' . USERS_TABLE . ' u, ' . FORUMS_TABLE . " f
                WHERE $where_sql
                    AND f.forum_id = p.forum_id
                    AND p.poster_id = u.user_id
                    AND post_approved = 1
                ORDER BY post_time DESC";
            $result = $db->sql_query_limit($sql, $end, $start, $config['syndication_ttl']);

            while ($row = $db->sql_fetchrow($result))
            {
                $link = ($global) ? "{$board_url}/viewtopic.$phpEx?f={$row['forum_id']}&t={$row['topic_id']}" : "{$board_url}/viewtopic.$phpEx?f={$row['forum_id']}&t={$row['topic_id']}";

                $feed_data['items'][] = array(
                    'author'    => (!empty($row['post_username'])) ? $row['post_username'] : $row['username'],
                    'time'        => $row['post_time'],
                    'link'            => $link . '#p' . $row['post_id'],
                    'identifier'    => $link . '#p' . $row['post_id'],
                    'title'        => $row['post_subject'] . ' - ' . $row['forum_name'],
                    'text'        => parse_message($row)
                );
            }
            $db->sql_freeresult($result);
        break;

        case 'topics':
            global $forum_ids;

            $sql = 'SELECT t.topic_id, t.forum_id, forum_name, topic_title, topic_first_poster_name, topic_time, post_text, bbcode_uid, bbcode_bitfield, enable_bbcode, enable_smilies, enable_magic_url
                FROM ' . TOPICS_TABLE . ' t, ' . POSTS_TABLE . ' p, ' . FORUMS_TABLE . ' f
                WHERE ' . $db->sql_in_set('t.forum_id', $forum_ids) . '
                    AND p.post_id = t.topic_first_post_id
                    AND p.post_approved = 1
                    AND t.topic_approved = 1
                    AND t.topic_moved_id = 0
                ORDER BY post_time DESC';
            $result = $db->sql_query_limit($sql, $end, $start, $config['syndication_ttl']);

            while ($row = $db->sql_fetchrow($result))
            {
                $link = ($global) ? "{$board_url}/viewtopic.$phpEx?f={$row['forum_id']}&t={$row['topic_id']}" : "{$board_url}/viewtopic.$phpEx?f={$row['forum_id']}&t={$row['topic_id']}";

                $feed_data['items'][] = array(
                    'author'    => $row['topic_first_poster_name'],
                    'time'        => $row['topic_time'],
                    'link'            => $link,
                    'identifier'    => $link,
                    'title'        => $row['forum_name'] . ' - ' . $row['topic_title'],
                    'text'        => parse_message($row)
                );
            }
            $db->sql_freeresult($result);
        break;

        case 'pm':
            global $folder;

            $sql = 'SELECT p.msg_id, message_text, p.author_id, message_time, message_subject, bbcode_bitfield, bbcode_uid, enable_bbcode, enable_smilies, enable_magic_url, u.username
                FROM ' . PRIVMSGS_TABLE . ' p, ' . PRIVMSGS_TO_TABLE . ' t, ' . USERS_TABLE . " u
                WHERE p.author_id = u.user_id
                    AND t.msg_id = p.msg_id
                    AND t.folder_id = $folder
                    AND t.folder_id != " . PRIVMSGS_NO_BOX . '
                    AND t.folder_id != ' . PRIVMSGS_HOLD_BOX . '
                ORDER BY message_time DESC';
            $result = $db->sql_query_limit($sql, $end, $start, $config['syndication_ttl']);

            while ($row = $db->sql_fetchrow($result))
            {
                $link = "{$board_url}/ucp.$phpEx?i=pm&mode=view&f=$folder&p={$row['msg_id']}";

                $feed_data['items'][] = array(
                    'author'    => $row['username'],
                    'time'        => $row['message_time'],
                    'link'            => $link,
                    'identifier'    => $link,
                    'title'        => $row['message_subject'],
                    'text'        => parse_message($row, true)
                );
            }
            $db->sql_freeresult($result);
        break;
    }
}    
canitb wrote:phpBB Debug] PHP Notice: in file /includes/functions.php on line 4230: Cannot modify header information - headers already sent by (output started at /language/en/common.php:1)
This error message says that there is some whitespace in /language/en/common.php on the first line which is not allowed to be there. Check if you have any spaces or new lines before the "<?php" tag in this file. The login issue you experience is a consequence of this because setting cookies fails under this condition.
musikgoat wrote:only supports rss1.0 and hasn't been updated since 05)
Adding RSS 1.0 support is not a big deal, it only requires a new template in RSS 1.0 format and adding few lines to the included files. Up to now, I didn't include RSS 1.0 as I thought it wouldn't be used any more, but if there is still demand for it, I can add it.
myquealer wrote:Is this a feature that the Syndication Suite does not currently have, or am I overlooking something?
Your observations are correct, this is currently not possible. But you can change the source code to fit your needs if you would like to have a different behaviour.
If you want to include moved topics for a feed containing topics, open includes/functions_syndication.php and remove this line:

Code: Select all

AND t.topic_moved_id = 0

Re: [BETA] Full Syndication Suite 0.9.4a (RSS/ATOM)

Posted: Thu May 31, 2007 1:32 pm
by G.I. Suck
Schumi,

This is awesome! Thanks! I even love how it'll refeed bumped topics too! :D

Re: [BETA] Full Syndication Suite 0.9.4a (RSS/ATOM)

Posted: Thu May 31, 2007 2:14 pm
by musikgoat
Schumi wrote:
musikgoat wrote:only supports rss1.0 and hasn't been updated since 05)
Adding RSS 1.0 support is not a big deal, it only requires a new template in RSS 1.0 format and adding few lines to the included files. Up to now, I didn't include RSS 1.0 as I thought it wouldn't be used any more, but if there is still demand for it, I can add it.
We took care of it on our back end, the feeds are working great. unless others need it, its not a big deal for us.
Time for caching contents of a syndiation feed:
Contents of posts or topics will not be retrieved more than once until this time frame has expired.
^^small typo

On a side note, i'm trying to get the feeds running on my personal web server, running through port 8080, would that have an effect on the functionality?

The reason being, after running sql_install.php and checking all permissions, and enabling the feeds in load settings, I still get the following:
Sorry, but syndication has been disabled for this forum or you do not have sufficent permissions.

I have verified that admins guests, registered users, and moderators have the right to post.

lastly, I cleared the cache.

still I cannot get past this error as an admin or a user, inside or outside (accessing by 8080)

Any suggestions?

Re: [BETA] Full Syndication Suite 0.9.4a (RSS/ATOM)

Posted: Thu May 31, 2007 7:55 pm
by JKeats
okay... i have everything working, and i can add the rss to my google reader, but it's not displaying any new posts when they're made.

Re: [BETA] Full Syndication Suite 0.9.4a (RSS/ATOM)

Posted: Fri Jun 01, 2007 1:58 am
by musikgoat
JKeats wrote:okay... i have everything working, and i can add the rss to my google reader, but it's not displaying any new posts when they're made.
there is a caching timer you can turn lower:

General -> Server Config -> Load Settings:
Time for caching contents of a syndiation feed:
Contents of posts or topics will not be retrieved more than once until this time frame has expired.



That may help you, if its just the speed of the updates.

Re: [BETA] Full Syndication Suite 0.9.4a (RSS/ATOM)

Posted: Fri Jun 01, 2007 2:25 am
by JKeats
that's not it. it's only set to 300 seconds. i'd have gotten something for sure by now in my reader.

Re: [BETA] Full Syndication Suite 0.9.4a (RSS/ATOM)

Posted: Fri Jun 01, 2007 3:45 am
by JKeats
found the problem.

the forums on my board aren't public. everything requires being logged in to read. google reader and/or firefox apparently can't handle that. i can get it to work in ie7 if i goto the http://....generate_feed.php.... page, but going to the same page in firefox doesn't even work. unlike ie7 which presents you with a popup for a login and pass that works, when you enter the lp in firefox it doesnt and just gives you the login popup over and over again.

Re: [BETA] Full Syndication Suite 0.9.4a (RSS/ATOM)

Posted: Fri Jun 01, 2007 3:54 am
by DoctorWombat
Could anyone who has installed a working version of this please post a link so we can check it out? :)

Re: [BETA] Full Syndication Suite 0.9.4a (RSS/ATOM)

Posted: Fri Jun 01, 2007 9:22 am
by Highstreet
Sure, check out the forum in my sig, this has the lastest version of the MOD enabled.

Re: [BETA] Full Syndication Suite 0.9.4a (RSS/ATOM)

Posted: Fri Jun 01, 2007 6:02 pm
by matgallis
ADD AFTER

Code: Select all

		'T_THEME_DATA'			=> (!$user->theme['theme_storedb']) ? '' : $user->theme['theme_data'],

		'SITE_LOGO_IMG'			=> $user->img('site_logo'))
	);


The first part of this code isn't near the second part. I found T_THEME_DATA but the later part of the string didn't match?

Re: [BETA] Full Syndication Suite 0.9.4a (RSS/ATOM)

Posted: Fri Jun 01, 2007 6:45 pm
by Quezza
This MOD sounds great, installing now...