Had this before, it caused a bunch of problems... I will think about it though.Perhaps wait until both sides have reported win/loss before updating the score?
is this a fix for the your only allowed the 'You can only select sub-ladders to join.' error?User view:
- Create Clan
- major bug
- Apparently you can't create a clan...
- As a user, from the "create clan" link, if you fill out all of the info you get a message saying "you can only join a sub ladder"
- I have created a sub ladder as an admin, so that probably isn't the problem.
- There is no sub ladder box to join in the clan signup box any more, but the dependency still seems to be there.
- Workaround
- Open /rivals/ladders_addclan.php
- Comment out (using \\)
Code: Select all
// Yes, handle the form. Check if they are joining a sub-ladder. // if ( $http_vars[ 'ladder_id' ] != '-1' ) // { // if ( $ladder->data ( 'ladder_parent', $http_vars[ 'ladder_id' ] ) == 0 ) // { // // No, warn them they can only join a sub-ladder. // trigger_error ( $user->lang[ 'rivals_ucsls' ] ); // } // } // else // { // $http_vars[ 'ladder_id' ] = 0; // }
A.I. BOT wrote:[*]@Twill: I have basically all the stuff you have reported fixed (code-wise, havent tested it yet). And I have added some feature suggestions you have asked for.
This is gonna be a pretty crap/quick "reply" to your report, I dont have much time on my hands atm.
Italics Text = Questions.
CREATE A CLANIn the "create a clan" form, there is a box called "clan contact" and it is a multi line free-for-all box that doesn't really tell you what it's for or where it's used. If you could instead have it be a couple of single line boxes with drop down lists to the right of them. In the drop down box you can choose "Forum Name" "Email address" "Phone number" "Other" and then in the Single line box, you enter the name/number/whatever and it will change the formating of the output according to the drop down list selection. It is more user friendly and leads the user to the exact content you want in the boxes.
- Create a clan errors, fixed.
- What do you mean by limit the size of clan name?
Say someone wants to create a clan called "Twills super duper clan of leeeeeeeeeeeeet madness to kill everyone else in the world and then rule!" - that name, while stupid, is possible and might break some layouts. If you could limit the name to say 27 characters or whatever the appropriate number is to not break the bracket system, that would be ideal- Clan tag stuff will stay as it is, so people can not be limited to just [ and ], rather to < or ( etc as well.
- Kinda lost on what you mean by the clan contact stuff.
VIEWING LADDERSWhat problems, perhaps I could make some suggestions?
- A message will now show up if no clans are in the ladder as you suggested.
You rock- match_extra fixed, had to change it to match_details.
- A PM is now sent to the challengee when a challenge is made. It includes some information and a link to the clan's profile.
- Spelling mistakes fixed.
Had this before, it caused a bunch of problems... I will think about it though.Perhaps wait until both sides have reported win/loss before updating the score?
TOURNAMENTSCREATE A LADDER/SUB-LADDER
- Tournament requires 4 clans or more, 2 clans wont work afaik.
You can still make a 2 clan tournaments, you might want to remove that option, because it does still "work" it just doesn't start.- Reporting tournaments, ah forgot to convert it over to the new tournament system stuff. Will require a bit of code >.< so I'll work on fixing this later tonight.
- The inconsistent use of acp_edittournament and acp_edittournaments has been fixed to all be acp_edittournaments.
- Reporting a win/loss thing should also now be fixed.
ACP EDIT CLAN
- A error message comes up and now says that you cant make a ladder until you make a platform... good enough?
I'd like to be able to make a ladder without a platform in an ideal world, but that's just me. this is perfect for what you have- Ladder rating is now explained. Big white box: dunno what Im gonna do with that, yet.
ACP EDIT TOURNAMENTS
- You can now add/remove the clan from ladders.
- You will now not get a blank template if the clan does not exist.
In the edit tournament/edit bracket page in the ACP, you should be able to manually add a clan who hasn't joined the tournament themselves. It would be nice to be able to force add them or pre-add them to a certain bracket (so we can force certain matchups between specific clans)
- The "calls" have been fixed... the file wasent de-modularized.
- For Auto Move-On... I can have a button in edit brackets page called "Auto Move-On" and it will move on all the clans for you when you click it. But as far as the system moving the clans on after they report automatically, no, because it creates a bunch of problems and any report conflicts cant be resolved easily.
So an admin would still have to click "auto move on" and it would move all pending winning clans forward? Why can't they move forward automatically without admin intervention (unless the admin wants to approve moves manually)? If you can figure out the report conflicts above, this should be pretty easy no? Just me wanting this to be the best it can be, and automated would make the admin's life a lot easier and the user experience much more transparent and smooth.- What do you mean by be able to change, add or remove clans from the brackets?
Like in phpBB's ACP, you can manually add or delete a user from the forum, from usergroups etc. We should be able to force-add or -remove clans from specific tournaments or matches.
GENERAL
Havent looked at much of what you posted in general, yet. I skimmed over it for now and it seems your talking about individuals... again, I have absolutely no idea how to implement this, yet, if at all, rivals is to dependent on clans to have something like this, dunno how to work around it yet.
I fully understand - it was a long post with a lot of requests
Thanks for all your work mate.
Will release fixes sometime this week.
Thanks.
EDIT: @mh0825: see docs/INSTALL in the zip file.
Some known issues that need to be fixed: Clans cant report tournaments. I need to convert it over to the new tournament system. Might be some more but I forget them... anyways, have fun and keep reporting, MANY thanks to everyone who has spent the time to find these bugs and report them.* All create clan errors are fixed.
* Misc. spelling mistakes fixed.
* Message now shows up if a ladder has no clans in it. (You wont see a blank page now! )
* PM is sent to the challengee when a challenge is issued.
* Inconsistent use of URL actions fixed.
* Reporting a win/loss in a tournament should now be fixed.
* Ladder rating is now explained in ACP.
* Admins can now add/remove a clan from ladders.
* Admins will no longer get blank pages on editing clans that dont exist!
Code: Select all
Parse error: parse error, unexpected '(', expecting ')' in /mnt/adm1/daddelgreise.de/phpBB3/rivals/acp_editclans.php on line 64
Code: Select all
[phpBB Debug] PHP Notice: in file /rivals.php on line 40: main(./rivals/ccp_clone.php) [function.main]: failed to open stream: No such file or directory
[phpBB Debug] PHP Notice: in file /rivals.php on line 40: main() [function.include]: Failed opening './rivals/ccp_clone.php' for inclusion (include_path='.;c:/php4/pear')
template->_tpl_load(): No file specified for handle body
@everyone else: The zip has been updated to remove the clan cloning thing and to fix the acp_editclans problems. Redownload and replace the files and you should be setADD:
'rivals_tickss' => '[SYSTEM] Challenge Issued by %s',
'rivals_ticksb' => 'This is an automated message from the system.
%s has issued you a challenge. Please login to your Clan CP and either accept or decline the challenge when ready.
Do not reply to this username,
Thank you.',
'rivals_nsk' => 'There are no clans currently joined with this ladder.',
'addedtoladderacp' => 'The clan has been added to the ladder.',
'removefladderacp' => 'The clan has been removed from the ladder.',
'rivals_cdneb' => 'The clan you have requested does not exist.',
'apartofladderacp' => 'The clan is already joined to the selected ladder.',
'rivals_notesub' => 'Ladder Rating is an alternative option for ranking clans in the ladder. ( wins - losses ) + 100 ... this will give a clan "rating".',
'no_platformma' => 'Sorry, you must first add a platform before you can add a ladder.',
'joemyers' => 'Tournament Reports',
'matches' => 'Matches',
REMOVE:
'tiewe' => 'Your opponent for this match reported a tie. You can not report anything but a tie, if this is wrong: please file a ticket in the Clan Control Panel.',
'losswe' => 'Your opponent for this match report a loss. You can not report a loss too. If this is wrong: please file a ticket in the Clan Control Panel.',
'winwe' => 'Your opponent for this match report a win. You can not report a win too. If this is wrong: please file a ticket in the Clan Control Panel.',
ADD:
'tiewe' => 'Your opponent reported a tie for this match. You can not report anything but a tie, if this is wrong: please file a ticket in the Clan Control Panel.',
'losswe' => 'Your opponent reported a loss for this match. You can not report a loss too. If this is wrong: please file a ticket in the Clan Control Panel.',
'winwe' => 'Your opponent reported a win for this match. You can not report a win too. If this is wrong: please file a ticket in the Clan Control Panel.',
'rivals_npm' => 'No Pending Matches',
REMOVE:
'wlwe' => 'Your opponent for this match reported a win or loss. You can not report a tie. If this is wrong: please file a ticket in the Clan Control Panel.',
ADD:
'wlwe' => 'Your opponent reported either a win or loss for this match. You can not report a tie. If this is wrong: please file a ticket in the Clan Control Panel.',
REMOVE:
'rivals_cdacc' => 'The match has been update.',
ADD:
'rivals_cdacc' => 'The match has been updated.',
Reaplce acp_editclans.php, ccp_editclans.php, class_clan.php, ccp_index.html I believe is all.Benely wrote:Is that the only thing thats been updated in the new zip, cause i've done some edits to get this Gamertag thing working and dont fancy replacing everything when i can jsut replace the one file
EDIT: When you send an invite and then when the suer clicks accept the file doesn't exsist...
Code: Select all
Fatal error: [] operator not supported for strings in /mnt/adm1/daddelgreise.de/phpBB3/rivals/classes/class_clan.php on line 69