[ABD] Profile comments/ Feedback/ Karma (1.6.6)

Any abandoned MODs will be moved to this forum.

WARNING: MODs in this forum are not currently being supported or maintained by the original MOD author. Proceed at your own risk.
Forum rules
IMPORTANT: MOD Development Forum rules

WARNING: MODs in this forum are not currently being supported nor updated by the original MOD author. Proceed at your own risk.
Locked
janmyszkier
Registered User
Posts: 294
Joined: Tue Oct 09, 2007 4:53 pm

Re: [RC2]Profile comments/ Feedback/ Karma (1.5.4)

Post by janmyszkier »

which one do you mean? profile view or viewall mode?

User avatar
muggins
Registered User
Posts: 1183
Joined: Fri Feb 22, 2008 5:12 pm
Location: Texas
Name: Donovan
Contact:

Re: [RC2]Profile comments/ Feedback/ Karma (1.5.4)

Post by muggins »

I haven't installed yet, but from your test board I think it is the profile view. I will check now and edit this post to clarify...

Edit: What do you by mean by viewall? This image is all I could see in John's profile:

Image

It would be much cleaner and blend with the board style better with the radio buttons and dialog box above the lines of comments, with the comment lines paginated.

I would attempt it myself, but as I said, I can barely read PHP and HTML, much less write it... :oops:
Muggins

janmyszkier
Registered User
Posts: 294
Joined: Tue Oct 09, 2007 4:53 pm

Re: [RC2]Profile comments/ Feedback/ Karma (1.5.4)

Post by janmyszkier »

you want me to make these boxes (divs now) the same look as post boxes?

Image

as you can see if you adjust it to the style, on of the colors is going to be invisible, so only 1/2 of the boxes are visible ;)

User avatar
muggins
Registered User
Posts: 1183
Joined: Fri Feb 22, 2008 5:12 pm
Location: Texas
Name: Donovan
Contact:

Re: [RC2]Profile comments/ Feedback/ Karma (1.5.4)

Post by muggins »

Here's a screenshot of my board:

Image

With the outside div there, the panels show up fine...

If you can get me that far, I could probably hack my way through the style details. :)
Last edited by muggins on Fri Aug 14, 2009 2:22 pm, edited 1 time in total.
Muggins

janmyszkier
Registered User
Posts: 294
Joined: Tue Oct 09, 2007 4:53 pm

Re: [RC2]Profile comments/ Feedback/ Karma (1.5.4)

Post by janmyszkier »

honestly, i don't know what you want me to do.... please clarify.

janmyszkier
Registered User
Posts: 294
Joined: Tue Oct 09, 2007 4:53 pm

Re: [RC2]Profile comments/ Feedback/ Karma (1.5.4)

Post by janmyszkier »

memberlist.php and acp_board.php install instructions were fixed to suit NON-mysql databases (sorry nonmysql users for this overlook earlier) this has been fixed so if you don't have mysql and it didn't worked for you earlier, you might want to reinstall it with the most recent package updated while ago (but still 1.5.4). Waiting for your comments on profile comments ;)

there is also a change in memberlist.php regarding the look of the comment boxes, they were changed to the look like in the post i posted earlier (rounded boxes, just like post ones) http://www.xn--roliny-owadoerne-pbd81d.pl/forum.gif

muggins: i finally read through your post ;) yes i now it's on some other background color, however, comments are already in one of these boxes, the only way would be applying the newest comment recent style, then modifying the profile_commetns.html to change background a little (by hand)

EDIT: (15:17 GMT+1) I've updated the package once again, comment_recent is no more recursive, profile_comments.html has been changed for easier outer div handling (muggins, take note of this ;) it's for you) So i advice you all to replace the memberlist.php and profile_comments.html in prosilver (subsilver not yet updated)

User avatar
muggins
Registered User
Posts: 1183
Joined: Fri Feb 22, 2008 5:12 pm
Location: Texas
Name: Donovan
Contact:

Re: [RC2]Profile comments/ Feedback/ Karma (1.5.4)

Post by muggins »

Thank you, sir! I like it! :mrgreen:
Muggins

janmyszkier
Registered User
Posts: 294
Joined: Tue Oct 09, 2007 4:53 pm

Re: [RC3]Profile comments/ Feedback/ Karma (1.6.0)

Post by janmyszkier »

there it is! 1.6.0 finally i made it through.....*sigh*

this version comes with more bugfixes (and some newbugs aswell i think :) ),
- comment appearance depeds only on template files now (PHPBB way ;) )
- language code fixes (wherever it was hard coded, it isn't now)
- some sql fixes

ok now it's time for testing! All people are welcome to test it, i hope you'll bring me all bugs you can find! After we test it, it's going to be resubmitted to the MODDB And hopefully accepted!

User avatar
muggins
Registered User
Posts: 1183
Joined: Fri Feb 22, 2008 5:12 pm
Location: Texas
Name: Donovan
Contact:

Re: [RC3]Profile comments/ Feedback/ Karma (1.6.0)

Post by muggins »

Doggone it! You're making me download it again?

Good thing I hadn't had time to install 1.5.4... :mrgreen:

It will be tested this week on my live board. That's why I have pestered you so, and thanks again! :D
Muggins

janmyszkier
Registered User
Posts: 294
Joined: Tue Oct 09, 2007 4:53 pm

Re: [RC3]Profile comments/ Feedback/ Karma (1.6.1)

Post by janmyszkier »

thanks to kevinroxxx we have some bugs found and fixed!

- language issue ('COMMENT_EMAIL_SUBJECT', name changed now to working)
- comment count issue (new Comments were badly counted, now fixed)
- profile comments remove has a bad character in it, now changed
- some sql querys fixed and results are freed
- profile link in viewall mode fixed
- some conditions fixed, (like the one that let users delete own comments if turned on in ACP)

well, that's all I remember! i guess there were some more of them ;)
files touched by this:
memberlist.php
includes/functions.php

so if you want to update 160->161 just apply instructions for these files and reupload the files given within the package----remember to purge your cache!

ah .. also... subsilver2 not yet finished, will be added in around 24 hours. (version won't be changed, i will just reupload the package and let you know, version will change if new bugs are found ;) )

User avatar
muggins
Registered User
Posts: 1183
Joined: Fri Feb 22, 2008 5:12 pm
Location: Texas
Name: Donovan
Contact:

Re: [RC3]Profile comments/ Feedback/ Karma (1.6.1)

Post by muggins »

Crazy, man! :ugeek: I will wait a day or two to install...

Thanks again!
Muggins

User avatar
muggins
Registered User
Posts: 1183
Joined: Fri Feb 22, 2008 5:12 pm
Location: Texas
Name: Donovan
Contact:

Re: [RC3]Profile comments/ Feedback/ Karma (1.6.1)

Post by muggins »

Jan, you rock!

I haven't made a list of issues yet. I'm going through some online testing now. I have some small changes that I made, but the notification email still has something wrong, I think. I will have to verify whether it was a bad edit on my part, or interference with some of my kludged-up previous changes to other things...

In all, it seems very close!

Edit: Avatar resizing is problematic, somehow. One of my users sent me a comment, and her avatar is linked off-site. It is very large in one view. Here are screenshots:

Image

Image
Muggins

kevinroxx
Registered User
Posts: 94
Joined: Fri Dec 14, 2007 9:57 pm

Re: [RC3]Profile comments/ Feedback/ Karma (1.6.1)

Post by kevinroxx »

That is strange why it isn't resizing. Works fine for me.

What I decided to do though was delete the avatar in memberlist and keep the avatar in the view all area.

To do this open memberlist.php and Find:
$avatar = get_user_avatar($row_av['user_avatar'], $row_av['user_avatar_type'], '45%','45%' );

Replace With:
//$avatar = get_user_avatar($row_av['user_avatar'], $row_av['user_avatar_type'], '45%','45%' );

Thanks for the help their jan ;)

Muggins, what browser are you using and what are the dimensions of the avatar?

User avatar
muggins
Registered User
Posts: 1183
Joined: Fri Feb 22, 2008 5:12 pm
Location: Texas
Name: Donovan
Contact:

Re: [RC3]Profile comments/ Feedback/ Karma (1.6.1)

Post by muggins »

FF3, and the image is 600x605 px. It is obviously resized some... :)

Edit: I just re-read your post. I suppose instead of specifying the percentage, I could set the size absolutely? Or will that just crop the image?

I'll play with it. I'm not a programmer, so if you hear screams.... :D
Muggins

User avatar
muggins
Registered User
Posts: 1183
Joined: Fri Feb 22, 2008 5:12 pm
Location: Texas
Name: Donovan
Contact:

Re: [RC3]Profile comments/ Feedback/ Karma (1.6.1)

Post by muggins »

That did the trick! instead of '45%', change it to '45px', or whatever size floats your boat... :mrgreen:

Edit: I'm working on some changes in profile_comments.html. Mostly the addition of <br /> and &nbsp; tags, but I changed the column widths to 70% and 30%, respectively.

How can I make the textarea a bit wider? Here's a screenshot:

Image
Muggins

Locked

Return to “[3.0.x] Abandoned MODs”