[ABD] Forum Favorites 1.0.5

Any abandoned MODs will be moved to this forum.

WARNING: MODs in this forum are not currently being supported or maintained by the original MOD author. Proceed at your own risk.
Forum rules
IMPORTANT: MOD Development Forum rules

WARNING: MODs in this forum are not currently being supported nor updated by the original MOD author. Proceed at your own risk.
User avatar
Typo
Former Team Member
Posts: 404
Joined: Tue Dec 30, 2008 6:12 am
Location: USA
Name: Jeremy Lorenzo
Contact:

Re: [RC] Forum Favorites 1.0.4

Post by Typo » Sun Feb 22, 2009 3:37 pm

Ok, I am on two different pc's.

PC 1 = IE 7 (6.0.2900.3180)
PC 2 = IE 7 (7.0.5730.13)

Not sure why the first one says IE 7 and yet shows 6.0 but hey that's Microsoft for ya, all I know is the big blue number next to Internet Explorer is 7 and yet the numbers in parentheses next to it is 6.0.

I have this forum set to notify me when a reply is posted and I will be around all day so if you need help with testing just let me know.

I will set my PM's notify on as well so you can PM if you wish.

Thanks for your prompt replies.

Typo

User avatar
Typo
Former Team Member
Posts: 404
Joined: Tue Dec 30, 2008 6:12 am
Location: USA
Name: Jeremy Lorenzo
Contact:

Re: [RC] Forum Favorites 1.0.4

Post by Typo » Sun Feb 22, 2009 8:02 pm

I just noticed while looking in the ucp_favorites_view_list.html that it looks like there is supposed to be imags showing next to the words "Add" and "View List". As you can see in the screenshot provided above, there is no images showing in FireFox where we can actually see the links.

This made me wonder so I looked at the source.

Code: Select all

	<tr class="bg1">

			<td>
						&nbsp;Into the mystic    van morrison						</td>
			<td></td>
			<td style="width: 60px; text-align: right; white-space: nowrap;">
            <form id="item_2" method="post" action="./ucp.php?i=favorites&mode=view_list&catid=1"  style="margin: 0 ; padding: 0; display: inline;">
            <button type="submit" name="add_item" value="add" style="border: 0; background-color: transparent"><img alt="Add" title="Add this favorite to your list" src="" /></button> 
            <input type="hidden" name="text" value="Into the mystic    van morrison" /><input type="hidden" name="url" value="" /><span style="display:none"></form></span>
            <form id="item_2" method="post" action="./ucp.php?i=favorites&mode=view_list&catid=1"  style="margin: 0 ; padding: 0; display: inline;">
            <button type="submit"  name="view_users" value="view" style="border: 0; background-color: transparent"><img alt="View users" title="View users with this favorite" src=""></button>

            <input type="hidden" name="text" value="Into the mystic    van morrison" />
            </form></td>	</tr>
	</tbody>
Notice the src="" and the value="" .

I looked in the code in ucp_favorites_view_list.html and those are supposed to have been filled with {fav_list.URL} and {IMG_ADD_BUTTON} or {IMG_SEARCH_BUTTON}.

Hope this helps.

Typo
Last edited by Typo on Sun Feb 22, 2009 8:14 pm, edited 1 time in total.

User avatar
Agrajag
Registered User
Posts: 124
Joined: Sun Jan 13, 2008 12:39 am

Re: [RC] Forum Favorites 1.0.4

Post by Agrajag » Sun Feb 22, 2009 8:04 pm

You probably haven't updated your imageset cache properly. After making the edits to imageset.cfg, you need to refresh the cache (instructions are at the bottom of the xml file, copied below).
Click on the Styles tab in the ACP. Then choose Imagesets on the left bar, and click on the Refresh action for each style you have installed the mod icons for.
It's actually not working in Firefox either, it's supposed to show images in both. But Firefox shows the alt text if the images fail to load, whereas IE just shows nothing because it's a piece of garbage :?

User avatar
Typo
Former Team Member
Posts: 404
Joined: Tue Dec 30, 2008 6:12 am
Location: USA
Name: Jeremy Lorenzo
Contact:

Re: [RC] Forum Favorites 1.0.4

Post by Typo » Sun Feb 22, 2009 8:28 pm

Ok, that was odd, I know for sure I had refreshed that yesterday but refreshing it did indeed restore the images in FireFox.

The words "Add" and "View Image" were replaced by images.

In IE there is still nothing, no image or words.

Here is the new source, the missing source"" 's are now fixed thanks to cache refresh but the missing value"" is still there.

Code: Select all

	<tr class="bg1">
			<td>
						&nbsp;Into the mystic    van morrison						</td>
			<td></td>
			<td style="width: 60px; text-align: right; white-space: nowrap;">
            <form id="item_2" method="post" action="./ucp.php?i=favorites&mode=view_list&catid=1"  style="margin: 0 ; padding: 0; display: inline;">
            <button type="submit" name="add_item" value="add" style="border: 0; background-color: transparent"><img alt="Add" title="Add this favorite to your list" src="./styles/prosilver/imageset/icon_ffavorites_add.gif" /></button> 
            <input type="hidden" name="text" value="Into the mystic    van morrison" /><input type="hidden" name="url" value="" /><span style="display:none"></form></span>
            <form id="item_2" method="post" action="./ucp.php?i=favorites&mode=view_list&catid=1"  style="margin: 0 ; padding: 0; display: inline;">
            <button type="submit"  name="view_users" value="view" style="border: 0; background-color: transparent"><img alt="View users" title="View users with this favorite" src="./styles/prosilver/imageset/icon_ffavorites_search.gif"></button>
            <input type="hidden" name="text" value="Into the mystic    van morrison" />
            </form></td>	</tr>
	</tbody>
I still find it very odd that I refreshed the image cache yesterday and yet it needed it again but was really bummed when it didn't help the IE problem.

I re refreshed the theme, template and main cache as well to be tripple sure.

Typo

User avatar
Typo
Former Team Member
Posts: 404
Joined: Tue Dec 30, 2008 6:12 am
Location: USA
Name: Jeremy Lorenzo
Contact:

Re: [RC] Forum Favorites 1.0.4

Post by Typo » Mon Feb 23, 2009 1:44 am

In case it can help, I thought I would include a screenshot of the page loaded in IE.

Aside from the missing words/pictures, notice how the second column has darker borders, I assumed this was due to the same error but thought it was worth mentioning.
Image
Still hoping you can help.

Typo

User avatar
Agrajag
Registered User
Posts: 124
Joined: Sun Jan 13, 2008 12:39 am

Re: [RC] Forum Favorites 1.0.4

Post by Agrajag » Mon Feb 23, 2009 2:34 am

The dark border thing is some other IE error I can't quite figure out, it's not related. Unfortunately I didn't get a chance to do any testing today, and I'm pretty busy this whole week. I'll look into it some more as soon as I get free time.

Has anyone else been having trouble viewing things in IE? It would be helpful to know if it's a global issue with the mod, or if it's just something wrong with Typos setup.

User avatar
Typo
Former Team Member
Posts: 404
Joined: Tue Dec 30, 2008 6:12 am
Location: USA
Name: Jeremy Lorenzo
Contact:

Re: [RC] Forum Favorites 1.0.4

Post by Typo » Mon Feb 23, 2009 7:11 am

I am very sad to hear I can count on a wait of at least a week for help on fixing this, I am left to try and fix it myself or with the help of other users. I know life gets busy but you shouldn't have told me you needed info immediately so you can work on it today if I am going to be left waiting a week or more for your help looking into this issue. I feel as if I have now wasted a whole day waiting for you when I should apparently have been working on the issue myself or asking for help elsewhere.

Hoping you find some free time.

Typo

User avatar
Agrajag
Registered User
Posts: 124
Joined: Sun Jan 13, 2008 12:39 am

Re: [RC] Forum Favorites 1.0.4

Post by Agrajag » Mon Feb 23, 2009 11:15 am

Sorry, but this isn't a real priority for me. I'm happy to help when I can, but this is mod is just a little side project I wrote up on the side in my spare time. I have an actual paying job and other real life responsibilities that are slightly more important. And don't blame me for "wasting" your day, if it was that important to you to get it fixed immediately you could have been looking into it more yourself the whole day. If you can figure it out on your own, then great. If you fix it, come back and post what you did in case other users are experiencing similar problems.

User avatar
Typo
Former Team Member
Posts: 404
Joined: Tue Dec 30, 2008 6:12 am
Location: USA
Name: Jeremy Lorenzo
Contact:

Re: [RC] Forum Favorites 1.0.4

Post by Typo » Mon Feb 23, 2009 3:21 pm

I did start to look at it earlier but its a bit beyond my scope so I figured I would leave it to the experts

I would definitely post anything I find but I've been messing with it for a while now and I'm drawing a blank.

Typo

User avatar
Typo
Former Team Member
Posts: 404
Joined: Tue Dec 30, 2008 6:12 am
Location: USA
Name: Jeremy Lorenzo
Contact:

Re: [RC] Forum Favorites 1.0.4

Post by Typo » Wed Feb 25, 2009 5:16 am

Ok, I almost have it. The images are now visible in both browsers and completely functional. The only problem I am having now is in IE the images are stacking one on the other and in FireFox, everything is perfect.

I'm trying to get it to unstack in IE but at least now I have the buttons both working and visible as image in both browsers.

I'll keep at it and reply here with my current code if I cant get rid of the stacking or the code I come up with if I can.

Typo

User avatar
Typo
Former Team Member
Posts: 404
Joined: Tue Dec 30, 2008 6:12 am
Location: USA
Name: Jeremy Lorenzo
Contact:

Re: [RC] Forum Favorites 1.0.4

Post by Typo » Thu Feb 26, 2009 2:18 am

I have fixed both of the problems. The images are no longer stacking and are visible and usable in both IE and FireFox and I fixed the dark borders in the URL column.

The image issue I was able to fix by using an <image type=image.... /> instad of your <img-.... /> in between the <button.....> and </button> tags and adding another <input type=hidden.... /> to pass the info on that <button></button> was formerly passing. I fixed the images stacking finally by adding" white-space: nowrap;" to the style attribute inside the <form...></form> tags.

The darker borders in the favorite url column I solved by putting in a hard space (&nbsp;) inside the <td></td> for that section when there is no url present so that the column would technically never be "empty" and it solved it. I put it in an else statement so that its not added to a url if one is present.

I also made another small change to mine. I added a legend below the table.

To add the legend simply add the following code:
FIND:

Code: Select all

</div>

<!-- INCLUDE jumpbox.html -->
REPLACE WITH:

Code: Select all

</div>
<center><img alt="{L_FAVORITES_ADD_ALT}" title="{L_FAVORITES_ADD_TITLE}" src="{IMG_ADD_BUTTON}" /><strong>Add this item to your favorites.	</strong><img alt="{L_FAVORITES_VIEW_ALT}" title="{L_FAVORITES_VIEW_TITLE}" src="{IMG_SEARCH_BUTTON}"><strong>View the names of everyone with this item added.</strong></center>
<!-- INCLUDE jumpbox.html -->
Here is a screenshot from IE with the code I am currently using.
Image
And here is the updated code I came up with for the fixes. This is everything between and including
<!-- BEGIN fav_list -->
and
<!-- END fav_list -->
inside the file
/root/styles/prosilver/template/ucp_favorites_view_list.html

Code: Select all

<!-- BEGIN fav_list -->
	<tr class="<!-- IF fav_list.S_ROW_COUNT is even -->bg1<!-- ELSE -->bg2<!-- ENDIF -->">
			<td>
			<!-- IF S_BUTTON_BEFORE -->
            <form id="item_{fav_list.S_ROW_COUNT}" method="post" action="{S_UCP_ACTION}&catid={CURRENT_CAT}"  style="margin: 0 ; padding: 0; display: inline; white-space: nowrap;">
            <input type="image" src="{IMG_ADD_BUTTON}" border="0" alt="{L_FAVORITES_ADD_ALT}" />
            <input type="hidden" name="text" value="{fav_list.TEXT}" /><input type="hidden" name="url" value="{fav_list.URL}" /><input type="hidden" name="add_item" value="add" /><span style="display:none"></form></span>
            <form id="item_{fav_list.S_ROW_COUNT}" method="post" action="{S_UCP_ACTION}&catid={CURRENT_CAT}"  style="margin: 0; padding: 0; display: inline; white-space: nowrap;">
            <input type="image" src="{IMG_SEARCH_BUTTON}" border="0" alt="{L_FAVORITES_VIEW_ALT}" />
            <input type="hidden" name="text" value="{fav_list.TEXT}" /><input type="hidden" name="view_users" value="view" /></form>
            <!-- ENDIF -->
			&nbsp;{fav_list.TEXT}
			<!-- IF S_BUTTON_AFTER -->&nbsp;
            <form id="item_{fav_list.S_ROW_COUNT}" method="post" action="{S_UCP_ACTION}&catid={CURRENT_CAT}"  style="margin: 0 ; padding: 0; display: inline; white-space: nowrap;">
            <input type="image" src="{IMG_ADD_BUTTON}" border="0" alt="{L_FAVORITES_ADD_ALT}" />
            <input type="hidden" name="text" value="{fav_list.TEXT}" /><input type="hidden" name="url" value="{fav_list.URL}" /><input type="hidden" name="add_item" value="add" /><span style="display:none"></form></span>
            <form id="item_{fav_list.S_ROW_COUNT}" method="post" action="{S_UCP_ACTION}&catid={CURRENT_CAT}"  style="margin: 0; padding: 0; display: inline; white-space: nowrap;">
            <input type="image" src="{IMG_SEARCH_BUTTON}" border="0" alt="{L_FAVORITES_VIEW_ALT}" />
            <input type="hidden" name="text" value="{fav_list.TEXT}" /><input type="hidden" name="view_users" value="view" /></form>
            <!-- ENDIF -->
			</td>
			<td><!-- IF fav_list.URL --><a href="{fav_list.URL}">{fav_list.URL}</a><!-- ELSE -->&nbsp;<!-- ENDIF --></td>
			<!-- IF S_BUTTON_COL--><td style="width: 60px; text-align: center; white-space: nowrap;">
            <form id="item_{fav_list.S_ROW_COUNT}" method="post" action="{S_UCP_ACTION}&catid={CURRENT_CAT}"  style="margin: 0 ; padding: 0; display: inline; white-space: nowrap;">
            <input type="image" src="{IMG_ADD_BUTTON}" border="0" alt="{L_FAVORITES_ADD_ALT}" />
            <input type="hidden" name="text" value="{fav_list.TEXT}" /><input type="hidden" name="url" value="{fav_list.URL}" /><input type="hidden" name="add_item" value="add" /><span style="display:none"></form></span>
            <form id="item_{fav_list.S_ROW_COUNT}" method="post" action="{S_UCP_ACTION}&catid={CURRENT_CAT}"  style="margin: 0; padding: 0; display: inline; white-space: nowrap;">
            <input type="image" src="{IMG_SEARCH_BUTTON}" border="0" alt="{L_FAVORITES_VIEW_ALT}" />
            <input type="hidden" name="text" value="{fav_list.TEXT}" /><input type="hidden" name="view_users" value="view" /></form>
            </td><!-- ENDIF -->
	</tr>
<!-- END fav_list -->
On a different note.

I would love the fix to stop the php error log from filling up with errors when you get it done. I have debugging disabled but I use a mod that "Logs phpBB Errors and Warnings in a Custom Error Log, so you can turn off the DEBUG/DEBUG EXTRA for your users and find all errors in the error log." and your mod is currently filling it up with errors. I know you are aware of this and currently fixing it but figured I would offer my help if you need someone to do some testing or anything else I can do for you to help this mod along.

One feature suggestion I do have is to make the page title so it says "Favorites" or something like that instead of "User control panel".

Thanks again for a great mod and I hope all this ends up being of use to someone.

Typo

User avatar
Agrajag
Registered User
Posts: 124
Joined: Sun Jan 13, 2008 12:39 am

Re: [RC] Forum Favorites 1.0.4

Post by Agrajag » Thu Feb 26, 2009 3:58 am

Hmm, I was never able to actually get the buttons to be functional in all browsers when using an <image> button instead of a <button> button, which is why I switched to using <button> in the first place. But if you got it working somehow, that's awesome.

I don't think I can change the page title because the page is actually a UCP module and not a standalone page (I did this to simplify development and installation). I'll see if maybe I can override the title somehow though.

If you have a log of all the places where debug errors pop up, that would be super helpful. If you want to PM that to me I can go through and fix them (it's mostly just un-initialized variables I believe, shouldn't be a hard fix).

Thanks a ton. I'm really sorry I couldn't fix this for you myself, I just have no time to work on this sort of thing currently.

Fridge
Registered User
Posts: 307
Joined: Sat Nov 11, 2006 1:41 am
Location: Rotterdam, The Netherlands
Name: Martin
Contact:

Re: [RC] Forum Favorites 1.0.4

Post by Fridge » Thu Feb 26, 2009 8:56 am

Typos wrote:I also made another small change to mine. I added a legend below the table.

To add the legend simply add the following code:
FIND:

Code: Select all

</div>

<!-- INCLUDE jumpbox.html -->
REPLACE WITH:

Code: Select all

</div>
<center><img alt="{L_FAVORITES_ADD_ALT}" title="{L_FAVORITES_ADD_TITLE}" src="{IMG_ADD_BUTTON}" /><strong>Add this item to your favorites.	</strong><img alt="{L_FAVORITES_VIEW_ALT}" title="{L_FAVORITES_VIEW_TITLE}" src="{IMG_SEARCH_BUTTON}"><strong>View the names of everyone with this item added.</strong></center>
<!-- INCLUDE jumpbox.html -->
I use this...

Code: Select all

</div>
<div align="center"><span><img src="{IMG_ADD_BUTTON}" /> {L_FAVORITES_ADD_TITLE}   <img src="{IMG_SEARCH_BUTTON}"> {L_FAVORITES_VIEW_TITLE}</span>
<br />
<!-- INCLUDE jumpbox.html -->
;)

superj707
Registered User
Posts: 1136
Joined: Thu Feb 26, 2009 12:20 am

Re: [RC] Forum Favorites 1.0.4

Post by superj707 » Fri Apr 10, 2009 6:52 pm

this is a cool mod

User avatar
Agrajag
Registered User
Posts: 124
Joined: Sun Jan 13, 2008 12:39 am

Re: [RC] Forum Favorites 1.0.4

Post by Agrajag » Sat Apr 11, 2009 1:45 am

Thanks! Unfortunately I really don't have much time to work on it anymore. I'll get it into modDB eventually though.

Would anyone else out there who is using the mod be interested in helping with development? I've been considering throwing it up on github and letting other people contribute code and improvements since I don't really have enough free time to seriously work on it (and certainly not enough time to add all the great features that have been suggested).

Locked

Return to “[3.0.x] Abandoned MODs”