I've been using
Code: Select all
Why did you post here then if you already knew there was a consensus? Why post a feature request that you had no intention to support? Looks to me like you asked for a free lunch and you got most of it. Now that you got what you wanted and have nothing to gain, you're leaving. Nothing of value was lost and you'll be back in a few months to complain that phpBB development is stale.mamba wrote: ↑Sat Jul 14, 2018 2:48 amSorry but the consensus over time seems to be that the censor is just hunky dory and working as planned, so if that's true and the "400,000 members here or the tens of thousands of other phpBB users" (see above) are perfectly happy with it, I'll look after my own needs and leave it be. It takes me a few seconds to alter renderer.php, versus a big hassle, lost time ($) and potentially some ridicule and abuse via the PR system. So no. Bye
Only your time is apparently precious, that of the people who made you achieve your final goal is not instead. Not to mention all those who voluntarily offer their free collaboration to this project. Please note that this is a note based on what you post, it is not very difficult to do what you do not want to do for reasons that I think are quite futile, at least interested. Amen.
I learned that there is some sort of (IMO cockeyed) consensus in this thread. Isn't that obvious?
I've started 2 threads on this topic, collated bug reports ... isn't that enough effort? You want more? Must I write the code changes too?Why post a feature request that you had no intention to support?
Wow. This is exactly why I won't take this to a pull request, because there are always characters who love to snipe.Looks to me like you asked for a free lunch and you got most of it.
In that file the use ofToxyy wrote: ↑Sat Jul 14, 2018 5:46 pmI've been usingto get config values set by the acp, if that helps you.
Code: Select all
$config['your_new_config']will do if correctly configured in that function like https://github.com/phpbb/phpbb/blob/508 ... r.php#L153
$html = $this->censor->censorHtml($html, $config['your_new_config']);
2 thumbs-up / 0 thumbs-down, I wouldn't go ahead in this case making a PR.
Yes. Linking to bug reports posted 10 years ago doesn't help much to be honest. It's like having a flat tyre and collecting the phone numbers of other people who have experienced a flat tyre. Somebody has to change the tyre and nobody here is getting paid for it. Who do you think should write this code?
Nah, I think you won't make a pull request because you have no intention of making any effort to create something. It's easier to complain and stomp out of the room. Now you're at an impasse because the only way to prove it wrong is to actually create that pull request.
Users browsing this forum: No registered users and 3 guests