Posts waiting for approval should be visible to the authors

https://www.phpbb.com/ideas/
Ideas Bot
Registered User
Posts: 291
Joined: Sat Oct 13, 2012 10:06 am

Posts waiting for approval should be visible to the authors

Post by Ideas Bot » Sat Jul 13, 2013 5:55 pm

This would help reduce the number of times people don't read the message and just resubmit their post a few times.

User avatar
nickvergessen
Former Team Member
Posts: 4397
Joined: Mon Apr 30, 2007 5:33 pm
Location: Stuttgart, Germany
Name: Joas Schilling
Contact:

Re: Posts waiting for approval should be visible to the auth

Post by nickvergessen » Sat Jul 13, 2013 7:21 pm

I tried to implement that while creating softdelete.
The problem is, it makes the queries way more complex and heavier.
The query run time for the most important queries increase by factor 10.

Also for guests it's almost impossible, because we don't have any comparison base, which is why we don't allow delete/edit for guests
No Support via PM

User avatar
noth
Registered User
Posts: 2431
Joined: Fri Jan 07, 2005 7:10 pm
Location: North Surrey
Contact:

Re: Posts waiting for approval should be visible to the auth

Post by noth » Sat Jul 13, 2013 7:40 pm

great explanation by NickV

and some good initial ideas by callum, at least callum is coming up with things! :D

User avatar
Crizzo
Translations & International Support Teams Manager
Translations & International Support Teams Manager
Posts: 617
Joined: Thu Apr 23, 2009 1:20 pm
Location: Germany
Name: Christian
Contact:

Re: Posts waiting for approval should be visible to the auth

Post by Crizzo » Sat Jul 13, 2013 8:15 pm

nickvergessen wrote:I tried to implement that while creating softdelete.
The problem is, it makes the queries way more complex and heavier.
The query run time for the most important queries increase by factor 10.
Will this have an great effect on the performance of phpBB?
Also for guests it's almost impossible, because we don't have any comparison base, which is why we don't allow delete/edit for guests
You can create this feature only for registered users. That might be a comfort function to the user, who has created a account. ;)

User avatar
nickvergessen
Former Team Member
Posts: 4397
Joined: Mon Apr 30, 2007 5:33 pm
Location: Stuttgart, Germany
Name: Joas Schilling
Contact:

Re: Posts waiting for approval should be visible to the auth

Post by nickvergessen » Sat Jul 13, 2013 8:26 pm

Crizzo wrote:
nickvergessen wrote:I tried to implement that while creating softdelete.
The problem is, it makes the queries way more complex and heavier.
The query run time for the most important queries increase by factor 10.
Will this have an great effect on the performance of phpBB?
On my test back then when implementing the basic of softdelete it doubled the loading time of viewforum in the end.
No Support via PM

User avatar
naderman
Consultant
Consultant
Posts: 3734
Joined: Fri Aug 01, 2003 10:06 pm
Location: Berlin, Germany
Name: Nils Adermann
Contact:

Re: Posts waiting for approval should be visible to the auth

Post by naderman » Sat Jul 13, 2013 9:16 pm

This should be easy to make a lot faster by caching a counter of unapproved posts/topics per forum/topic in the user table (like user_permissions) and only running additional queries to retrieve these topics (rather than modifying any existing queries) if the user actually has any unapproved topics/posts in the forum/topic she is in.
I appreciate gifts from my Amazon wishlist.
naderman.de twitter: @naderman

User avatar
brunoais
QA Team
Posts: 378
Joined: Wed Jun 18, 2008 10:50 am

Re: Posts waiting for approval should be visible to the auth

Post by brunoais » Sun Jul 14, 2013 8:21 am

1 thing (a bit tecnical but I think it makes sense).
Why not use carefully crafted foreign keys?
AFAIK phpbb does not have foreign keys. At least, I don't have them in my DB when I last installed it 3 months ago.

Hardolaf
Google Summer of Code Student
Posts: 10
Joined: Sat Mar 31, 2012 11:01 pm
Name: Joseph Warner

Re: Posts waiting for approval should be visible to the auth

Post by Hardolaf » Sun Jul 14, 2013 5:35 pm

phpBB does not use foreign keys as of the time of this post.

PardyCo
Registered User
Posts: 11
Joined: Thu Jul 11, 2013 12:26 pm

Re: Posts waiting for approval should be visible to the auth

Post by PardyCo » Tue Aug 06, 2013 4:46 pm

Kinda useless :/
WebGuruBB - Leading Webmasters to Online Greatness!
Chat Forum - Off Topicz: A place to come get off | 2.1 million post forum.

User avatar
callumacrae
Infrastructure Team Member
Infrastructure Team Member
Posts: 2662
Joined: Tue Feb 12, 2008 12:28 pm
Location: London, UK
Name: Callum Macrae
Contact:

Re: Posts waiting for approval should be visible to the auth

Post by callumacrae » Wed Aug 07, 2013 1:33 pm

PardyCo wrote:Kinda useless :/
How? Have you not ran a board where people submit something multiple times because they do not realise that their post is in the moderation queue?
macr.ae = my website. you probably won't like it.
Proud user ofProud user of

victor114
Registered User
Posts: 30
Joined: Wed Aug 07, 2013 2:35 am

Re: Posts waiting for approval should be visible to the auth

Post by victor114 » Thu Aug 08, 2013 2:45 am

Doesn't very necessity, but is a good idea for profissionalize the next version of phpbb !
+1

User avatar
peopleopinion
Registered User
Posts: 372
Joined: Thu Nov 07, 2013 7:12 pm
Contact:

Re: Posts waiting for approval should be visible to the auth

Post by peopleopinion » Sat Nov 09, 2013 8:44 pm

callumacrae wrote:
PardyCo wrote:Kinda useless :/
How? Have you not ran a board where people submit something multiple times because they do not realise that their post is in the moderation queue?

I agree with this idea: I have the identical problem in my phpbb forum. And I'm pretty sure that it can be solved if a user can see his own messages while waiting for moderation with the note "This post is waiting for moderation.".

So user can be more patient and wait without flooding the forum because their post is not publicated immediately.

The callumacrae's idea is better than showing the message in a separate page.
Also For the same reason I think that this solution is good for anonymous / unregistered / guest users too.
Please explicate why you voted negative or positive, so it will be possible to better understand each one's point of view.
Please visit and vote my website and express freely your opinion on it (phpbb ver.: 3.0.12):
http://peopleopinion.altervista.org
Thanks. Best Regards, peopleopinion.

User avatar
Zaishen
Registered User
Posts: 189
Joined: Sat Dec 18, 2010 6:08 am

Re: Posts waiting for approval should be visible to the auth

Post by Zaishen » Thu Mar 13, 2014 7:16 am

I agree with this idea

User avatar
peopleopinion
Registered User
Posts: 372
Joined: Thu Nov 07, 2013 7:12 pm
Contact:

Re: Posts waiting for approval should be visible to the auth

Post by peopleopinion » Mon Mar 24, 2014 12:47 pm

... also this feature will prevent the need of users to write to Admins or Mods things like:
I have written twice a message but it is not publicated. Is the web site working?
If there will be the possibility for authors to modify their messages while waiting for moderation it will be a further positive thing: in fact IMHO visibility and modifiability of waiting posts are part of the same aspect.
Please explicate why you voted negative or positive, so it will be possible to better understand each one's point of view.
Please visit and vote my website and express freely your opinion on it (phpbb ver.: 3.0.12):
http://peopleopinion.altervista.org
Thanks. Best Regards, peopleopinion.

User avatar
Big Mac
Registered User
Posts: 29
Joined: Sun May 27, 2012 11:31 am
Location: London, UK
Name: David Shepheard
Contact:

Re: Posts waiting for approval should be visible to the auth

Post by Big Mac » Mon May 05, 2014 4:11 pm

peopleopinion wrote:... also this feature will prevent the need of users to write to Admins or Mods things like:
I have written twice a message but it is not publicated. Is the web site working?
If there will be the possibility for authors to modify their messages while waiting for moderation it will be a further positive thing: in fact IMHO visibility and modifiability of waiting posts are part of the same aspect.
This would be most useful. Don't just make it visible. Make it editable too.

It only needs to work for people who are logged in and who do not have the right to post without going into the moderation queue. If other users are pre-approved, they should skip past the invisible messages. And moderators should see them, just like the authors waiting for approval would. I guess that means you almost need to give the moderated user the same sort of access (to their own post only) as a moderator.
David "Big Mac" Shepheard

Post Reply

Return to “phpBB Ideas”

Who is online

Users browsing this forum: No registered users and 3 guests

cron