Page 2 of 2

Re: Posts waiting for approval should be visible to the auth

Posted: Sun May 11, 2014 7:09 pm
by Master_Cylinder
Big Mac wrote:Don't just make it visible. Make it editable too.
I don't want them editing a post in the moderation queue. I don't even want them to see it, personally. If implemented I hope it's permission based, not default.

Re: Posts waiting for approval should be visible to the auth

Posted: Fri Aug 29, 2014 2:32 am
by peopleopinion
Master_Cylinder wrote:
Big Mac wrote:Don't just make it visible. Make it editable too.
I don't want them editing a post in the moderation queue. I don't even want them to see it, personally. If implemented I hope it's permission based, not default.

Permission based is the right direction imho too.

Re: Posts waiting for approval should be visible to the authors

Posted: Thu Oct 01, 2015 4:11 am
by peopleopinion
nickvergessen wrote:I tried to implement that while creating softdelete.
The problem is, it makes the queries way more complex and heavier.
The query run time for the most important queries increase by factor 10.
:idea: For the problem of the slowness of queries, is the following idea helpful for keeping queries quick and easier to maintain? (hope I didn't made any mistake):
  1. Now we have a table where all posts are stored. Let's call this table PostPubTab (just for explicating this idea!)
  2. Add a second table into DB to host posts waiting for approval. Let's call it PostToModTab
  3. This second table is perfectly equal to the first one: PostToModTab = PostPubTab
  4. When the post is published, a query (qWrite) stores it into PostPubTab
  5. When the post needs moderation the same query (qWrite) changes its destination and stores the post into PostToModTab. The post isn't public yet but the author will be able to access it for further editing, until the browser is open or until it has stored in its local cache the right cookie that refs to that specific post. (instead the cookie is possibile to do this using the IP of the user, until the IP doesn't change, the user will be able to access to all posts (s)he made, but only for a certain time, let's say h hours). It is possible to add into ACP a field to allow admins to customize this value
  6. During such time (h hours) the post is not visible for moderation, or it is visible but not "moderable"
  7. When the post is moderated (not before h hours) and approved, a query (qRead) reads the post data and passes it to the query (qWrite) that inserts everything needed into the PostPubTab. The post is now public.
  8. Another query (qDel) deletes the same row from PostToModTab, the table is updated accordingly

Re: Posts waiting for approval should be visible to the authors

Posted: Sat Sep 16, 2017 7:48 am
by John connor
I don't understand this. I have set that the Newly Registered user be placed in moderation que for a first post. After that first post is approved he/she is free to post at will. I do know for a fact with my test accounts a message is given to the new user saying their post needs to be approved.

Am I missing something here from this idea that's been submitted?

Re: Posts waiting for approval should be visible to the authors

Posted: Sat Sep 16, 2017 10:05 am
by canonknipser
The newly registered user gets the message the post he just made needs to be approved by a moderator, but has never a chance to see his post until it is approved. So it is vanished for him.
When people are to slow in reading or just missed that messages, some of them post the same message a second time because they believe it wasn't send the first time, which happens two or three times a week at our german support board.

Re: Posts waiting for approval should be visible to the authors

Posted: Sat Sep 16, 2017 10:26 am
by JimA
canonknipser wrote:
Sat Sep 16, 2017 10:05 am
When people are to slow in reading or just missed that messages, some of them post the same message a second time because they believe it wasn't send the first time, which happens two or three times a week at our german support board.
This happens quite a lot on here as well, so I'd definitely appreciate such a feature.

Re: Posts waiting for approval should be visible to the authors

Posted: Thu Oct 05, 2017 3:45 pm
by Sophist-UK
To add a further explanation of why the message needs to be visible and editable (if acl allows)...

My role playing board needs new users to post a moderated introduction to their character.

In some cases, the post needs an iterative approach to get it to the required standard before approval, with moderators making comments and users editing it until both are happy where upon the moderator approves it.

At the present time there is no way to achieve this since unapproved posts are invisible to the authors.

Re: Posts waiting for approval should be visible to the auth

Posted: Thu Oct 05, 2017 3:49 pm
by Sophist-UK
nickvergessen wrote:
Sat Jul 13, 2013 7:21 pm
I tried to implement that while creating softdelete.
The problem is, it makes the queries way more complex and heavier.
The query run time for the most important queries increase by factor 10.
@NickV Any chance you could explain why it makes it a lot slower e.g. by providing before and after examples of the SQL generated?

Re: Posts waiting for approval should be visible to the auth

Posted: Wed Jan 03, 2018 4:37 am
by steve1200
nickvergessen wrote:
Sat Jul 13, 2013 8:26 pm
Crizzo wrote:
nickvergessen wrote:I tried to implement that while creating softdelete.
The problem is, it makes the queries way more complex and heavier.
The query run time for the most important queries increase by factor 10.
Will this have an great effect on the performance of phpBB?
On my test back then when implementing the basic of softdelete it doubled the loading time of viewforum in the end.
I don't like processes that slow things down and I know enough about programming to be dangerous. This is a complicated issue especially if guests can post. Running a query is tedious because changing the title or post a bit makes it more difficult to detect, so I can see why it would slow things down a lot.

One option would be to add an email field to the post page for guests so a dynamic IP would not matter. If a member is logged in the field is hidden but if they are a guest they would need to enter an email address to submit a post. A guest's email address would not be displayed anywhere and only visible to administrators during post approval. When a member or a guest hits the submit button unapproved posts would be displayed with a message to not duplicate posts awaiting approval. Searches should be faster because you search by member or email address and post status to display unapproved posts. Once they review their list and select continue, they could could either confirm or abandon the new post submission. If there is no list their post is submitted. This method is not fool proof because someone could still duplicate a post but it would let users see their posts and the status.

I'm not familiar with the inner workings of phpBB so this may not be as easy as I think because a database modification is necessary to add an email address field to the topic for searches. This option has other possibilities. For instance if a guest becomes a member their posts could be moved to the member. Additionally administrators would have either a member or email address associated with all posts on their system.

One might argue guests do not want to submit their email address which is fine. Give admins the option of selecting a radio button in the ACP to disable the function. If the function is disabled, phpBB would work like it does now.

Thought I would throw it out there for other opinions.

Re: Posts waiting for approval should be visible to the authors

Posted: Wed Jan 03, 2018 9:25 am
by Protopia
Yes - I can see that there might be complications to handle all cases.

However, I am not sure that it makes sense for Guests to see their own posts waiting for approval. A guest, by definition, is anonymous - and if e.g. they are using a public PC, there is no expectation that the next user of the same PC won't be able to reuse the same session and see the unapproved post.

So, IMO, this functionality should be limited to users who are signed-in, and this should make the SQL much simpler and more efficient because you don't have to check both the userid (for signed-in users) and the session (for guests).

Re: Posts waiting for approval should be visible to the authors

Posted: Thu Jan 04, 2018 8:35 am
by warmweer
Protopia wrote:
Wed Jan 03, 2018 9:25 am
...
So, IMO, this functionality should be limited to users who are signed-in, and this should make the SQL much simpler and more efficient because you don't have to check both the userid (for signed-in users) and the session (for guests).
Seconded

Re: Posts waiting for approval should be visible to the authors

Posted: Fri May 11, 2018 3:47 pm
by CHItA
PR is here, if anyone wants to follow the changes or review them.

Re: Posts waiting for approval should be visible to the authors

Posted: Sat May 12, 2018 3:34 pm
by JimA
CHItA wrote:
Fri May 11, 2018 3:47 pm
PR is here, if anyone wants to follow the changes or review them.
Awesome, nice job!