Page 1 of 2

Posts waiting for approval should be visible to the authors

Posted: Sat Jul 13, 2013 5:55 pm
by callumacrae
This would help reduce the number of times people don't read the message and just resubmit their post a few times.

----------

View idea at: Posts waiting for approval should be visible to the authors

Posted by callumacrae

Re: Posts waiting for approval should be visible to the auth

Posted: Sat Jul 13, 2013 7:21 pm
by nickvergessen
I tried to implement that while creating softdelete.
The problem is, it makes the queries way more complex and heavier.
The query run time for the most important queries increase by factor 10.

Also for guests it's almost impossible, because we don't have any comparison base, which is why we don't allow delete/edit for guests

Re: Posts waiting for approval should be visible to the auth

Posted: Sat Jul 13, 2013 7:40 pm
by noth
great explanation by NickV

and some good initial ideas by callum, at least callum is coming up with things! :D

Re: Posts waiting for approval should be visible to the auth

Posted: Sat Jul 13, 2013 8:15 pm
by Crizzo
nickvergessen wrote:I tried to implement that while creating softdelete.
The problem is, it makes the queries way more complex and heavier.
The query run time for the most important queries increase by factor 10.
Will this have an great effect on the performance of phpBB?
Also for guests it's almost impossible, because we don't have any comparison base, which is why we don't allow delete/edit for guests
You can create this feature only for registered users. That might be a comfort function to the user, who has created a account. ;)

Re: Posts waiting for approval should be visible to the auth

Posted: Sat Jul 13, 2013 8:26 pm
by nickvergessen
Crizzo wrote:
nickvergessen wrote:I tried to implement that while creating softdelete.
The problem is, it makes the queries way more complex and heavier.
The query run time for the most important queries increase by factor 10.
Will this have an great effect on the performance of phpBB?
On my test back then when implementing the basic of softdelete it doubled the loading time of viewforum in the end.

Re: Posts waiting for approval should be visible to the auth

Posted: Sat Jul 13, 2013 9:16 pm
by naderman
This should be easy to make a lot faster by caching a counter of unapproved posts/topics per forum/topic in the user table (like user_permissions) and only running additional queries to retrieve these topics (rather than modifying any existing queries) if the user actually has any unapproved topics/posts in the forum/topic she is in.

Re: Posts waiting for approval should be visible to the auth

Posted: Sun Jul 14, 2013 8:21 am
by brunoais
1 thing (a bit tecnical but I think it makes sense).
Why not use carefully crafted foreign keys?
AFAIK phpbb does not have foreign keys. At least, I don't have them in my DB when I last installed it 3 months ago.

Re: Posts waiting for approval should be visible to the auth

Posted: Sun Jul 14, 2013 5:35 pm
by Hardolaf
phpBB does not use foreign keys as of the time of this post.

Re: Posts waiting for approval should be visible to the auth

Posted: Tue Aug 06, 2013 4:46 pm
by PardyCo
Kinda useless :/

Re: Posts waiting for approval should be visible to the auth

Posted: Wed Aug 07, 2013 1:33 pm
by callumacrae
PardyCo wrote:Kinda useless :/
How? Have you not ran a board where people submit something multiple times because they do not realise that their post is in the moderation queue?

Re: Posts waiting for approval should be visible to the auth

Posted: Thu Aug 08, 2013 2:45 am
by victor114
Doesn't very necessity, but is a good idea for profissionalize the next version of phpbb !
+1

Re: Posts waiting for approval should be visible to the auth

Posted: Sat Nov 09, 2013 8:44 pm
by peopleopinion
callumacrae wrote:
PardyCo wrote:Kinda useless :/
How? Have you not ran a board where people submit something multiple times because they do not realise that their post is in the moderation queue?

I agree with this idea: I have the identical problem in my phpbb forum. And I'm pretty sure that it can be solved if a user can see his own messages while waiting for moderation with the note "This post is waiting for moderation.".

So user can be more patient and wait without flooding the forum because their post is not publicated immediately.

The callumacrae's idea is better than showing the message in a separate page.
Also For the same reason I think that this solution is good for anonymous / unregistered / guest users too.

Re: Posts waiting for approval should be visible to the auth

Posted: Thu Mar 13, 2014 7:16 am
by Zaishen
I agree with this idea

Re: Posts waiting for approval should be visible to the auth

Posted: Mon Mar 24, 2014 12:47 pm
by peopleopinion
... also this feature will prevent the need of users to write to Admins or Mods things like:
I have written twice a message but it is not publicated. Is the web site working?
If there will be the possibility for authors to modify their messages while waiting for moderation it will be a further positive thing: in fact IMHO visibility and modifiability of waiting posts are part of the same aspect.

Re: Posts waiting for approval should be visible to the auth

Posted: Mon May 05, 2014 4:11 pm
by Big Mac
peopleopinion wrote:... also this feature will prevent the need of users to write to Admins or Mods things like:
I have written twice a message but it is not publicated. Is the web site working?
If there will be the possibility for authors to modify their messages while waiting for moderation it will be a further positive thing: in fact IMHO visibility and modifiability of waiting posts are part of the same aspect.
This would be most useful. Don't just make it visible. Make it editable too.

It only needs to work for people who are logged in and who do not have the right to post without going into the moderation queue. If other users are pre-approved, they should skip past the invisible messages. And moderators should see them, just like the authors waiting for approval would. I guess that means you almost need to give the moderated user the same sort of access (to their own post only) as a moderator.