Page 1 of 2

Toggle Extension Credits

Posted: Fri May 24, 2019 4:10 am
by Sniper_E
I would like to take a different approach with this. If I can make a suggestion.

First off, I would like to appoligize to any extention developers that were affended when I boldly introduced that Hide Credits extention. I should have asked first, it effects all of our ext credits.

Users with several extentions installed, their footer can get a little thick. You can see by my image how thick my footer gets in my style. But with a 'Ext Credits' link in the footer navbar my footer looks as clean as it dose here at .com

Question: Would you ext developers allow a user to place your credits in the footer on a toggle link?

This image shows the change in the footer, and the toggle action.
Image

I have a togglecredits_1.0.1.zip extension on standby. Maybe an idea for the styles team to concider looking into.

What's your stand on this?
Me? As long as my credits were in the footer when the extension credits were toggled on, I would not have any problem letting the admin of a site clean up his/her site's footer with this change. I would still give support.

Re: Toggle Extension Credits

Posted: Fri May 24, 2019 6:01 am
by .m.
I'd prefer a separate page for the extensions credits with a top link (or a footer link) for the page

Re: Toggle Extension Credits

Posted: Fri May 24, 2019 6:38 am
by david63
.m. wrote:
Fri May 24, 2019 6:01 am
I'd prefer a separate page for the extensions credits with a top link (or a footer link) for the page
If there has to be anywhere for extension credits I would second that.

None of my extensions adds a credit line to the index page, and off the top of my head I am not aware of many that do

Re: Toggle Extension Credits

Posted: Fri May 24, 2019 7:19 am
by AmigoJack
Why not turning lines into one line? Separated by i.e. bullets. That would be a smarter use the space and most likely eliminate the need for any toggle.

Re: Toggle Extension Credits

Posted: Sat May 25, 2019 5:10 am
by Sniper_E
Double post

Re: Toggle Extension Credits

Posted: Sat May 25, 2019 5:11 am
by Sniper_E
:oops:
.m. wrote:
Fri May 24, 2019 6:01 am
I'd prefer a separate page for the extensions credits with a top link (or a footer link) for the page
I wouldn't want a seperate page for credits, maybe a popup page if that. I would prefer to keep them in the footer.
AmigoJack wrote:
Fri May 24, 2019 7:19 am
Why not turning lines into one line? Separated by i.e. bullets. That would be a smarter use the space and most likely eliminate the need for any toggle.
I thought about floating half to the left and the other half to the right. But that still fills the footer. A one liner would look weird I think.

What about moving the extension credits into the navbar?
Image
Keep that nice clean looking footer.

I have version 1.0.2 of this on standby... ; ~ )

With that same link in the header.
Image

Re: Toggle Extension Credits

Posted: Sat May 25, 2019 4:39 pm
by Dan Stylez
If that many extensions were on one line it would look bad on small screens,

Would it not be easier to put the trigger for your toggle box under phpBB line,

Powered by phpBB® Forum Software © phpBB Limited
Extension Credits +
Privacy | Terms

Re: Toggle Extension Credits

Posted: Sat May 25, 2019 9:19 pm
by Sniper_E
Dan Stylez wrote:
Sat May 25, 2019 4:39 pm
Would it not be easier to put the trigger for your toggle box under phpBB line,

Powered by phpBB® Forum Software © phpBB Limited
Extension Credits +
Privacy | Terms
Not really. It was easy putting the toggle link in the footer navbar. The idea of this extension was to free up that thick footer by moving the credits out of the footer.

The extension credits are now a part of the navbars using the .dropdown codes, removed my toggle function. This makes the credits open up in the navbar, as you see in my last post.

Now the credits have a dropdown in the header navbar if you want it there. I even have the credit link and dropdown in my sidebars extension.
Image

But look, I can't get too far off the path with this in fear of ruffling the feathers of all the other ext developers.

Have I gone too far already developers? Do you like it developers? Your ext credits will show in more places in the forums.

Re: Toggle Extension Credits

Posted: Sun May 26, 2019 2:32 am
by 3Di
If I can say, this seems to be more a phpBB discussion's topic than an idea for the core code.

Which this forum is devoted to.. my 2 €uro cents.

Re: Toggle Extension Credits

Posted: Sun May 26, 2019 6:53 am
by Raul [ThE KuKa]
3Di wrote:
Sun May 26, 2019 2:32 am
If I can say, this seems to be more a phpBB discussion's topic than an idea for the core code.
.................
I think the same, I don't think this is for the "core" of phpBB.

Re: Toggle Extension Credits

Posted: Tue May 28, 2019 4:21 am
by Sniper_E
Yes this is an idea of a phpBB core change.

Maybe the subject title in this topic could be changed to
Isolate the extension credits from the footer

Either way you say it, it means remove the extension credits from cluddering up our footer and place them somewhere else in the style. In a new page like some would like to see happen or in a dropdown like I've shown with this extension.

Not sure how to do it but what comes to mind,
The phpbb_ext table has... data ['ext_name'] ['ext_active'] ['ext_state']

Maybe expand that table and add data from the composer.json of each extension listed.
data ['ext_title'] ['ext_version'] ['ext_author'] ['ext_link'] ['ext_author2'] ['ext_link2'] if more than one author.

Then all of the installed extensions that are active could be pulled into a template or a dropdown somewhere other than in the footer. If the data was pulled from that table then all extensions enabled on a site would get credit in the 'Extension Credits' Authors would not have to write their credits in an event template.

Re: Toggle Extension Credits

Posted: Tue May 28, 2019 6:10 am
by david63
@Sniper_E - I actually started to create an extension to do that earlier this year but ran out of time. Perhaps I should revisit it!

The actual credits page works. What I need to do is add a back end set of permissions for each extension to be able to control who can see which credit as there may be some extensions that you do not want members/Moderators/other Admins to know about.

Re: Toggle Extension Credits

Posted: Tue May 28, 2019 11:44 am
by spaceace
i actually think that only the phpBB forum software itself and styles should have credits in the footer. reason is that many extension writers end up closing their sites leaving dead links in the footer. there's many other ways extension writers can add credits without cluttering up the footer. an example would be my chat extension

Re: Toggle Extension Credits

Posted: Thu May 30, 2019 2:03 pm
by david63

Re: Toggle Extension Credits

Posted: Thu May 30, 2019 3:23 pm
by Talk19Zehn
The EXT would be good to solicit theft via a proof if they do not comply with the rules and / or licenses. (I would prefer the same result for designs.)
I think this is for the "core" of phpBB important.

Best regards