No valid update directory was found...

https://www.phpbb.com/ideas/
Post Reply
User avatar
Marek Muc
Registered User
Posts: 70
Joined: Tue Sep 04, 2018 2:59 pm
Location: Warsaw, Poland
Contact:

No valid update directory was found...

Post by Marek Muc »

This message that pops up during upgrade (orange background):
upgrade warning.JPG
It is really, I mean really, disturbing for inexperienced users... I think we should change it so that it does not imply that something is wrong when it isn't. I will be happy to suggest new wording but I'm not sure what this message is exactly about...
User avatar
EA117
Registered User
Posts: 1805
Joined: Wed Aug 15, 2018 3:23 am
Contact:

Re: No valid update directory was found...

Post by EA117 »

Certainly agreed.

I've been presuming -- but no actual definitive knowledge -- that this message is "generic". In that the same /install code handles kicking off both an automatic update (partial files to patch the current installation) and full update (where all files have already been replaced, so no file actions need to happen).

And this /install code is just warning "I could not find any automatic update package to process", just in case your expectation was that you should have been about to initiate an automatic update. This warning would alert you to the fact that something was not uploaded correctly, before you try and commence with the update.

But it does seem like there should be some way to definitively indicate "full package file replacement has occurred", versus "the board's files are still of a previous version, and so some kind of automatic update is the only thing we could be about to initiate here". i.e. Files in the board are for a version newer than the phpBB version currently in the database.

And present a warning more suited to each scenario. e.g. If we can tell full file replacement has already happened, then detecting an automatic update in the /install folder would be "the thing that is unexpected", and deserve a warning or full stop error.

And if we can tell that full file replacement hasn't happened (i.e. files still match the database version), then the warning currently being presented would be appropriate if an automatic update package wasn't found. If not simply a full-stop error saying something is wrong with your upload. Since if the files still match the database version, there is no way a "database only" update gets the user where they intended their board to be.
User avatar
qcz
Registered User
Posts: 302
Joined: Wed Apr 22, 2020 10:59 am
Location: Melbourne, Australia
Contact:

Re: No valid update directory was found...

Post by qcz »

+1, although you shouldn't really be hosting a forum if you're not experienced at tech
Last edited by qcz on Mon Sep 14, 2020 1:21 am, edited 1 time in total.
My personal site: https://broadcastre.cc

When replying directly to me please quote me so I get notified. Thanks.

Broadcastre Computer Chat https://broadcastre.cc/forum (please consider joining)
User avatar
3Di
Former Team Member
Posts: 16032
Joined: Mon Apr 04, 2005 11:09 pm
Location: Milan (IT) Frankfurt (DE)
Name: Marco
Contact:

Re: No valid update directory was found...

Post by 3Di »

This message is generic as per its own color: orange or whatever but not red.
Marek Muc wrote:
Fri Sep 11, 2020 1:41 pm
This message that pops up during upgrade (orange background):
You have not specified the way you used to upgrade BTW.

Moreover, more than an idea I could call this a good opportunity to open a file in the bug tracker. :)
Please PM me only to request paid works. Thx.
Want to compensate me for my interest? Donate
My development's activity º PhpStorm's proud user
Extensions, Scripts, MOD porting, Update/Upgrades
Looking for a specific feature or alternative option? We will rock you! 🚀
User avatar
Marek Muc
Registered User
Posts: 70
Joined: Tue Sep 04, 2018 2:59 pm
Location: Warsaw, Poland
Contact:

Re: No valid update directory was found...

Post by Marek Muc »

I used the full package method. Red or orange, it's not green ;)
'Please make sure you uploaded the relevant files' does seem like an error message to me...
It don't think it's a bug (=unintended) though
User avatar
3Di
Former Team Member
Posts: 16032
Joined: Mon Apr 04, 2005 11:09 pm
Location: Milan (IT) Frankfurt (DE)
Name: Marco
Contact:

Re: No valid update directory was found...

Post by 3Di »

Again, that's not an idea at all IMO.

I mean it would have been posted as a bug in the tracker instead of discussing it, so I voted down what an idea it is not.
Also I am not sure it has been not already discussed there since I recall I posted years ago something related.

red = error
orange = now used as generic message
green = alright
3Di wrote:
Sat Sep 12, 2020 9:52 pm
this a good opportunity to open a file in the bug tracker.
https://tracker.phpbb.com/secure/Dashboard.jspa
Please PM me only to request paid works. Thx.
Want to compensate me for my interest? Donate
My development's activity º PhpStorm's proud user
Extensions, Scripts, MOD porting, Update/Upgrades
Looking for a specific feature or alternative option? We will rock you! 🚀
User avatar
Marek Muc
Registered User
Posts: 70
Joined: Tue Sep 04, 2018 2:59 pm
Location: Warsaw, Poland
Contact:

Re: No valid update directory was found...

Post by Marek Muc »

User avatar
3Di
Former Team Member
Posts: 16032
Joined: Mon Apr 04, 2005 11:09 pm
Location: Milan (IT) Frankfurt (DE)
Name: Marco
Contact:

Re: No valid update directory was found...

Post by 3Di »

Thank you for your contribute.
Please PM me only to request paid works. Thx.
Want to compensate me for my interest? Donate
My development's activity º PhpStorm's proud user
Extensions, Scripts, MOD porting, Update/Upgrades
Looking for a specific feature or alternative option? We will rock you! 🚀
Post Reply

Return to “phpBB Ideas”