[CDB] Tabbed profile view

A place for Extension Authors to post and receive feedback on Extensions still in development. No Extensions within this forum should be used within a live environment!
Ideas Centre
Forum rules
READ: phpBB.com Board-Wide Rules and Regulations

IMPORTANT: Extensions Development rules

IMPORTANT FOR NEEDED EVENTS!!!
If you need an event for your extension please read this for the steps to follow to request the event(s)
User avatar
Zyleta
Registered User
Posts: 41
Joined: Fri Apr 25, 2014 10:59 am

[CDB] Tabbed profile view

Post by Zyleta » Mon Jul 18, 2016 11:10 am

Extension Name: Tabbed profile view
Author: Zyleta

Extension Description:

An extension, which change standard profile view into tabbed view

Version 1.0.5
  • changed font-size in contact, statistics and signature into little smaller
Version 1.0.4
  • fixed bug in the code
  • changed profile details on left side (not middle)
  • improved responsive view
Version 1.0.3
  • moved signature content into memberlist_view_contact_before.html
  • improved *css code
  • deleted not needed file memberlist_view_contact_after.html
Version 1.0.2
  • now it should works well with phpBB 3.2.0-RC1
Version 1.0.1
  • changed the name of event. Read README.md to know how to implement Your own extension into tabbed profile view
Version 1.0.0

Features:
  • added only needed classes, all old are the same
  • avatar box is the same, but the css of it is changed
  • avatar box always is showed, contact, stats and signature are on tabs
  • images on signature are re-sized when are to large, to max-width of signature box
  • the view is adapted (I think that it is) into responsive view
  • in README.md file i wrote short instruction, how to add (through another extensions) new tabs, to works with it - didn't tested yet, if this would works, but soon i will test, and if needed do change in this
  • extension works fine with prosilver, and will works fine with every style, that didn't change memberlist_view.html. Maybe some css styling would be needed

Screenshots:
Image

Image

Image

Image


Download:
Download Link

Github:
Tabbed profile view

Installation:
  1. 1. Download the latest release.
    2. Unzip the downloaded release, and change the name of the folder to `tabbedprofileview`.
    3. In the `ext` directory of your phpBB board, create a new directory named `zyleta` (if it does not already exist).
    4. Copy the `tabbedprofileview` folder to `/ext/zyleta/` (if done correctly, you'll have the main extension class at (your forum root)/ext/zyleta/tabbedprofileview/composer.json).
    5. Navigate in the ACP to `Customise -> Manage extensions`.
    6. Look for `Tabbed profile view` under the Disabled Extensions list, and click its `Enable` link.
Additional informations:
This is my first extension, I added here (my second, but the first one i don't want to add right now, I think that I can improve it), I hope You will tell me, what did I wrong, and give me some instruction, how to fix it.
Actually, I don't have own forum, so all problems with this ext (I'm not advanced, but if I know how to help, I will) will be did here.
And, I don't know really good github, first time use it, and I don't know how to do the version check with github, so it is unavailable right now.
I didn't checked, if 3.2 changed something with memberlist_view, and tabs, but if not, I think, that it will works on 3.2.
I hope, that I placed right tag ([DEV]) to this topic.
And sorry for my english. It isn't well, but I hope You can understand what I wrote :)
Last edited by Zyleta on Sun Nov 06, 2016 11:54 pm, edited 11 times in total.

chfs
Registered User
Posts: 231
Joined: Mon Feb 04, 2013 10:01 am

Re: [DEV] Tabbed profile view

Post by chfs » Mon Jul 18, 2016 11:25 am

Thanks! Good job.
You are all great developers 8-)
I'm sorry for my english. :?

User avatar
david63
Registered User
Posts: 16669
Joined: Thu Dec 19, 2002 8:08 am
Location: Lancashire, UK
Name: David Wood
Contact:

Re: [DEV] Tabbed profile view

Post by david63 » Mon Jul 18, 2016 11:50 am

Zyleta wrote:I added also new events, <!-- EVENT memberlist_tabbed_view_tablist_prepend --> and <!-- EVENT memberlist_tabbed_view_tablist_append --> (I don't know if this is ok, if it can be done like this. If not, let me know, I will try to change the code. Those event are used for another, further extensions, which will add some new content into profile view and which would like to use another tab)
Those events have not been added to the core yet so this extension will not work until they are.

Also your naming convention for the events is incorrect as there is no memberlist_tabbed_view template file.

You will need to create a pull request to have those events added.
Last edited by david63 on Mon Jul 18, 2016 1:58 pm, edited 1 time in total.
David
Remember: You only know what you know and - you don't know what you don't know!
My CDB Contributions | How to install an extension
I will not be accepting translations for any of my extensions in Github - please post any translations in the appropriate topic.
No support requests via PM or email as they will be ignored

User avatar
RMcGirr83
Recognised Extension Developer
Posts: 21034
Joined: Wed Jun 22, 2005 4:33 pm
Location: Your display
Name: Rich McGirr
Contact:

Re: [DEV] Tabbed profile view

Post by RMcGirr83 » Mon Jul 18, 2016 1:26 pm

David, I believe the events he is adding are specific template events for this extension. Not sure he would need a PR for that just that it be documented that they are there is another extension wants to use them.
In times of change, learners inherit the earth, while the learned find themselves beautifully equipped to deal with a world that no longer exists - Eric Hoffer
Former Modifications/Extensions Team Member | My extensions
Appreciate the extensions/mods/support then buy me a beer
All requests for support via PM will be ignored

User avatar
Zyleta
Registered User
Posts: 41
Joined: Fri Apr 25, 2014 10:59 am

Re: [DEV] Tabbed profile view

Post by Zyleta » Mon Jul 18, 2016 1:41 pm

RMcGirr83 wrote:David, I believe the events he is adding are specific template events for this extension. Not sure he would need a PR for that just that it be documented that they are there is another extension wants to use them.
You have right. This event I mentioned is placed inside my extension, in file in \ext\zyleta\tabbedprofileview\styles\prosilver\template\event\memberlist_view_content_prepend.html - for this isn't needed any request?

But name of it, I would change, if it is important how events are named. Could You give me prompt, how to name it?
David said, that should be name of where it is placed, so I should name it from file where it is (memberlist_view_content_prepend.html) or just from memberlist_view.html

Or should I name it from extension name, so tabbed_profile_view_tablist

User avatar
RMcGirr83
Recognised Extension Developer
Posts: 21034
Joined: Wed Jun 22, 2005 4:33 pm
Location: Your display
Name: Rich McGirr
Contact:

Re: [DEV] Tabbed profile view

Post by RMcGirr83 » Mon Jul 18, 2016 1:56 pm

Zyleta wrote:Or should I name it from extension name, so tabbed_profile_view_tablist
That's probably what I would do.
In times of change, learners inherit the earth, while the learned find themselves beautifully equipped to deal with a world that no longer exists - Eric Hoffer
Former Modifications/Extensions Team Member | My extensions
Appreciate the extensions/mods/support then buy me a beer
All requests for support via PM will be ignored

User avatar
david63
Registered User
Posts: 16669
Joined: Thu Dec 19, 2002 8:08 am
Location: Lancashire, UK
Name: David Wood
Contact:

Re: [DEV] Tabbed profile view

Post by david63 » Mon Jul 18, 2016 1:57 pm

Sorry - you are right. It was just a bit confusing in your OP - personally I would remove that paragraph from your OP.
Zyleta wrote:Or should I name it from extension name, so tabbed_profile_view_tablist
That would, in my opinion, be a better way to name it - using memberlist means that people, like me, will go off and look for it in one of the memberlist templates.
David
Remember: You only know what you know and - you don't know what you don't know!
My CDB Contributions | How to install an extension
I will not be accepting translations for any of my extensions in Github - please post any translations in the appropriate topic.
No support requests via PM or email as they will be ignored

User avatar
Zyleta
Registered User
Posts: 41
Joined: Fri Apr 25, 2014 10:59 am

Re: [DEV] Tabbed profile view

Post by Zyleta » Mon Jul 18, 2016 3:03 pm

Thanks for Your replies :)
I changed it right now.
I make also some changes in phpbb requirment (in composer.json. Based on, when was added events used by me), but still didn't test it on 3.2.x, so don't know if it will works there

User avatar
david63
Registered User
Posts: 16669
Joined: Thu Dec 19, 2002 8:08 am
Location: Lancashire, UK
Name: David Wood
Contact:

Re: [DEV] Tabbed profile view

Post by david63 » Mon Jul 18, 2016 3:22 pm

Zyleta wrote:but still didn't test it on 3.2.x, so don't know if it will works there
It does not fully work in 3.2 - there are no tabs, only the text
David
Remember: You only know what you know and - you don't know what you don't know!
My CDB Contributions | How to install an extension
I will not be accepting translations for any of my extensions in Github - please post any translations in the appropriate topic.
No support requests via PM or email as they will be ignored

User avatar
Zyleta
Registered User
Posts: 41
Joined: Fri Apr 25, 2014 10:59 am

Re: [DEV] Tabbed profile view

Post by Zyleta » Mon Jul 18, 2016 3:32 pm

david63 wrote:
Zyleta wrote:but still didn't test it on 3.2.x, so don't know if it will works there
It does not fully work in 3.2 - there are no tabs, only the text
I just tried it.
Open memberlist_view_content_prepend.html
On 3rd line change:

Code: Select all

	<div id="tabs" class="sub-panels" data-show-panel="{$SHOW_PANEL}" role="tablist">
into this:

Code: Select all

	<div id="tabs" class="tabs sub-panels" data-show-panel="{$SHOW_PANEL}" role="tablist">
On 3.2.0-RC1 it works.

Or, Just download this file memberlist_view_content_prepend.html from github

chfs
Registered User
Posts: 231
Joined: Mon Feb 04, 2013 10:01 am

Re: [DEV] Tabbed profile view

Post by chfs » Tue Jul 19, 2016 9:22 pm

Thank you, it works.
But signature not working properly on phpBB 3.2 RC1 :?
I'm sorry for my english. :?

User avatar
Zyleta
Registered User
Posts: 41
Joined: Fri Apr 25, 2014 10:59 am

Re: [DEV] Tabbed profile view

Post by Zyleta » Tue Jul 19, 2016 10:21 pm

chfs wrote:But signature not working properly on phpBB 3.2 RC1 :?
Can You tell me more about it?
What happens, what You did, maybe a screen with Your problem.
I placed a text, image, image + text and didn't noticed any errors, more information will make easier to find what is wrong and how to fix it :)

chfs
Registered User
Posts: 231
Joined: Mon Feb 04, 2013 10:01 am

Re: [DEV] Tabbed profile view

Post by chfs » Wed Jul 20, 2016 7:10 am

Look. Thanks.
Image

Image
I'm sorry for my english. :?

User avatar
Zyleta
Registered User
Posts: 41
Joined: Fri Apr 25, 2014 10:59 am

Re: [DEV] Tabbed profile view

Post by Zyleta » Wed Jul 20, 2016 8:51 am

Ok, I see it.
Look at newer version on github, or do changes manually:
copy all from file memberlist_view_contact_after.html (it means signature content) and paste at the end of file memberlist_view_contact_before.html (so all tabs content would be in one file). Delete empty file memberlist_view_contact_after.html (its no needed anymore).

Also, You have to do some changes in tabbedprofileview.css - open it and do changes:
find #viewprofile .tabstats, and add there padding: 0;
find #viewprofile .bg1 and replace margin-right: 25px; with margin-right: 5px;

and add this:

Code: Select all

#viewprofile .tabstats .inner {
	padding: 5px 10px;
}
You can as well just download new version from github.
Remember to purge cache, because it have changes in template files.

If the problem still would be there, I would ask You for extensions You use (I sure it is extension) and I will try to tell You how to fix the problem

chfs
Registered User
Posts: 231
Joined: Mon Feb 04, 2013 10:01 am

Re: [DEV] Tabbed profile view

Post by chfs » Wed Jul 20, 2016 1:52 pm

Thanks, it works 8-)
I'm sorry for my english. :?

Locked

Return to “Extensions in Development”