[RC] Digests 3.2.10

A place for Extension Authors to post and receive feedback on Extensions still in development. No Extensions within this forum should be used within a live environment!
Suggested Hosts
Forum rules
READ: phpBB.com Board-Wide Rules and Regulations

IMPORTANT: Extensions Development rules

IMPORTANT FOR NEEDED EVENTS!!!
If you need an event for your extension please read this for the steps to follow to request the event(s)
User avatar
MarkDHamill
Registered User
Posts: 3553
Joined: Fri Aug 02, 2002 12:36 am
Location: Florence, MA USA
Contact:

Re: [RC] Digests 3.2.10

Post by MarkDHamill » Thu Dec 06, 2018 8:43 pm

Eichohrkater wrote:
Thu Dec 06, 2018 8:32 pm
Bounce, cause of being missed.
Eichohrkater wrote:
Fri Nov 30, 2018 1:48 pm
Thanks for this very nice work.

But for me when trying „Manually run the mailer“ and setting switch „Clear the store“ to Yes, it runs in following Error:

Code: Select all

Fatal error: Uncaught RuntimeException: Directory name must not be empty. in /var/www/vhosts/xxx/httpdocs/forum/ext/phpbbservices/digests/acp/main_module.php:1565 Stack trace: #0 /var/www/vhosts/xxx/httpdocs/forum/ext/phpbbservices/digests/acp/main_module.php(1565): DirectoryIterator->__construct('') #1 /var/www/vhosts/xxx/httpdocs/forum/includes/functions_module.php(676): phpbbservices\digests\acp\main_module->main('\\phpbbservices\\...', 'digests_test') #2 /var/www/vhosts/xxx/httpdocs/forum/adm/index.php(82): p_master->load_active() #3 {main} thrown in /var/www/vhosts/xxx/httpdocs/forum/ext/phpbbservices/digests/acp/main_module.php on line 1565

There is also a small mistake in the German Translation.
In Line 51 there are /' what results in Error. Right would be \'
Sadly, I did not found contact data’s of the translator to inform him myself.


And is there any possibility to disable the digest for specific usergroops or users?
I would prefer to not allow it to fresh registered users.

Thanks
Please change that line to:

Code: Select all

					foreach (new \DirectoryIterator($this->phpbb_root_path) as $file_info)
Thanks for reporting the bug. It was also noticed in the latest review.

As for the German translation, report it to Praggle on GitHub: https://github.com/Praggle/digests
Get the latest versions of my Digests and Smartfeed mods and extensions.
Need phpBB services or a phpBB consultant? I offer most phpBB services.

User avatar
kasimi
Extension Customisations
Extension Customisations
Posts: 3360
Joined: Sat Sep 10, 2011 7:12 pm
Location: Germany
Contact:

Re: [RC] Digests 3.2.10

Post by kasimi » Thu Dec 06, 2018 9:08 pm

MarkDHamill wrote:
Thu Dec 06, 2018 8:43 pm

Please change that line to:

Code: Select all

					foreach (new \DirectoryIterator($this->phpbb_root_path) as $file_info)
Careful, that will delete .html and .txt files in your board's root folder. I think you want it replaced with this:

Code: Select all

					foreach (new \DirectoryIterator($this->phpbb_root_path . 'store/phpbbservices/digests') as $file_info)

User avatar
MarkDHamill
Registered User
Posts: 3553
Joined: Fri Aug 02, 2002 12:36 am
Location: Florence, MA USA
Contact:

Re: [RC] Digests 3.2.10

Post by MarkDHamill » Thu Dec 06, 2018 10:53 pm

If after this line around line 1566:

Code: Select all

					$all_cleared = true;
I had added:

Code: Select all

					$path = $this->phpbb_root_path . 'store/phpbbservices/digests';
the code would have worked. Thanks for noticing this.
Get the latest versions of my Digests and Smartfeed mods and extensions.
Need phpBB services or a phpBB consultant? I offer most phpBB services.

User avatar
3Di
Registered User
Posts: 13097
Joined: Mon Apr 04, 2005 11:09 pm
Location: Milan (IT) Frankfurt (DE)
Name: Marco
Contact:

Re: [RC] Digests 3.2.10

Post by 3Di » Thu Dec 06, 2018 11:05 pm

In this case perhaps should have been?

Code: Select all

foreach (new \DirectoryIterator($path) as $file_info)
I am not reading the code, just a thought.
:game_die: The new Dice Roller extension for phpBB 3.2 is out! :game_die:

Please PM me only to request paid works. Thx.
Want to compensate me for my interest? Donate
Extensions, Scripts, MOD porting, Update/Upgrades
My development's activity º PhpStorm's proud user

Praggle
Registered User
Posts: 55
Joined: Thu Feb 26, 2015 6:07 pm

Re: [RC] Digests 3.2.10

Post by Praggle » Fri Dec 07, 2018 8:17 am

Eichohrkater wrote:
Fri Nov 30, 2018 1:48 pm

There is also a small mistake in the German Translation.
In Line 51 there are /' what results in Error. Right would be \'
Sadly, I did not found contact data’s of the translator to inform him myself.
You can find an updated version in github now. If you find errors in the german translation, it is the best way to contact me over github as Marc posted already (https://github.com/Praggle/digests). There you can make a pull request or a comment directly into the code, where you found the error.

Vielen Dank für den Hinweis!

Praggle

colinshead
Registered User
Posts: 48
Joined: Sun Mar 29, 2015 11:37 am

Re: [RC] Digests 3.2.10

Post by colinshead » Sun Dec 09, 2018 11:17 am

Hi Ian

An idea for a minor enhancement if you have an opportunity.

At the foot of each Digest e-mail there is text

If you have questions or feedback on your digests please send it to the 'Forum Name' webmaster.

That is the extension assumes that the person to help is the 'webmaster', rather than picking up the Contact Name form phpBB core, or providing a facility to set it in the ACP.

It's easy to change by editing common.php in the language folder, but would be more elegant if the extension simply picked up the contact name etc.

All the best

Colin

colinshead
Registered User
Posts: 48
Joined: Sun Mar 29, 2015 11:37 am

Re: [RC] Digests 3.2.10

Post by colinshead » Sun Dec 09, 2018 5:02 pm

Hi Mark

I am still having issues getting Remote content images, in Digest styled e-mails, to display in e-mail clients, even after tweaking all the controls on the clients to allow html content with in-line images to be displayed.

This is definitely not an issue with the Digests extension, I have inspected the e-mail source text and the HTML is correctly formed, and if copied out as a HTML file the images are rendered perfectly well in a conventional browser.

I think the issue is associated with the form of the links for the in-line images which are not conventional links e.g.:

href="https://www.something.org.uk/download/image.jpg"

but are of the form:

href="https://www.something.org.uk/download/file.php?id=2618"

i.e. a conventional browser can 'trigger' the file.php file to download and display the image perfectly well, whilst the e-mail clients do not.

I assume that the format of the links is not something which you have any control over, but I would be interested in knowing whether you have any pearls of wisdom to offer on this subject.

All the best

Colin

User avatar
MarkDHamill
Registered User
Posts: 3553
Joined: Fri Aug 02, 2002 12:36 am
Location: Florence, MA USA
Contact:

Re: [RC] Digests 3.2.10

Post by MarkDHamill » Sun Dec 09, 2018 5:37 pm

file.php is responsible for rendering attachments. If an image, it will return the image just fine. phpBB stores attachments including attached images to posts in the file folder under a random file name. It shouldn't be an issue as it will return correct HTTP headers for the attachment indicating it is a picture. I haven't noticed the issue in my testing. It sounds like some peculiarity with your email client.
Get the latest versions of my Digests and Smartfeed mods and extensions.
Need phpBB services or a phpBB consultant? I offer most phpBB services.

colinshead
Registered User
Posts: 48
Joined: Sun Mar 29, 2015 11:37 am

Re: [RC] Digests 3.2.10

Post by colinshead » Sun Dec 09, 2018 5:44 pm

Hi Mark

Been trying Thunderbird and Gmail both the app and in a browser, I cannot get either to display inline remote content images in the Digest emails, though other html emails from the likes of online retailers are rendered perfectly.

Not a show stopper but frustrating!

All the best

Colin

User avatar
MarkDHamill
Registered User
Posts: 3553
Joined: Fri Aug 02, 2002 12:36 am
Location: Florence, MA USA
Contact:

Re: [RC] Digests 3.2.10

Post by MarkDHamill » Sun Dec 09, 2018 10:00 pm

With GMail in the browser, I have gotten it to work. There is an option to show remote content.

https://support.google.com/mail/answer/ ... ktop&hl=en

For Thunderbird, I don't use it but this is supposed to work:

https://support.mozilla.org/en-US/kb/re ... n-messages
Get the latest versions of my Digests and Smartfeed mods and extensions.
Need phpBB services or a phpBB consultant? I offer most phpBB services.

colinshead
Registered User
Posts: 48
Joined: Sun Mar 29, 2015 11:37 am

Re: [RC] Digests 3.2.10

Post by colinshead » Sun Dec 09, 2018 10:59 pm

Hi Mark

Thanks for your time and attention, I am familiar with the content of these links, have tried all, but so far no joy.

It might possibly be an issue with hot linking protection on the server (currently disabled) , but as the HTML content renders perfectly well in a conventional browser, I am puzzled why the email clients do not behave in the same way.

I continue to work on this, and report a solution if found, as most likely other users of the Digest extension will have the same problem.

All the best

Colin

User avatar
MarkDHamill
Registered User
Posts: 3553
Joined: Fri Aug 02, 2002 12:36 am
Location: Florence, MA USA
Contact:

Re: [RC] Digests 3.2.10

Post by MarkDHamill » Mon Dec 10, 2018 12:06 am

Are you using a site like CloudFlare? Maybe having it enabled it causing the problem.
Get the latest versions of my Digests and Smartfeed mods and extensions.
Need phpBB services or a phpBB consultant? I offer most phpBB services.

colinshead
Registered User
Posts: 48
Joined: Sun Mar 29, 2015 11:37 am

Re: [RC] Digests 3.2.10

Post by colinshead » Mon Dec 10, 2018 7:47 am

Hi Mark

No, it's a regular shared Linux host from Zen Internet.

All the best

Colin

colinshead
Registered User
Posts: 48
Joined: Sun Mar 29, 2015 11:37 am

Re: [RC] Digests 3.2.10

Post by colinshead » Mon Dec 10, 2018 9:51 am

Hi Mark

Just to keep you in the loop. I have conducted an experiment using Thunderbird.

I exported a Digest e-mail with failing images, and manually edited the links in the e-mail source code so that the links pointed to a straightforward jpg file I had uploaded into the phpBB downloads folder, the same folder which contains file.php. I then re-imported the email back into Thunderbird. Result, the links work perfectly and thumbnails etc. are displayed correctly.

This I believe has to mean that Thunderbird does not operate correctly with links of the form href="https://www.something.org.uk/download/file.php?id=2618" but is happy with links of the form href="https://www.something.org.uk/download/image.jpg"

I have no idea why presently ! I rather suspect that some other e-mail clients have exactly the same issue.

I'll investigate further, and see if the Thunderbird support forum can provide a solution.

All the best

Colin

User avatar
canonknipser
Registered User
Posts: 1705
Joined: Thu Sep 08, 2011 4:16 am
Location: Germany
Name: Frank Jakobs
Contact:

Re: [RC] Digests 3.2.10

Post by canonknipser » Mon Dec 10, 2018 10:27 am

colinshead wrote:
Mon Dec 10, 2018 9:51 am
Thunderbird does not operate correctly with links of the form href="https://www.something.org.uk/download/file.php?id=2618"
What do you expect? It s a valid link to a URL, so Thunderbird shows you the link. That is the expected behaviour for every internet browser and internet client.
To render a image the link must be a image-link, as phpBB already creates them:
<a href="https://www.something.org.uk/download/file.php?id=2618&amp;mode=view"><img src="https://www.something.org.uk/download/file.php?id=2618&amp;t=1" /></a>
colinshead wrote:
Mon Dec 10, 2018 9:51 am
is happy with links of the form href="https://www.something.org.uk/download/image.jpg"


I suspect Thunderbird just guessing it is a image when the linked file ends up in one of the well known image extensions like jgp, png, tiff ...
Greetings, Frank
phpbb.de support team member
English is not my native language - no support via PM or mail
New arrival - Extensions and scripts for phpBB

Post Reply

Return to “Extensions in Development”

Who is online

Users browsing this forum: </Solidjeuh>, Google [Bot], nextgen and 36 guests