[3.3][RC] Schedule Topic Lock

A place for Extension Authors to post and receive feedback on Extensions still in development. No Extensions within this forum should be used within a live environment!
Anti-Spam Guide
Forum rules
READ: phpBB.com Board-Wide Rules and Regulations

IMPORTANT: Extensions Development rules

IMPORTANT FOR NEEDED EVENTS!!!
If you need an event for your extension please read this for the steps to follow to request the event(s)
User avatar
david63
Registered User
Posts: 19067
Joined: Thu Dec 19, 2002 8:08 am
Location: Lancashire, UK
Contact:

Re: [3.3][RC] Schedule Topic Lock

Post by david63 »

G83 wrote:
Tue Feb 23, 2021 1:20 pm
Not sure if this is related, however, in a thread scheduled to close this evening, the first post of each new page is missing until a new page is created.
I cannot recreate that issue and I cannot see how this extension would cause that to happen as it does not touch any posts
David
Remember: You only know what you know and - you don't know what you don't know!
My CDB Contributions | How to install an extension
I will not be accepting translations for any of my extensions in Github - please post any translations in the appropriate topic.
No support requests via PM or email as they will be ignored
G83
Registered User
Posts: 25
Joined: Thu Feb 11, 2021 3:05 pm

Re: [3.3][RC] Schedule Topic Lock

Post by G83 »

No idea, as I say, may not be connected, however it's only happened in this single thread. I originally tested to lock the thread and then unlocked it and set a later date. The posts are visible in the database, but not showing in the post.
User avatar
HiFiKabin
Community Team Member
Community Team Member
Posts: 5261
Joined: Wed May 14, 2014 9:10 am
Location: Swearing at the PC, UK
Name: James
Contact:

Re: [3.3][RC] Schedule Topic Lock

Post by HiFiKabin »

david63 wrote:
Tue Feb 23, 2021 2:42 pm
I think that there was a bug (now fixed).

Can you try RC3 please
RC3 looks good here and all working as it should, thanks David
User avatar
david63
Registered User
Posts: 19067
Joined: Thu Dec 19, 2002 8:08 am
Location: Lancashire, UK
Contact:

Re: [3.3][RC] Schedule Topic Lock

Post by david63 »

HiFiKabin wrote:
Tue Feb 23, 2021 4:59 pm
Thanks for the confirmation
David
Remember: You only know what you know and - you don't know what you don't know!
My CDB Contributions | How to install an extension
I will not be accepting translations for any of my extensions in Github - please post any translations in the appropriate topic.
No support requests via PM or email as they will be ignored
G83
Registered User
Posts: 25
Joined: Thu Feb 11, 2021 3:05 pm

Re: [3.3][RC] Schedule Topic Lock

Post by G83 »

G83 wrote:
Tue Feb 23, 2021 3:09 pm
No idea, as I say, may not be connected, however it's only happened in this single thread. I originally tested to lock the thread and then unlocked it and set a later date. The posts are visible in the database, but not showing in the post.
Not sure what triggered it, but it seems as though the "verified posts" column in the thread had missed 1... I added one to that value, and it's fine. Not sure what could have caused it!
User avatar
david63
Registered User
Posts: 19067
Joined: Thu Dec 19, 2002 8:08 am
Location: Lancashire, UK
Contact:

Re: [3.3][RC] Schedule Topic Lock

Post by david63 »

G83 wrote:
Wed Feb 24, 2021 1:12 pm
the "verified posts" column
There is no verified posts column in a standard install of phpBB - it must be from an extension
David
Remember: You only know what you know and - you don't know what you don't know!
My CDB Contributions | How to install an extension
I will not be accepting translations for any of my extensions in Github - please post any translations in the appropriate topic.
No support requests via PM or email as they will be ignored
G83
Registered User
Posts: 25
Joined: Thu Feb 11, 2021 3:05 pm

Re: [3.3][RC] Schedule Topic Lock

Post by G83 »

Sorry, I got the name wrong...

"topic_posts_approved"

Does that exist? If so, that was what I added 1 to and it worked.

Also, I'm running Feed Post Bot, and feeds have stopped coming in and when I tried to force it I got the following error:

Code: Select all

SQL ERROR [ mysqli ]

Column 'topic_schedule_lock_time' cannot be null [1048]

An SQL error occurred while fetching this page. Please contact the Board Administrator if this problem persists.
Having looked at the "topic_schedule_lock_time", the default is 0 so shouldn't it just be assigning a 0 instead of a null?
User avatar
david63
Registered User
Posts: 19067
Joined: Thu Dec 19, 2002 8:08 am
Location: Lancashire, UK
Contact:

Re: [3.3][RC] Schedule Topic Lock

Post by david63 »

G83 wrote:
Wed Feb 24, 2021 1:36 pm
I'm running Feed Post Bot, and feeds have stopped coming in and when I tried to force it I got the following error:
Possible bug - try using RC4
David
Remember: You only know what you know and - you don't know what you don't know!
My CDB Contributions | How to install an extension
I will not be accepting translations for any of my extensions in Github - please post any translations in the appropriate topic.
No support requests via PM or email as they will be ignored
G83
Registered User
Posts: 25
Joined: Thu Feb 11, 2021 3:05 pm

Re: [3.3][RC] Schedule Topic Lock

Post by G83 »

david63 wrote:
Wed Feb 24, 2021 2:16 pm
G83 wrote:
Wed Feb 24, 2021 1:36 pm
I'm running Feed Post Bot, and feeds have stopped coming in and when I tried to force it I got the following error:
Possible bug - try using RC4
Appears to have done the job. Thanks David.
G83
Registered User
Posts: 25
Joined: Thu Feb 11, 2021 3:05 pm

Re: [3.3][RC] Schedule Topic Lock

Post by G83 »

Hi David,

First proper attempt at a scheduled lock failed. One scheduled to lock yesterday at 18:50 didn't lock, I checked a couple of minutes later by clicking edit post and the checkbox was unchecked and the time said 18:52. This was a sticky topic, would that make a difference?
User avatar
david63
Registered User
Posts: 19067
Joined: Thu Dec 19, 2002 8:08 am
Location: Lancashire, UK
Contact:

Re: [3.3][RC] Schedule Topic Lock

Post by david63 »

G83 wrote:
Wed Mar 03, 2021 9:18 pm
I checked a couple of minutes later by clicking edit post
Do you mean that the topic was open and you just tried to edit it? The way it works is that when someone, be that a user or a bot, visits a topic after the scheduled time them the topic is locked.
David
Remember: You only know what you know and - you don't know what you don't know!
My CDB Contributions | How to install an extension
I will not be accepting translations for any of my extensions in Github - please post any translations in the appropriate topic.
No support requests via PM or email as they will be ignored
G83
Registered User
Posts: 25
Joined: Thu Feb 11, 2021 3:05 pm

Re: [3.3][RC] Schedule Topic Lock

Post by G83 »

david63 wrote:
Wed Mar 03, 2021 9:43 pm
G83 wrote:
Wed Mar 03, 2021 9:18 pm
I checked a couple of minutes later by clicking edit post
Do you mean that the topic was open and you just tried to edit it? The way it works is that when someone, be that a user or a bot, visits a topic after the scheduled time them the topic is locked.
Does this apply regardless of the user’s group? I opened the thread as a moderator and it wasn’t locked and as it hadn’t locked I clicked edit to see if the box etc was checked, but it was then unchecked and the date was reset. I will try getting a normal user to open it next time (Saturday) and try that.
User avatar
david63
Registered User
Posts: 19067
Joined: Thu Dec 19, 2002 8:08 am
Location: Lancashire, UK
Contact:

Re: [3.3][RC] Schedule Topic Lock

Post by david63 »

G83 wrote:
Thu Mar 04, 2021 8:45 pm
Does this apply regardless of the user’s group?
Group makes no difference.
G83 wrote:
Thu Mar 04, 2021 8:45 pm
the date was reset
That would only happen if you tried to edit a topic after the scheduled lock time as the time cannot be earlier than the current time.
David
Remember: You only know what you know and - you don't know what you don't know!
My CDB Contributions | How to install an extension
I will not be accepting translations for any of my extensions in Github - please post any translations in the appropriate topic.
No support requests via PM or email as they will be ignored
G83
Registered User
Posts: 25
Joined: Thu Feb 11, 2021 3:05 pm

Re: [3.3][RC] Schedule Topic Lock

Post by G83 »

david63 wrote:
Fri Mar 05, 2021 8:01 am
That would only happen if you tried to edit a topic after the scheduled lock time as the time cannot be earlier than the current time.
[/quote]

I understand that, however it hadn’t already locked. If I open the topic and then go back to the forum, should it then lock automatically?
Post Reply

Return to “Extensions in Development”