[CDB] Share On

A place for Extension Authors to post and receive feedback on Extensions still in development. No Extensions within this forum should be used within a live environment!
Suggested Hosts
Forum rules
READ: phpBB.com Board-Wide Rules and Regulations

IMPORTANT: Extensions Development rules

IMPORTANT FOR NEEDED EVENTS!!!
If you need an event for your extension please read this for the steps to follow to request the event(s)
Locked
User avatar
piatachki
Registered User
Posts: 24
Joined: Fri Jul 03, 2015 2:57 pm
Location: Moscow
Name: Vasily Batishchev
Contact:

Re: [RC] Share On

Post by piatachki » Wed Jul 22, 2015 10:46 am

Autor, thanx for great extension!

There are little, but annoying mistake in russian translation:

String 'SO_STATUS' at ACP must be

'SO_STATUS' => 'Включить расширение Поделиться',

Please, look at this when release will rolling out.

Sorry :)

User avatar
piatachki
Registered User
Posts: 24
Joined: Fri Jul 03, 2015 2:57 pm
Location: Moscow
Name: Vasily Batishchev
Contact:

Re: [RC] Share On

Post by piatachki » Wed Jul 22, 2015 11:07 am

Webwatcher_eu wrote:i see that the share on icons will be open in same tab. for me it will be better if facebook, twitter ect will be open in a new tab - there is no setup for this right now - if i can select this (same tab or new tab) from acp it will be also for other users helpfull.

please check if this is possible.
At

Code: Select all

ext/%extension%/styles/prosilver/template/event/viewtopic_body_postrow_post_notices_after.html
add target="_blank" after href tag. ForEx., for vk.com:

For same tab:

Code: Select all

			<!-- IF S_SO_VK --><li>
				<a href="{postrow.U_VK}" title="{L_SHARE_ON_VK}" class="share-button share-icon-button vk-icon"><span>{L_SHARE_ON_VK}</span></a>
			</li><!-- ENDIF -->
For new tab:

Code: Select all

			<!-- IF S_SO_VK --><li>
				<a href="{postrow.U_VK}" target="_blank" title="{L_SHARE_ON_VK}" class="share-button share-icon-button vk-icon"><span>{L_SHARE_ON_VK}</span></a>
			</li><!-- ENDIF -->
And re-cache!
Last edited by piatachki on Wed Jul 22, 2015 3:21 pm, edited 1 time in total.

User avatar
Webwatcher_eu
Registered User
Posts: 102
Joined: Tue Nov 25, 2014 10:59 am
Contact:

Re: [RC] Share On

Post by Webwatcher_eu » Wed Jul 22, 2015 2:28 pm

hmm this file looks a bit differend:

Code: Select all

<ul class="share-buttons">
			<!-- IF S_SO_FACEBOOK --><li>
				<a href="{postrow.U_FACEBOOK}" title="{L_SHARE_ON_FACEBOOK}" class="share-button share-icon-button facebook-icon"><span>{L_SHARE_ON_FACEBOOK}</span></a>
			</li><!-- ENDIF -->

			<!-- IF S_SO_TWITTER --><li>
				<a href="{postrow.U_TWITTER}" title="{L_SHARE_ON_TWITTER}" class="share-button share-icon-button twitter-icon"><span>{L_SHARE_ON_TWITTER}</span></a>
			</li><!-- ENDIF -->
changed to this:

Code: Select all

			<!-- IF S_SO_FACEBOOK --><li>
				<a href="{postrow.U_FACEBOOK}" target="_blank" title="{L_SHARE_ON_FACEBOOK}" class="share-button share-icon-button facebook-icon"><span>{L_SHARE_ON_FACEBOOK}</span></a>
			</li><!-- ENDIF -->

			<!-- IF S_SO_TWITTER --><li>
				<a href="{postrow.U_TWITTER}" target="_blank" title="{L_SHARE_ON_TWITTER}" class="share-button share-icon-button twitter-icon"><span>{L_SHARE_ON_TWITTER}</span></a>
			</li><!-- ENDIF -->
result --> no icons and no entry in ACP

User avatar
piatachki
Registered User
Posts: 24
Joined: Fri Jul 03, 2015 2:57 pm
Location: Moscow
Name: Vasily Batishchev
Contact:

Re: [RC] Share On

Post by piatachki » Wed Jul 22, 2015 3:03 pm

I have no idea why. May be with/without BOM.

I attach my file, which work correctly on my site.

Attached here: http://hooleegan.ru/viewtopic.php?f=15&t=61

User avatar
Webwatcher_eu
Registered User
Posts: 102
Joined: Tue Nov 25, 2014 10:59 am
Contact:

Re: [RC] Share On

Post by Webwatcher_eu » Wed Jul 22, 2015 3:09 pm

yes i see

i scan for <!-- IF S_SO_VK --><li> in all files but no result - so you must have a other version (or ext?)

please re-check

User avatar
Webwatcher_eu
Registered User
Posts: 102
Joined: Tue Nov 25, 2014 10:59 am
Contact:

Re: [RC] Share On

Post by Webwatcher_eu » Wed Jul 22, 2015 3:15 pm

A other qustiuon:

by Twitter the box looks like this:

Subject: URL

how i can have 2 <br/> between Subject and url so it looks like this

Subject:

URL

User avatar
Webwatcher_eu
Registered User
Posts: 102
Joined: Tue Nov 25, 2014 10:59 am
Contact:

Re: [RC] Share On

Post by Webwatcher_eu » Thu Jul 23, 2015 3:17 pm

Webwatcher_eu wrote:A other qustiuon:

by Twitter the box looks like this:

Subject: URL

how i can have 2 <br/> between Subject and url so it looks like this

Subject:

URL
also it would be fine if it will be possible to add a hashtag by twitter

Subject:

URL #hashtag #hashtag

or

#hashtag #hashtag Subject:

URL

wmdcf
Registered User
Posts: 26
Joined: Sun Jan 11, 2015 2:37 am

Re: [RC] Share On

Post by wmdcf » Fri Jul 24, 2015 3:48 pm

Hi All, I have installed this mod on my live board and it's working perfectly.
Thanks guys! 8-)

User avatar
optimusvault
Registered User
Posts: 108
Joined: Tue Jul 28, 2015 2:51 am
Name: Aaron

Re: [RC] Share On

Post by optimusvault » Mon Aug 03, 2015 10:29 pm

I have run into an issue where the share links show on the newspage extension.
https://www.phpbb.com/customise/db/exte ... _newspage/

It would be fine if they worked, but it shows your extension as links and they are stacked one on top of each other instead of next to each other like in the forums.
Cheers,
Aaron

User avatar
nhseacoast
Registered User
Posts: 518
Joined: Sun Sep 22, 2002 10:31 pm
Location: NH, USA
Contact:

Re: [RC] Share On

Post by nhseacoast » Tue Aug 04, 2015 10:45 pm

Is there an ETA for the safe version? Thanks.

User avatar
peteetongman
Registered User
Posts: 393
Joined: Wed Jul 17, 2013 4:29 am
Location: Atlanta GA USA

Re: [RC] Share On

Post by peteetongman » Thu Aug 13, 2015 5:05 pm

I have noticed that this extension is visible to my mods, but only this extension. they would be able to change settings if they wanted to. If it was just a matter of a permission setting it seems like they would see all extensions

User avatar
ouiouiphoto
Registered User
Posts: 88
Joined: Mon Jun 15, 2015 5:30 am
Contact:

Re: [RC] Share On

Post by ouiouiphoto » Mon Aug 17, 2015 8:09 pm

Hello.

I'm testing this extention. Nice work ;) . Just a question. I have see a png will all the icon inside. Is there anyway to replace it with another one with bigger icons (32X32 for exemple) and what do i have to change after.

Thanks

User avatar
Simps
Registered User
Posts: 40
Joined: Thu Jul 23, 2015 11:49 am
Location: Stafford. UK
Name: Simon

Re: [RC] Share On

Post by Simps » Tue Aug 18, 2015 12:33 pm

Hi there , there is a bug with QuickReply Reloaded 1.0.0-beta5
When setting is Topic Only.
The share icons are added whenever a user makes a post. To the post they just made
They are just loaded in the ajax but when you refresh the page the icons are gone and it is displayed as it should be.
Hope that makes sense.
Do I need to report it on that mod page also ?

Image

Cheers.

User avatar
Simps
Registered User
Posts: 40
Joined: Thu Jul 23, 2015 11:49 am
Location: Stafford. UK
Name: Simon

Re: [RC] Share On

Post by Simps » Thu Aug 20, 2015 10:19 am


Locked

Return to “Extensions in Development”