I was testing your extension a bit and here is a feedback:
When I try to give reputation points to user in ACP I get this error:
Code: Select all
Fatal error: Call to undefined method pico88\reputation\core\manager::give_point() in /home/xxxxxxx/yyyyyyyy/forum/ext/pico88/reputation/acp/reputation_module.php on line 779
When I click on user's profile I can't go to "Rate user" page and when I try to "View Details" I get this error:
Code: Select all
General Error
SQL ERROR [ mysql4 ]
You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'int 182 AND (action = 1 OR action = 2) AND time > 1390500991' at line 3 [1064]
SQL
SELECT point FROM phpbb3_reputations WHERE rep_from = int 182 AND (action = 1 OR action = 2) AND time > 1390500991
BACKTRACE
FILE: (not given by php)
LINE: (not given by php)
CALL: msg_handler()
FILE: [ROOT]/phpbb/db/driver/driver.php
LINE: 803
CALL: trigger_error()
FILE: [ROOT]/phpbb/db/driver/mysql.php
LINE: 184
CALL: phpbb\db\driver\driver->sql_error()
FILE: [ROOT]/ext/pico88/reputation/core/power.php
LINE: 148
CALL: phpbb\db\driver\mysql->sql_query()
FILE: [ROOT]/ext/pico88/reputation/controller/details.php
LINE: 273
CALL: pico88\reputation\core\power->used()
FILE: (not given by php)
LINE: (not given by php)
CALL: pico88\reputation\controller\details->main()
FILE: [ROOT]/vendor/symfony/http-kernel/Symfony/Component/HttpKernel/HttpKernel.php
LINE: 117
CALL: call_user_func_array()
FILE: [ROOT]/vendor/symfony/http-kernel/Symfony/Component/HttpKernel/HttpKernel.php
LINE: 61
CALL: Symfony\Component\HttpKernel\HttpKernel->handleRaw()
FILE: [ROOT]/app.php
LINE: 29
CALL: Symfony\Component\HttpKernel\HttpKernel->handle()
I'm also not able to rate post of user but I can see the thumbs)
I'm using latest (2014-01-22) phpBB 3.1 a2 from
here.
Some possible language issues:
in language/en/info_acp_reputation.php (missing words on the end of second sentence?)
Code: Select all
'RS_USER_RATING_GAP_EXPLAIN' => 'Time period a user must wait before they can give another rating to a user they have already rated. Setting the value to 0 disables this behaviour and users can rate other users once each.',
Plurals in language/en/reputation_system.php
I think these strings should be plurals:
Code: Select all
'RS_COMMENT_TOO_LONG' => 'Your comment contains %1$s characters and is too long.<br />The maximum allowed characters: %2$s.',
Code: Select all
'RS_SAME_POST' => 'You have already rated this post.<br />You gave %s reputation points.',
Code: Select all
'RS_VOTE_POWER_LEFT_OF_MAX' => '%1$d reputation power points left of %2$d.<br />Maximum per vote: %3$d',
I'm not sure about the following. If it shows that user can try it again in xy minutes/hours/days it should be in plurals:
Code: Select all
'RS_USER_GAP' => 'You cannot rate the same user so soon. You can try again in %s.',
I think this can be one plural (array):
Code: Select all
'RS_NEW_REP' => 'You received <strong>1 new</strong> reputation comment',
'RS_NEW_REPS' => 'You received <strong>%s new</strong> reputation comments',
It probably doesn't matter, but the following strings doesn't have to be plurals (in arrays), because there are not specified numbers (what i mean is that it always will be for example 'Delete points' and doesn't matter how many points is deleted.)
Code: Select all
'RS_DELETE_POINTS' => array(
1 => 'Delete point',
2 => 'Delete points'
),
'RS_DELETE_POINTS_CONFIRM' => array(
1 => 'Do you really want to delete this reputation point?',
2 => 'Do you really want to delete these reputation points?',
),
'RS_POINTS_DELETED' => array(
1 => 'The reputation point has been deleted.',
2 => 'The reputation points have been deleted.',
),
In ACP settings on Reputation Power tab is missing language string:
