[CDB] Lightbox

A place for Extension Authors to post and receive feedback on Extensions still in development. No Extensions within this forum should be used within a live environment!
Ideas Centre
Forum rules
READ: phpBB.com Board-Wide Rules and Regulations

IMPORTANT: Extensions Development rules

IMPORTANT FOR NEEDED EVENTS!!!
If you need an event for your extension please read this for the steps to follow to request the event(s)
User avatar
Volksdevil
Registered User
Posts: 2414
Joined: Sun Oct 03, 2010 2:03 pm
Location: Lancashire, UK
Name: Neil
Contact:

Re: [BETA] Lightbox

Post by Volksdevil »

Just a note...If a user posts an image with something like photobucket and uses the linked version, images don't exapand. The white box/loader comes up but nothing happens.
My phpBB Extensions
Finally found great Website Hosting from Image KUALO!
Do NOT use 123-reg.co.uk - Incapable of running phpBB!
:ugeek: TekNeil - Streamer on Mixer | My Volkswagen Corrado G60
User avatar
MattF
Extensions Development Coordinator
Extensions Development Coordinator
Posts: 5183
Joined: Sat Jan 17, 2009 9:37 am
Location: Los Angeles, CA
Name: Matt Friedman
Contact:

Re: [BETA] Lightbox

Post by MattF »

Volksdevil wrote:Just a note...If a user posts an image with something like photobucket and uses the linked version, images don't exapand. The white box/loader comes up but nothing happens.
Of course not, because in that case, the image is a link. Clicking the image opens the link to the original image. This is to be expected.
Formerly known as VSEMy ExtensionsPlease do not PM me for support.
User avatar
PayBas
Former Team Member
Posts: 930
Joined: Thu May 25, 2006 12:37 am

Re: [BETA] Lightbox

Post by PayBas »

VSE wrote:
Volksdevil wrote:Just a note...If a user posts an image with something like photobucket and uses the linked version, images don't exapand. The white box/loader comes up but nothing happens.
Of course not, because in that case, the image is a link. Clicking the image opens the link to the original image. This is to be expected.
It should just open these links in a new window/tab (which it does on my board). However, Volksdevil seems to be saying that the lightbox actually activates in those instances.
User avatar
Volksdevil
Registered User
Posts: 2414
Joined: Sun Oct 03, 2010 2:03 pm
Location: Lancashire, UK
Name: Neil
Contact:

Re: [BETA] Lightbox

Post by Volksdevil »

Yep. This does not happen in my case.
VSE wrote:Clicking the image opens the link to the original image.
No link opens, the lighbox appears with nothing in it, just loading forever. Google chrome tested only. phpbb 3.1.2. Example: (First image) http://www.corradog60.com/viewtopic.php?f=2&t=384 Note: I do have the External link manager extension, but that shouldn't matter from what I can work out...
My phpBB Extensions
Finally found great Website Hosting from Image KUALO!
Do NOT use 123-reg.co.uk - Incapable of running phpBB!
:ugeek: TekNeil - Streamer on Mixer | My Volkswagen Corrado G60
User avatar
PayBas
Former Team Member
Posts: 930
Joined: Thu May 25, 2006 12:37 am

Re: [BETA] Lightbox

Post by PayBas »

Volksdevil wrote:Yep. This does not happen in my case.
VSE wrote:Clicking the image opens the link to the original image.
No link opens, the lighbox appears with nothing in it, just loading forever. Google chrome tested only. phpbb 3.1.2. Example: (First image) http://www.corradog60.com/viewtopic.php?f=2&t=384 Note: I do have the External link manager extension, but that shouldn't matter from what I can work out...
It might be. You could try disabling the external links extension and see what happens.
User avatar
Volksdevil
Registered User
Posts: 2414
Joined: Sun Oct 03, 2010 2:03 pm
Location: Lancashire, UK
Name: Neil
Contact:

Re: [BETA] Lightbox

Post by Volksdevil »

Good point. Disabled that ext, and now when the linked image is clicked, the link opens in the same window. (Which I'm not a fan of). Is some tweaking needed on this extension or the ext link manager extension? It needs fixing somehow. :) I'm sure lightbox used to deal with ext links just fine in 3.0.12.
My phpBB Extensions
Finally found great Website Hosting from Image KUALO!
Do NOT use 123-reg.co.uk - Incapable of running phpBB!
:ugeek: TekNeil - Streamer on Mixer | My Volkswagen Corrado G60
User avatar
MattF
Extensions Development Coordinator
Extensions Development Coordinator
Posts: 5183
Joined: Sat Jan 17, 2009 9:37 am
Location: Los Angeles, CA
Name: Matt Friedman
Contact:

Re: [BETA] Lightbox

Post by MattF »

Volksdevil wrote:Good point. Disabled that ext, and now when the linked image is clicked, the link opens in the same window. (Which I'm not a fan of). Is some tweaking needed on this extension or the ext link manager extension? It needs fixing somehow. :) I'm sure lightbox used to deal with ext links just fine in 3.0.12.
It's the fault of the External Links - URL Manager extension. They are deleting neccessary core classes, which breaks Lightbox. If you must use that extension, you need to set the class of external links in its settings back to what it should be, postlink. Or use a simpler extension that does the same thing: ELONW aka "External Links Open in New Window".
Formerly known as VSEMy ExtensionsPlease do not PM me for support.
User avatar
Volksdevil
Registered User
Posts: 2414
Joined: Sun Oct 03, 2010 2:03 pm
Location: Lancashire, UK
Name: Neil
Contact:

Re: [BETA] Lightbox

Post by Volksdevil »

Is that because Lightbox refers to postlink somewhere?

In the ACP of External link manager you can add your own class as it seems you know, I added ext_link and then some css to correspond to it. So maybe I'm best to find where lightbox refers to postlink, and change it to ext_link?

Hope I've understood properly. I'd like to get the two to work together if I can as the ELONW ext doesn't have the full ability of the ext link manager.

EDIT: OK, in overall_footer_after.html I found:
if ($(this).closest('.[color=#FF0000]postlink[/color]').length > 0) return;

And changed it to:
if ($(this).closest('.[color=#FF0000]ext_link[/color]').length > 0) return;

After a quick check, that seems to do the trick, but can you foresee any negative effects here Matt?

EDIT2: Well I knew there probably would be. Doh. The lightbox isn't applied straight away to normal non linked images, you have to view it and click back, or refresh the page...Damn.
My phpBB Extensions
Finally found great Website Hosting from Image KUALO!
Do NOT use 123-reg.co.uk - Incapable of running phpBB!
:ugeek: TekNeil - Streamer on Mixer | My Volkswagen Corrado G60
User avatar
MattF
Extensions Development Coordinator
Extensions Development Coordinator
Posts: 5183
Joined: Sat Jan 17, 2009 9:37 am
Location: Los Angeles, CA
Name: Matt Friedman
Contact:

Re: [BETA] Lightbox

Post by MattF »

DO NOT edit this extension. Yes, there will be negative effects. The problem is that link extension is removing phpBB's classes...very bad!

The solution is to make those settings right. Either leave that setting empty, or make it "postlink" and make your own styling for postlink or make it "postlink ext_link"

PS: That extension is doing a terrible thing with respect to classes. It should be ADDING classes, not replacing the built in classes. You should ask its author to work on making their extension more "compatible" within the phpBB ecosystem.
Formerly known as VSEMy ExtensionsPlease do not PM me for support.
User avatar
spaceace
Registered User
Posts: 1985
Joined: Wed Jan 30, 2008 8:50 pm
Contact:

Re: [BETA] Lightbox

Post by spaceace »

installed, tested, and working great :D

thanks. nice work :D
maxlinux2000
Registered User
Posts: 20
Joined: Fri May 31, 2013 3:19 pm

Re: [BETA] Lightbox

Post by maxlinux2000 »

Works fine in phpbb3.1.2 - debian7 - apache2 - imagemagick from official repository.
koraldon
Registered User
Posts: 529
Joined: Sat Jun 30, 2007 12:42 pm

Re: [BETA] Lightbox

Post by koraldon »

Hi,
I wanted to install this extension in my forum, are there showstoppers to prevent it from being a RC?
xH4wK
Registered User
Posts: 4
Joined: Thu Feb 05, 2015 1:13 am

Re: [BETA] Lightbox

Post by xH4wK »

Does not seem to be working for me.

-installed extension
-enabled it
-set up options as mentioned in guide
-Uploaded image 2560x1440

Image still appears the old way, can't click on it it does not appear to have any link related

Tried to disable all extensions except this, still not working.

EDIT: I got it working after all, just had to re-add the attachment.
User avatar
Volksdevil
Registered User
Posts: 2414
Joined: Sun Oct 03, 2010 2:03 pm
Location: Lancashire, UK
Name: Neil
Contact:

Re: [ALPHA] Lightbox

Post by Volksdevil »

alexp999 wrote:Working well here, except that it also "lightboxes" images in signatures.

Any way of making it only apply to posts?
Just changed signature on my board and noticed this too. Any way to stop it? :)
My phpBB Extensions
Finally found great Website Hosting from Image KUALO!
Do NOT use 123-reg.co.uk - Incapable of running phpBB!
:ugeek: TekNeil - Streamer on Mixer | My Volkswagen Corrado G60
User avatar
martin123456
I've Been Banned!
Posts: 726
Joined: Sat Mar 05, 2011 7:44 pm

Re: [BETA] Lightbox

Post by martin123456 »

Works well in mchat :)

Code: Select all

<!-- IF S_CODE_UNTIDY and S_MESS_ON_INDEX Good If_Not_TIDY_Then_SUBMIT -->
Locked

Return to “Extensions in Development”