Yes, this looks fine. Just saw your relevant PR for boardrules.VSE wrote:Extensions can really do whatever they want, so long as the doc blocks are valid.
Having said that, we have actually been using @package incorrectly:
"The @package tag can be used as a counterpart or supplement to Namespaces."
http://www.phpdoc.org/docs/latest/refer ... ckage.html
I would say the following format should be the way to go moving forward:Code: Select all
/** * * Board Announcements extension for the phpBB Forum Software package. * * @copyright (c) 2014 phpBB Limited <https://www.phpbb.com> * @license GNU General Public License, version 2 (GPL-2.0) * */
This extension is still in development. You should wait until a release version is announced (soon).ForumsFaciles wrote:Hello,
Installed on my testing board (running beta 4) and can't see where to adjust parameters in the ACP.
Could you please tell me where I have to go ?
Many thanks
Code: Select all
Fatal error: Uncaught exception 'Twig_Error_Loader' with message 'Unable to find template "acp_posting_buttons.html" (looked into: ./../ext/phpbb/boardannouncements/adm/style, ./../adm/style) in "board_announcements.html" at line 69.' in /public_html/xxxxxxx/xxxxxxx/net/communaute/vendor/twig/twig/lib/Twig/Loader/Filesystem.php:202 Stack trace: #0 /public_html/xxxxxxx/xxxxxxx/net/communaute/phpbb/template/twig/loader.php(106): Twig_Loader_Filesystem->findTemplate('acp_posting_but...') #1 /public_html/xxxxxxx/xxxxxxx/net/communaute/vendor/twig/twig/lib/Twig/Loader/Filesystem.php(138): phpbb\template\twig\loader->findTemplate('acp_posting_but...') #2 /public_html/xxxxxxx/xxxxxxx/net/communaute/vendor/twig/twig/lib/Twig/Environment.php(265): Twig_Loader_Filesystem->getCacheKey('acp_posting_but...') #3 /public_html/xxxxxxx/xxxxxxx/net/communaute/vendor/twig/twig/lib/Twig/Environment.php(312): Twig_Environment->getTemplateClass('acp_posting_but...', NULL) #4 /public_html/domains/forumsfaciles/net/ in /public_html/xxxxxxx/xxxxxxx/net/communaute/vendor/twig/twig/lib/Twig/Loader/Filesystem.php on line 202
Code: Select all
<?php
/**
*
* Board Announcements extension for the phpBB Forum Software package.
*
* @copyright (c) 2014 phpBB Limited <https://www.phpbb.com>
* @license GNU General Public License, version 2 (GPL-2.0)
*
*/
/**
* DO NOT CHANGE
*/
if (!defined('IN_PHPBB'))
{
exit;
}
if (empty($lang) || !is_array($lang))
{
$lang = array();
}
// DEVELOPERS PLEASE NOTE
//
// All language files should use UTF-8 as their encoding and the files must not contain a BOM.
//
// Placeholders can now contain order information, e.g. instead of
// 'Page %s of %s' you can (and should) write 'Page %1$s of %2$s', this allows
// translators to re-order the output of data while ensuring it remains correct
//
// You do not need this where single placeholders are used, e.g. 'Message %d' is fine
// equally where a string contains only two placeholders which are used to wrap text
// in a url you again do not need to specify an order e.g., 'Click %sHERE%s' is fine
//
// Some characters you may want to copy&paste:
// ’ » “ ” …
//
$lang = array_merge($lang, array(
'BOARD_ANNOUNCEMENT_CLOSE' => 'Sluit mededeling',
));
Code: Select all
<?php
/**
*
* Board Announcements extension for the phpBB Forum Software package.
*
* @copyright (c) 2014 phpBB Limited <https://www.phpbb.com>
* @license GNU General Public License, version 2 (GPL-2.0)
*
*/
/**
* DO NOT CHANGE
*/
if (!defined('IN_PHPBB'))
{
exit;
}
if (empty($lang) || !is_array($lang))
{
$lang = array();
}
// DEVELOPERS PLEASE NOTE
//
// All language files should use UTF-8 as their encoding and the files must not contain a BOM.
//
// Placeholders can now contain order information, e.g. instead of
// 'Page %s of %s' you can (and should) write 'Page %1$s of %2$s', this allows
// translators to re-order the output of data while ensuring it remains correct
//
// You do not need this where single placeholders are used, e.g. 'Message %d' is fine
// equally where a string contains only two placeholders which are used to wrap text
// in a url you again do not need to specify an order e.g., 'Click %sHERE%s' is fine
//
// Some characters you may want to copy&paste:
// ’ » “ ” …
//
$lang = array_merge($lang, array(
'BOARD_ANNOUNCEMENTS_SETTINGS' => 'Instellingen forum mededeling',
'BOARD_ANNOUNCEMENTS_SETTINGS_EXPLAIN' => 'Hier kan je de forum mededeling aanpassen, dit bericht wordt op iedere pagina van je forum getoond.',
'BOARD_ANNOUNCEMENTS_ENABLE' => 'Forum mededeling inschakelen',
'BOARD_ANNOUNCEMENTS_GUESTS' => 'Laat forum mededeling zien aan gasten',
'BOARD_ANNOUNCEMENTS_BGCOLOR' => 'Achtergrond kleur',
'BOARD_ANNOUNCEMENTS_BGCOLOR_EXPLAIN' => 'Je kunt de achtergrond kleur van de forum mededeling aanpassen door het gebruik van een hex code (e.g: FFFF80). Laat dit veld leeg om de standaard kleur te gebruiken.',
'BOARD_ANNOUNCEMENTS_TEXT' => 'Forum mededeling bericht',
'BOARD_ANNOUNCEMENTS_PREVIEW' => 'Forum mededeling- Voorbeeld',
'BOARD_ANNOUNCEMENTS_UPDATED' => 'Forum mededeling succesvol bijgewerkt.',
// ACP Module
'ACP_BOARD_ANNOUNCEMENTS' => 'Forum mededeling ',
'ACP_BOARD_ANNOUNCEMENTS_SETTINGS' => 'Instellingen mededeling ',
));
Looks like composer wasn't updated.cprgolds wrote:NB: actually I had beta 2 of the extension. The zip file name is beta 2, but the version in the extensions manager shows beta 1.
There is no smiley popup in the announcement message editor, as the ACP posting template does not have smileys included in it. That does not mean, however, that you can't still use them. You just have to type them in manually like:cprgolds wrote:Did not see smilies -- am assuming they are not in the extension yet
:)