[DEV] Post Love

A place for Extension Authors to post and receive feedback on Extensions still in development. No Extensions within this forum should be used within a live environment!
Scam Warning
Forum rules
READ: phpBB.com Board-Wide Rules and Regulations

IMPORTANT: Extensions Development rules

IMPORTANT FOR NEEDED EVENTS!!!
If you need an event for your extension please read this for the steps to follow to request the event(s)
Satanasov
Registered User
Posts: 1180
Joined: Sun Jul 29, 2012 5:48 am
Name: Stanislav Atanasov
Contact:

Re: [BETA] Post Love

Post by Satanasov » Mon Feb 22, 2016 9:23 am

v12mike wrote:
Satanasov wrote:
v12mike wrote:
Satanasov wrote:
v12mike wrote:
You might want to look at viewtopic.php?f=461&t=2359521&p=14354696#p14354696, which also applies to the lovelist window on v1.1
You could probably loose the $web_root_path and use some other route ...
Trouble is that it is in the $this->user_loader->get_username() calls in lovelist.php.
And what is the problem there?

Why do you need to define system wide variable?
It is in your code, not mine.... the get_username() function eventually calls a function that uses $web_root_path to form the url for the user profile page. In this case, I think because it is called from a modal window (on a forum where the forum root is not the web root), the value is wrong, causing the url to be wrong.

The proposed phpBB 3.2 patch does fix this issue, but breaks other things (at least on 3.1.6).
Sh*t ... Pardon my french ... this is going to require some doing ... let's continue the discussuion in github.
For list of all my extensions go to https://github.com/satanasov
If you want custom functions in some of my products - PM me and we will discuss it.

edwormald
Registered User
Posts: 1
Joined: Thu Feb 25, 2016 12:14 am

Re: [BETA] Post Love

Post by edwormald » Thu Feb 25, 2016 12:23 am

had a slight issue when I logged in as someone who'd received a PostLove notification:

duplicate key value violates unique constraint "phpbb_notification_types_type"

disabled and re-enabled the extension and the problem seems to have disappeared.

love your work! :D

Satanasov
Registered User
Posts: 1180
Joined: Sun Jul 29, 2012 5:48 am
Name: Stanislav Atanasov
Contact:

Re: [BETA] Post Love

Post by Satanasov » Thu Feb 25, 2016 9:23 pm

v12mike wrote:..
Please provide list of changes and issues you have found so I can start working on this.
For list of all my extensions go to https://github.com/satanasov
If you want custom functions in some of my products - PM me and we will discuss it.

Satanasov
Registered User
Posts: 1180
Joined: Sun Jul 29, 2012 5:48 am
Name: Stanislav Atanasov
Contact:

Re: [BETA] Post Love

Post by Satanasov » Sun Feb 28, 2016 4:34 am

So ... I've made some incremental fixes (usernames still give error when open from short).

Added additional tests and code coverage ...
For list of all my extensions go to https://github.com/satanasov
If you want custom functions in some of my products - PM me and we will discuss it.

Rhaethe
Registered User
Posts: 3
Joined: Mon Feb 22, 2016 6:18 pm

Re: [BETA] Post Love

Post by Rhaethe » Wed Mar 02, 2016 2:20 am

Hey there :) Installed, but it is not showing up in extensions to enable. I suspect this is due to our using a custom theme. Do you mind if I message you to find out exactly how to get our custom theme added?

Thanks!

User avatar
sysz
Registered User
Posts: 278
Joined: Mon Jan 30, 2012 11:36 pm
Location: Sweden, Helsingborg
Name: Kimmy Lindell Ekström
Contact:

Re: [BETA] Post Love

Post by sysz » Wed Mar 02, 2016 7:12 pm

Downloaded the "newst" version from github but it still says version 1.1.1 instead of 1.1.2.
Currently working on the community

mriggins
Registered User
Posts: 16
Joined: Fri Mar 04, 2016 11:51 pm

Re: [BETA] Post Love

Post by mriggins » Fri Mar 04, 2016 11:55 pm

Rhaethe wrote:Hey there :) Installed, but it is not showing up in extensions to enable. I suspect this is due to our using a custom theme. Do you mind if I message you to find out exactly how to get our custom theme added?

Thanks!
Having the same issue, but on prosilver. I have forums/ext/anavaro/postlove/ and inside there I dumped the contents of the postlove-master latest git zip I downloaded, which was updated 6 days ago. Went to ACP/Customise/Manage Extensions and under Disabled I don't see Post Love.

Rhaethe
Registered User
Posts: 3
Joined: Mon Feb 22, 2016 6:18 pm

Re: [BETA] Post Love

Post by Rhaethe » Sun Mar 06, 2016 2:01 pm

Hmmm. Then am thinking it isn't a problem with theme, since prosilver is default.

Going to dig more and see what I can find out. Thanks for letting me know!

~C

Rhaethe
Registered User
Posts: 3
Joined: Mon Feb 22, 2016 6:18 pm

Re: [BETA] Post Love

Post by Rhaethe » Sun Mar 06, 2016 2:19 pm

Aha. Took a look into acp_postlove_info.php and the directory path it is looking for is not $phpbb_root/ext/anavaro

but rather

$phpbb_root/ext/anavaro/postlove

Works on prosilver, but we use a custom theme. So now I have to figure out how to add it. :)

mtridersclb
Registered User
Posts: 86
Joined: Wed Oct 01, 2008 7:15 pm

Re: [BETA] Post Love

Post by mtridersclb » Thu Mar 10, 2016 8:22 am

This is what Ive been looking for, we used it on our last forum and was very popular so Thank you!
My only embarrassing question is, how do I install it? I am on a steep learning curve with this, Im using:

3.1
Prosilver SE

do I just pop it into the .ext folder and manage it from the ACP/ ext?

Thank you for your patience :-)

Simon
http://www.mtridersclub.co.uk/index.php

Satanasov
Registered User
Posts: 1180
Joined: Sun Jul 29, 2012 5:48 am
Name: Stanislav Atanasov
Contact:

Re: [BETA] Post Love

Post by Satanasov » Thu Mar 10, 2016 11:51 am

mtridersclb wrote:This is what Ive been looking for, we used it on our last forum and was very popular so Thank you!
My only embarrassing question is, how do I install it? I am on a steep learning curve with this, Im using:

3.1
Prosilver SE

do I just pop it into the .ext folder and manage it from the ACP/ ext?

Thank you for your patience :-)

Simon
http://www.mtridersclub.co.uk/index.php
Just put it in to ext and go trough ACP.
For list of all my extensions go to https://github.com/satanasov
If you want custom functions in some of my products - PM me and we will discuss it.

mtridersclb
Registered User
Posts: 86
Joined: Wed Oct 01, 2008 7:15 pm

Re: [BETA] Post Love

Post by mtridersclb » Thu Mar 10, 2016 3:10 pm

Sorry for being dim, but do I need to create a dir in the ext folder called anavaro then dump the postlove-master folder into it whole, or unpack it into anavaro?

ie

ext/anavaro/postlove-master/acp etc

or

ext/anavaro/acp etc

or just ext/postlove-master?

Again sorry, its all good learning,..

DrewCraven
Registered User
Posts: 29
Joined: Fri Jan 07, 2011 2:41 pm

Re: [BETA] Post Love

Post by DrewCraven » Thu Mar 10, 2016 5:32 pm

I think you also need to remove the word 'master' from the directory name, so it would be:

ext/anavaro/postlove/acp etc

mtridersclb
Registered User
Posts: 86
Joined: Wed Oct 01, 2008 7:15 pm

Re: [BETA] Post Love

Post by mtridersclb » Thu Mar 10, 2016 6:35 pm

Ah, that works thank you very much.

Why is there 2 of each heart colour?
I have changed the heart icon to a thumbs up (Im sorry but we are a military based forum and the heart didnt suit!), for ease I have changed the name of the new icons to:

heart-red-16
heart-white-16

and of course suffixed the original.

But the heart still shows. Is the image stored anywhere else?

Thank you

Satanasov
Registered User
Posts: 1180
Joined: Sun Jul 29, 2012 5:48 am
Name: Stanislav Atanasov
Contact:

Re: [BETA] Post Love

Post by Satanasov » Thu Mar 10, 2016 9:10 pm

mtridersclb wrote:Ah, that works thank you very much.

Why is there 2 of each heart colour?
I have changed the heart icon to a thumbs up (Im sorry but we are a military based forum and the heart didnt suit!), for ease I have changed the name of the new icons to:

heart-red-16
heart-white-16

and of course suffixed the original.

But the heart still shows. Is the image stored anywhere else?

Thank you
Hmmm ... please review all and/or prosilver theme folders ...
For list of all my extensions go to https://github.com/satanasov
If you want custom functions in some of my products - PM me and we will discuss it.

Post Reply

Return to “Extensions in Development”