Page 34 of 53

Re: [BETA] Post Love

Posted: Sat Feb 11, 2017 11:38 pm
by teeeceee
After gotten it to work:

When pressing the "heart" - Nothing happends

Pressing once again goes to -0 . pressing multiple times.. -1, -2, -3 etc...

Seems it needs some work because im pretty sure that is not the way it is supposed to work !?

Re: [BETA] Post Love

Posted: Sun Feb 12, 2017 4:25 am
by nkyracer
nkyracer wrote:
Sat Feb 11, 2017 10:58 pm
Satanasov wrote:
Fri Feb 10, 2017 3:55 am
Hey thanks for the PRs. However I can't accept the language file PR - please change the single and double quotation marks.
done
I went ahead and did all the language files fixing the 'NOTIFICATION_POSTLOVE_ADD' line for the new notification and added a new pull request.

Re: [BETA] Post Love

Posted: Sun Feb 12, 2017 8:11 pm
by amiroslo
Any idea when a stable 3.2 vesion is coming out?

Re: [BETA] Post Love

Posted: Sun Feb 12, 2017 10:25 pm
by Satanasov
As I said - I'm doing the extensions in alphabet order. Just finished the friend enhance one. I have the PM search to do and I'll be on the Post Love ... so few days, depending on my real life things that I need to handle.

And I know how to fix most of the issues the 3.2 version is facing ...

Re: [BETA] Post Love

Posted: Mon Feb 13, 2017 2:28 pm
by nkyracer
With the most recent commits the 1.2 branch is now working flawlessly for me on 3.2. No errors anywhere.

Re: [BETA] Post Love

Posted: Mon Feb 13, 2017 5:34 pm
by pszyman
Works for me as well although there is/are some cosmetic issues.

Image

Re: [BETA] Post Love

Posted: Wed Feb 15, 2017 8:53 pm
by bcurran3
pszyman wrote:
Mon Feb 13, 2017 5:34 pm
Works for me as well although there is/are some cosmetic issues.

Image
Looking at that image....Satanasov, it would be great if instead of just using external images included with the extension, you could add support for the Font Awesome thumbs up and thumbs down images. Theoretically, it would reduce I/O hits, show what most people are used to (i.e. Facebook), and be less cute than the hearts that might be considered TOO cute for some people's boards (mine!).

refernce:  fa-thumbs-down []  fa-thumbs-o-down []  fa-thumbs-o-up []  fa-thumbs-up []

Re: [BETA] Post Love

Posted: Wed Feb 15, 2017 9:13 pm
by Mitch1063
That would be an excellent feature. So would being able to rename post love to like or anything the installer wants

Re: [BETA] Post Love

Posted: Wed Feb 22, 2017 12:22 am
by null2
News about this extension?

Re: [BETA] Post Love

Posted: Wed Feb 22, 2017 1:38 pm
by peteetongman
re an earlier post about the desire to make this extension look like Facebook: Please, for the love of God and all things holy, don't make us look like Facebook. I despise Facebook LOL

I'm sort-of halfway kidding; make it look like anything you want

Re: [BETA] Post Love

Posted: Mon Feb 27, 2017 12:23 pm
by Satanasov
I will be doing the fontawesome integration. I just need to get to this extension. I think I have few more before going for this one ...

And yes - I'll be dropping the external images - some CSS fu can create the same effect as them. This will streamline the loading and remove external resources.

Re: [BETA] Post Love

Posted: Tue Feb 28, 2017 5:39 pm
by EmmaL
I'm getting a debug warning:

[phpBB Debug] PHP Warning: in file [ROOT]/phpbb/language/language.php on line 313: vsprintf(): Too few arguments

It only turns up when I enable Post Love. Disabling Post Love while leaving all other extensions enabled makes the error disappear. I did a git pull to see if anything changed. It probably got me nkyracer's fixes but I didn't get rid of the warning.

Re: [BETA] Post Love

Posted: Tue Feb 28, 2017 5:51 pm
by Holger
Do you have a default language that is not available in the Ext?

Re: [BETA] Post Love

Posted: Tue Feb 28, 2017 7:11 pm
by EmmaL
No, default language is Dutch (nl).

Re: [BETA] Post Love

Posted: Wed Mar 01, 2017 3:41 am
by nkyracer
If I remember I'll take a look at the dutch file and see if i forgot to remove an argument in the notification language. That is where I made changes. Can you access the board index with the extension active? Anyone with a postlove notification probably can't access the board.