[DEV] Thanks for posts

A place for Extension Authors to post and receive feedback on Extensions still in development. No Extensions within this forum should be used within a live environment!
Get Involved
Forum rules
READ: phpBB.com Board-Wide Rules and Regulations

IMPORTANT: Extensions Development rules

IMPORTANT FOR NEEDED EVENTS!!!
If you need an event for your extension please read this for the steps to follow to request the event(s)
Art Poulos
Registered User
Posts: 51
Joined: Thu May 01, 2014 2:38 pm

Re: [DEV] Thanks for posts

Post by Art Poulos » Thu Jul 06, 2017 9:34 pm

If I log in as admin, the "thanks" count (under a user's name) is different than what I see if I log in as regular user. As a regular user the count is always less, sometimes as much as a thousand less. Anyone know why?

rxu
Extensions Development Team
Posts: 2770
Joined: Wed Oct 25, 2006 12:46 pm
Location: Siberia, Russian Federation
Name: Ruslan
Contact:

Re: [DEV] Thanks for posts

Post by rxu » Fri Jul 07, 2017 8:52 am

Art Poulos wrote:
Thu Jul 06, 2017 9:34 pm
Anyone know why?
because of some amount of thanks in private forums which is unavaiable for regulasr users and thus not counted for them.

rxu
Extensions Development Team
Posts: 2770
Joined: Wed Oct 25, 2006 12:46 pm
Location: Siberia, Russian Federation
Name: Ruslan
Contact:

Re: [DEV] Thanks for posts

Post by rxu » Fri Jul 07, 2017 8:54 am

Toxyy wrote:
Thu Jul 06, 2017 3:44 am
I have not implemented ajax yet.
____________________________

Ajax will be in the version after I release this with downthanking as an option.
There's addon already https://github.com/alg5/AddonForThanksForPosts

User avatar
RMcGirr83
Recognised Extension Developer
Posts: 20442
Joined: Wed Jun 22, 2005 4:33 pm
Location: Your display
Name: Rich McGirr
Contact:

Re: [DEV] Thanks for posts

Post by RMcGirr83 » Fri Jul 07, 2017 9:24 am

rxu wrote:
Fri Jul 07, 2017 8:54 am
There's addon already https://github.com/alg5/AddonForThanksForPosts
Which no one would know about as there is no title nor a descriptive readme unless one were to read the composer file.
In times of change, learners inherit the earth, while the learned find themselves beautifully equipped to deal with a world that no longer exists - Eric Hoffer
Former Modifications/Extensions Team Member | My extensions
Appreciate the extensions/mods/support then buy me a beer
All requests for support via PM will be ignored

rxu
Extensions Development Team
Posts: 2770
Joined: Wed Oct 25, 2006 12:46 pm
Location: Siberia, Russian Federation
Name: Ruslan
Contact:

Re: [DEV] Thanks for posts

Post by rxu » Fri Jul 07, 2017 11:50 am

RMcGirr83 wrote:
Fri Jul 07, 2017 9:24 am
Which no one would know about
Good point. I'd add it to the 1st post but editing it leads to loosing the screenshots (as attachments).

User avatar
paulie
Registered User
Posts: 50
Joined: Thu Mar 30, 2017 3:41 pm
Location: Hull, East Yorkshire.

Re: [DEV] Thanks for posts

Post by paulie » Fri Jul 07, 2017 12:09 pm

DWFII wrote:
Thu Jul 06, 2017 2:38 pm
But while you're here, I DL'd the file at Github yesterday (?) but am wondering how this is different from the file Paulie mentioned above.
I changed a few files from rxu's original download. I changed the appearance of the block that holds the names of those who liked the post and I changed it's position at the bottom of the 'Liked' post. Also changed some of the text in the Language files. I experimented on a test board until I got the look I wanted :)

I also disabled the 'Rating' - I didn't see any point in that, 'Thanks List' and 'Thanks in Profiles' in the ACP. Keep it simple!
'Life in the Air Age isn't all the brochures say ...'

Toxyy
Registered User
Posts: 323
Joined: Mon Oct 24, 2016 3:22 pm

Re: [DEV] Thanks for posts

Post by Toxyy » Fri Jul 07, 2017 1:30 pm

rxu wrote:
Fri Jul 07, 2017 8:54 am
Toxyy wrote:
Thu Jul 06, 2017 3:44 am
I have not implemented ajax yet.
____________________________

Ajax will be in the version after I release this with downthanking as an option.
There's addon already https://github.com/alg5/AddonForThanksForPosts
This is great. Thank you!

Also, do you recommend me starting my own topic/fork?

Any issues that you know of so I can take this out of dev?
I am a web developer/administrator, specializing in forums. If you have work you need done or are too lazy to do, pm me!

DWFII
Registered User
Posts: 324
Joined: Fri Oct 20, 2006 2:17 am
Name: D.W.
Contact:

Re: [DEV] Thanks for posts

Post by DWFII » Fri Jul 07, 2017 8:28 pm

paulie wrote:
Fri Jul 07, 2017 12:09 pm
DWFII wrote:
Thu Jul 06, 2017 2:38 pm
But while you're here, I DL'd the file at Github yesterday (?) but am wondering how this is different from the file Paulie mentioned above.
I changed a few files from rxu's original download. I changed the appearance of the block that holds the names of those who liked the post and I changed it's position at the bottom of the 'Liked' post. Also changed some of the text in the Language files. I experimented on a test board until I got the look I wanted :)

I also disabled the 'Rating' - I didn't see any point in that, 'Thanks List' and 'Thanks in Profiles' in the ACP. Keep it simple!
Well, I don't have a "test forum" and I just looked at the language/en/info_acp_thanks.php...and I've got to say I don't know where to begin.

You or someone like you should ""twig"(?) / create a branch of this extension that is simple, subs out "like" for "thanks", and is ready to go for the clueless.

I know I'd be a happy camper.
DWFII
In the High Desert of Central Oregon

DWFII
Registered User
Posts: 324
Joined: Fri Oct 20, 2006 2:17 am
Name: D.W.
Contact:

Re: [DEV] Thanks for posts

Post by DWFII » Sun Jul 09, 2017 5:49 pm

I have this extension up and running with the modifications paulie recommended. And it works fine.

But I have several reservations:

First, under the user name and avatar the word "thanks" or "thanked" is still present. Not "liked." and in the users profile the word "thanks" is also used.

How does the average user equate the very nice, simple "thumbs up" "like" icon with "Thanks?"

And second I am getting this:

Image

I don't like the "X" there--it seems out of place and ill-positioned.

Thoughts, comments...help...appreciated.
Last edited by DWFII on Sun Jul 09, 2017 5:51 pm, edited 1 time in total.
DWFII
In the High Desert of Central Oregon

DWFII
Registered User
Posts: 324
Joined: Fri Oct 20, 2006 2:17 am
Name: D.W.
Contact:

Re: [DEV] Thanks for posts

Post by DWFII » Sun Jul 09, 2017 5:51 pm

And why doesn't posting an image work anyway?

Ooops...sorry, got it.
DWFII
In the High Desert of Central Oregon

User avatar
paulie
Registered User
Posts: 50
Joined: Thu Mar 30, 2017 3:41 pm
Location: Hull, East Yorkshire.

Re: [DEV] Thanks for posts

Post by paulie » Sun Jul 09, 2017 6:30 pm

DWFII wrote:
Sun Jul 09, 2017 5:49 pm
I have this extension up and running with the modifications paulie recommended. And it works fine.

But I have several reservations:

First, under the user name and avatar the word "thanks" or "thanked" is still present. Not "liked." and in the users profile the word "thanks" is also used.

How does the average user equate the very nice, simple "thumbs up" "like" icon with "Thanks?"

And second I am getting this:

Image

I don't like the "X" there--it seems out of place and ill-positioned.

Thoughts, comments...help...appreciated.
Only you as Admin can see the 'X', it's for clearing the 'Likes' from the post, your members can't see it so it doesn't really matter.

As mentioned, I disabled the 'Rating' and 'Show Thanks in Profile' in the ACP. You would need to find the files that contain the words 'Thanks' and replace them with the word 'Liked'.
'Life in the Air Age isn't all the brochures say ...'

DWFII
Registered User
Posts: 324
Joined: Fri Oct 20, 2006 2:17 am
Name: D.W.
Contact:

Re: [DEV] Thanks for posts

Post by DWFII » Sun Jul 09, 2017 6:45 pm

RE: the "X"... OK thanks...that's acceptable, i guess.

Re: the rest...hmmm, well I'm not up for that. As I said, I wouldn't know where to begin. That said, I like having those stats available I just don't like the disconnect.

Beyond all that, I have to thank you again for all the help. If this board had a thumbs-up smilie...it would be here.
DWFII
In the High Desert of Central Oregon

sakm
Registered User
Posts: 461
Joined: Sun Jan 21, 2007 8:14 pm
Location: Hull, uk
Name: Stu
Contact:

Re: [DEV] Thanks for posts

Post by sakm » Sun Jul 09, 2017 6:48 pm

Have you a screen shot of the ones you need changing?

DWFII
Registered User
Posts: 324
Joined: Fri Oct 20, 2006 2:17 am
Name: D.W.
Contact:

Re: [DEV] Thanks for posts

Post by DWFII » Sun Jul 09, 2017 7:08 pm

Well, I guess that would require several (3? 4 ?) screen shots. I can provide them...it may take a couple of hours.

I was thinking that if I knew what files controlled those stats, I could open them in Notepad+ and search for "been thanked':", "has thanked:" as well as "been thanked:" and "has thanked:" in the file that controls user profile stats for Thanks for Posts. And replace them with something like "likes received" and "likes given."

But honestly it scares me a little...I don't know what is safe and what's not. This board has been in existence for 20+ years...I don't want to be the one to bring it down.

Oh and BTW, thank you for your generosity.
DWFII
In the High Desert of Central Oregon

sakm
Registered User
Posts: 461
Joined: Sun Jan 21, 2007 8:14 pm
Location: Hull, uk
Name: Stu
Contact:

Re: [DEV] Thanks for posts

Post by sakm » Sun Jul 09, 2017 7:27 pm

Messing with the files will not kill the board if you mess it up you just replace that file ;)

Post Reply

Return to “Extensions in Development”

Who is online

Users browsing this forum: dmzx, gio73, RomaamoR, van de werde and 31 guests

cron