[DEV] Thanks for posts

A place for Extension Authors to post and receive feedback on Extensions still in development. No Extensions within this forum should be used within a live environment!
Anti-Spam Guide
Forum rules
READ: phpBB.com Board-Wide Rules and Regulations

IMPORTANT: Extensions Development rules

IMPORTANT FOR NEEDED EVENTS!!!
If you need an event for your extension please read this for the steps to follow to request the event(s)
RickWebMaster
Registered User
Posts: 17
Joined: Thu Jun 22, 2017 11:34 am
Name: Rick
Contact:

Re: [DEV] Thanks for posts

Post by RickWebMaster » Sun Jul 23, 2017 10:29 am

Does anyone know how/where to upload the icon image for the thank you button; it shows the button ok but not the little icon but the square.

thanks

User avatar
daroreando
Registered User
Posts: 1
Joined: Sun Jul 23, 2017 4:40 pm

I need this ext in 3.1.x

Post by daroreando » Sun Jul 23, 2017 4:44 pm

Hello, I can not find the 3.1.x version and I need this D: How can i get this version? :?:

User avatar
Galixte de EzCom
Registered User
Posts: 667
Joined: Mon Oct 04, 2004 11:14 pm
Location: France
Name: Raphaël M.
Contact:

Re: [DEV] Thanks for posts

Post by Galixte de EzCom » Sun Jul 23, 2017 5:18 pm

Hi rxu,

on phpBB 3.2.1, on the toplist page, in “RATING TOPICS” table, the Topic icons don’t appear correctly, see here: https://github.com/rxu/thanks_for_posts/issues/87.
Communau EzCom
Image « Traductions d’extensions & styles pour phpBB 3.1.x & 3.2.x ».
ImageLists of all extensions identified for phpBB 3.1.x & 3.2.x.

rxu
Extensions Development Team
Posts: 2693
Joined: Wed Oct 25, 2006 12:46 pm
Location: Siberia, Russian Federation
Name: Ruslan
Contact:

Re: [DEV] Thanks for posts

Post by rxu » Sun Jul 23, 2017 6:09 pm

daroreando wrote:
Sun Jul 23, 2017 4:44 pm
3.1.x version and I need this
https://github.com/rxu/thanks_for_posts/tree/master
RickWebMaster wrote:
Sun Jul 23, 2017 10:29 am
Does anyone know how/where to upload the icon image for the thank you button
What phpBB version?
Galixte de EzCom wrote:
Sun Jul 23, 2017 5:18 pm
Topic icons don’t appear correctly
Thanks, I'll take a look when I have free time.

User avatar
Galixte de EzCom
Registered User
Posts: 667
Joined: Mon Oct 04, 2004 11:14 pm
Location: France
Name: Raphaël M.
Contact:

Re: [DEV] Thanks for posts

Post by Galixte de EzCom » Sun Jul 23, 2017 6:42 pm

rxu wrote:
Sun Jul 23, 2017 6:09 pm
Galixte de EzCom wrote:
Sun Jul 23, 2017 5:18 pm
Topic icons don’t appear correctly
Thanks, I'll take a look when I have free time.
Patch proposed: https://github.com/rxu/thanks_for_posts ... -317269427.
Communau EzCom
Image « Traductions d’extensions & styles pour phpBB 3.1.x & 3.2.x ».
ImageLists of all extensions identified for phpBB 3.1.x & 3.2.x.

User avatar
Froddelaar
Registered User
Posts: 421
Joined: Tue Mar 29, 2016 3:45 am
Location: Aalst (Belgium)
Name: Andy Dm
Contact:

Re: [DEV] Thanks for posts

Post by Froddelaar » Thu Aug 03, 2017 8:50 pm

Would it be possible to see the stars in viewforum.php ?

Like:

Image

Ps: It's not for an illegal download forum
I'm A Stupid F*ck.. And Proud Of it!
Download +32.000 arcade extension games @ ~ https://www.froddelpower.be ~

Dutch Extension Translations @ https://github.com/Solidjeuh
Donations are always welcome @ https://www.froddelpower.be/donation

Goztow
Registered User
Posts: 364
Joined: Fri Aug 17, 2007 10:31 am
Location: Belgium
Contact:

Re: [DEV] Thanks for posts

Post by Goztow » Thu Aug 03, 2017 9:03 pm

Hello, I've been using a personally modified version of this great extension on my forum. I posted some of my code around page 35, but I don't think the creator added it.

I would now like to update to version 3.2 without having to redo all mods because I didn't document them very well. Could one of the modders please tell me which files to replace? I noticed there were changed in notification/thanks.php and in services.yml but is it sufficient to just modify them?

Thanks in advance.

User avatar
Galixte de EzCom
Registered User
Posts: 667
Joined: Mon Oct 04, 2004 11:14 pm
Location: France
Name: Raphaël M.
Contact:

Re: [DEV] Thanks for posts

Post by Galixte de EzCom » Fri Aug 04, 2017 12:24 pm

Froddelaar wrote:
Thu Aug 03, 2017 8:50 pm
Would it be possible to see the stars in viewforum.php ?

Like:

Image

Ps: It's not for an illegal download forum
Yes it's already possible, in ACP on the “Moon Phases” page you have to activate the “Show forums rating:” option.
Communau EzCom
Image « Traductions d’extensions & styles pour phpBB 3.1.x & 3.2.x ».
ImageLists of all extensions identified for phpBB 3.1.x & 3.2.x.

User avatar
Galixte de EzCom
Registered User
Posts: 667
Joined: Mon Oct 04, 2004 11:14 pm
Location: France
Name: Raphaël M.
Contact:

Re: [DEV] Thanks for posts

Post by Galixte de EzCom » Fri Aug 04, 2017 12:36 pm

Goztow wrote:
Thu Aug 03, 2017 9:03 pm
Hello, I've been using a personally modified version of this great extension on my forum. I posted some of my code around page 35, but I don't think the creator added it.

I would now like to update to version 3.2 without having to redo all mods because I didn't document them very well. Could one of the modders please tell me which files to replace? I noticed there were changed in notification/thanks.php and in services.yml but is it sufficient to just modify them?

Thanks in advance.
Are you talking about this message: viewtopic.php?p=14181086#p14181086 ? There is a previous message, just before this, but it’s about displaying a new background color in some cases. I don’t see any code about implementation of a “recent thanks” function.

To re-implement your function, you have to do the inverse method, by adding the changes from your extension modified (august 2015) into the new version of Thanks for posts extension dedicated to phpBB 3.2.x.

Why i don’t suggest you to apply all the modifications since august 2015 to today? Because there are many changes! See that: https://github.com/rxu/thanks_for_posts ... les_bucket (47 changed files with 1,167 additions and 477 deletions). ;)

So, you can use Winmerge to compare files between your current version (on your phpBB 3.1.x forum) and the original when you posted your message, download this: https://github.com/rxu/thanks_for_posts ... 40e00b.zip (Thanks for posts extension on 20 august 2015). With this you’ll can compare the files between the original extension at this date and yours. After noted the differences, you’ll can apply these to the new version for phpBB 3.2.x.
Communau EzCom
Image « Traductions d’extensions & styles pour phpBB 3.1.x & 3.2.x ».
ImageLists of all extensions identified for phpBB 3.1.x & 3.2.x.

User avatar
Froddelaar
Registered User
Posts: 421
Joined: Tue Mar 29, 2016 3:45 am
Location: Aalst (Belgium)
Name: Andy Dm
Contact:

Re: [DEV] Thanks for posts

Post by Froddelaar » Fri Aug 04, 2017 4:11 pm

Galixte de EzCom wrote:
Fri Aug 04, 2017 12:24 pm
Froddelaar wrote:
Thu Aug 03, 2017 8:50 pm
Would it be possible to see the stars in viewforum.php ?

Like:

Image

Ps: It's not for an illegal download forum
Yes it's already possible, in ACP on the “Moon Phases” page you have to activate the “Show forums rating:” option.
That option is enabled, still don't see it on the viewforum.php page. :oops:

Image
I'm A Stupid F*ck.. And Proud Of it!
Download +32.000 arcade extension games @ ~ https://www.froddelpower.be ~

Dutch Extension Translations @ https://github.com/Solidjeuh
Donations are always welcome @ https://www.froddelpower.be/donation

rxu
Extensions Development Team
Posts: 2693
Joined: Wed Oct 25, 2006 12:46 pm
Location: Siberia, Russian Federation
Name: Ruslan
Contact:

Re: [DEV] Thanks for posts

Post by rxu » Fri Aug 04, 2017 4:22 pm

Froddelaar wrote:
Fri Aug 04, 2017 4:11 pm
That option is enabled, still don't see it on the viewforum.php page
What style?

User avatar
Froddelaar
Registered User
Posts: 421
Joined: Tue Mar 29, 2016 3:45 am
Location: Aalst (Belgium)
Name: Andy Dm
Contact:

Re: [DEV] Thanks for posts

Post by Froddelaar » Fri Aug 04, 2017 4:27 pm

rxu wrote:
Fri Aug 04, 2017 4:22 pm
Froddelaar wrote:
Fri Aug 04, 2017 4:11 pm
That option is enabled, still don't see it on the viewforum.php page
What style?
Tried with prosilver & se_square

phpBB 3.2.1, PHP 7.0
I'm A Stupid F*ck.. And Proud Of it!
Download +32.000 arcade extension games @ ~ https://www.froddelpower.be ~

Dutch Extension Translations @ https://github.com/Solidjeuh
Donations are always welcome @ https://www.froddelpower.be/donation

rxu
Extensions Development Team
Posts: 2693
Joined: Wed Oct 25, 2006 12:46 pm
Location: Siberia, Russian Federation
Name: Ruslan
Contact:

Re: [DEV] Thanks for posts

Post by rxu » Fri Aug 04, 2017 6:55 pm

Well, what you have enabled is actually forums rating. As far as I've understood you're trying to get topics rating, which is connected to the Show topic rating setting in the Rating options.

User avatar
Froddelaar
Registered User
Posts: 421
Joined: Tue Mar 29, 2016 3:45 am
Location: Aalst (Belgium)
Name: Andy Dm
Contact:

Re: [DEV] Thanks for posts

Post by Froddelaar » Fri Aug 04, 2017 8:25 pm

rxu wrote:
Fri Aug 04, 2017 6:55 pm
Well, what you have enabled is actually forums rating. As far as I've understood you're trying to get topics rating, which is connected to the Show topic rating setting in the Rating options.
It's all enabled

Image
I'm A Stupid F*ck.. And Proud Of it!
Download +32.000 arcade extension games @ ~ https://www.froddelpower.be ~

Dutch Extension Translations @ https://github.com/Solidjeuh
Donations are always welcome @ https://www.froddelpower.be/donation

rxu
Extensions Development Team
Posts: 2693
Joined: Wed Oct 25, 2006 12:46 pm
Location: Siberia, Russian Federation
Name: Ruslan
Contact:

Re: [DEV] Thanks for posts

Post by rxu » Sat Aug 05, 2017 5:49 am

Froddelaar wrote:
Fri Aug 04, 2017 8:25 pm
It's all enabled
Try disabling all "...in a column" options as they're unworkable and most likely will be removed at some point.

Post Reply

Return to “Extensions in Development”

Who is online

Users browsing this forum: imkingdavid, kustajuspin, pszyman and 35 guests