Page 31 of 75

Re: [DEV] Thanks for posts

Posted: Sun Jul 26, 2015 12:44 pm
by CoinHELP
Thanks. For some reason the version I previously downloaded had "master" in the path.

Re: [DEV] Thanks for posts

Posted: Sun Jul 26, 2015 1:45 pm
by CoinHELP
Still not working and it's not even showing up in my extension checker log. I am wondering if this isn't because I am using subsilver?

I uploaded thanks_for_post_v135 to ext

I uploaded thanks_for_posts_1_3_5 to ext

But neither path will show up in my extensions manager. I currently have 11 different extensions installed so I am not new to this, but I can't get this one to work.

Re: [DEV] Thanks for posts

Posted: Sun Jul 26, 2015 1:48 pm
by Sisem
Path should be:

ext/gfksx/ThanksForPosts/

It does state this clearly in the first post tho... :)

Re: [DEV] Thanks for posts

Posted: Sun Jul 26, 2015 1:51 pm
by rxu
CoinHELP wrote:I uploaded thanks_for_post_v135 to ext
That isn't the extension but a MOD for phpBB 3.0.

Re: [DEV] Thanks for posts

Posted: Sun Jul 26, 2015 3:23 pm
by CoinHELP
Sisem wrote:Path should be:

ext/gfksx/ThanksForPosts/

It does state this clearly in the first post tho... :)
I saw that but what I am downloading doesn't have that path. Linky to 3.1 download please?

I am not downloading the correct file evidently.

Re: [DEV] Thanks for posts

Posted: Sun Jul 26, 2015 3:25 pm
by Sisem
First post, development repository, down load zip, then extract the zip to that path which you will need to create the folders for. :)

Re: [DEV] Thanks for posts

Posted: Sun Jul 26, 2015 4:03 pm
by SalazarAG
Hello!I would like to change some code to the tanned notifications come apart?

example:

3 users like the same post.
The post's author receives a notification: "User, User 2 and User 3 likes his post"

Its separate notifications to come individually to each person who enjoys the post?

Re: [DEV] Thanks for posts

Posted: Sun Jul 26, 2015 4:14 pm
by rxu
SalazarAG wrote:3 users like the same post.
The post's author receives a notification: "User, User 2 and User 3 likes his post"

Its separate notifications to come individually to each person who enjoys the post?
Nope as it's a notification about the same post. You can't create several notifications of the same type for the same item, so when things change notification is just get updated.

Re: [DEV] Thanks for posts

Posted: Sun Jul 26, 2015 4:29 pm
by faisca1
Bug

Invisible symbol quote

I logged in as a test and I can not quote make the admin message

Image

Re: [DEV] Thanks for posts

Posted: Sun Jul 26, 2015 4:33 pm
by Sisem
The missing quote button is due to the overlay issue I posted the fix for on the last page.

Re: [DEV] Thanks for posts

Posted: Sun Jul 26, 2015 4:59 pm
by rxu
This is known bug of the current development state, thanks. Working on fixing it (hopefully as of upcoming phpBB 3.1.6).

Re: [DEV] Thanks for posts

Posted: Sun Jul 26, 2015 5:03 pm
by Sisem
rxu wrote:This is known bug of the current development state, thanks. Working on fixing it (hopefully as of upcoming phpBB 3.1.6).
Have you seen my fix on the last page?

Re: [DEV] Thanks for posts

Posted: Sun Jul 26, 2015 5:11 pm
by rxu
Sisem wrote:Have you seen my fix on the last page?
Sure, but that is not actually a fix but a rolling back to the before-bug development state: https://github.com/rxu/thanks_for_posts ... db282ff779.

Re: [DEV] Thanks for posts

Posted: Sun Jul 26, 2015 5:16 pm
by Sisem
rxu wrote:
Sisem wrote:Have you seen my fix on the last page?
Sure, but that is not actually a fix but a rolling back to the before-bug development state: https://github.com/rxu/thanks_for_posts ... db282ff779.
Not sure what you mean about rolling back, I found the issue where the mod is creating a duplicate class:

viewtopic.php?f=456&t=2259046&start=435#p14151111

Re: [DEV] Thanks for posts

Posted: Sun Jul 26, 2015 5:21 pm
by rxu
Sisem wrote:I found the issue where the mod is creating a duplicate class
This is exactly what is the bug about. Fixing it the way you stated is rolling the extension back to the previous state pointed by the link above.
This change was intended really.