[CDB] Thanks for posts

zpintar · Post by **zpintar** » Sat Dec 17, 2016 1:51 pm

rxu wrote:What I replied in the quote. 3.1.10 has a bug preventing some extensions from installing. if you have 3.1.10, you need to wait for 3.1.11.

Super, so we must wait for new (sub)version of phpBB for months until someone resolve that serious bug?

I'm not impressed.

Hippie459MN · Post by **Hippie459MN** » Sat Dec 17, 2016 2:05 pm

What seems to be the problem with this with 3.1.10 cause its working fine that I can see for me on 3.1.10. Maybe I am not seeing something or overlooking something but all is well here.

rxu · Post by **rxu** » Sat Dec 17, 2016 2:45 pm

zpintar wrote:
rxu wrote:What I replied in the quote. 3.1.10 has a bug preventing some extensions from installing. if you have 3.1.10, you need to wait for 3.1.11.
Super, so we must wait for new (sub)version of phpBB for months until someone resolve that serious bug?

I'm not impressed.

Again. This is NOT the extension but phpBB core bug. It can't be resolved by extension.

Hippie459MN wrote:What seems to be the problem with this with 3.1.10 cause its working fine

Some extensions can't be installed on 3.1.10, that's rather random.

zpintar · Post by **zpintar** » Sat Dec 17, 2016 3:18 pm

rxu wrote:
Again. This is NOT the extension but phpBB core bug. It can't be resolved by extension.

I know. I'm not impressed with that kind of phpBB development.

BTW your extension still working very well on my old phpBB 3.0 forum.

Hippie459MN · Post by **Hippie459MN** » Sat Dec 17, 2016 3:26 pm

rxu wrote:
Hippie459MN wrote:What seems to be the problem with this with 3.1.10 cause its working fine
Some extensions can't be installed on 3.1.10, that's rather random.

I installed it when I was on 3.1.8 so maybe thats why cause it was already installed. Either way, working great here and no issues that I can really see.

rxu · Post by **rxu** » Sat Dec 17, 2016 4:12 pm

zpintar wrote:I'm not impressed with that kind of phpBB development.

well, any software has more or less serious bugs, that's normal. They just have to be fixed and they will be

zpintar wrote:your extension still working very well on my old phpBB 3.0 forum.

Thanks but the MOD is not mine, I just converted it to extension

ArKay99 · Post by **ArKay99** » Fri Jan 06, 2017 4:49 pm

Any info on whether this will also be fixed or installable for 3.2?

btw, kudos to the whole team...it just boggles my mind that people become upset with developers of software of this magnitude when it's for free...

rxu · Post by **rxu** » Fri Jan 06, 2017 4:57 pm

ArKay99 wrote: ↑Fri Jan 06, 2017 4:49 pm Any info on whether this will also be fixed or installable for 3.2?

The develop branch for phpBB 3.2 is here https://github.com/rxu/thanks_for_posts ... elop-3.2.x

GoHod · Post by **GoHod** » Sat Jan 07, 2017 3:45 pm

Not sure if I'm missing something. I'm on 3.2 RC-2 now. I used to have the original mod working on 3.0.x

Trying to install the 3.2 branch extension and it's failing as it can;' find the table 'FORUMNAME_thanks' (I've censored that). Not sure if there's something left over in an old setting somewhere?

Any thoughts?

Cheers.

rxu · Post by **rxu** » Sat Jan 07, 2017 4:06 pm

How do you upgrade exactly?

GoHod · Post by **GoHod** » Sat Jan 07, 2017 5:12 pm

Via 3.1.10.

Unfortunately, I had to turn off the 'thanks' mod in 3.0.x and it came back broken, so it's been switched off for a month or so. Obviously I couldn't install the extension on 3.1.10, so I was hoping it would work on 3.2-RC2 (initially with the standard extension and then with the 3.2 branch version). Not sure when it's supposed to create the new table, or where it's getting the table name from. I think I've deleted all the modules that had anything to do with the old 'thanks' mod. Cheers.

GenesMan · Post by **GenesMan** » Tue Jan 10, 2017 8:02 pm

Any news in compatibility adjustments to be used in 3.2 ?

CheGuevara · Post by **CheGuevara** » Wed Jan 11, 2017 5:26 am

It works fine with 3.2. Apart from the fact I now get 2 thanks icons that overlay each other,

Code: Select all

													<li>
			<a id='lnk_thanks_post1562611' href="./viewtopic.php?f=9&amp;p=1562611&amp;thanks=1562611&amp;to_id=300498&amp;from_id=95756" title="Say Thanks to the author of the post: ggold"  class="button button-icon-only">
				<i class="icon thanks-icon fa-fw" aria-hidden="true"></i><span class="sr-only">Thanks</span>
			</a>
		</li>
					</ul>
										<ul class="post-buttons">
			<li>
				<a id='lnk_thanks_post1562611' href="./viewtopic.php?f=9&amp;p=1562611&amp;thanks=1562611&amp;to_id=300498&amp;from_id=95756" title="Say Thanks to the author of the post: ggold" class="button icon-button thanks-icon"><span>Thanks</span></a>
			</li>

rxu · Post by **rxu** » Wed Jan 11, 2017 5:13 pm

6 posts above viewtopic.php?p=14596966#p14596966

GoHod · Post by **GoHod** » Wed Jan 11, 2017 6:16 pm

Any idea about the SQL table issue?